* [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling
@ 2014-08-22 9:12 Romain Naour
2014-08-22 9:12 ` [Buildroot] [PATCH v2 2/2] Revert "package/localedef: don't use config.site when cross-compiling" Romain Naour
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Romain Naour @ 2014-08-22 9:12 UTC (permalink / raw)
To: buildroot
On fedora 20 64bits host, the file /usr/share/config.site contains
a fix for installing libraries into /lib/lib64 on 64bits systems
that redefine libdir in the generated Makefile
For safety and avoid the bug #7262 [1], disable loading this file
when running the configure script for the target and the host.
Note: configure scripts generated with autoconf < 2.65 will source
the /dev/null and print this line:
"configure: loading site script /dev/null"
[1]: https://bugs.busybox.net/show_bug.cgi?id=7262
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v2:
Use /dev/null for CONFIG_SITE to avoid sourcing a file nammed "no"
(ThomasDS and Mike Zick)
Add a note about autoconf version
Add reference to the bug #7262
---
package/pkg-autotools.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
index bcc648d..a424a1c 100644
--- a/package/pkg-autotools.mk
+++ b/package/pkg-autotools.mk
@@ -126,6 +126,7 @@ define $(2)_CONFIGURE_CMDS
$$(TARGET_CONFIGURE_OPTS) \
$$(TARGET_CONFIGURE_ARGS) \
$$($$(PKG)_CONF_ENV) \
+ CONFIG_SITE=/dev/null \
./configure \
--target=$$(GNU_TARGET_NAME) \
--host=$$(GNU_TARGET_NAME) \
@@ -159,6 +160,7 @@ define $(2)_CONFIGURE_CMDS
CFLAGS="$$(HOST_CFLAGS)" \
LDFLAGS="$$(HOST_LDFLAGS)" \
$$($$(PKG)_CONF_ENV) \
+ CONFIG_SITE=/dev/null \
./configure \
--prefix="$$(HOST_DIR)/usr" \
--sysconfdir="$$(HOST_DIR)/etc" \
--
1.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 2/2] Revert "package/localedef: don't use config.site when cross-compiling"
2014-08-22 9:12 [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling Romain Naour
@ 2014-08-22 9:12 ` Romain Naour
2014-08-22 10:02 ` Thomas De Schampheleire
2014-09-14 22:38 ` Peter Korsgaard
2014-08-22 10:01 ` [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling Thomas De Schampheleire
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Romain Naour @ 2014-08-22 9:12 UTC (permalink / raw)
To: buildroot
CONFIG_SITE is now a part of pkg-autotools infrastructure.
This reverts commit 85448febb3c9f21e6e4082fc344b3ef46261c782.
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v2: commit log: add missing Sob
---
package/localedef/localedef.mk | 4 ----
1 file changed, 4 deletions(-)
diff --git a/package/localedef/localedef.mk b/package/localedef/localedef.mk
index 9a7118a..17ffd14 100644
--- a/package/localedef/localedef.mk
+++ b/package/localedef/localedef.mk
@@ -8,10 +8,6 @@ LOCALEDEF_VERSION = 2.14.1-r17443-ptx1
LOCALEDEF_SOURCE = localedef-eglibc-$(LOCALEDEF_VERSION).tar.bz2
LOCALEDEF_SITE = http://www.pengutronix.de/software/ptxdist/temporary-src
-# Avoid loading /usr/share/config.site that can redefine libdir when
-# the host arch is a 64bit system.
-HOST_LOCALEDEF_CONF_ENV = CONFIG_SITE="no"
-
HOST_LOCALEDEF_CONF_OPT += \
--prefix=/usr \
--with-glibc=./eglibc
--
1.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling
2014-08-22 9:12 [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling Romain Naour
2014-08-22 9:12 ` [Buildroot] [PATCH v2 2/2] Revert "package/localedef: don't use config.site when cross-compiling" Romain Naour
@ 2014-08-22 10:01 ` Thomas De Schampheleire
2014-08-24 16:14 ` Thomas Petazzoni
2014-09-14 22:38 ` Peter Korsgaard
3 siblings, 0 replies; 9+ messages in thread
From: Thomas De Schampheleire @ 2014-08-22 10:01 UTC (permalink / raw)
To: buildroot
On Fri, Aug 22, 2014 at 11:12 AM, Romain Naour <romain.naour@openwide.fr> wrote:
> On fedora 20 64bits host, the file /usr/share/config.site contains
> a fix for installing libraries into /lib/lib64 on 64bits systems
> that redefine libdir in the generated Makefile
>
> For safety and avoid the bug #7262 [1], disable loading this file
> when running the configure script for the target and the host.
>
> Note: configure scripts generated with autoconf < 2.65 will source
> the /dev/null and print this line:
> "configure: loading site script /dev/null"
>
> [1]: https://bugs.busybox.net/show_bug.cgi?id=7262
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Acked-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 2/2] Revert "package/localedef: don't use config.site when cross-compiling"
2014-08-22 9:12 ` [Buildroot] [PATCH v2 2/2] Revert "package/localedef: don't use config.site when cross-compiling" Romain Naour
@ 2014-08-22 10:02 ` Thomas De Schampheleire
2014-09-14 22:38 ` Peter Korsgaard
1 sibling, 0 replies; 9+ messages in thread
From: Thomas De Schampheleire @ 2014-08-22 10:02 UTC (permalink / raw)
To: buildroot
On Fri, Aug 22, 2014 at 11:12 AM, Romain Naour <romain.naour@openwide.fr> wrote:
> CONFIG_SITE is now a part of pkg-autotools infrastructure.
>
> This reverts commit 85448febb3c9f21e6e4082fc344b3ef46261c782.
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Acked-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling
2014-08-22 9:12 [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling Romain Naour
2014-08-22 9:12 ` [Buildroot] [PATCH v2 2/2] Revert "package/localedef: don't use config.site when cross-compiling" Romain Naour
2014-08-22 10:01 ` [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling Thomas De Schampheleire
@ 2014-08-24 16:14 ` Thomas Petazzoni
2014-08-24 16:39 ` Romain Naour
2014-09-14 22:38 ` Peter Korsgaard
3 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2014-08-24 16:14 UTC (permalink / raw)
To: buildroot
Dear Romain Naour,
On Fri, 22 Aug 2014 11:12:53 +0200, Romain Naour wrote:
> On fedora 20 64bits host, the file /usr/share/config.site contains
> a fix for installing libraries into /lib/lib64 on 64bits systems
> that redefine libdir in the generated Makefile
>
> For safety and avoid the bug #7262 [1], disable loading this file
> when running the configure script for the target and the host.
>
> Note: configure scripts generated with autoconf < 2.65 will source
> the /dev/null and print this line:
> "configure: loading site script /dev/null"
>
> [1]: https://bugs.busybox.net/show_bug.cgi?id=7262
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
I am wondering if this change should go in master (for 2014.08) or in
the next branch (for 2014.11). That close to the release, doing a
change in the core infrastructure seems a bit invasive to me. What if
it breaks the build of other packages? Seems unlikely, I admit, but
still. What do others think?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling
2014-08-24 16:14 ` Thomas Petazzoni
@ 2014-08-24 16:39 ` Romain Naour
2014-08-24 18:31 ` Thomas De Schampheleire
0 siblings, 1 reply; 9+ messages in thread
From: Romain Naour @ 2014-08-24 16:39 UTC (permalink / raw)
To: buildroot
Hi Thomas,
Le 24/08/2014 18:14, Thomas Petazzoni a ?crit :
> Dear Romain Naour,
>
> On Fri, 22 Aug 2014 11:12:53 +0200, Romain Naour wrote:
>> On fedora 20 64bits host, the file /usr/share/config.site contains
>> a fix for installing libraries into /lib/lib64 on 64bits systems
>> that redefine libdir in the generated Makefile
>>
>> For safety and avoid the bug #7262 [1], disable loading this file
>> when running the configure script for the target and the host.
>>
>> Note: configure scripts generated with autoconf < 2.65 will source
>> the /dev/null and print this line:
>> "configure: loading site script /dev/null"
>>
>> [1]: https://bugs.busybox.net/show_bug.cgi?id=7262
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>
> I am wondering if this change should go in master (for 2014.08) or in
> the next branch (for 2014.11). That close to the release, doing a
> change in the core infrastructure seems a bit invasive to me. What if
> it breaks the build of other packages? Seems unlikely, I admit, but
> still. What do others think?
I think this patch can go to next since the issue is already fixed in master but
just for host-localedef.
Actually, it seems that only host-localedef was affected by this issue.
Best regards,
Romain
> Thanks!
>
> Thomas
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling
2014-08-24 16:39 ` Romain Naour
@ 2014-08-24 18:31 ` Thomas De Schampheleire
0 siblings, 0 replies; 9+ messages in thread
From: Thomas De Schampheleire @ 2014-08-24 18:31 UTC (permalink / raw)
To: buildroot
Hi Thomas, Romain,
On Sun, Aug 24, 2014 at 6:39 PM, Romain Naour <romain.naour@openwide.fr> wrote:
> Hi Thomas,
>
> Le 24/08/2014 18:14, Thomas Petazzoni a ?crit :
>> Dear Romain Naour,
>>
>> On Fri, 22 Aug 2014 11:12:53 +0200, Romain Naour wrote:
>>> On fedora 20 64bits host, the file /usr/share/config.site contains
>>> a fix for installing libraries into /lib/lib64 on 64bits systems
>>> that redefine libdir in the generated Makefile
>>>
>>> For safety and avoid the bug #7262 [1], disable loading this file
>>> when running the configure script for the target and the host.
>>>
>>> Note: configure scripts generated with autoconf < 2.65 will source
>>> the /dev/null and print this line:
>>> "configure: loading site script /dev/null"
>>>
>>> [1]: https://bugs.busybox.net/show_bug.cgi?id=7262
>>>
>>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>>
>> I am wondering if this change should go in master (for 2014.08) or in
>> the next branch (for 2014.11). That close to the release, doing a
>> change in the core infrastructure seems a bit invasive to me. What if
>> it breaks the build of other packages? Seems unlikely, I admit, but
>> still. What do others think?
>
> I think this patch can go to next since the issue is already fixed in master but
> just for host-localedef.
>
> Actually, it seems that only host-localedef was affected by this issue.
>
I was going to judge 'master', but then I saw Romain's reply. The
reported bug is indeed already fixed, and no other problems were
reported so far, so I agree now with applying these patches to -next.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling
2014-08-22 9:12 [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling Romain Naour
` (2 preceding siblings ...)
2014-08-24 16:14 ` Thomas Petazzoni
@ 2014-09-14 22:38 ` Peter Korsgaard
3 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2014-09-14 22:38 UTC (permalink / raw)
To: buildroot
>>>>> "Romain" == Romain Naour <romain.naour@openwide.fr> writes:
> On fedora 20 64bits host, the file /usr/share/config.site contains
> a fix for installing libraries into /lib/lib64 on 64bits systems
> that redefine libdir in the generated Makefile
> For safety and avoid the bug #7262 [1], disable loading this file
> when running the configure script for the target and the host.
> Note: configure scripts generated with autoconf < 2.65 will source
> the /dev/null and print this line:
> "configure: loading site script /dev/null"
> [1]: https://bugs.busybox.net/show_bug.cgi?id=7262
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 2/2] Revert "package/localedef: don't use config.site when cross-compiling"
2014-08-22 9:12 ` [Buildroot] [PATCH v2 2/2] Revert "package/localedef: don't use config.site when cross-compiling" Romain Naour
2014-08-22 10:02 ` Thomas De Schampheleire
@ 2014-09-14 22:38 ` Peter Korsgaard
1 sibling, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2014-09-14 22:38 UTC (permalink / raw)
To: buildroot
>>>>> "Romain" == Romain Naour <romain.naour@openwide.fr> writes:
> CONFIG_SITE is now a part of pkg-autotools infrastructure.
> This reverts commit 85448febb3c9f21e6e4082fc344b3ef46261c782.
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v2: commit log: add missing Sob
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-09-14 22:38 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-22 9:12 [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling Romain Naour
2014-08-22 9:12 ` [Buildroot] [PATCH v2 2/2] Revert "package/localedef: don't use config.site when cross-compiling" Romain Naour
2014-08-22 10:02 ` Thomas De Schampheleire
2014-09-14 22:38 ` Peter Korsgaard
2014-08-22 10:01 ` [Buildroot] [PATCH v2 1/2] package/pkg-autotools: don't use config.site when cross-compiling Thomas De Schampheleire
2014-08-24 16:14 ` Thomas Petazzoni
2014-08-24 16:39 ` Romain Naour
2014-08-24 18:31 ` Thomas De Schampheleire
2014-09-14 22:38 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.