All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming-Hung Tsai <mingnus@gmail.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's
Date: Sun, 20 Mar 2016 23:59:09 +0800	[thread overview]
Message-ID: <CAAYit8RG-xgY=jxcmVG3tGdUSN93GGJ=KCKkGQsxL_SwAjjY0Q@mail.gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.11.1603172245520.21357@mail.ewheeler.net>

2016-03-18 6:45 GMT+08:00 Eric Wheeler <dm-devel@lists.ewheeler.net>:
>
> On Thu, 17 Mar 2016, Joe Thornber wrote:
>
>> If you're skipping the mappings does the new thin_ls provide enough
>> information for you?
>
> Our primary need is the ability to specify --device-id in the o:L:d output
> format (old_format.cc) with mappings.  Our nightly dumps now take 50
> seconds instead of 40 minutes since we only dump the dev_id's that we
> need.

I think that the --device-id option is required for thin_dump, but the
necessity of --skip-mappings could be discussed. If thin_ls supports
--device-id, then thin_dump might not require --skip-mappings.

I put my code here for reference (based on v0.7-devel)
https://github.com/mingnus/thin-provisioning-tools/commits/v0.7-thin_dump-enhancement
I borrow the option name "--skip-mappings" and function name
"set_skip_mappings" from Eric, since that they sounds more clear.

Build method:
# autoconf; ./configure --enable-dev-tools; make

My use cases:
# thin_dump --device-id=<dev_id> --format=<f> [--skip-mappings]


Ming-Hung Tsai

  parent reply	other threads:[~2016-03-20 15:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15  1:45 [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's Eric Wheeler
2016-03-15 10:59 ` Thanos Makatos
2016-03-15 17:51   ` Eric Wheeler
2016-03-16  5:42     ` Ming-Hung Tsai
2016-03-16 19:14       ` Eric Wheeler
2016-03-17 15:44   ` Joe Thornber
2016-03-17 15:45 ` Joe Thornber
2016-03-17 22:45   ` Eric Wheeler
2016-03-18  2:04     ` Ming-Hung Tsai
2016-03-18  6:45     ` Ming-Hung Tsai
2016-03-20 15:59     ` Ming-Hung Tsai [this message]
2016-03-24 15:35 ` Joe Thornber
2016-03-28  2:51   ` Eric Wheeler
2016-03-28 22:05   ` Eric Wheeler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAYit8RG-xgY=jxcmVG3tGdUSN93GGJ=KCKkGQsxL_SwAjjY0Q@mail.gmail.com' \
    --to=mingnus@gmail.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.