All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Wheeler <dm-devel@lists.ewheeler.net>
To: Joe Thornber <thornber@redhat.com>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's
Date: Mon, 28 Mar 2016 02:51:37 +0000 (UTC)	[thread overview]
Message-ID: <alpine.LRH.2.11.1603280249540.13440@mail.ewheeler.net> (raw)
In-Reply-To: <20160324153509.GA3101@rh-vpn>

On Thu, 24 Mar 2016, Joe Thornber wrote:
> On Tue, Mar 15, 2016 at 01:45:15AM +0000, Eric Wheeler wrote:
> > Hi Joe,
> > 
> > Please review the patch below when you have a moment.  I am interested in 
> > your feedback, and also interested in having this functionality merged 
> > upstream.  This was written against thin-provisioning-tools.git tag 
> > v0.5.6.
> 
> These changes are now on the v0.7-devel branch:
> 
> i) --dev-id to filter thin_dump output on device id, multiple selections allowed.
> ii) --skip-mappings
> iii) thin_dump now takes a format called 'custom' that let's you use a plugin emitter of your own.
> 
>      eg, 
> 
>      thin_dump --format custom=contrib/ewheeler_emitter.so /dev/sda
> 
> 
> The contrib/ directory is for third party contributions.  Use 'make
> contrib' to build it.  I've put your emitter and tmakatos' emitter in
> there already.
> 
> I hope that covers everything you need.

I think that will work nicely. Thank you!  

-Eric

> 
> - Joe
> 

  reply	other threads:[~2016-03-28  2:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15  1:45 [PATCH] thin_dump: added --device-id, --skip-mappings, and new output --format's Eric Wheeler
2016-03-15 10:59 ` Thanos Makatos
2016-03-15 17:51   ` Eric Wheeler
2016-03-16  5:42     ` Ming-Hung Tsai
2016-03-16 19:14       ` Eric Wheeler
2016-03-17 15:44   ` Joe Thornber
2016-03-17 15:45 ` Joe Thornber
2016-03-17 22:45   ` Eric Wheeler
2016-03-18  2:04     ` Ming-Hung Tsai
2016-03-18  6:45     ` Ming-Hung Tsai
2016-03-20 15:59     ` Ming-Hung Tsai
2016-03-24 15:35 ` Joe Thornber
2016-03-28  2:51   ` Eric Wheeler [this message]
2016-03-28 22:05   ` Eric Wheeler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.11.1603280249540.13440@mail.ewheeler.net \
    --to=dm-devel@lists.ewheeler.net \
    --cc=dm-devel@redhat.com \
    --cc=thornber@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.