From: Ricardo Salveti <ricardo@foundries.io>
To: Andy <andreas.kling@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 1/2] mozjs: set -fno-schedule-insns2 on both CFLAGS and CXXFLAGS
Date: Wed, 15 Aug 2018 23:17:31 -0300 [thread overview]
Message-ID: <CAAaKDhEao-tigyhko=j3AWGxJd4kzryQ1r2tLf6DrNMmwxEWnw@mail.gmail.com> (raw)
In-Reply-To: <CAE-gg=6XBsP+Nm0fdSrmou6bYWYYcb4=W7P78KJt=7MTrh98-g@mail.gmail.com>
On Tue, Aug 14, 2018 at 3:50 PM, Andy <andreas.kling@gmail.com> wrote:
> Hi,
>
> Am Do., 2. Aug. 2018 um 10:34 Uhr schrieb Khem Raj <raj.khem@gmail.com>:
>>
>> Hi Ricardo
>>
>>
>> On Tue, Jul 31, 2018 at 8:06 PM Ricardo Salveti <ricardo@foundries.io> wrote:
>> >
>> > Mozjs fails to start on several architectures due broken build
>> > optimizations when building with GCC >= 6.
>> >
>> > Set -fno-schedule-insns2 as workaround (flag also used by Firefox and
>> > Debian).
>> >
>> > Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
>> > ---
>> > meta-oe/recipes-extended/mozjs/mozjs_52.8.1.bb | 5 +++++
>> > 1 file changed, 5 insertions(+)
>> >
>> > diff --git a/meta-oe/recipes-extended/mozjs/mozjs_52.8.1.bb b/meta-oe/recipes-extended/mozjs/mozjs_52.8.1.bb
>> > index da80b63..adc27ac 100644
>> > --- a/meta-oe/recipes-extended/mozjs/mozjs_52.8.1.bb
>> > +++ b/meta-oe/recipes-extended/mozjs/mozjs_52.8.1.bb
>> > @@ -30,6 +30,11 @@ CONFLICT_DISTRO_FEATURES_mipsarchn32 = "ld-is-gold"
>> >
>> > DEPENDS += "nspr zlib"
>> >
>> > +# Avoid broken JIT on several architectures (from Firefox and Debian)
>> > +# https://bugzilla.mozilla.org/show_bug.cgi?id=1245783
>> > +CFLAGS += "-fno-schedule-insns2"
>> > +CXXFLAGS += "-fno-schedule-insns2"
>> > +
>>
>> Could you test with -fno-tree-vrp -fno-strict-aliasing
>> -fno-delete-null-pointer-checks instead of -fno-schedule-insns2
>>
>
> at least polkit is able to start again using
>
> CFLAGS += "-fno-tree-vrp -fno-strict-aliasing -fno-delete-null-pointer-checks"
> CXXFLAGS += "-fno-tree-vrp -fno-strict-aliasing -fno-delete-null-pointer-checks"
>
> before I got:
> Assertion failure: !joinable()
> in cortexa7t2hf-neon-poky-linux-gnueabi/mozjs/52.8.1-r0/mozjs-52.8.1/js/src/threading/Thread.h:122
Finally able to test this locally across multiple builds, and these
flags seems to be working fine as well.
Looking around and it seems fedora is also using the flags you
suggested, should we use them instead of '-fno-schedule-insns2'? If
so, I can prepare another patch with the new changes.
Thanks,
--
Ricardo Salveti
next prev parent reply other threads:[~2018-08-16 2:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 3:06 [PATCH 1/2] mozjs: set -fno-schedule-insns2 on both CFLAGS and CXXFLAGS Ricardo Salveti
2018-08-01 3:06 ` [PATCH 2/2] mozjs: add support for RISC-V Ricardo Salveti
2018-08-02 8:34 ` [PATCH 1/2] mozjs: set -fno-schedule-insns2 on both CFLAGS and CXXFLAGS Khem Raj
2018-08-14 18:50 ` Andy
2018-08-16 2:17 ` Ricardo Salveti [this message]
2018-08-16 2:27 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAaKDhEao-tigyhko=j3AWGxJd4kzryQ1r2tLf6DrNMmwxEWnw@mail.gmail.com' \
--to=ricardo@foundries.io \
--cc=andreas.kling@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.