All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: ricardo@foundries.io
Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [PATCH 1/2] mozjs: set -fno-schedule-insns2 on both CFLAGS and CXXFLAGS
Date: Thu, 2 Aug 2018 01:34:24 -0700	[thread overview]
Message-ID: <CAMKF1sqAMyN2QErgLn1VZ4hxXjm-fGdRTnZ5ZeBEs5mXOqEL+g@mail.gmail.com> (raw)
In-Reply-To: <1533092773-22300-1-git-send-email-ricardo@foundries.io>

Hi Ricardo


On Tue, Jul 31, 2018 at 8:06 PM Ricardo Salveti <ricardo@foundries.io> wrote:
>
> Mozjs fails to start on several architectures due broken build
> optimizations when building with GCC >= 6.
>
> Set -fno-schedule-insns2 as workaround (flag also used by Firefox and
> Debian).
>
> Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
> ---
>  meta-oe/recipes-extended/mozjs/mozjs_52.8.1.bb | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta-oe/recipes-extended/mozjs/mozjs_52.8.1.bb b/meta-oe/recipes-extended/mozjs/mozjs_52.8.1.bb
> index da80b63..adc27ac 100644
> --- a/meta-oe/recipes-extended/mozjs/mozjs_52.8.1.bb
> +++ b/meta-oe/recipes-extended/mozjs/mozjs_52.8.1.bb
> @@ -30,6 +30,11 @@ CONFLICT_DISTRO_FEATURES_mipsarchn32 = "ld-is-gold"
>
>  DEPENDS += "nspr zlib"
>
> +# Avoid broken JIT on several architectures (from Firefox and Debian)
> +# https://bugzilla.mozilla.org/show_bug.cgi?id=1245783
> +CFLAGS += "-fno-schedule-insns2"
> +CXXFLAGS += "-fno-schedule-insns2"
> +

Could you test with -fno-tree-vrp -fno-strict-aliasing
-fno-delete-null-pointer-checks instead of -fno-schedule-insns2

>  # nspr's package-config is ignored so set libs manually
>  EXTRA_OECONF = " \
>      --target=${TARGET_SYS} \
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


  parent reply	other threads:[~2018-08-02  8:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01  3:06 [PATCH 1/2] mozjs: set -fno-schedule-insns2 on both CFLAGS and CXXFLAGS Ricardo Salveti
2018-08-01  3:06 ` [PATCH 2/2] mozjs: add support for RISC-V Ricardo Salveti
2018-08-02  8:34 ` Khem Raj [this message]
2018-08-14 18:50   ` [PATCH 1/2] mozjs: set -fno-schedule-insns2 on both CFLAGS and CXXFLAGS Andy
2018-08-16  2:17     ` Ricardo Salveti
2018-08-16  2:27       ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMKF1sqAMyN2QErgLn1VZ4hxXjm-fGdRTnZ5ZeBEs5mXOqEL+g@mail.gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=ricardo@foundries.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.