Re: [PATCH v2] iio: humidity: hdc100x: Add ACPI HID table

[Kai-Heng Feng <kai.heng.feng@canonical.com>]

On Thu, Jan 6, 2022 at 10:33 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Thu, Jan 6, 2022 at 6:13 AM Kai-Heng Feng
> <kai.heng.feng@canonical.com> wrote:
> >
> > x86 boards may use ACPI HID "TXN1010" to for hdc100x device.
>
> to for --> for the

Will correct it.

>
> > So add an ACPI match table for that accordingly.
>
> ...
>
> >  - Change the ID to follow ACPI Spec
>
> Is there any evidence Texas Instrument allocated this ID, or you just
> created it yourself?
> Please, add an excerpt from email from them to confirm this.

Sure, let me ask our customer to provide the excerpt.

>
> ...
>
> > +static const struct acpi_device_id __maybe_unused hdc100x_acpi_match[] = {
> > +       { "TXN1010" },
>
> > +       { },
>
> No comma is needed.

Got it.

>
> > +};
>
> > +
>
> No blank line is needed.

Will update.

>
> > +MODULE_DEVICE_TABLE(acpi, hdc100x_acpi_match);
>
> ...
>
> > +               .acpi_match_table = ACPI_PTR(hdc100x_acpi_match),
>
> It's the wrong usage of ACPI_PTR().

Can you please explain a bit more?

ACPI_PTR() turns the value to NULL when ACPI is not enabled, seems to
be correct?
Not to mention most other drivers also use ACPI_PTR() for acpi_match_table.

>
> >         },
>
> All the comments are applicable to all your patches. Some of them I
> already commented on and even kbuild bot has sent you a complaint.

That one should be solved by adding __maybe_unused to acpi_device_id array.

Kai-Heng

>
> --
> With Best Regards,
> Andy Shevchenko