Re: [PATCH v2] iio: humidity: hdc100x: Add ACPI HID table

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Chris Lesiak <chris.lesiak@licor.com>,
	Matt Ranostay <matt.ranostay@konsulko.com>,
	linux-iio <linux-iio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iio: humidity: hdc100x: Add ACPI HID table
Date: Thu, 6 Jan 2022 16:32:42 +0200	[thread overview]
Message-ID: <CAHp75VdxV+4_yxJv1H1MZPpu02e2gHUkP55dduUqN7QJ2j6aGg@mail.gmail.com> (raw)
In-Reply-To: <20220106041257.927664-1-kai.heng.feng@canonical.com>

On Thu, Jan 6, 2022 at 6:13 AM Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
>
> x86 boards may use ACPI HID "TXN1010" to for hdc100x device.

to for --> for the

> So add an ACPI match table for that accordingly.

...

>  - Change the ID to follow ACPI Spec

Is there any evidence Texas Instrument allocated this ID, or you just
created it yourself?
Please, add an excerpt from email from them to confirm this.

...

> +static const struct acpi_device_id __maybe_unused hdc100x_acpi_match[] = {
> +       { "TXN1010" },

> +       { },

No comma is needed.

> +};

> +

No blank line is needed.

> +MODULE_DEVICE_TABLE(acpi, hdc100x_acpi_match);

...

> +               .acpi_match_table = ACPI_PTR(hdc100x_acpi_match),

It's the wrong usage of ACPI_PTR().

>         },

All the comments are applicable to all your patches. Some of them I
already commented on and even kbuild bot has sent you a complaint.

-- 
With Best Regards,
Andy Shevchenko