All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jing Zhang <jingzhangos@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: KVM <kvm@vger.kernel.org>, KVMARM <kvmarm@lists.cs.columbia.edu>,
	LinuxMIPS <linux-mips@vger.kernel.org>,
	KVMPPC <kvm-ppc@vger.kernel.org>,
	LinuxS390 <linux-s390@vger.kernel.org>,
	Linuxkselftest <linux-kselftest@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
	Julien Thierry <julien.thierry.kdev@gmail.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Will Deacon <will@kernel.org>,
	Huacai Chen <chenhuacai@kernel.org>,
	Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Paul Mackerras <paulus@ozlabs.org>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Sean Christopherson <seanjc@google.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Jim Mattson <jmattson@google.com>,
	Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
	David Rientjes <rientjes@google.com>,
	Emanuele Giuseppe Esposito <eesposit@redhat.com>,
	David Matlack <dmatlack@google.com>,
	Ricardo Koller <ricarkol@google.com>,
	Krish Sadhukhan <krish.sadhukhan@oracle.com>,
	Fuad Tabba <tabba@google.com>
Subject: Re: [PATCH v10 3/5] KVM: stats: Add documentation for binary statistics interface
Date: Thu, 17 Jun 2021 10:09:27 -0500	[thread overview]
Message-ID: <CAAdAUtiySqu6VKpK2LDnG5S0m9tRKjrKSu5BWoFurkhWay4yCg@mail.gmail.com> (raw)
In-Reply-To: <YMrjKhV8TNwmRtf6@kroah.com>

Hi Greg,

On Thu, Jun 17, 2021 at 12:52 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Jun 17, 2021 at 04:41:44AM +0000, Jing Zhang wrote:
> > +     struct kvm_stats_desc {
> > +             __u32 flags;
> > +             __s16 exponent;
> > +             __u16 size;
> > +             __u32 offset;
> > +             __u32 unused;
> > +             char name[0];
> > +     };
> > +
> > +The ``flags`` field contains the type and unit of the statistics data described
> > +by this descriptor. The following flags are supported:
> > +
> > +Bits 0-3 of ``flags`` encode the type:
>
> <snip>
>
> As flags is a bit field, what is the endian of it?  Native or LE or BE?
> I'm guessing "cpu native", but you should be explicit as userspace will
> have to deal with this somehow.
Sure, will add clarification for endianness.
>
> thanks,
>
> greg k-h

Thanks,
Jing

WARNING: multiple messages have this Message-ID (diff)
From: Jing Zhang <jingzhangos@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: KVM <kvm@vger.kernel.org>, David Hildenbrand <david@redhat.com>,
	Paul Mackerras <paulus@ozlabs.org>,
	Linuxkselftest <linux-kselftest@vger.kernel.org>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Will Deacon <will@kernel.org>,
	KVMARM <kvmarm@lists.cs.columbia.edu>,
	Emanuele Giuseppe Esposito <eesposit@redhat.com>,
	LinuxS390 <linux-s390@vger.kernel.org>,
	Janosch Frank <frankja@linux.ibm.com>,
	Marc Zyngier <maz@kernel.org>,
	Huacai Chen <chenhuacai@kernel.org>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
	David Rientjes <rientjes@google.com>,
	KVMPPC <kvm-ppc@vger.kernel.org>,
	Krish Sadhukhan <krish.sadhukhan@oracle.com>,
	David Matlack <dmatlack@google.com>,
	Jim Mattson <jmattson@google.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sean Christopherson <seanjc@google.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Peter Shier <pshier@google.com>,
	LinuxMIPS <linux-mips@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH v10 3/5] KVM: stats: Add documentation for binary statistics interface
Date: Thu, 17 Jun 2021 10:09:27 -0500	[thread overview]
Message-ID: <CAAdAUtiySqu6VKpK2LDnG5S0m9tRKjrKSu5BWoFurkhWay4yCg@mail.gmail.com> (raw)
In-Reply-To: <YMrjKhV8TNwmRtf6@kroah.com>

Hi Greg,

On Thu, Jun 17, 2021 at 12:52 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Jun 17, 2021 at 04:41:44AM +0000, Jing Zhang wrote:
> > +     struct kvm_stats_desc {
> > +             __u32 flags;
> > +             __s16 exponent;
> > +             __u16 size;
> > +             __u32 offset;
> > +             __u32 unused;
> > +             char name[0];
> > +     };
> > +
> > +The ``flags`` field contains the type and unit of the statistics data described
> > +by this descriptor. The following flags are supported:
> > +
> > +Bits 0-3 of ``flags`` encode the type:
>
> <snip>
>
> As flags is a bit field, what is the endian of it?  Native or LE or BE?
> I'm guessing "cpu native", but you should be explicit as userspace will
> have to deal with this somehow.
Sure, will add clarification for endianness.
>
> thanks,
>
> greg k-h

Thanks,
Jing
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Jing Zhang <jingzhangos@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: KVM <kvm@vger.kernel.org>, KVMARM <kvmarm@lists.cs.columbia.edu>,
	LinuxMIPS <linux-mips@vger.kernel.org>,
	KVMPPC <kvm-ppc@vger.kernel.org>,
	LinuxS390 <linux-s390@vger.kernel.org>,
	Linuxkselftest <linux-kselftest@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
	Julien Thierry <julien.thierry.kdev@gmail.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Will Deacon <will@kernel.org>,
	Huacai Chen <chenhuacai@kernel.org>,
	Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Paul Mackerras <paulus@ozlabs.org>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Sean Christopherson <seanjc@google.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Jim Mattson <jmattson@google.com>,
	Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
	David Rientjes <rientjes@google.com>,
	Emanuele Giuseppe Esposito <eesposit@redhat.com>,
	David Matlack <dmatlack@google.com>,
	Ricardo Koller <ricarkol@google.com>,
	Krish Sadhukhan <krish.sadhukhan@oracle.com>,
	Fuad Tabba <tabba@google.com>
Subject: Re: [PATCH v10 3/5] KVM: stats: Add documentation for binary statistics interface
Date: Thu, 17 Jun 2021 15:09:27 +0000	[thread overview]
Message-ID: <CAAdAUtiySqu6VKpK2LDnG5S0m9tRKjrKSu5BWoFurkhWay4yCg@mail.gmail.com> (raw)
In-Reply-To: <YMrjKhV8TNwmRtf6@kroah.com>

Hi Greg,

On Thu, Jun 17, 2021 at 12:52 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Jun 17, 2021 at 04:41:44AM +0000, Jing Zhang wrote:
> > +     struct kvm_stats_desc {
> > +             __u32 flags;
> > +             __s16 exponent;
> > +             __u16 size;
> > +             __u32 offset;
> > +             __u32 unused;
> > +             char name[0];
> > +     };
> > +
> > +The ``flags`` field contains the type and unit of the statistics data described
> > +by this descriptor. The following flags are supported:
> > +
> > +Bits 0-3 of ``flags`` encode the type:
>
> <snip>
>
> As flags is a bit field, what is the endian of it?  Native or LE or BE?
> I'm guessing "cpu native", but you should be explicit as userspace will
> have to deal with this somehow.
Sure, will add clarification for endianness.
>
> thanks,
>
> greg k-h

Thanks,
Jing

  reply	other threads:[~2021-06-17 15:09 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  4:41 [PATCH v10 0/5] KVM statistics data fd-based binary interface Jing Zhang
2021-06-17  4:41 ` Jing Zhang
2021-06-17  4:41 ` [PATCH v10 1/5] KVM: stats: Separate generic stats from architecture specific ones Jing Zhang
2021-06-17  4:41   ` Jing Zhang
2021-06-17  4:41   ` Jing Zhang
2021-06-17  4:41 ` [PATCH v10 2/5] KVM: stats: Add fd-based API to read binary stats data Jing Zhang
2021-06-17  4:41   ` Jing Zhang
2021-06-17  4:41   ` Jing Zhang
2021-06-17  7:03   ` Greg KH
2021-06-17  7:03     ` Greg KH
2021-06-17  7:03     ` Greg KH
2021-06-17 11:23     ` Paolo Bonzini
2021-06-17 11:23       ` Paolo Bonzini
2021-06-17 11:23       ` Paolo Bonzini
2021-06-17 14:48     ` Jing Zhang
2021-06-17 14:48       ` Jing Zhang
2021-06-17 14:48       ` Jing Zhang
2021-06-17  7:24   ` Greg KH
2021-06-17  7:24     ` Greg KH
2021-06-17  7:24     ` Greg KH
2021-06-17 11:27     ` Paolo Bonzini
2021-06-17 11:27       ` Paolo Bonzini
2021-06-17 11:27       ` Paolo Bonzini
2021-06-17 14:56     ` Jing Zhang
2021-06-17 14:56       ` Jing Zhang
2021-06-17 14:56       ` Jing Zhang
2021-06-17 15:29       ` Paolo Bonzini
2021-06-17 15:29         ` Paolo Bonzini
2021-06-17 15:29         ` Paolo Bonzini
2021-06-17 15:42         ` Jing Zhang
2021-06-17 15:42           ` Jing Zhang
2021-06-17 15:42           ` Jing Zhang
2021-06-17  4:41 ` [PATCH v10 3/5] KVM: stats: Add documentation for binary statistics interface Jing Zhang
2021-06-17  4:41   ` Jing Zhang
2021-06-17  4:41   ` Jing Zhang
2021-06-17  5:52   ` Greg KH
2021-06-17  5:52     ` Greg KH
2021-06-17  5:52     ` Greg KH
2021-06-17 15:09     ` Jing Zhang [this message]
2021-06-17 15:09       ` Jing Zhang
2021-06-17 15:09       ` Jing Zhang
2021-06-17  5:56   ` Greg KH
2021-06-17  5:56     ` Greg KH
2021-06-17  5:56     ` Greg KH
2021-06-17 11:29     ` Paolo Bonzini
2021-06-17 11:29       ` Paolo Bonzini
2021-06-17 11:29       ` Paolo Bonzini
2021-06-17 11:42       ` Greg KH
2021-06-17 11:42         ` Greg KH
2021-06-17 11:42         ` Greg KH
2021-06-17 11:46         ` Paolo Bonzini
2021-06-17 11:46           ` Paolo Bonzini
2021-06-17 11:46           ` Paolo Bonzini
2021-06-17 15:45       ` Jing Zhang
2021-06-17 15:45         ` Jing Zhang
2021-06-17 15:45         ` Jing Zhang
2021-06-17 15:20     ` Jing Zhang
2021-06-17 15:20       ` Jing Zhang
2021-06-17 15:20       ` Jing Zhang
2021-06-17 22:15       ` Jing Zhang
2021-06-17 22:15         ` Jing Zhang
2021-06-17 22:15         ` Jing Zhang
2021-06-17  6:05   ` Greg KH
2021-06-17  6:05     ` Greg KH
2021-06-17  6:05     ` Greg KH
2021-06-17 15:41     ` Jing Zhang
2021-06-17 15:41       ` Jing Zhang
2021-06-17 15:41       ` Jing Zhang
2021-06-17  6:07   ` Greg KH
2021-06-17  6:07     ` Greg KH
2021-06-17  6:07     ` Greg KH
2021-06-17 11:19     ` Paolo Bonzini
2021-06-17 11:19       ` Paolo Bonzini
2021-06-17 11:19       ` Paolo Bonzini
2021-06-17 11:34       ` Greg KH
2021-06-17 11:34         ` Greg KH
2021-06-17 11:34         ` Greg KH
2021-06-17 15:51         ` Jing Zhang
2021-06-17 15:51           ` Jing Zhang
2021-06-17 15:51           ` Jing Zhang
2021-06-17  4:41 ` [PATCH v10 4/5] KVM: selftests: Add selftest for KVM statistics data binary interface Jing Zhang
2021-06-17  4:41   ` Jing Zhang
2021-06-17  4:41   ` Jing Zhang
2021-06-17  4:41 ` [PATCH v10 5/5] KVM: stats: Remove code duplication for binary and debugfs stats Jing Zhang
2021-06-17  4:41   ` Jing Zhang
2021-06-17  4:41   ` Jing Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAdAUtiySqu6VKpK2LDnG5S0m9tRKjrKSu5BWoFurkhWay4yCg@mail.gmail.com \
    --to=jingzhangos@google.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=borntraeger@de.ibm.com \
    --cc=chenhuacai@kernel.org \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=dmatlack@google.com \
    --cc=eesposit@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=imbrenda@linux.ibm.com \
    --cc=james.morse@arm.com \
    --cc=jmattson@google.com \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=krish.sadhukhan@oracle.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oupton@google.com \
    --cc=paulus@ozlabs.org \
    --cc=pbonzini@redhat.com \
    --cc=pshier@google.com \
    --cc=ricarkol@google.com \
    --cc=rientjes@google.com \
    --cc=seanjc@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tabba@google.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=vkuznets@redhat.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.