All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jing Zhang <jingzhangos@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: David Matlack <dmatlack@google.com>, KVM <kvm@vger.kernel.org>,
	KVMPPC <kvm-ppc@vger.kernel.org>,
	Sean Christopherson <seanjc@google.com>,
	Jim Mattson <jmattson@google.com>,
	Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v1 2/4] KVM: stats: Update doc for histogram statistics
Date: Fri, 30 Jul 2021 10:32:43 -0700	[thread overview]
Message-ID: <CAAdAUtj-e=bvZ07iH7r7eqg4Fy-KaPPgQiMHHVOh8EL4GfUJqA@mail.gmail.com> (raw)
In-Reply-To: <40bb3dd8-346e-81ee-8ec1-b41a46a8cbdf@redhat.com>

On Wed, Jul 28, 2021 at 5:42 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 08/07/21 01:31, David Matlack wrote:
> >> +
> >> +8.35 KVM_CAP_STATS_BINARY_FD
> >> +----------------------------
> >> +
> >> +:Architectures: all
> >> +
> >> +This capability indicates the feature that userspace can get a file descriptor
> >> +for every VM and VCPU to read statistics data in binary format.
> > This should probably be in a separate patch with a Fixes tag.
>
> Generally this chapter (which is probably incomplete, though) only
> includes capabilities for which KVM_CHECK_EXTENSION can return a value
> other than 0 or 1.  So there is no need to include KVM_CAP_STATS_BINARY_FD.
Got it. Will drop this change.
>
> Paolo
>
Thanks,
Jing

WARNING: multiple messages have this Message-ID (diff)
From: Jing Zhang <jingzhangos@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: David Matlack <dmatlack@google.com>, KVM <kvm@vger.kernel.org>,
	KVMPPC <kvm-ppc@vger.kernel.org>,
	Sean Christopherson <seanjc@google.com>,
	Jim Mattson <jmattson@google.com>,
	Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v1 2/4] KVM: stats: Update doc for histogram statistics
Date: Fri, 30 Jul 2021 17:32:43 +0000	[thread overview]
Message-ID: <CAAdAUtj-e=bvZ07iH7r7eqg4Fy-KaPPgQiMHHVOh8EL4GfUJqA@mail.gmail.com> (raw)
In-Reply-To: <40bb3dd8-346e-81ee-8ec1-b41a46a8cbdf@redhat.com>

On Wed, Jul 28, 2021 at 5:42 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 08/07/21 01:31, David Matlack wrote:
> >> +
> >> +8.35 KVM_CAP_STATS_BINARY_FD
> >> +----------------------------
> >> +
> >> +:Architectures: all
> >> +
> >> +This capability indicates the feature that userspace can get a file descriptor
> >> +for every VM and VCPU to read statistics data in binary format.
> > This should probably be in a separate patch with a Fixes tag.
>
> Generally this chapter (which is probably incomplete, though) only
> includes capabilities for which KVM_CHECK_EXTENSION can return a value
> other than 0 or 1.  So there is no need to include KVM_CAP_STATS_BINARY_FD.
Got it. Will drop this change.
>
> Paolo
>
Thanks,
Jing

  reply	other threads:[~2021-07-30 17:32 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 18:03 [PATCH v1 0/4] Linear and Logarithmic histogram statistics Jing Zhang
2021-07-06 18:03 ` Jing Zhang
2021-07-06 18:03 ` [PATCH v1 1/4] KVM: stats: Support linear and logarithmic " Jing Zhang
2021-07-06 18:03   ` Jing Zhang
2021-07-08 21:01   ` David Matlack
2021-07-08 21:01     ` David Matlack
2021-07-08 21:40     ` Jing Zhang
2021-07-08 21:40       ` Jing Zhang
2021-07-08 21:45       ` David Matlack
2021-07-08 21:45         ` David Matlack
2021-07-12 14:10   ` kernel test robot
2021-07-12 14:10     ` kernel test robot
2021-07-12 14:10     ` kernel test robot
2021-07-12 16:16     ` Jing Zhang
2021-07-12 16:16       ` Jing Zhang
2021-07-12 16:16       ` Jing Zhang
2021-07-12 18:53   ` kernel test robot
2021-07-12 18:53     ` kernel test robot
2021-07-12 18:53     ` kernel test robot
2021-07-28 12:39   ` Paolo Bonzini
2021-07-28 12:39     ` Paolo Bonzini
2021-07-30 17:31     ` Jing Zhang
2021-07-30 17:31       ` Jing Zhang
2021-07-06 18:03 ` [PATCH v1 2/4] KVM: stats: Update doc for " Jing Zhang
2021-07-06 18:03   ` Jing Zhang
2021-07-07 23:31   ` David Matlack
2021-07-07 23:31     ` David Matlack
2021-07-08 14:29     ` Jing Zhang
2021-07-08 14:29       ` Jing Zhang
2021-07-28 12:42     ` Paolo Bonzini
2021-07-28 12:42       ` Paolo Bonzini
2021-07-30 17:32       ` Jing Zhang [this message]
2021-07-30 17:32         ` Jing Zhang
2021-07-08 21:14   ` David Matlack
2021-07-08 21:14     ` David Matlack
2021-07-08 21:16     ` David Matlack
2021-07-08 21:16       ` David Matlack
2021-07-08 21:43       ` Jing Zhang
2021-07-08 21:43         ` Jing Zhang
2021-07-06 18:03 ` [PATCH v1 3/4] KVM: selftests: Add checks for histogram stats parameters Jing Zhang
2021-07-06 18:03   ` Jing Zhang
2021-07-08 21:26   ` David Matlack
2021-07-08 21:26     ` David Matlack
2021-07-06 18:03 ` [PATCH v1 4/4] KVM: stats: Add halt polling related histogram stats Jing Zhang
2021-07-06 18:03   ` Jing Zhang
2021-07-08 21:42   ` David Matlack
2021-07-08 21:42     ` David Matlack
2021-07-09 15:18     ` Jing Zhang
2021-07-09 15:18       ` Jing Zhang
2021-07-09 15:25       ` David Matlack
2021-07-09 15:25         ` David Matlack
2021-07-28 12:45   ` Paolo Bonzini
2021-07-28 12:45     ` Paolo Bonzini
2021-07-30 17:34     ` Jing Zhang
2021-07-30 17:34       ` Jing Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAdAUtj-e=bvZ07iH7r7eqg4Fy-KaPPgQiMHHVOh8EL4GfUJqA@mail.gmail.com' \
    --to=jingzhangos@google.com \
    --cc=dmatlack@google.com \
    --cc=jmattson@google.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=oupton@google.com \
    --cc=pbonzini@redhat.com \
    --cc=pshier@google.com \
    --cc=rientjes@google.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.