* [PATCH] common-user: Fix tail calls to safe_syscall_set_errno_tail
@ 2022-01-04 19:04 Richard Henderson
2022-01-04 19:17 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Richard Henderson @ 2022-01-04 19:04 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier
For the ABIs in which the syscall return register is not
also the first function argument register, move the errno
value into the correct place.
Fixes: a3310c0397e2
Reported-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
common-user/host/i386/safe-syscall.inc.S | 1 +
common-user/host/mips/safe-syscall.inc.S | 1 +
common-user/host/x86_64/safe-syscall.inc.S | 1 +
3 files changed, 3 insertions(+)
diff --git a/common-user/host/i386/safe-syscall.inc.S b/common-user/host/i386/safe-syscall.inc.S
index baf5400a29..9c45e56e48 100644
--- a/common-user/host/i386/safe-syscall.inc.S
+++ b/common-user/host/i386/safe-syscall.inc.S
@@ -120,6 +120,7 @@ safe_syscall_end:
pop %ebp
.cfi_adjust_cfa_offset -4
.cfi_restore ebp
+ mov %eax, (%esp)
jmp safe_syscall_set_errno_tail
.cfi_endproc
diff --git a/common-user/host/mips/safe-syscall.inc.S b/common-user/host/mips/safe-syscall.inc.S
index fc75a337d1..6a44614970 100644
--- a/common-user/host/mips/safe-syscall.inc.S
+++ b/common-user/host/mips/safe-syscall.inc.S
@@ -141,6 +141,7 @@ safe_syscall_end:
1: USE_ALT_CP(t0)
SETUP_GPX(t1)
SETUP_GPX64(t0, t1)
+ move a0, v0
PTR_LA t9, safe_syscall_set_errno_tail
jr t9
diff --git a/common-user/host/x86_64/safe-syscall.inc.S b/common-user/host/x86_64/safe-syscall.inc.S
index a20927a783..d1a67a303a 100644
--- a/common-user/host/x86_64/safe-syscall.inc.S
+++ b/common-user/host/x86_64/safe-syscall.inc.S
@@ -99,6 +99,7 @@ safe_syscall_end:
1: pop %rbp
.cfi_def_cfa_offset 8
.cfi_restore rbp
+ mov %eax, %edi
jmp safe_syscall_set_errno_tail
.cfi_endproc
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] common-user: Fix tail calls to safe_syscall_set_errno_tail
2022-01-04 19:04 [PATCH] common-user: Fix tail calls to safe_syscall_set_errno_tail Richard Henderson
@ 2022-01-04 19:17 ` Philippe Mathieu-Daudé
2022-01-04 20:16 ` Laurent Vivier
2022-01-04 23:40 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-01-04 19:17 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel@nongnu.org Developers, Laurent Vivier
On Tue, Jan 4, 2022 at 8:05 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> For the ABIs in which the syscall return register is not
> also the first function argument register, move the errno
> value into the correct place.
>
> Fixes: a3310c0397e2
Using Laurent alias [*]:
Fixes: a3310c0397e ("linux-user: Move syscall error detection into
safe_syscall_base")
[*] https://lore.kernel.org/qemu-devel/6c69b3b6-f1f0-da38-d47a-dba01e33bd6a@redhat.com/
> Reported-by: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> common-user/host/i386/safe-syscall.inc.S | 1 +
> common-user/host/mips/safe-syscall.inc.S | 1 +
> common-user/host/x86_64/safe-syscall.inc.S | 1 +
> 3 files changed, 3 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] common-user: Fix tail calls to safe_syscall_set_errno_tail
2022-01-04 19:04 [PATCH] common-user: Fix tail calls to safe_syscall_set_errno_tail Richard Henderson
2022-01-04 19:17 ` Philippe Mathieu-Daudé
@ 2022-01-04 20:16 ` Laurent Vivier
2022-01-04 23:40 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2022-01-04 20:16 UTC (permalink / raw)
To: Richard Henderson, qemu-devel
Le 04/01/2022 à 20:04, Richard Henderson a écrit :
> For the ABIs in which the syscall return register is not
> also the first function argument register, move the errno
> value into the correct place.
>
> Fixes: a3310c0397e2
> Reported-by: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> common-user/host/i386/safe-syscall.inc.S | 1 +
> common-user/host/mips/safe-syscall.inc.S | 1 +
> common-user/host/x86_64/safe-syscall.inc.S | 1 +
> 3 files changed, 3 insertions(+)
>
Tested-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] common-user: Fix tail calls to safe_syscall_set_errno_tail
2022-01-04 19:04 [PATCH] common-user: Fix tail calls to safe_syscall_set_errno_tail Richard Henderson
2022-01-04 19:17 ` Philippe Mathieu-Daudé
2022-01-04 20:16 ` Laurent Vivier
@ 2022-01-04 23:40 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2022-01-04 23:40 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier
On 1/4/22 11:04 AM, Richard Henderson wrote:
> For the ABIs in which the syscall return register is not
> also the first function argument register, move the errno
> value into the correct place.
>
> Fixes: a3310c0397e2
> Reported-by: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> common-user/host/i386/safe-syscall.inc.S | 1 +
> common-user/host/mips/safe-syscall.inc.S | 1 +
> common-user/host/x86_64/safe-syscall.inc.S | 1 +
> 3 files changed, 3 insertions(+)
Queued to tcg-next.
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-04 23:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 19:04 [PATCH] common-user: Fix tail calls to safe_syscall_set_errno_tail Richard Henderson
2022-01-04 19:17 ` Philippe Mathieu-Daudé
2022-01-04 20:16 ` Laurent Vivier
2022-01-04 23:40 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.