From: "Philippe Mathieu-Daudé" <f4bug@amsat.org> To: "Alex Bennée" <alex.bennee@linaro.org> Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Shahab Vahedi <shahab.vahedi@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH] cputlb: Fix io_readx() to respect the access_type Date: Sat, 20 Apr 2019 11:49:48 +0200 [thread overview] Message-ID: <CAAdtpL5yj3dDoxQ+_V32MDPE3bYa15wGHKSBOEgGdDSujPxgxw@mail.gmail.com> (raw) In-Reply-To: <871s1xha0f.fsf@zen.linaroharston> Hi Alex, Le sam. 20 avr. 2019 01:05, Alex Bennée <alex.bennee@linaro.org> a écrit : > > Shahab Vahedi <shahab.vahedi@gmail.com> writes: > > > This change adapts io_readx() to its input access_type. Currently > > io_readx() treats any memory access as a read, although it has an > > input argument "MMUAccessType access_type". This results in: > > > > 1) Calling the tlb_fill() only with MMU_DATA_LOAD > > 2) Considering only entry->addr_read as the tlb_addr > > > > Buglink: https://bugs.launchpad.net/qemu/+bug/1825359 > > This bug talks about the distinction between DATA_LOAD and INST_FETCH > but... > > > > > Signed-off-by: Shahab Vahedi <shahab.vahedi@gmail.com> > > --- > > accel/tcg/cputlb.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c > > index 88cc8389e9..0daac0e806 100644 > > --- a/accel/tcg/cputlb.c > > +++ b/accel/tcg/cputlb.c > > @@ -878,10 +878,13 @@ static uint64_t io_readx(CPUArchState *env, > CPUIOTLBEntry *iotlbentry, > > CPUTLBEntry *entry; > > target_ulong tlb_addr; > > > > - tlb_fill(cpu, addr, size, MMU_DATA_LOAD, mmu_idx, retaddr); > > + tlb_fill(cpu, addr, size, access_type, mmu_idx, retaddr); > > > > entry = tlb_entry(env, mmu_idx, addr); > > - tlb_addr = entry->addr_read; > > + tlb_addr = > > + (access_type == MMU_DATA_LOAD ) ? entry->addr_read : > > + (access_type == MMU_DATA_STORE) ? entry->addr_write : > > + entry->addr_code; > > ...why do we care here about MMU_DATA_STORE? > > We could just assert (access_type == MMU_DATA_LOAD || access_type == > MMU_INST_FETCH) and then have: > Is asserting the best we can do here? > (access_type == MMU_DATA_LOAD ) ? entry->addr_read : entry->addr_code > > > > if (!(tlb_addr & ~(TARGET_PAGE_MASK | TLB_RECHECK))) { > > /* RAM access */ > > uintptr_t haddr = addr + entry->addend; > > > -- > Alex Bennée > >
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org> To: "Alex Bennée" <alex.bennee@linaro.org> Cc: Shahab Vahedi <shahab.vahedi@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH] cputlb: Fix io_readx() to respect the access_type Date: Sat, 20 Apr 2019 11:49:48 +0200 [thread overview] Message-ID: <CAAdtpL5yj3dDoxQ+_V32MDPE3bYa15wGHKSBOEgGdDSujPxgxw@mail.gmail.com> (raw) Message-ID: <20190420094948.LhCJNqmOIbQr-fxavHmLB3h2cqVrteVH7ICEcEBhsWg@z> (raw) In-Reply-To: <871s1xha0f.fsf@zen.linaroharston> Hi Alex, Le sam. 20 avr. 2019 01:05, Alex Bennée <alex.bennee@linaro.org> a écrit : > > Shahab Vahedi <shahab.vahedi@gmail.com> writes: > > > This change adapts io_readx() to its input access_type. Currently > > io_readx() treats any memory access as a read, although it has an > > input argument "MMUAccessType access_type". This results in: > > > > 1) Calling the tlb_fill() only with MMU_DATA_LOAD > > 2) Considering only entry->addr_read as the tlb_addr > > > > Buglink: https://bugs.launchpad.net/qemu/+bug/1825359 > > This bug talks about the distinction between DATA_LOAD and INST_FETCH > but... > > > > > Signed-off-by: Shahab Vahedi <shahab.vahedi@gmail.com> > > --- > > accel/tcg/cputlb.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c > > index 88cc8389e9..0daac0e806 100644 > > --- a/accel/tcg/cputlb.c > > +++ b/accel/tcg/cputlb.c > > @@ -878,10 +878,13 @@ static uint64_t io_readx(CPUArchState *env, > CPUIOTLBEntry *iotlbentry, > > CPUTLBEntry *entry; > > target_ulong tlb_addr; > > > > - tlb_fill(cpu, addr, size, MMU_DATA_LOAD, mmu_idx, retaddr); > > + tlb_fill(cpu, addr, size, access_type, mmu_idx, retaddr); > > > > entry = tlb_entry(env, mmu_idx, addr); > > - tlb_addr = entry->addr_read; > > + tlb_addr = > > + (access_type == MMU_DATA_LOAD ) ? entry->addr_read : > > + (access_type == MMU_DATA_STORE) ? entry->addr_write : > > + entry->addr_code; > > ...why do we care here about MMU_DATA_STORE? > > We could just assert (access_type == MMU_DATA_LOAD || access_type == > MMU_INST_FETCH) and then have: > Is asserting the best we can do here? > (access_type == MMU_DATA_LOAD ) ? entry->addr_read : entry->addr_code > > > > if (!(tlb_addr & ~(TARGET_PAGE_MASK | TLB_RECHECK))) { > > /* RAM access */ > > uintptr_t haddr = addr + entry->addend; > > > -- > Alex Bennée > >
next prev parent reply other threads:[~2019-04-20 10:05 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-19 10:37 [Qemu-devel] [PATCH] cputlb: Fix io_readx() to respect the access_type Shahab Vahedi 2019-04-19 10:37 ` Shahab Vahedi 2019-04-19 10:41 ` no-reply 2019-04-19 10:41 ` no-reply 2019-04-19 23:04 ` Alex Bennée 2019-04-20 9:49 ` Philippe Mathieu-Daudé [this message] 2019-04-20 9:49 ` Philippe Mathieu-Daudé 2019-04-19 11:45 Shahab Vahedi 2019-04-19 11:45 ` Shahab Vahedi 2019-04-20 18:57 ` Peter Maydell 2019-04-20 18:57 ` Peter Maydell 2019-04-21 8:03 ` Shahab Vahedi 2019-04-21 8:03 ` Shahab Vahedi 2019-04-21 14:19 ` Peter Maydell 2019-04-21 14:19 ` Peter Maydell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAdtpL5yj3dDoxQ+_V32MDPE3bYa15wGHKSBOEgGdDSujPxgxw@mail.gmail.com \ --to=f4bug@amsat.org \ --cc=alex.bennee@linaro.org \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=shahab.vahedi@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.