* [Qemu-devel] [PATCH] util/cacheinfo: add missing include
@ 2017-07-11 1:55 Philippe Mathieu-Daudé
2017-07-11 2:38 ` Richard Henderson
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-07-11 1:55 UTC (permalink / raw)
To: qemu-devel, Emilio G. Cota, Richard Henderson, Pranith Kumar,
Alex Bennée, David Gibson, Geert Martin Ijewski
Cc: Philippe Mathieu-Daudé
This include was forgotten when splitting cacheinfo.c out of
tcg/ppc/tcg-target.inc.c (see commit b255b2c8).
While compiling on powerpc:
CC util/cacheinfo.o
qemu/util/cacheinfo.c: In function 'arch_cache_info':
qemu/util/cacheinfo.c:137:33: error: 'AT_ICACHEBSIZE' undeclared (first use in this function)
*isize = qemu_getauxval(AT_ICACHEBSIZE);
^
qemu/util/cacheinfo.c:137:33: note: each undeclared identifier is reported only once for each function it appears in
qemu/util/cacheinfo.c:140:33: error: 'AT_DCACHEBSIZE' undeclared (first use in this function)
*dsize = qemu_getauxval(AT_DCACHEBSIZE);
^
qemu/rules.mak:66: recipe for target 'util/cacheinfo.o' failed
make: *** [util/cacheinfo.o] Error 1
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
util/cacheinfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/cacheinfo.c b/util/cacheinfo.c
index 6253049533..593940f27b 100644
--- a/util/cacheinfo.c
+++ b/util/cacheinfo.c
@@ -129,6 +129,7 @@ static void arch_cache_info(int *isize, int *dsize)
}
#elif defined(_ARCH_PPC) && defined(__linux__)
+# include "elf.h"
static void arch_cache_info(int *isize, int *dsize)
{
--
2.13.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] util/cacheinfo: add missing include
2017-07-11 1:55 [Qemu-devel] [PATCH] util/cacheinfo: add missing include Philippe Mathieu-Daudé
@ 2017-07-11 2:38 ` Richard Henderson
2017-07-11 3:27 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Richard Henderson @ 2017-07-11 2:38 UTC (permalink / raw)
To: Philippe Mathieu-Daudé,
qemu-devel, Emilio G. Cota, Pranith Kumar, Alex Bennée,
David Gibson, Geert Martin Ijewski
On 07/10/2017 03:55 PM, Philippe Mathieu-Daudé wrote:
> This include was forgotten when splitting cacheinfo.c out of
> tcg/ppc/tcg-target.inc.c (see commit b255b2c8).
>
> While compiling on powerpc:
>
> CC util/cacheinfo.o
> qemu/util/cacheinfo.c: In function 'arch_cache_info':
> qemu/util/cacheinfo.c:137:33: error: 'AT_ICACHEBSIZE' undeclared (first use in this function)
> *isize = qemu_getauxval(AT_ICACHEBSIZE);
> ^
> qemu/util/cacheinfo.c:137:33: note: each undeclared identifier is reported only once for each function it appears in
> qemu/util/cacheinfo.c:140:33: error: 'AT_DCACHEBSIZE' undeclared (first use in this function)
> *dsize = qemu_getauxval(AT_DCACHEBSIZE);
> ^
> qemu/rules.mak:66: recipe for target 'util/cacheinfo.o' failed
> make: *** [util/cacheinfo.o] Error 1
For the record, what is the os version?
Because this doesn't happen here for Centos7.
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] util/cacheinfo: add missing include
2017-07-11 2:38 ` Richard Henderson
@ 2017-07-11 3:27 ` Philippe Mathieu-Daudé
2017-07-12 1:02 ` Richard Henderson
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-07-11 3:27 UTC (permalink / raw)
To: Richard Henderson
Cc: qemu-devel@nongnu.org Developers, Emilio G. Cota, Pranith Kumar,
Alex Bennée, David Gibson, Geert Martin Ijewski
Hi Richard,
On Mon, Jul 10, 2017 at 11:38 PM, Richard Henderson <rth@twiddle.net> wrote:
> On 07/10/2017 03:55 PM, Philippe Mathieu-Daudé wrote:
>>
>> This include was forgotten when splitting cacheinfo.c out of
>> tcg/ppc/tcg-target.inc.c (see commit b255b2c8).
>>
>> While compiling on powerpc:
>>
>> CC util/cacheinfo.o
>> qemu/util/cacheinfo.c: In function 'arch_cache_info':
>> qemu/util/cacheinfo.c:137:33: error: 'AT_ICACHEBSIZE' undeclared
>> (first use in this function)
>> *isize = qemu_getauxval(AT_ICACHEBSIZE);
>> ^
>> qemu/util/cacheinfo.c:137:33: note: each undeclared identifier is
>> reported only once for each function it appears in
>> qemu/util/cacheinfo.c:140:33: error: 'AT_DCACHEBSIZE' undeclared
>> (first use in this function)
>> *dsize = qemu_getauxval(AT_DCACHEBSIZE);
>> ^
>> qemu/rules.mak:66: recipe for target 'util/cacheinfo.o' failed
>> make: *** [util/cacheinfo.o] Error 1
>
>
> For the record, what is the os version?
> Because this doesn't happen here for Centos7.
Oops true I forgot to log this info in the commit.
This happens on debian/powerpc Jessie, using GCC 4.9.2-10
$ make subdir-ppc-softmmu
CC util/cacheinfo.o
/home/phil/source/qemu/util/cacheinfo.c: In function 'arch_cache_info':
/home/phil/source/qemu/util/cacheinfo.c:137:33: error:
'AT_ICACHEBSIZE' undeclared (first use in this function)
*isize = qemu_getauxval(AT_ICACHEBSIZE);
^
compiling with -dU:
#define _ARCH_PPC 1
# 134 "/home/phil/source/qemu/util/cacheinfo.c"
static void arch_cache_info(int *isize, int *dsize)
{
if (*isize == 0) {
*isize = qemu_getauxval(AT_ICACHEBSIZE);
}
if (*dsize == 0) {
*dsize = qemu_getauxval(AT_DCACHEBSIZE);
}
}
Regards,
Phil.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] util/cacheinfo: add missing include
2017-07-11 3:27 ` Philippe Mathieu-Daudé
@ 2017-07-12 1:02 ` Richard Henderson
0 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2017-07-12 1:02 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel@nongnu.org Developers, Emilio G. Cota, Pranith Kumar,
Alex Bennée, David Gibson, Geert Martin Ijewski
On 07/10/2017 05:27 PM, Philippe Mathieu-Daudé wrote:
>> For the record, what is the os version?
>> Because this doesn't happen here for Centos7.
> Oops true I forgot to log this info in the commit.
>
> This happens on debian/powerpc Jessie, using GCC 4.9.2-10
Thanks. Queued to tcg-next.
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-12 1:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-11 1:55 [Qemu-devel] [PATCH] util/cacheinfo: add missing include Philippe Mathieu-Daudé
2017-07-11 2:38 ` Richard Henderson
2017-07-11 3:27 ` Philippe Mathieu-Daudé
2017-07-12 1:02 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.