From: Andrey Konovalov <andreyknvl@google.com> To: Marco Elver <elver@google.com> Cc: Dmitry Vyukov <dvyukov@google.com>, Alexander Potapenko <glider@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Evgenii Stepanov <eugenis@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Branislav Rankov <Branislav.Rankov@arm.com>, Kevin Brodsky <kevin.brodsky@arm.com>, Andrew Morton <akpm@linux-foundation.org>, kasan-dev <kasan-dev@googlegroups.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Memory Management List <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 10/20] kasan: inline and rename kasan_unpoison_memory Date: Thu, 12 Nov 2020 20:45:18 +0100 [thread overview] Message-ID: <CAAeHK+wvvkYko=tM=NHODkKas13h5Jvsswvg05jhv9LqE0jSjQ@mail.gmail.com> (raw) In-Reply-To: <20201111174902.GK517454@elver.google.com> On Wed, Nov 11, 2020 at 6:49 PM Marco Elver <elver@google.com> wrote: > > On Tue, Nov 10, 2020 at 11:20PM +0100, Andrey Konovalov wrote: > > Currently kasan_unpoison_memory() is used as both an external annotation > > and as an internal memory poisoning helper. Rename external annotation to > > kasan_unpoison_data() and inline the internal helper for hardware > > tag-based mode to avoid undeeded function calls. > > I don't understand why this needs to be renamed again. The users of > kasan_unpoison_memory() outweigh those of kasan_unpoison_slab(), of > which there seems to be only 1! The idea is to make kasan_(un)poison_memory() functions inlinable for internal use. It doesn't have anything to do with the number of times they are used. Perhaps we can drop the kasan_ prefix for the internal implementations though, and keep using kasan_unpoison_memory() externally. > So can't we just get rid of kasan_unpoison_slab() and just open-code it > in mm/mempool.c:kasan_unpoison_element()? That function is already > kasan-prefixed, so we can even place a small comment there (which would > also be an improvement over current interface, since > kasan_unpoison_slab() is not documented and its existence not quite > justified). We can, but this is a change unrelated to this patch.
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Konovalov <andreyknvl@google.com> To: Marco Elver <elver@google.com> Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>, Branislav Rankov <Branislav.Rankov@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Kevin Brodsky <kevin.brodsky@arm.com>, Will Deacon <will.deacon@arm.com>, LKML <linux-kernel@vger.kernel.org>, kasan-dev <kasan-dev@googlegroups.com>, Linux Memory Management List <linux-mm@kvack.org>, Alexander Potapenko <glider@google.com>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Andrew Morton <akpm@linux-foundation.org>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Evgenii Stepanov <eugenis@google.com> Subject: Re: [PATCH v2 10/20] kasan: inline and rename kasan_unpoison_memory Date: Thu, 12 Nov 2020 20:45:18 +0100 [thread overview] Message-ID: <CAAeHK+wvvkYko=tM=NHODkKas13h5Jvsswvg05jhv9LqE0jSjQ@mail.gmail.com> (raw) In-Reply-To: <20201111174902.GK517454@elver.google.com> On Wed, Nov 11, 2020 at 6:49 PM Marco Elver <elver@google.com> wrote: > > On Tue, Nov 10, 2020 at 11:20PM +0100, Andrey Konovalov wrote: > > Currently kasan_unpoison_memory() is used as both an external annotation > > and as an internal memory poisoning helper. Rename external annotation to > > kasan_unpoison_data() and inline the internal helper for hardware > > tag-based mode to avoid undeeded function calls. > > I don't understand why this needs to be renamed again. The users of > kasan_unpoison_memory() outweigh those of kasan_unpoison_slab(), of > which there seems to be only 1! The idea is to make kasan_(un)poison_memory() functions inlinable for internal use. It doesn't have anything to do with the number of times they are used. Perhaps we can drop the kasan_ prefix for the internal implementations though, and keep using kasan_unpoison_memory() externally. > So can't we just get rid of kasan_unpoison_slab() and just open-code it > in mm/mempool.c:kasan_unpoison_element()? That function is already > kasan-prefixed, so we can even place a small comment there (which would > also be an improvement over current interface, since > kasan_unpoison_slab() is not documented and its existence not quite > justified). We can, but this is a change unrelated to this patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-12 19:45 UTC|newest] Thread overview: 166+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-10 22:20 [PATCH v2 00/20] kasan: boot parameters for hardware tag-based mode Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` [PATCH v2 01/20] kasan: simplify quarantine_put call site Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 16:08 ` Marco Elver 2020-11-11 16:08 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 02/20] kasan: rename get_alloc/free_info Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 16:09 ` Marco Elver 2020-11-11 16:09 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 03/20] kasan: introduce set_alloc_info Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 16:10 ` Marco Elver 2020-11-11 16:10 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 04/20] kasan, arm64: unpoison stack only with CONFIG_KASAN_STACK Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 16:13 ` Marco Elver 2020-11-11 16:13 ` Marco Elver 2020-11-12 9:51 ` Catalin Marinas 2020-11-12 9:51 ` Catalin Marinas 2020-11-12 19:38 ` Andrey Konovalov 2020-11-12 19:38 ` Andrey Konovalov 2020-11-12 19:38 ` Andrey Konovalov 2020-11-10 22:20 ` [PATCH v2 05/20] kasan: allow VMAP_STACK for HW_TAGS mode Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 16:20 ` Marco Elver 2020-11-11 16:20 ` Marco Elver 2020-11-12 0:24 ` Andrey Konovalov 2020-11-12 0:24 ` Andrey Konovalov 2020-11-12 0:24 ` Andrey Konovalov 2020-11-12 10:31 ` Catalin Marinas 2020-11-12 10:31 ` Catalin Marinas 2020-11-10 22:20 ` [PATCH v2 06/20] kasan: remove __kasan_unpoison_stack Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 16:42 ` Marco Elver 2020-11-11 16:42 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 07/20] kasan: inline kasan_reset_tag for tag-based modes Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 16:54 ` Marco Elver 2020-11-11 16:54 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 08/20] kasan: inline random_tag for HW_TAGS Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 17:02 ` Marco Elver 2020-11-11 17:02 ` Marco Elver 2020-11-12 0:21 ` Andrey Konovalov 2020-11-12 0:21 ` Andrey Konovalov 2020-11-12 0:21 ` Andrey Konovalov 2020-11-10 22:20 ` [PATCH v2 09/20] kasan: inline kasan_poison_memory and check_invalid_free Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 17:50 ` Marco Elver 2020-11-11 17:50 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 10/20] kasan: inline and rename kasan_unpoison_memory Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 17:49 ` Marco Elver 2020-11-11 17:49 ` Marco Elver 2020-11-12 19:45 ` Andrey Konovalov [this message] 2020-11-12 19:45 ` Andrey Konovalov 2020-11-12 19:45 ` Andrey Konovalov 2020-11-12 19:52 ` Marco Elver 2020-11-12 19:52 ` Marco Elver 2020-11-12 19:52 ` Marco Elver 2020-11-12 20:54 ` Andrey Konovalov 2020-11-12 20:54 ` Andrey Konovalov 2020-11-12 20:54 ` Andrey Konovalov 2020-11-12 22:20 ` Marco Elver 2020-11-12 22:20 ` Marco Elver 2020-11-12 22:20 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 11/20] kasan: add and integrate kasan boot parameters Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 18:29 ` Marco Elver 2020-11-11 18:29 ` Marco Elver 2020-11-12 19:51 ` Andrey Konovalov 2020-11-12 19:51 ` Andrey Konovalov 2020-11-12 19:51 ` Andrey Konovalov 2020-11-12 11:35 ` Catalin Marinas 2020-11-12 11:35 ` Catalin Marinas 2020-11-12 11:53 ` Marco Elver 2020-11-12 11:53 ` Marco Elver 2020-11-12 11:53 ` Marco Elver 2020-11-12 12:54 ` Catalin Marinas 2020-11-12 12:54 ` Catalin Marinas 2020-11-12 19:52 ` Andrey Konovalov 2020-11-12 19:52 ` Andrey Konovalov 2020-11-12 19:52 ` Andrey Konovalov 2020-11-13 17:52 ` Marco Elver 2020-11-13 17:52 ` Marco Elver 2020-11-13 17:55 ` Marco Elver 2020-11-13 17:55 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 12/20] kasan, mm: check kasan_enabled in annotations Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 14:48 ` Marco Elver 2020-11-11 14:48 ` Marco Elver 2020-11-11 14:48 ` Marco Elver 2020-11-12 0:36 ` Andrey Konovalov 2020-11-12 0:36 ` Andrey Konovalov 2020-11-12 0:36 ` Andrey Konovalov 2020-11-10 22:20 ` [PATCH v2 13/20] kasan: simplify kasan_poison_kfree Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 18:42 ` Marco Elver 2020-11-11 18:42 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 14/20] kasan, mm: rename kasan_poison_kfree Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 18:53 ` Marco Elver 2020-11-11 18:53 ` Marco Elver 2020-11-12 1:05 ` Andrey Konovalov 2020-11-12 1:05 ` Andrey Konovalov 2020-11-12 1:05 ` Andrey Konovalov 2020-11-10 22:20 ` [PATCH v2 15/20] kasan: don't round_up too much Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 19:08 ` Marco Elver 2020-11-11 19:08 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 16/20] kasan: simplify assign_tag and set_tag calls Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 19:17 ` Marco Elver 2020-11-11 19:17 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 17/20] kasan: clarify comment in __kasan_kfree_large Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 19:18 ` Marco Elver 2020-11-11 19:18 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 18/20] kasan: clean up metadata allocation and usage Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 23:06 ` Marco Elver 2020-11-11 23:06 ` Marco Elver 2020-11-12 20:11 ` Andrey Konovalov 2020-11-12 20:11 ` Andrey Konovalov 2020-11-12 20:11 ` Andrey Konovalov 2020-11-10 22:20 ` [PATCH v2 19/20] kasan, mm: allow cache merging with no metadata Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 15:13 ` Marco Elver 2020-11-11 15:13 ` Marco Elver 2020-11-12 23:00 ` Andrey Konovalov 2020-11-12 23:00 ` Andrey Konovalov 2020-11-12 23:00 ` Andrey Konovalov 2020-11-11 23:27 ` Marco Elver 2020-11-11 23:27 ` Marco Elver 2020-11-10 22:20 ` [PATCH v2 20/20] kasan: update documentation Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-10 22:20 ` Andrey Konovalov 2020-11-11 16:03 ` Marco Elver 2020-11-11 16:03 ` Marco Elver 2020-11-12 0:51 ` Andrey Konovalov 2020-11-12 0:51 ` Andrey Konovalov 2020-11-12 0:51 ` Andrey Konovalov 2020-11-10 22:24 ` [PATCH v2 00/20] kasan: boot parameters for hardware tag-based mode Andrey Konovalov 2020-11-10 22:24 ` Andrey Konovalov 2020-11-10 22:24 ` Andrey Konovalov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAAeHK+wvvkYko=tM=NHODkKas13h5Jvsswvg05jhv9LqE0jSjQ@mail.gmail.com' \ --to=andreyknvl@google.com \ --cc=Branislav.Rankov@arm.com \ --cc=akpm@linux-foundation.org \ --cc=aryabinin@virtuozzo.com \ --cc=catalin.marinas@arm.com \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=eugenis@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=kevin.brodsky@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=vincenzo.frascino@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.