From: Andrey Konovalov <andreyknvl@google.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Marco Elver <elver@google.com>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>,
Alexander Potapenko <glider@google.com>,
Evgenii Stepanov <eugenis@google.com>,
Kostya Serebryany <kcc@google.com>,
Peter Collingbourne <pcc@google.com>,
Serban Constantinescu <serbanc@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Elena Petrova <lenaptr@google.com>,
Branislav Rankov <Branislav.Rankov@arm.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK
Date: Mon, 16 Nov 2020 14:50:47 +0100 [thread overview]
Message-ID: <CAAeHK+xb4w1XSe_cXeV77d3VkHq6ABAKkKuEaFN-uFVY457-Ww@mail.gmail.com> (raw)
In-Reply-To: <9d4156e6-ec4f-a742-a44e-f38bf7fa9ba9@arm.com>
On Mon, Nov 16, 2020 at 1:42 PM Vincenzo Frascino
<vincenzo.frascino@arm.com> wrote:
>
> >>>>
> >>>> Not sure why we did this instead of the following, but okay.
> >>>>
> >>>> config KASAN_STACK
> >>>> - int
> >>>> - default 1 if KASAN_STACK_ENABLE || CC_IS_GCC
> >>>> - default 0
> >>>> + bool
> >>>> + default y if KASAN_STACK_ENABLE || CC_IS_GCC
> >>>> + default n
> >>>
> >>> I wondered the same, but then looking at scripts/Makefile.kasan I
> >>> think it's because we directly pass it to the compiler:
> >>> ...
> >>> $(call cc-param,asan-stack=$(CONFIG_KASAN_STACK)) \
> >>> ...
> >>
> >> Try this instead:
> >>
> >> $(call cc-param,asan-stack=$(if $(CONFIG_KASAN_STACK),1,0)) \
> >
> >
> > We could have just 1 config instead of 2 as well.
> > For gcc we could do no prompt and default value y, and for clang --
> > prompt and default value n. I think it should do what we need.
> >
>
> I agree with Catalin's proposal since it should simplify things.
>
> Nit: 'default n' is the default hence I do not think it should be required
> explicitly.
Fixing this sounds like a good idea, but perhaps not as a part of this
series, to not overinflate it even further.
I've filed a bug for this: https://bugzilla.kernel.org/show_bug.cgi?id=210221
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Konovalov <andreyknvl@google.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Marco Elver <elver@google.com>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: Branislav Rankov <Branislav.Rankov@arm.com>,
Elena Petrova <lenaptr@google.com>, Linux-MM <linux-mm@kvack.org>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Will Deacon <will.deacon@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Kostya Serebryany <kcc@google.com>,
Alexander Potapenko <glider@google.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Serban Constantinescu <serbanc@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Collingbourne <pcc@google.com>,
Evgenii Stepanov <eugenis@google.com>
Subject: Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK
Date: Mon, 16 Nov 2020 14:50:47 +0100 [thread overview]
Message-ID: <CAAeHK+xb4w1XSe_cXeV77d3VkHq6ABAKkKuEaFN-uFVY457-Ww@mail.gmail.com> (raw)
In-Reply-To: <9d4156e6-ec4f-a742-a44e-f38bf7fa9ba9@arm.com>
On Mon, Nov 16, 2020 at 1:42 PM Vincenzo Frascino
<vincenzo.frascino@arm.com> wrote:
>
> >>>>
> >>>> Not sure why we did this instead of the following, but okay.
> >>>>
> >>>> config KASAN_STACK
> >>>> - int
> >>>> - default 1 if KASAN_STACK_ENABLE || CC_IS_GCC
> >>>> - default 0
> >>>> + bool
> >>>> + default y if KASAN_STACK_ENABLE || CC_IS_GCC
> >>>> + default n
> >>>
> >>> I wondered the same, but then looking at scripts/Makefile.kasan I
> >>> think it's because we directly pass it to the compiler:
> >>> ...
> >>> $(call cc-param,asan-stack=$(CONFIG_KASAN_STACK)) \
> >>> ...
> >>
> >> Try this instead:
> >>
> >> $(call cc-param,asan-stack=$(if $(CONFIG_KASAN_STACK),1,0)) \
> >
> >
> > We could have just 1 config instead of 2 as well.
> > For gcc we could do no prompt and default value y, and for clang --
> > prompt and default value n. I think it should do what we need.
> >
>
> I agree with Catalin's proposal since it should simplify things.
>
> Nit: 'default n' is the default hence I do not think it should be required
> explicitly.
Fixing this sounds like a good idea, but perhaps not as a part of this
series, to not overinflate it even further.
I've filed a bug for this: https://bugzilla.kernel.org/show_bug.cgi?id=210221
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-16 13:51 UTC|newest]
Thread overview: 210+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 13:18 [PATCH RFC v2 00/21] kasan: hardware tag-based mode for production use on arm64 Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-22 13:18 ` [PATCH RFC v2 01/21] kasan: simplify quarantine_put call site Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-27 12:40 ` Dmitry Vyukov
2020-10-27 12:40 ` Dmitry Vyukov
2020-10-27 12:40 ` Dmitry Vyukov
2020-10-22 13:18 ` [PATCH RFC v2 02/21] kasan: rename get_alloc/free_info Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-27 12:40 ` Dmitry Vyukov
2020-10-27 12:40 ` Dmitry Vyukov
2020-10-27 12:40 ` Dmitry Vyukov
2020-10-22 13:18 ` [PATCH RFC v2 03/21] kasan: introduce set_alloc_info Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-27 12:41 ` Dmitry Vyukov
2020-10-27 12:41 ` Dmitry Vyukov
2020-10-27 12:41 ` Dmitry Vyukov
2020-10-22 13:18 ` [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-27 12:44 ` Dmitry Vyukov
2020-10-27 12:44 ` Dmitry Vyukov
2020-10-27 12:44 ` Dmitry Vyukov
2020-10-27 12:45 ` Dmitry Vyukov
2020-10-27 12:45 ` Dmitry Vyukov
2020-10-27 12:45 ` Dmitry Vyukov
2020-10-29 19:57 ` Andrey Konovalov
2020-10-29 19:57 ` Andrey Konovalov
2020-10-29 19:57 ` Andrey Konovalov
2020-11-16 10:59 ` Dmitry Vyukov
2020-11-16 10:59 ` Dmitry Vyukov
2020-11-16 10:59 ` Dmitry Vyukov
2020-11-16 11:50 ` Marco Elver
2020-11-16 11:50 ` Marco Elver
2020-11-16 11:50 ` Marco Elver
2020-11-16 12:16 ` Catalin Marinas
2020-11-16 12:16 ` Catalin Marinas
2020-11-16 12:19 ` Dmitry Vyukov
2020-11-16 12:19 ` Dmitry Vyukov
2020-11-16 12:19 ` Dmitry Vyukov
2020-11-16 12:45 ` Vincenzo Frascino
2020-11-16 12:45 ` Vincenzo Frascino
2020-11-16 13:50 ` Andrey Konovalov [this message]
2020-11-16 13:50 ` Andrey Konovalov
2020-11-16 13:50 ` Andrey Konovalov
2020-11-16 14:50 ` Vincenzo Frascino
2020-11-16 14:50 ` Vincenzo Frascino
2020-10-22 13:18 ` [PATCH RFC v2 05/21] kasan: allow VMAP_STACK for HW_TAGS mode Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-27 12:49 ` Dmitry Vyukov
2020-10-27 12:49 ` Dmitry Vyukov
2020-10-27 12:49 ` Dmitry Vyukov
2020-10-29 20:00 ` Andrey Konovalov
2020-10-29 20:00 ` Andrey Konovalov
2020-10-29 20:00 ` Andrey Konovalov
2020-10-22 13:18 ` [PATCH RFC v2 06/21] kasan: mark kasan_init_tags as __init Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-28 10:08 ` Dmitry Vyukov
2020-10-28 10:08 ` Dmitry Vyukov
2020-10-28 10:08 ` Dmitry Vyukov
2020-10-29 20:08 ` Andrey Konovalov
2020-10-29 20:08 ` Andrey Konovalov
2020-10-29 20:08 ` Andrey Konovalov
2020-10-22 13:18 ` [PATCH RFC v2 07/21] kasan, arm64: move initialization message Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-22 13:18 ` Andrey Konovalov
2020-10-28 10:55 ` Dmitry Vyukov
2020-10-28 10:55 ` Dmitry Vyukov
2020-10-28 10:55 ` Dmitry Vyukov
2020-10-29 20:14 ` Andrey Konovalov
2020-10-29 20:14 ` Andrey Konovalov
2020-10-29 20:14 ` Andrey Konovalov
2020-11-03 15:33 ` Andrey Konovalov
2020-11-03 15:33 ` Andrey Konovalov
2020-11-03 15:33 ` Andrey Konovalov
2020-10-22 13:19 ` [PATCH RFC v2 08/21] kasan: remove __kasan_unpoison_stack Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 10:57 ` Dmitry Vyukov
2020-10-28 10:57 ` Dmitry Vyukov
2020-10-28 10:57 ` Dmitry Vyukov
2020-10-22 13:19 ` [PATCH RFC v2 09/21] kasan: inline kasan_reset_tag for tag-based modes Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 11:05 ` Dmitry Vyukov
2020-10-28 11:05 ` Dmitry Vyukov
2020-10-28 11:05 ` Dmitry Vyukov
2020-10-30 16:19 ` Andrey Konovalov
2020-10-30 16:19 ` Andrey Konovalov
2020-10-30 16:19 ` Andrey Konovalov
2020-10-22 13:19 ` [PATCH RFC v2 10/21] kasan: inline random_tag for HW_TAGS Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 11:08 ` Dmitry Vyukov
2020-10-28 11:08 ` Dmitry Vyukov
2020-10-28 11:08 ` Dmitry Vyukov
2020-10-30 15:48 ` Andrey Konovalov
2020-10-30 15:48 ` Andrey Konovalov
2020-10-30 15:48 ` Andrey Konovalov
2020-10-30 16:07 ` Andrey Konovalov
2020-10-30 16:07 ` Andrey Konovalov
2020-10-30 16:07 ` Andrey Konovalov
2020-10-22 13:19 ` [PATCH RFC v2 11/21] kasan: inline kasan_poison_memory and check_invalid_free Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 11:29 ` Dmitry Vyukov
2020-10-28 11:29 ` Dmitry Vyukov
2020-10-28 11:29 ` Dmitry Vyukov
2020-10-22 13:19 ` [PATCH RFC v2 12/21] kasan: inline and rename kasan_unpoison_memory Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 11:36 ` Dmitry Vyukov
2020-10-28 11:36 ` Dmitry Vyukov
2020-10-28 11:36 ` Dmitry Vyukov
2020-10-30 16:34 ` Andrey Konovalov
2020-10-30 16:34 ` Andrey Konovalov
2020-10-30 16:34 ` Andrey Konovalov
2020-10-30 17:46 ` Dmitry Vyukov
2020-10-30 17:46 ` Dmitry Vyukov
2020-10-30 17:46 ` Dmitry Vyukov
2020-10-22 13:19 ` [PATCH RFC v2 13/21] arm64: kasan: Add cpu_supports_tags helper Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 11:38 ` Dmitry Vyukov
2020-10-28 11:38 ` Dmitry Vyukov
2020-10-28 11:38 ` Dmitry Vyukov
2020-10-22 13:19 ` [PATCH RFC v2 14/21] kasan: add and integrate kasan boot parameters Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 18:50 ` Marco Elver
2020-10-22 18:50 ` Marco Elver
2020-10-22 18:50 ` Marco Elver
2020-10-22 20:28 ` Andrey Konovalov
2020-10-22 20:28 ` Andrey Konovalov
2020-10-22 20:28 ` Andrey Konovalov
2020-10-28 12:27 ` Dmitry Vyukov
2020-10-28 12:27 ` Dmitry Vyukov
2020-10-28 12:27 ` Dmitry Vyukov
2020-10-30 19:30 ` Andrey Konovalov
2020-10-30 19:30 ` Andrey Konovalov
2020-10-30 19:30 ` Andrey Konovalov
2020-10-30 14:45 ` Marco Elver
2020-10-30 14:45 ` Marco Elver
2020-10-30 14:45 ` Marco Elver
2020-10-30 19:30 ` Andrey Konovalov
2020-10-30 19:30 ` Andrey Konovalov
2020-10-30 19:30 ` Andrey Konovalov
2020-10-22 13:19 ` [PATCH RFC v2 15/21] kasan: check kasan_enabled in annotations Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 16:47 ` Dmitry Vyukov
2020-10-28 16:47 ` Dmitry Vyukov
2020-10-28 16:47 ` Dmitry Vyukov
2020-10-30 19:47 ` Andrey Konovalov
2020-10-30 19:47 ` Andrey Konovalov
2020-10-30 19:47 ` Andrey Konovalov
2020-10-22 13:19 ` [PATCH RFC v2 16/21] kasan: optimize poisoning in kmalloc and krealloc Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 16:55 ` Dmitry Vyukov
2020-10-28 16:55 ` Dmitry Vyukov
2020-10-28 16:55 ` Dmitry Vyukov
2020-11-02 15:17 ` Andrey Konovalov
2020-11-02 15:17 ` Andrey Konovalov
2020-11-02 15:17 ` Andrey Konovalov
2020-10-22 13:19 ` [PATCH RFC v2 17/21] kasan: simplify kasan_poison_kfree Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 16:57 ` Dmitry Vyukov
2020-10-28 16:57 ` Dmitry Vyukov
2020-10-28 16:57 ` Dmitry Vyukov
2020-10-22 13:19 ` [PATCH RFC v2 18/21] kasan: rename kasan_poison_kfree Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 16:58 ` Dmitry Vyukov
2020-10-28 16:58 ` Dmitry Vyukov
2020-10-28 16:58 ` Dmitry Vyukov
2020-10-22 13:19 ` [PATCH RFC v2 19/21] kasan: don't round_up too much Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 17:01 ` Dmitry Vyukov
2020-10-28 17:01 ` Dmitry Vyukov
2020-10-28 17:01 ` Dmitry Vyukov
2020-10-22 13:19 ` [PATCH RFC v2 20/21] kasan: simplify assign_tag and set_tag calls Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 17:03 ` Dmitry Vyukov
2020-10-28 17:03 ` Dmitry Vyukov
2020-10-28 17:03 ` Dmitry Vyukov
2020-10-22 13:19 ` [PATCH RFC v2 21/21] kasan: clarify comment in __kasan_kfree_large Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-22 13:19 ` Andrey Konovalov
2020-10-28 17:04 ` Dmitry Vyukov
2020-10-28 17:04 ` Dmitry Vyukov
2020-10-28 17:04 ` Dmitry Vyukov
2020-10-22 15:15 ` [PATCH RFC v2 00/21] kasan: hardware tag-based mode for production use on arm64 Dmitry Vyukov
2020-10-22 15:15 ` Dmitry Vyukov
2020-10-22 15:15 ` Dmitry Vyukov
2020-10-22 17:00 ` Andrey Konovalov
2020-10-22 17:00 ` Andrey Konovalov
2020-10-22 17:00 ` Andrey Konovalov
2020-10-22 18:29 ` Kostya Serebryany
2020-10-22 18:29 ` Kostya Serebryany
2020-10-22 18:29 ` Kostya Serebryany
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeHK+xb4w1XSe_cXeV77d3VkHq6ABAKkKuEaFN-uFVY457-Ww@mail.gmail.com \
--to=andreyknvl@google.com \
--cc=Branislav.Rankov@arm.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kcc@google.com \
--cc=kevin.brodsky@arm.com \
--cc=lenaptr@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pcc@google.com \
--cc=serbanc@google.com \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.