All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Konovalov <andreyknvl@google.com>
To: Will Deacon <will@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	kasan-dev <kasan-dev@googlegroups.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"moderated list:ARM/Mediatek SoC..." 
	<linux-mediatek@lists.infradead.org>,
	yj.chiang@mediatek.com, Catalin Marinas <catalin.marinas@arm.com>,
	Ard Biesheuvel <ardb@kernel.org>, Mark Brown <broonie@kernel.org>,
	Guenter Roeck <linux@roeck-us.net>,
	rppt@kernel.org, tyhicks@linux.microsoft.com,
	Robin Murphy <robin.murphy@arm.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	gustavoars@kernel.org, Lecopzer Chen <lecopzer@gmail.com>,
	Lecopzer Chen <lecopzer.chen@mediatek.com>
Subject: Re: [PATCH v2 0/4] arm64: kasan: support CONFIG_KASAN_VMALLOC
Date: Thu, 21 Jan 2021 18:44:14 +0100	[thread overview]
Message-ID: <CAAeHK+z3oYx4WqX7Xor7gD=eqYkzW0UBS4h4is00HnfNnNkpDA@mail.gmail.com> (raw)
In-Reply-To: <20210109103252.812517-1-lecopzer@gmail.com>

On Sat, Jan 9, 2021 at 11:33 AM Lecopzer Chen <lecopzer@gmail.com> wrote:
>
> Linux supports KAsan for VMALLOC since commit 3c5c3cfb9ef4da9
> ("kasan: support backing vmalloc space with real shadow memory")
>
> Acroding to how x86 ported it [1], they early allocated p4d and pgd,
> but in arm64 I just simulate how KAsan supports MODULES_VADDR in arm64
> by not to populate the vmalloc area except for kimg address.
>
> Test environment:
>     4G and 8G Qemu virt,
>     39-bit VA + 4k PAGE_SIZE with 3-level page table,
>     test by lib/test_kasan.ko and lib/test_kasan_module.ko
>
> It also works in Kaslr with CONFIG_RANDOMIZE_MODULE_REGION_FULL
> and randomize module region inside vmalloc area.
>
>
> [1]: commit 0609ae011deb41c ("x86/kasan: support KASAN_VMALLOC")
>
> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> Acked-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Andrey Konovalov <andreyknvl@google.com>
>
>
> v2 -> v1
>         1. kasan_init.c tweak indent
>         2. change Kconfig depends only on HAVE_ARCH_KASAN
>         3. support randomized module region.
>
> v1:
> https://lore.kernel.org/lkml/20210103171137.153834-1-lecopzer@gmail.com/
>
> Lecopzer Chen (4):
>   arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC
>   arm64: kasan: abstract _text and _end to KERNEL_START/END
>   arm64: Kconfig: support CONFIG_KASAN_VMALLOC
>   arm64: kaslr: support randomized module area with KASAN_VMALLOC
>
>  arch/arm64/Kconfig         |  1 +
>  arch/arm64/kernel/kaslr.c  | 18 ++++++++++--------
>  arch/arm64/kernel/module.c | 16 +++++++++-------
>  arch/arm64/mm/kasan_init.c | 29 +++++++++++++++++++++--------
>  4 files changed, 41 insertions(+), 23 deletions(-)
>
> --
> 2.25.1
>

Hi Will,

Could you PTAL at the arm64 changes?

Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Andrey Konovalov <andreyknvl@google.com>
To: Will Deacon <will@kernel.org>
Cc: Lecopzer Chen <lecopzer.chen@mediatek.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	tyhicks@linux.microsoft.com,
	Alexander Potapenko <glider@google.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	yj.chiang@mediatek.com, kasan-dev <kasan-dev@googlegroups.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Lecopzer Chen <lecopzer@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	"moderated list:ARM/Mediatek SoC..."
	<linux-mediatek@lists.infradead.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	gustavoars@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	Robin Murphy <robin.murphy@arm.com>,
	rppt@kernel.org
Subject: Re: [PATCH v2 0/4] arm64: kasan: support CONFIG_KASAN_VMALLOC
Date: Thu, 21 Jan 2021 18:44:14 +0100	[thread overview]
Message-ID: <CAAeHK+z3oYx4WqX7Xor7gD=eqYkzW0UBS4h4is00HnfNnNkpDA@mail.gmail.com> (raw)
In-Reply-To: <20210109103252.812517-1-lecopzer@gmail.com>

On Sat, Jan 9, 2021 at 11:33 AM Lecopzer Chen <lecopzer@gmail.com> wrote:
>
> Linux supports KAsan for VMALLOC since commit 3c5c3cfb9ef4da9
> ("kasan: support backing vmalloc space with real shadow memory")
>
> Acroding to how x86 ported it [1], they early allocated p4d and pgd,
> but in arm64 I just simulate how KAsan supports MODULES_VADDR in arm64
> by not to populate the vmalloc area except for kimg address.
>
> Test environment:
>     4G and 8G Qemu virt,
>     39-bit VA + 4k PAGE_SIZE with 3-level page table,
>     test by lib/test_kasan.ko and lib/test_kasan_module.ko
>
> It also works in Kaslr with CONFIG_RANDOMIZE_MODULE_REGION_FULL
> and randomize module region inside vmalloc area.
>
>
> [1]: commit 0609ae011deb41c ("x86/kasan: support KASAN_VMALLOC")
>
> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> Acked-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Andrey Konovalov <andreyknvl@google.com>
>
>
> v2 -> v1
>         1. kasan_init.c tweak indent
>         2. change Kconfig depends only on HAVE_ARCH_KASAN
>         3. support randomized module region.
>
> v1:
> https://lore.kernel.org/lkml/20210103171137.153834-1-lecopzer@gmail.com/
>
> Lecopzer Chen (4):
>   arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC
>   arm64: kasan: abstract _text and _end to KERNEL_START/END
>   arm64: Kconfig: support CONFIG_KASAN_VMALLOC
>   arm64: kaslr: support randomized module area with KASAN_VMALLOC
>
>  arch/arm64/Kconfig         |  1 +
>  arch/arm64/kernel/kaslr.c  | 18 ++++++++++--------
>  arch/arm64/kernel/module.c | 16 +++++++++-------
>  arch/arm64/mm/kasan_init.c | 29 +++++++++++++++++++++--------
>  4 files changed, 41 insertions(+), 23 deletions(-)
>
> --
> 2.25.1
>

Hi Will,

Could you PTAL at the arm64 changes?

Thanks!

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Andrey Konovalov <andreyknvl@google.com>
To: Will Deacon <will@kernel.org>
Cc: Lecopzer Chen <lecopzer.chen@mediatek.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	tyhicks@linux.microsoft.com,
	Alexander Potapenko <glider@google.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	yj.chiang@mediatek.com, kasan-dev <kasan-dev@googlegroups.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Lecopzer Chen <lecopzer@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	"moderated list:ARM/Mediatek SoC..."
	<linux-mediatek@lists.infradead.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	gustavoars@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	Robin Murphy <robin.murphy@arm.com>,
	rppt@kernel.org
Subject: Re: [PATCH v2 0/4] arm64: kasan: support CONFIG_KASAN_VMALLOC
Date: Thu, 21 Jan 2021 18:44:14 +0100	[thread overview]
Message-ID: <CAAeHK+z3oYx4WqX7Xor7gD=eqYkzW0UBS4h4is00HnfNnNkpDA@mail.gmail.com> (raw)
In-Reply-To: <20210109103252.812517-1-lecopzer@gmail.com>

On Sat, Jan 9, 2021 at 11:33 AM Lecopzer Chen <lecopzer@gmail.com> wrote:
>
> Linux supports KAsan for VMALLOC since commit 3c5c3cfb9ef4da9
> ("kasan: support backing vmalloc space with real shadow memory")
>
> Acroding to how x86 ported it [1], they early allocated p4d and pgd,
> but in arm64 I just simulate how KAsan supports MODULES_VADDR in arm64
> by not to populate the vmalloc area except for kimg address.
>
> Test environment:
>     4G and 8G Qemu virt,
>     39-bit VA + 4k PAGE_SIZE with 3-level page table,
>     test by lib/test_kasan.ko and lib/test_kasan_module.ko
>
> It also works in Kaslr with CONFIG_RANDOMIZE_MODULE_REGION_FULL
> and randomize module region inside vmalloc area.
>
>
> [1]: commit 0609ae011deb41c ("x86/kasan: support KASAN_VMALLOC")
>
> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> Acked-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Andrey Konovalov <andreyknvl@google.com>
>
>
> v2 -> v1
>         1. kasan_init.c tweak indent
>         2. change Kconfig depends only on HAVE_ARCH_KASAN
>         3. support randomized module region.
>
> v1:
> https://lore.kernel.org/lkml/20210103171137.153834-1-lecopzer@gmail.com/
>
> Lecopzer Chen (4):
>   arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC
>   arm64: kasan: abstract _text and _end to KERNEL_START/END
>   arm64: Kconfig: support CONFIG_KASAN_VMALLOC
>   arm64: kaslr: support randomized module area with KASAN_VMALLOC
>
>  arch/arm64/Kconfig         |  1 +
>  arch/arm64/kernel/kaslr.c  | 18 ++++++++++--------
>  arch/arm64/kernel/module.c | 16 +++++++++-------
>  arch/arm64/mm/kasan_init.c | 29 +++++++++++++++++++++--------
>  4 files changed, 41 insertions(+), 23 deletions(-)
>
> --
> 2.25.1
>

Hi Will,

Could you PTAL at the arm64 changes?

Thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-01-21 17:46 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09 10:32 [PATCH v2 0/4] arm64: kasan: support CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-01-09 10:32 ` Lecopzer Chen
2021-01-09 10:32 ` Lecopzer Chen
2021-01-09 10:32 ` [PATCH v2 1/4] arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-01-09 10:32   ` Lecopzer Chen
2021-01-09 10:32   ` Lecopzer Chen
2021-02-03 18:37   ` Ard Biesheuvel
2021-02-03 18:37     ` Ard Biesheuvel
2021-02-03 18:37     ` Ard Biesheuvel
2021-02-03 18:37     ` Ard Biesheuvel
2021-02-04  6:21     ` Lecopzer Chen
2021-02-04  6:21       ` Lecopzer Chen
2021-02-04  6:21       ` Lecopzer Chen
2021-02-04 12:45   ` Will Deacon
2021-02-04 12:45     ` Will Deacon
2021-02-04 12:45     ` Will Deacon
2021-02-04 14:46     ` Lecopzer Chen
2021-02-04 14:46       ` Lecopzer Chen
2021-02-04 14:46       ` Lecopzer Chen
2021-02-04 15:01       ` Will Deacon
2021-02-04 15:01         ` Will Deacon
2021-02-04 15:01         ` Will Deacon
2021-02-04 16:37         ` Lecopzer Chen
2021-02-04 16:37           ` Lecopzer Chen
2021-02-04 16:37           ` Lecopzer Chen
2021-02-05 17:18           ` Will Deacon
2021-02-05 17:18             ` Will Deacon
2021-02-05 17:18             ` Will Deacon
2021-02-05 17:30             ` Andrey Konovalov
2021-02-05 17:30               ` Andrey Konovalov
2021-02-05 17:30               ` Andrey Konovalov
2021-02-05 17:30               ` Andrey Konovalov
2021-02-05 17:43               ` Will Deacon
2021-02-05 17:43                 ` Will Deacon
2021-02-05 17:43                 ` Will Deacon
2021-02-05 17:43                 ` Will Deacon
2021-02-05 20:50                 ` Andrey Konovalov
2021-02-05 20:50                   ` Andrey Konovalov
2021-02-05 20:50                   ` Andrey Konovalov
2021-02-05 20:50                   ` Andrey Konovalov
2021-02-05 18:10             ` Lecopzer Chen
2021-02-05 18:10               ` Lecopzer Chen
2021-02-05 18:10               ` Lecopzer Chen
2021-02-05 18:10               ` Lecopzer Chen
2021-01-09 10:32 ` [PATCH v2 2/4] arm64: kasan: abstract _text and _end to KERNEL_START/END Lecopzer Chen
2021-01-09 10:32   ` Lecopzer Chen
2021-01-09 10:32   ` Lecopzer Chen
2021-02-04 12:46   ` Will Deacon
2021-02-04 12:46     ` Will Deacon
2021-02-04 12:46     ` Will Deacon
2021-02-04 14:51     ` Lecopzer Chen
2021-02-04 14:51       ` Lecopzer Chen
2021-02-04 14:51       ` Lecopzer Chen
2021-02-04 14:55       ` Will Deacon
2021-02-04 14:55         ` Will Deacon
2021-02-04 14:55         ` Will Deacon
2021-02-04 16:06         ` Lecopzer Chen
2021-02-04 16:06           ` Lecopzer Chen
2021-02-04 16:06           ` Lecopzer Chen
2021-02-04 16:06           ` Lecopzer Chen
2021-02-05 17:02           ` Will Deacon
2021-02-05 17:02             ` Will Deacon
2021-02-05 17:02             ` Will Deacon
2021-01-09 10:32 ` [PATCH v2 3/4] arm64: Kconfig: support CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-01-09 10:32   ` Lecopzer Chen
2021-01-09 10:32   ` Lecopzer Chen
2021-01-09 10:32 ` [PATCH v2 4/4] arm64: kaslr: support randomized module area with KASAN_VMALLOC Lecopzer Chen
2021-01-09 10:32   ` Lecopzer Chen
2021-01-09 10:32   ` Lecopzer Chen
2021-01-27 23:04   ` Will Deacon
2021-01-27 23:04     ` Will Deacon
2021-01-27 23:04     ` Will Deacon
2021-01-28  8:53     ` Lecopzer Chen
2021-01-28  8:53       ` Lecopzer Chen
2021-01-28  8:53       ` Lecopzer Chen
2021-01-28 20:26       ` Will Deacon
2021-01-28 20:26         ` Will Deacon
2021-01-28 20:26         ` Will Deacon
2021-01-21 10:19 ` [PATCH v2 0/4] arm64: kasan: support CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-01-21 10:19   ` Lecopzer Chen
2021-01-21 10:19   ` Lecopzer Chen
2021-01-21 17:44 ` Andrey Konovalov [this message]
2021-01-21 17:44   ` Andrey Konovalov
2021-01-21 17:44   ` Andrey Konovalov
2021-01-21 17:44   ` Andrey Konovalov
2021-01-22 19:05   ` Will Deacon
2021-01-22 19:05     ` Will Deacon
2021-01-22 19:05     ` Will Deacon
2021-01-22 19:05     ` Will Deacon
2021-02-03 18:31 ` Ard Biesheuvel
2021-02-03 18:31   ` Ard Biesheuvel
2021-02-03 18:31   ` Ard Biesheuvel
2021-02-03 18:31   ` Ard Biesheuvel
2021-02-04 12:49 ` Will Deacon
2021-02-04 12:49   ` Will Deacon
2021-02-04 12:49   ` Will Deacon
2021-02-04 15:53   ` Lecopzer Chen
2021-02-04 15:53     ` Lecopzer Chen
2021-02-04 15:53     ` Lecopzer Chen
2021-02-04 17:57     ` Will Deacon
2021-02-04 17:57       ` Will Deacon
2021-02-04 17:57       ` Will Deacon
2021-02-04 18:32       ` Lecopzer Chen
2021-02-04 18:41       ` Lecopzer Chen
2021-02-04 18:41         ` Lecopzer Chen
2021-02-04 18:41         ` Lecopzer Chen
2021-02-04 18:41         ` Lecopzer Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAeHK+z3oYx4WqX7Xor7gD=eqYkzW0UBS4h4is00HnfNnNkpDA@mail.gmail.com' \
    --to=andreyknvl@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=ardb@kernel.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dan.j.williams@intel.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=gustavoars@kernel.org \
    --cc=kasan-dev@googlegroups.com \
    --cc=lecopzer.chen@mediatek.com \
    --cc=lecopzer@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@roeck-us.net \
    --cc=robin.murphy@arm.com \
    --cc=rppt@kernel.org \
    --cc=tyhicks@linux.microsoft.com \
    --cc=vincenzo.frascino@arm.com \
    --cc=will@kernel.org \
    --cc=yj.chiang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.