All of lore.kernel.org
 help / color / mirror / Atom feed
* Sony VAIO VPC-SA2 blinking/waves on LVDS
@ 2011-10-09 23:19 Олег Герман
  2011-10-10  7:04 ` Daniel Vetter
  0 siblings, 1 reply; 8+ messages in thread
From: Олег Герман @ 2011-10-09 23:19 UTC (permalink / raw)
  To: intel-gfx

Hello.

I have a VAIO VPC-SA2 laptop, with an Ubuntu 11.04 installed.
The problem lies in the strange screen (LVDS 1600x900) blinking/waves
( which is mostly
noticeable in grey gradients and causes eyes fatigue and pain after
prolonged use.
This problem does not occur with the VESA driver, Windows and other
outputs, but it's
reproduced in Fedora Core and Ubuntu 10.10/11.04/11.10 at X-window and
cosole (with i915 module). It is clear that the problem is in the
driver, but I can't determine the source of noise, it may be because
of the backlight, or the display-panel.

I captured how it looks like
http://www.youtube.com/watch?feature=player_profilepage&v=C3LcYLrFwHU


With best regards
Oleg German

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Sony VAIO VPC-SA2 blinking/waves on LVDS
  2011-10-09 23:19 Sony VAIO VPC-SA2 blinking/waves on LVDS Олег Герман
@ 2011-10-10  7:04 ` Daniel Vetter
  2011-10-10  7:36   ` Олег Герман
                     ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Daniel Vetter @ 2011-10-10  7:04 UTC (permalink / raw)
  To: Олег Герман
  Cc: intel-gfx

On Mon, Oct 10, 2011 at 03:19:13AM +0400, Олег Герман wrote:
> I have a VAIO VPC-SA2 laptop, with an Ubuntu 11.04 installed.
> The problem lies in the strange screen (LVDS 1600x900) blinking/waves
> ( which is mostly
> noticeable in grey gradients and causes eyes fatigue and pain after
> prolonged use.
> This problem does not occur with the VESA driver, Windows and other
> outputs, but it's
> reproduced in Fedora Core and Ubuntu 10.10/11.04/11.10 at X-window and
> cosole (with i915 module). It is clear that the problem is in the
> driver, but I can't determine the source of noise, it may be because
> of the backlight, or the display-panel.
> 
> I captured how it looks like
> http://www.youtube.com/watch?feature=player_profilepage&v=C3LcYLrFwHU

I'd wager this is dithering gone wrong. Can you boot with drm.debug=0xe
and attach the full dmesg? Also please attach xrandr --verbose.

Yours, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Sony VAIO VPC-SA2 blinking/waves on LVDS
  2011-10-10  7:04 ` Daniel Vetter
@ 2011-10-10  7:36   ` Олег Герман
  2011-10-10  8:31   ` Daniel Vetter
  2011-10-11  9:50   ` Олег Герман
  2 siblings, 0 replies; 8+ messages in thread
From: Олег Герман @ 2011-10-10  7:36 UTC (permalink / raw)
  To: Daniel Vetter, intel-gfx

dmesg output
http://pastebin.com/Z6u2M0c0

xrandr --verbose
http://pastebin.com/Yenu9Hxn

2011/10/10 Daniel Vetter <daniel@ffwll.ch>:

> I'd wager this is dithering gone wrong. Can you boot with drm.debug=0xe
> and attach the full dmesg? Also please attach xrandr --verbose.
>
> Yours, Daniel
> --
> Daniel Vetter
> Mail: daniel@ffwll.ch
> Mobile: +41 (0)79 365 57 48
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Sony VAIO VPC-SA2 blinking/waves on LVDS
  2011-10-10  7:04 ` Daniel Vetter
  2011-10-10  7:36   ` Олег Герман
@ 2011-10-10  8:31   ` Daniel Vetter
  2011-10-11  9:50   ` Олег Герман
  2 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2011-10-10  8:31 UTC (permalink / raw)
  To: Олег Герман
  Cc: intel-gfx

On Mon, Oct 10, 2011 at 09:04:45AM +0200, Daniel Vetter wrote:
> On Mon, Oct 10, 2011 at 03:19:13AM +0400, Олег Герман wrote:
> > I have a VAIO VPC-SA2 laptop, with an Ubuntu 11.04 installed.
> > The problem lies in the strange screen (LVDS 1600x900) blinking/waves
> > ( which is mostly
> > noticeable in grey gradients and causes eyes fatigue and pain after
> > prolonged use.
> > This problem does not occur with the VESA driver, Windows and other
> > outputs, but it's
> > reproduced in Fedora Core and Ubuntu 10.10/11.04/11.10 at X-window and
> > cosole (with i915 module). It is clear that the problem is in the
> > driver, but I can't determine the source of noise, it may be because
> > of the backlight, or the display-panel.
> > 
> > I captured how it looks like
> > http://www.youtube.com/watch?feature=player_profilepage&v=C3LcYLrFwHU
> 
> I'd wager this is dithering gone wrong. Can you boot with drm.debug=0xe
> and attach the full dmesg? Also please attach xrandr --verbose.

Another thing to try is disabling SSC with i915.lvds_use_ssc=0 on the
kernel cmdline.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Sony VAIO VPC-SA2 blinking/waves on LVDS
  2011-10-10  7:04 ` Daniel Vetter
  2011-10-10  7:36   ` Олег Герман
  2011-10-10  8:31   ` Daniel Vetter
@ 2011-10-11  9:50   ` Олег Герман
  2011-10-11 10:58     ` Daniel Vetter
  2 siblings, 1 reply; 8+ messages in thread
From: Олег Герман @ 2011-10-11  9:50 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

> I'd wager this is dithering gone wrong. Can you boot with drm.debug=0xe
> and attach the full dmesg? Also please attach xrandr --verbose.

also bug is not reproduced on external monitors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Sony VAIO VPC-SA2 blinking/waves on LVDS
  2011-10-11  9:50   ` Олег Герман
@ 2011-10-11 10:58     ` Daniel Vetter
       [not found]       ` <CAAfHt_+ymuRW5PQruQAztimOH_h9d0HO1Q=my4BW1xjuKN0mCA@mail.gmail.com>
  0 siblings, 1 reply; 8+ messages in thread
From: Daniel Vetter @ 2011-10-11 10:58 UTC (permalink / raw)
  To: Олег Герман
  Cc: intel-gfx

On Tue, Oct 11, 2011 at 01:50:34PM +0400, Олег Герман wrote:
> > I'd wager this is dithering gone wrong. Can you boot with drm.debug=0xe
> > and attach the full dmesg? Also please attach xrandr --verbose.
> 
> also bug is not reproduced on external monitors

Can you try the below patch, please?
-Daniel

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index f0e5f9f..d145527 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5533,7 +5533,7 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
 	pipeconf &= ~PIPECONF_DITHER_TYPE_MASK;
 	if ((is_lvds && dev_priv->lvds_dither) || dither) {
 		pipeconf |= PIPECONF_DITHER_EN;
-		pipeconf |= PIPECONF_DITHER_TYPE_ST1;
+		//pipeconf |= PIPECONF_DITHER_TYPE_ST1;
 	}
 	if (is_dp || intel_encoder_is_pch_edp(&has_edp_encoder->base)) {
 		intel_dp_set_m_n(crtc, mode, adjusted_mode);

-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: Sony VAIO VPC-SA2 blinking/waves on LVDS
       [not found]       ` <CAAfHt_+ymuRW5PQruQAztimOH_h9d0HO1Q=my4BW1xjuKN0mCA@mail.gmail.com>
@ 2011-10-11 21:39         ` Олег Герман
  2011-10-11 22:13           ` Daniel Vetter
  0 siblings, 1 reply; 8+ messages in thread
From: Олег Герман @ 2011-10-11 21:39 UTC (permalink / raw)
  To: Daniel Vetter, intel-gfx

Is it complete solution or temporary workaround?
How can I help, to push this fix to upsteam?

2011/10/11 Олег Герман <oleg.german@gmail.com>:
> yep, i just commented-out this line in ubuntu kernel
> http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-oneiric.git;a=blob;f=drivers/gpu/drm/i915/intel_display.c;h=e917c7b853bc62f885ffb731049ac3ff03ef8a70;hb=HEAD#l5120
>
> and it works!
>
> 2011/10/11 Daniel Vetter <daniel@ffwll.ch>:
>> On Tue, Oct 11, 2011 at 01:50:34PM +0400, Олег Герман wrote:
>>> > I'd wager this is dithering gone wrong. Can you boot with drm.debug=0xe
>>> > and attach the full dmesg? Also please attach xrandr --verbose.
>>>
>>> also bug is not reproduced on external monitors
>>
>> Can you try the below patch, please?
>> -Daniel
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> index f0e5f9f..d145527 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -5533,7 +5533,7 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
>>        pipeconf &= ~PIPECONF_DITHER_TYPE_MASK;
>>        if ((is_lvds && dev_priv->lvds_dither) || dither) {
>>                pipeconf |= PIPECONF_DITHER_EN;
>> -               pipeconf |= PIPECONF_DITHER_TYPE_ST1;
>> +               //pipeconf |= PIPECONF_DITHER_TYPE_ST1;
>>        }
>>        if (is_dp || intel_encoder_is_pch_edp(&has_edp_encoder->base)) {
>>                intel_dp_set_m_n(crtc, mode, adjusted_mode);
>>
>> --
>> Daniel Vetter
>> Mail: daniel@ffwll.ch
>> Mobile: +41 (0)79 365 57 48
>>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Sony VAIO VPC-SA2 blinking/waves on LVDS
  2011-10-11 21:39         ` Олег Герман
@ 2011-10-11 22:13           ` Daniel Vetter
  0 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2011-10-11 22:13 UTC (permalink / raw)
  To: Олег Герман
  Cc: intel-gfx

2011/10/11 Олег Герман <oleg.german@gmail.com>:
> How can I help, to push this fix to upsteam?

Already submitted as a proper patch to intel-gfx with your tested-by, see:
Message-Id: <1318346871-3042-1-git-send-email-daniel.vetter@ffwll.ch>

Cheers, Daniel
-- 
Daniel Vetter
daniel.vetter@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-10-11 22:13 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-09 23:19 Sony VAIO VPC-SA2 blinking/waves on LVDS Олег Герман
2011-10-10  7:04 ` Daniel Vetter
2011-10-10  7:36   ` Олег Герман
2011-10-10  8:31   ` Daniel Vetter
2011-10-11  9:50   ` Олег Герман
2011-10-11 10:58     ` Daniel Vetter
     [not found]       ` <CAAfHt_+ymuRW5PQruQAztimOH_h9d0HO1Q=my4BW1xjuKN0mCA@mail.gmail.com>
2011-10-11 21:39         ` Олег Герман
2011-10-11 22:13           ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.