* [PATCH] drm/sprd: Remove of_node_put() in sprd_crtc_init()
@ 2022-07-07 2:50 Liang He
2022-07-08 9:25 ` Chunyan Zhang
0 siblings, 1 reply; 2+ messages in thread
From: Liang He @ 2022-07-07 2:50 UTC (permalink / raw)
To: airlied, orsonzhai, baolin.wang7, zhang.lyra, windhl, dri-devel
As the new reference created in 'dpu->base.port' will be escaped out,
we need not to call of_node_put() again.
Fixes: b07bcf34b6c9 ("drm/sprd: add Unisoc's drm display controller driver")
Signed-off-by: Liang He <windhl@126.com>
---
drivers/gpu/drm/sprd/sprd_dpu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dpu.c
index 1637203ea103..e1b70f989da5 100644
--- a/drivers/gpu/drm/sprd/sprd_dpu.c
+++ b/drivers/gpu/drm/sprd/sprd_dpu.c
@@ -741,7 +741,6 @@ static struct sprd_dpu *sprd_crtc_init(struct drm_device *drm,
return ERR_PTR(-EINVAL);
}
dpu->base.port = port;
- of_node_put(port);
return dpu;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/sprd: Remove of_node_put() in sprd_crtc_init()
2022-07-07 2:50 [PATCH] drm/sprd: Remove of_node_put() in sprd_crtc_init() Liang He
@ 2022-07-08 9:25 ` Chunyan Zhang
0 siblings, 0 replies; 2+ messages in thread
From: Chunyan Zhang @ 2022-07-08 9:25 UTC (permalink / raw)
To: Liang He, tang pengchuan; +Cc: David Airlie, Orson Zhai, Baolin Wang, dri-devel
+ Kevin
On Thu, 7 Jul 2022 at 11:25, Liang He <windhl@126.com> wrote:
>
> As the new reference created in 'dpu->base.port' will be escaped out,
> we need not to call of_node_put() again.
>
> Fixes: b07bcf34b6c9 ("drm/sprd: add Unisoc's drm display controller driver")
> Signed-off-by: Liang He <windhl@126.com>
> ---
> drivers/gpu/drm/sprd/sprd_dpu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dpu.c
> index 1637203ea103..e1b70f989da5 100644
> --- a/drivers/gpu/drm/sprd/sprd_dpu.c
> +++ b/drivers/gpu/drm/sprd/sprd_dpu.c
> @@ -741,7 +741,6 @@ static struct sprd_dpu *sprd_crtc_init(struct drm_device *drm,
> return ERR_PTR(-EINVAL);
> }
> dpu->base.port = port;
> - of_node_put(port);
>
> return dpu;
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-08 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-07 2:50 [PATCH] drm/sprd: Remove of_node_put() in sprd_crtc_init() Liang He
2022-07-08 9:25 ` Chunyan Zhang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.