Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

From: Lyra Zhang <zhang.lyra@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Murali Karicheri" <m-karicheri2@ti.com>,
	"Chunyan Zhang" <chunyan.zhang@spreadtrum.com>,
	"Grant Likely" <grant.likely@linaro.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"jslaby@suse.cz" <jslaby@suse.cz>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Ramkumar Ramachandra" <artagnon@gmail.com>,
	"rrichter@cavium.com" <rrichter@cavium.com>,
	"Will Deacon" <will.deacon@arm.com>,
	"gnomes@lxorguk.ukuu.org.uk" <gnomes@lxorguk.ukuu.org.uk>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"jason@lakedaemon.net" <jason@lakedaemon.net>,
	"Mark Brown" <broonie@kernel.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	"florian.vaussard@epfl.ch" <florian.vaussard@epfl.ch>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	"Hayato Suzuki" <hytszk@gmail.com>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"geng.ren@spreadtrum.com" <geng.ren@spreadtrum.com>,
	"zhizhou.zhang" <zhizhou.zhang@spreadtrum.com>,
	"lanqing.liu@spreadtrum.com" <lanqing.liu@spreadtrum.com>,
	"Wei Qiao (乔伟)" <wei.qiao@spreadtrum.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"sprdlinux@freelists.org" <sprdlinux@freelists.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>
Subject: Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support
Date: Wed, 3 Dec 2014 20:15:48 +0800	[thread overview]
Message-ID: <CAAfSe-smHeyRyaPYD7NsT8WNRhu+5uofc-oZ9rKX9Mkc2WV7Bg@mail.gmail.com> (raw)
In-Reply-To: <3212776.kDbe7yX4eX@wuerfel>

2014-12-03 17:50 GMT+08:00 Arnd Bergmann <arnd@arndb.de>:
> On Wednesday 03 December 2014 17:17:13 Lyra Zhang wrote:
>
>> 2014-11-27 2:29 GMT+08:00 Murali Karicheri <m-karicheri2@ti.com>:
>> > How about sorting this includes? asm/irq.h go first followed linux/ in alphabatical order?
>>
>> There are a few compile warnings if I moved asm/irq.h to the top of
>> all included files.
>
> The order that Murali meant is
>
> - first all linux/*.h headers, sorted alphabetically
> - then all asm/*.h headers, again sorted alphabetically
>
> This is the recommended style in general.
>
>> Warning details are below:
>>
>> In file included from drivers/tty/serial/sprd_serial.c:14:0:
>> ./arch/arm64/include/asm/irq.h:6:39: warning: ‘struct pt_regs’
>> declared inside parameter list [enabled by default]
>>  extern void (*handle_arch_irq)(struct pt_regs *);
>>                                        ^
>> ./arch/arm64/include/asm/irq.h:6:39: warning: its scope is only this
>> definition or declaration, which is probably not what you want
>> [enabled by default]
>> ./arch/arm64/include/asm/irq.h:8:54: warning: ‘struct pt_regs’
>> declared inside parameter list [enabled by default]
>>  extern void set_handle_irq(void (*handle_irq)(struct pt_regs *));
>>
>
> I would consider this a (minor) bug in asm/irq.h. If you don't mind,
> please submit a patch to add a line with 'struct pt_regs;' to
> asm/irq.h.

OK, I would like to send another separate patch for this.

Best regards,
Chunyan

>
>         Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/