From: Anup Patel <anup@brainfault.org> To: Rob Herring <robh@kernel.org> Cc: Anup Patel <anup.patel@wdc.com>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Damien Le Moal <damien.lemoal@wdc.com>, Atish Patra <atish.patra@wdc.com>, Alistair Francis <Alistair.Francis@wdc.com>, linux-riscv <linux-riscv@lists.infradead.org>, "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>, devicetree@vger.kernel.org, Palmer Dabbelt <palmerdabbelt@google.com>, Emil Renner Berhing <kernel@esmil.dk> Subject: Re: [PATCH v5 4/4] dt-bindings: timer: Add CLINT bindings Date: Fri, 24 Jul 2020 08:25:58 +0530 [thread overview] Message-ID: <CAAhSdy0tvy65zYSqeSAq781gRA4P0v5Suad+PidNFgPYLd+U1w@mail.gmail.com> (raw) In-Reply-To: <20200723170806.GA535824@bogus> On Thu, Jul 23, 2020 at 10:38 PM Rob Herring <robh@kernel.org> wrote: > > On Thu, Jul 23, 2020 at 07:54:09PM +0530, Anup Patel wrote: > > We add DT bindings documentation for CLINT device. > > > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > > Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> > > Tested-by: Emil Renner Berhing <kernel@esmil.dk> > > --- > > .../bindings/timer/sifive,clint.yaml | 58 +++++++++++++++++++ > > 1 file changed, 58 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/timer/sifive,clint.yaml > > > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > > new file mode 100644 > > index 000000000000..8ad115611860 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > > @@ -0,0 +1,58 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/timer/sifive,clint.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: SiFive Core Local Interruptor > > + > > +maintainers: > > + - Palmer Dabbelt <palmer@dabbelt.com> > > + - Anup Patel <anup.patel@wdc.com> > > + > > +description: > > + SiFive (and other RISC-V) SOCs include an implementation of the SiFive > > + Core Local Interruptor (CLINT) for M-mode timer and M-mode inter-processor > > + interrupts. It directly connects to the timer and inter-processor interrupt > > + lines of various HARTs (or CPUs) so RISC-V per-HART (or per-CPU) local > > + interrupt controller is the parent interrupt controller for CLINT device. > > + The clock frequency of CLINT is specified via "timebase-frequency" DT > > + property of "/cpus" DT node. The "timebase-frequency" DT property is > > + described in Documentation/devicetree/bindings/riscv/cpus.yaml > > + > > +properties: > > + compatible: > > + items: > > + - const: sifive,clint0 > > + - const: sifive,fu540-c000-clint > > Wrong order. Most specific goes first. Okay, will update. > > > + > > + description: > > + Should be "sifive,<chip>-clint" and "sifive,clint<version>". > > + Supported compatible strings are - > > + "sifive,fu540-c000-clint" for the SiFive CLINT v0 as integrated > > + onto the SiFive FU540 chip, and "sifive,clint0" for the SiFive > > + CLINT v0 IP block with no chip integration tweaks. > > + Please refer to sifive-blocks-ip-versioning.txt for details > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts-extended: > > + minItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts-extended > > Add: > > additionalProperties: false Okay, will add. > > > + > > +examples: > > + - | > > + clint@2000000 { > > timer@... Okay, will rename. > > > + compatible = "sifive,clint0", "sifive,fu540-c000-clint"; > > + interrupts-extended = <&cpu1intc 3 &cpu1intc 7 > > + &cpu2intc 3 &cpu2intc 7 > > + &cpu3intc 3 &cpu3intc 7 > > + &cpu4intc 3 &cpu4intc 7>; > > + reg = <0x2000000 0x4000000>; > > 64MB of register space? Doesn't matter much for 64-bit, but would waste > lots of virtual space (low mem) on 32-bit. This is a typo. The register space size is 64KB not 64MB. I will update. > > > + }; > > +... > > -- > > 2.25.1 > > Regards, Anup
WARNING: multiple messages have this Message-ID (diff)
From: Anup Patel <anup@brainfault.org> To: Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org, Damien Le Moal <damien.lemoal@wdc.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Emil Renner Berhing <kernel@esmil.dk>, Anup Patel <anup.patel@wdc.com>, "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>, Atish Patra <atish.patra@wdc.com>, Albert Ou <aou@eecs.berkeley.edu>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmerdabbelt@google.com>, Alistair Francis <Alistair.Francis@wdc.com>, Thomas Gleixner <tglx@linutronix.de>, linux-riscv <linux-riscv@lists.infradead.org> Subject: Re: [PATCH v5 4/4] dt-bindings: timer: Add CLINT bindings Date: Fri, 24 Jul 2020 08:25:58 +0530 [thread overview] Message-ID: <CAAhSdy0tvy65zYSqeSAq781gRA4P0v5Suad+PidNFgPYLd+U1w@mail.gmail.com> (raw) In-Reply-To: <20200723170806.GA535824@bogus> On Thu, Jul 23, 2020 at 10:38 PM Rob Herring <robh@kernel.org> wrote: > > On Thu, Jul 23, 2020 at 07:54:09PM +0530, Anup Patel wrote: > > We add DT bindings documentation for CLINT device. > > > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > > Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> > > Tested-by: Emil Renner Berhing <kernel@esmil.dk> > > --- > > .../bindings/timer/sifive,clint.yaml | 58 +++++++++++++++++++ > > 1 file changed, 58 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/timer/sifive,clint.yaml > > > > diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > > new file mode 100644 > > index 000000000000..8ad115611860 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml > > @@ -0,0 +1,58 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/timer/sifive,clint.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: SiFive Core Local Interruptor > > + > > +maintainers: > > + - Palmer Dabbelt <palmer@dabbelt.com> > > + - Anup Patel <anup.patel@wdc.com> > > + > > +description: > > + SiFive (and other RISC-V) SOCs include an implementation of the SiFive > > + Core Local Interruptor (CLINT) for M-mode timer and M-mode inter-processor > > + interrupts. It directly connects to the timer and inter-processor interrupt > > + lines of various HARTs (or CPUs) so RISC-V per-HART (or per-CPU) local > > + interrupt controller is the parent interrupt controller for CLINT device. > > + The clock frequency of CLINT is specified via "timebase-frequency" DT > > + property of "/cpus" DT node. The "timebase-frequency" DT property is > > + described in Documentation/devicetree/bindings/riscv/cpus.yaml > > + > > +properties: > > + compatible: > > + items: > > + - const: sifive,clint0 > > + - const: sifive,fu540-c000-clint > > Wrong order. Most specific goes first. Okay, will update. > > > + > > + description: > > + Should be "sifive,<chip>-clint" and "sifive,clint<version>". > > + Supported compatible strings are - > > + "sifive,fu540-c000-clint" for the SiFive CLINT v0 as integrated > > + onto the SiFive FU540 chip, and "sifive,clint0" for the SiFive > > + CLINT v0 IP block with no chip integration tweaks. > > + Please refer to sifive-blocks-ip-versioning.txt for details > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts-extended: > > + minItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts-extended > > Add: > > additionalProperties: false Okay, will add. > > > + > > +examples: > > + - | > > + clint@2000000 { > > timer@... Okay, will rename. > > > + compatible = "sifive,clint0", "sifive,fu540-c000-clint"; > > + interrupts-extended = <&cpu1intc 3 &cpu1intc 7 > > + &cpu2intc 3 &cpu2intc 7 > > + &cpu3intc 3 &cpu3intc 7 > > + &cpu4intc 3 &cpu4intc 7>; > > + reg = <0x2000000 0x4000000>; > > 64MB of register space? Doesn't matter much for 64-bit, but would waste > lots of virtual space (low mem) on 32-bit. This is a typo. The register space size is 64KB not 64MB. I will update. > > > + }; > > +... > > -- > > 2.25.1 > > Regards, Anup _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-07-24 2:56 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-23 14:24 [PATCH v5 0/4] Dedicated CLINT timer driver Anup Patel 2020-07-23 14:24 ` Anup Patel 2020-07-23 14:24 ` [PATCH v5 1/4] RISC-V: Add mechanism to provide custom IPI operations Anup Patel 2020-07-23 14:24 ` Anup Patel 2020-07-23 14:24 ` [PATCH v5 2/4] clocksource/drivers: Add CLINT timer driver Anup Patel 2020-07-23 14:24 ` Anup Patel 2020-07-23 14:34 ` Daniel Lezcano 2020-07-23 14:34 ` Daniel Lezcano 2020-07-23 14:24 ` [PATCH v5 3/4] RISC-V: Remove CLINT related code from timer and arch Anup Patel 2020-07-23 14:24 ` Anup Patel 2020-07-23 14:35 ` Daniel Lezcano 2020-07-23 14:35 ` Daniel Lezcano 2020-07-23 14:24 ` [PATCH v5 4/4] dt-bindings: timer: Add CLINT bindings Anup Patel 2020-07-23 14:24 ` Anup Patel 2020-07-23 17:08 ` Rob Herring 2020-07-23 17:08 ` Rob Herring 2020-07-24 2:55 ` Anup Patel [this message] 2020-07-24 2:55 ` Anup Patel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAhSdy0tvy65zYSqeSAq781gRA4P0v5Suad+PidNFgPYLd+U1w@mail.gmail.com \ --to=anup@brainfault.org \ --cc=Alistair.Francis@wdc.com \ --cc=anup.patel@wdc.com \ --cc=aou@eecs.berkeley.edu \ --cc=atish.patra@wdc.com \ --cc=damien.lemoal@wdc.com \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=kernel@esmil.dk \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=palmerdabbelt@google.com \ --cc=paul.walmsley@sifive.com \ --cc=robh@kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.