All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error.
@ 2022-06-08  1:12 Yupeng Li
  2022-06-08  1:41 ` Guenter Roeck
  2022-06-09 20:25 ` Thomas Bogendoerfer
  0 siblings, 2 replies; 4+ messages in thread
From: Yupeng Li @ 2022-06-08  1:12 UTC (permalink / raw)
  To: chenhuacai, jiaxun.yang, tsbogend, jdelvare, linux
  Cc: linux-mips, linux-kernel, linux-hwmon, caizp2008, Yupeng Li

  set cpu_hwmon as a module build with loongson_sysconf, loongson_chiptemp
  undefined error,fix cpu_hwmon compile options to be bool.Some kernel
  compilation error information is as follows:

  Checking missing-syscalls for N32
  CALL    scripts/checksyscalls.sh
  Checking missing-syscalls for O32
  CALL    scripts/checksyscalls.sh
  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  CC [M]  drivers/platform/mips/cpu_hwmon.o
  Building modules, stage 2.
  MODPOST 200 modules
ERROR: "loongson_sysconf" [drivers/platform/mips/cpu_hwmon.ko] undefined!
ERROR: "loongson_chiptemp" [drivers/platform/mips/cpu_hwmon.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92:__modpost] 错误 1
make: *** [Makefile:1261:modules] 错误 2

Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>
---
 drivers/platform/mips/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
index d421e1482395..6b51ad01f791 100644
--- a/drivers/platform/mips/Kconfig
+++ b/drivers/platform/mips/Kconfig
@@ -17,7 +17,7 @@ menuconfig MIPS_PLATFORM_DEVICES
 if MIPS_PLATFORM_DEVICES
 
 config CPU_HWMON
-	tristate "Loongson-3 CPU HWMon Driver"
+	bool "Loongson-3 CPU HWMon Driver"
 	depends on MACH_LOONGSON64
 	select HWMON
 	default y
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error.
  2022-06-08  1:12 [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error Yupeng Li
@ 2022-06-08  1:41 ` Guenter Roeck
  2022-06-08  4:11   ` Huacai Chen
  2022-06-09 20:25 ` Thomas Bogendoerfer
  1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2022-06-08  1:41 UTC (permalink / raw)
  To: Yupeng Li, chenhuacai, jiaxun.yang, tsbogend, jdelvare
  Cc: linux-mips, linux-kernel, linux-hwmon, caizp2008

On 6/7/22 18:12, Yupeng Li wrote:
>    set cpu_hwmon as a module build with loongson_sysconf, loongson_chiptemp
>    undefined error,fix cpu_hwmon compile options to be bool.Some kernel
>    compilation error information is as follows:
> 
>    Checking missing-syscalls for N32
>    CALL    scripts/checksyscalls.sh
>    Checking missing-syscalls for O32
>    CALL    scripts/checksyscalls.sh
>    CALL    scripts/checksyscalls.sh
>    CHK     include/generated/compile.h
>    CC [M]  drivers/platform/mips/cpu_hwmon.o
>    Building modules, stage 2.
>    MODPOST 200 modules
> ERROR: "loongson_sysconf" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> ERROR: "loongson_chiptemp" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:92:__modpost] 错误 1
> make: *** [Makefile:1261:modules] 错误 2
> 
> Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/platform/mips/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> index d421e1482395..6b51ad01f791 100644
> --- a/drivers/platform/mips/Kconfig
> +++ b/drivers/platform/mips/Kconfig
> @@ -17,7 +17,7 @@ menuconfig MIPS_PLATFORM_DEVICES
>   if MIPS_PLATFORM_DEVICES
>   
>   config CPU_HWMON
> -	tristate "Loongson-3 CPU HWMon Driver"
> +	bool "Loongson-3 CPU HWMon Driver"
>   	depends on MACH_LOONGSON64
>   	select HWMON
>   	default y


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error.
  2022-06-08  1:41 ` Guenter Roeck
@ 2022-06-08  4:11   ` Huacai Chen
  0 siblings, 0 replies; 4+ messages in thread
From: Huacai Chen @ 2022-06-08  4:11 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Yupeng Li, Jiaxun Yang, Thomas Bogendoerfer, Jean Delvare,
	open list:MIPS, LKML, linux-hwmon, caizp2008

Reviewed-by: Huacai Chen <chenhuacai@kernel.org>

On Wed, Jun 8, 2022 at 9:41 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 6/7/22 18:12, Yupeng Li wrote:
> >    set cpu_hwmon as a module build with loongson_sysconf, loongson_chiptemp
> >    undefined error,fix cpu_hwmon compile options to be bool.Some kernel
> >    compilation error information is as follows:
> >
> >    Checking missing-syscalls for N32
> >    CALL    scripts/checksyscalls.sh
> >    Checking missing-syscalls for O32
> >    CALL    scripts/checksyscalls.sh
> >    CALL    scripts/checksyscalls.sh
> >    CHK     include/generated/compile.h
> >    CC [M]  drivers/platform/mips/cpu_hwmon.o
> >    Building modules, stage 2.
> >    MODPOST 200 modules
> > ERROR: "loongson_sysconf" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> > ERROR: "loongson_chiptemp" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> > make[1]: *** [scripts/Makefile.modpost:92:__modpost] 错误 1
> > make: *** [Makefile:1261:modules] 错误 2
> >
> > Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> > ---
> >   drivers/platform/mips/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> > index d421e1482395..6b51ad01f791 100644
> > --- a/drivers/platform/mips/Kconfig
> > +++ b/drivers/platform/mips/Kconfig
> > @@ -17,7 +17,7 @@ menuconfig MIPS_PLATFORM_DEVICES
> >   if MIPS_PLATFORM_DEVICES
> >
> >   config CPU_HWMON
> > -     tristate "Loongson-3 CPU HWMon Driver"
> > +     bool "Loongson-3 CPU HWMon Driver"
> >       depends on MACH_LOONGSON64
> >       select HWMON
> >       default y
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error.
  2022-06-08  1:12 [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error Yupeng Li
  2022-06-08  1:41 ` Guenter Roeck
@ 2022-06-09 20:25 ` Thomas Bogendoerfer
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2022-06-09 20:25 UTC (permalink / raw)
  To: Yupeng Li
  Cc: chenhuacai, jiaxun.yang, jdelvare, linux, linux-mips,
	linux-kernel, linux-hwmon, caizp2008

On Wed, Jun 08, 2022 at 09:12:29AM +0800, Yupeng Li wrote:
>   set cpu_hwmon as a module build with loongson_sysconf, loongson_chiptemp
>   undefined error,fix cpu_hwmon compile options to be bool.Some kernel
>   compilation error information is as follows:
> 
>   Checking missing-syscalls for N32
>   CALL    scripts/checksyscalls.sh
>   Checking missing-syscalls for O32
>   CALL    scripts/checksyscalls.sh
>   CALL    scripts/checksyscalls.sh
>   CHK     include/generated/compile.h
>   CC [M]  drivers/platform/mips/cpu_hwmon.o
>   Building modules, stage 2.
>   MODPOST 200 modules
> ERROR: "loongson_sysconf" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> ERROR: "loongson_chiptemp" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:92:__modpost] 错误 1
> make: *** [Makefile:1261:modules] 错误 2
> 
> Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>
> ---
>  drivers/platform/mips/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> index d421e1482395..6b51ad01f791 100644
> --- a/drivers/platform/mips/Kconfig
> +++ b/drivers/platform/mips/Kconfig
> @@ -17,7 +17,7 @@ menuconfig MIPS_PLATFORM_DEVICES
>  if MIPS_PLATFORM_DEVICES
>  
>  config CPU_HWMON
> -	tristate "Loongson-3 CPU HWMon Driver"
> +	bool "Loongson-3 CPU HWMon Driver"
>  	depends on MACH_LOONGSON64
>  	select HWMON
>  	default y
> -- 
> 2.34.1

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-06-09 20:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-08  1:12 [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error Yupeng Li
2022-06-08  1:41 ` Guenter Roeck
2022-06-08  4:11   ` Huacai Chen
2022-06-09 20:25 ` Thomas Bogendoerfer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.