From: "David R. Bild" <david.bild@xaptum.com> To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Cc: James Bottomley <James.Bottomley@hansenpartnership.com>, philip.b.tricca@intel.com, Jason Gunthorpe <jgg@ziepe.ca>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Peter Huewe <peterhuewe@gmx.de>, linux-usb@vger.kernel.org, linux-integrity@vger.kernel.org Subject: [v3,2/2] usb: misc: xapea00x: perform platform initialization of TPM Date: Thu, 10 May 2018 09:29:14 -0500 [thread overview] Message-ID: <CAAi9uDvHLhTYsao0LJH4jTfxufiC7W61S+9=gWOqByMrHrU+0w@mail.gmail.com> (raw) On Wed, May 9, 2018 at 8:44 PM, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote: > On Tue, May 08, 2018 at 10:29:41AM -0500, David R. Bild wrote: >> On Tue, May 8, 2018 at 10:25 AM, James Bottomley >> <James.Bottomley@hansenpartnership.com> wrote: >> > >> > > On Fri, May 04, 2018 at 02:56:25PM -0500, David R. Bild wrote: >> > [...] >> > > > In particular, it sets the credentials for the platform hierarchy. >> > > > The platform hierarchy is essentially the "root" account of the >> > > > TPM, so it's critical that those credentials be set before the TPM >> > > > is exposed to user-space. (The platform credentials aren't >> > > > persisted in the TPM and must be set by the platform on every >> > > > boot.) If the driver registers the TPM before doing >> > > > initialization, there's a chance that something else could access >> > > > the TPM before the platform credentials get set. >> > > > Who is able to test these changes if we even consider pulling them? I can send you and the other maintainers cards to test with. That's dead simple. (With a USB-A plug, not mini PCI-e, so you can plug it into any computer.) They won't have the Xaptum credentials pre-provisioned, and will just function as normal TPMs. > I do not have such a card so it will be hard to accept also given > that it is more intrusive change than usual. The current approach (the driver does all the initialization) requires no changes to the TPM driver. Only someone who buys our card will ever run that code, so it doesn't impact anyone else. Best, David --- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "David R. Bild" <david.bild@xaptum.com> To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Cc: James Bottomley <James.Bottomley@hansenpartnership.com>, philip.b.tricca@intel.com, Jason Gunthorpe <jgg@ziepe.ca>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Peter Huewe <peterhuewe@gmx.de>, linux-usb@vger.kernel.org, linux-integrity@vger.kernel.org Subject: Re: [PATCH v3 2/2] usb: misc: xapea00x: perform platform initialization of TPM Date: Thu, 10 May 2018 09:29:14 -0500 [thread overview] Message-ID: <CAAi9uDvHLhTYsao0LJH4jTfxufiC7W61S+9=gWOqByMrHrU+0w@mail.gmail.com> (raw) In-Reply-To: <20180510014433.GM6190@linux.intel.com> On Wed, May 9, 2018 at 8:44 PM, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote: > On Tue, May 08, 2018 at 10:29:41AM -0500, David R. Bild wrote: >> On Tue, May 8, 2018 at 10:25 AM, James Bottomley >> <James.Bottomley@hansenpartnership.com> wrote: >> > >> > > On Fri, May 04, 2018 at 02:56:25PM -0500, David R. Bild wrote: >> > [...] >> > > > In particular, it sets the credentials for the platform hierarchy. >> > > > The platform hierarchy is essentially the "root" account of the >> > > > TPM, so it's critical that those credentials be set before the TPM >> > > > is exposed to user-space. (The platform credentials aren't >> > > > persisted in the TPM and must be set by the platform on every >> > > > boot.) If the driver registers the TPM before doing >> > > > initialization, there's a chance that something else could access >> > > > the TPM before the platform credentials get set. >> > > > Who is able to test these changes if we even consider pulling them? I can send you and the other maintainers cards to test with. That's dead simple. (With a USB-A plug, not mini PCI-e, so you can plug it into any computer.) They won't have the Xaptum credentials pre-provisioned, and will just function as normal TPMs. > I do not have such a card so it will be hard to accept also given > that it is more intrusive change than usual. The current approach (the driver does all the initialization) requires no changes to the TPM driver. Only someone who buys our card will ever run that code, so it doesn't impact anyone else. Best, David
next reply other threads:[~2018-05-10 14:29 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-10 14:29 David R. Bild [this message] 2018-05-10 14:29 ` [PATCH v3 2/2] usb: misc: xapea00x: perform platform initialization of TPM David R. Bild -- strict thread matches above, loose matches on Subject: below -- 2018-05-25 20:31 [v3,2/2] " Ken Goldman 2018-05-25 20:31 ` [PATCH v3 2/2] " Ken Goldman 2018-05-25 20:23 [v3,2/2] " Ken Goldman 2018-05-25 20:23 ` [PATCH v3 2/2] " Ken Goldman 2018-05-14 20:12 [v3,2/2] " David R. Bild 2018-05-14 20:12 ` [PATCH v3 2/2] " David R. Bild 2018-05-14 20:08 [v3,2/2] " Jason Gunthorpe 2018-05-14 20:08 ` [PATCH v3 2/2] " Jason Gunthorpe 2018-05-14 19:59 [v3,2/2] " David R. Bild 2018-05-14 19:59 ` [PATCH v3 2/2] " David R. Bild 2018-05-14 19:31 [v3,2/2] " Jason Gunthorpe 2018-05-14 19:31 ` [PATCH v3 2/2] " Jason Gunthorpe 2018-05-13 8:51 [v3,2/2] " Jarkko Sakkinen 2018-05-13 8:51 ` [PATCH v3 2/2] " Jarkko Sakkinen 2018-05-13 8:46 [v3,2/2] " Jarkko Sakkinen 2018-05-13 8:46 ` [PATCH v3 2/2] " Jarkko Sakkinen 2018-05-10 15:17 [v3,2/2] " David R. Bild 2018-05-10 15:17 ` [PATCH v3 2/2] " David R. Bild 2018-05-10 14:47 [v3,2/2] " James Bottomley 2018-05-10 14:47 ` [PATCH v3 2/2] " James Bottomley 2018-05-10 14:41 [v3,2/2] " David R. Bild 2018-05-10 14:41 ` [PATCH v3 2/2] " David R. Bild 2018-05-10 14:31 [v3,2/2] " David R. Bild 2018-05-10 14:31 ` [PATCH v3 2/2] " David R. Bild 2018-05-10 14:25 [v3,2/2] " David R. Bild 2018-05-10 14:25 ` [PATCH v3 2/2] " David R. Bild 2018-05-10 14:09 [v3,2/2] " David R. Bild 2018-05-10 14:09 ` [PATCH v3 2/2] " David R. Bild 2018-05-10 1:59 [v3,2/2] " Jarkko Sakkinen 2018-05-10 1:59 ` [PATCH v3 2/2] " Jarkko Sakkinen 2018-05-10 1:44 [v3,2/2] " Jarkko Sakkinen 2018-05-10 1:44 ` [PATCH v3 2/2] " Jarkko Sakkinen 2018-05-10 1:42 [v3,2/2] " Jarkko Sakkinen 2018-05-10 1:42 ` [PATCH v3 2/2] " Jarkko Sakkinen 2018-05-10 1:42 [v3,2/2] " Jarkko Sakkinen 2018-05-10 1:42 ` [PATCH v3 2/2] " Jarkko Sakkinen 2018-05-08 15:36 [v3,2/2] " James Bottomley 2018-05-08 15:36 ` [PATCH v3 2/2] " James Bottomley 2018-05-08 15:29 [v3,2/2] " David R. Bild 2018-05-08 15:29 ` [PATCH v3 2/2] " David R. Bild 2018-05-08 15:25 [v3,2/2] " James Bottomley 2018-05-08 15:25 ` [PATCH v3 2/2] " James Bottomley 2018-05-08 10:55 [v3,2/2] " Jarkko Sakkinen 2018-05-08 10:55 ` [PATCH v3 2/2] " Jarkko Sakkinen 2018-05-08 10:47 [v3,2/2] " Jarkko Sakkinen 2018-05-08 10:47 ` [PATCH v3 2/2] " Jarkko Sakkinen 2018-05-08 9:09 [v3,1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card Oliver Neukum 2018-05-08 9:09 ` [PATCH v3 1/2] " Oliver Neukum 2018-05-07 14:12 EXTERNAL: [PATCH v3 2/2] usb: misc: xapea00x: perform platform initialization of TPM Jeremy Boone 2018-05-07 14:12 ` Jeremy Boone 2018-05-07 13:31 [v3,1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card David R. Bild 2018-05-07 13:31 ` [PATCH v3 1/2] " David R. Bild 2018-05-07 9:58 [v3,1/2] " Oliver Neukum 2018-05-07 9:58 ` [PATCH v3 1/2] " Oliver Neukum 2018-05-06 15:02 [v3,2/2] usb: misc: xapea00x: perform platform initialization of TPM Jason Gunthorpe 2018-05-06 15:02 ` [PATCH v3 2/2] " Jason Gunthorpe 2018-05-04 20:19 [v3,2/2] " David R. Bild 2018-05-04 20:19 ` [PATCH v3 2/2] " David R. Bild 2018-05-04 19:56 [v3,2/2] " David R. Bild 2018-05-04 19:56 ` [PATCH v3 2/2] " David R. Bild 2018-05-04 19:06 [v3,2/2] " Jason Gunthorpe 2018-05-04 19:06 ` [PATCH v3 2/2] " Jason Gunthorpe 2018-05-04 13:00 [v3,2/2] " David R. Bild 2018-05-04 13:00 ` [PATCH v3 2/2] " David R. Bild 2018-05-04 13:00 [v3,1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card David R. Bild 2018-05-04 13:00 ` [PATCH v3 1/2] " David R. Bild [not found] <20180430125418.31344-1-david.bild@xaptum.com> 2018-05-04 13:00 ` [PATCH v3 0/2] Add driver for Xaptum ENF Access card (XAP-EA-00x) David R. Bild
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAAi9uDvHLhTYsao0LJH4jTfxufiC7W61S+9=gWOqByMrHrU+0w@mail.gmail.com' \ --to=david.bild@xaptum.com \ --cc=James.Bottomley@hansenpartnership.com \ --cc=gregkh@linuxfoundation.org \ --cc=jarkko.sakkinen@linux.intel.com \ --cc=jgg@ziepe.ca \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=peterhuewe@gmx.de \ --cc=philip.b.tricca@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.