All of lore.kernel.org
 help / color / mirror / Atom feed
* arm/boot/dts/at91sam9260.dtsi USB clock divisors and AT91SAM9G20
@ 2016-10-25 17:49 Andrey Yurovsky
  2016-10-26  7:52 ` Alexandre Belloni
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Yurovsky @ 2016-10-25 17:49 UTC (permalink / raw)
  To: linux-arm-kernel

I'm working at an AT91SAM9G20 on which the USB clock divisor was wrong
and traced the issue down to arm/boot/dts/at91sam9260.dtsi which is
included like this:

at91sam9g20ek_common.dtsi
    at91sam9g20.dtsi
        at91sam9260.dtsi

This has a node:

                usb: usbck {
                    compatible = "atmel,at91rm9200-clk-usb";
                    #clock-cells = <0>;
                    atmel,clk-divisors = <1 2 4 0>;
                    clocks = <&pllb>;
                };

However the G20 parts seem to need a different divisor, for me this works:

                usb: usbck {
                    compatible = "atmel,at91rm9200-clk-usb";
                    #clock-cells = <0>;
                    atmel,clk-divisors = <4 2 0 0>;
                    clocks = <&pllb>;
                };

Should the USB clock node be moved to a separate .dtsi file to account
for this difference?

^ permalink raw reply	[flat|nested] 2+ messages in thread

* arm/boot/dts/at91sam9260.dtsi USB clock divisors and AT91SAM9G20
  2016-10-25 17:49 arm/boot/dts/at91sam9260.dtsi USB clock divisors and AT91SAM9G20 Andrey Yurovsky
@ 2016-10-26  7:52 ` Alexandre Belloni
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2016-10-26  7:52 UTC (permalink / raw)
  To: linux-arm-kernel

On 25/10/2016 at 10:49:01 -0700, Andrey Yurovsky wrote :
> I'm working at an AT91SAM9G20 on which the USB clock divisor was wrong
> and traced the issue down to arm/boot/dts/at91sam9260.dtsi which is
> included like this:
> 
> at91sam9g20ek_common.dtsi
>     at91sam9g20.dtsi
>         at91sam9260.dtsi
> 
> This has a node:
> 
>                 usb: usbck {
>                     compatible = "atmel,at91rm9200-clk-usb";
>                     #clock-cells = <0>;
>                     atmel,clk-divisors = <1 2 4 0>;
>                     clocks = <&pllb>;
>                 };
> 
> However the G20 parts seem to need a different divisor, for me this works:
> 
>                 usb: usbck {
>                     compatible = "atmel,at91rm9200-clk-usb";
>                     #clock-cells = <0>;
>                     atmel,clk-divisors = <4 2 0 0>;
>                     clocks = <&pllb>;
>                 };
> 
> Should the USB clock node be moved to a separate .dtsi file to account
> for this difference?

I think the easiest way of doing it is to override atmel,clk-divisors in
at91sam9g20.dtsi.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-26  7:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-25 17:49 arm/boot/dts/at91sam9260.dtsi USB clock divisors and AT91SAM9G20 Andrey Yurovsky
2016-10-26  7:52 ` Alexandre Belloni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.