From: Joonsoo Kim <js1304@gmail.com> To: Jesper Dangaard Brouer <brouer@redhat.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>, Linux Memory Management List <linux-mm@kvack.org>, Christoph Lameter <cl@linux.com>, Andrew Morton <akpm@linux-foundation.org>, Linux-Netdev <netdev@vger.kernel.org>, Alexander Duyck <alexander.duyck@gmail.com> Subject: Re: [PATCH 7/7] slub: initial bulk free implementation Date: Tue, 16 Jun 2015 21:00:39 +0900 [thread overview] Message-ID: <CAAmzW4P4kHW4NJv=BFXye4bENv1L7Tdyhuwio3rm5j-3y-tE-g@mail.gmail.com> (raw) In-Reply-To: <20150616112033.0b8bafb8@redhat.com> 2015-06-16 18:20 GMT+09:00 Jesper Dangaard Brouer <brouer@redhat.com>: > On Tue, 16 Jun 2015 16:23:28 +0900 > Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote: > >> On Mon, Jun 15, 2015 at 05:52:56PM +0200, Jesper Dangaard Brouer wrote: >> > This implements SLUB specific kmem_cache_free_bulk(). SLUB allocator >> > now both have bulk alloc and free implemented. >> > >> > Play nice and reenable local IRQs while calling slowpath. >> > >> > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> >> > --- >> > mm/slub.c | 32 +++++++++++++++++++++++++++++++- >> > 1 file changed, 31 insertions(+), 1 deletion(-) >> > >> > diff --git a/mm/slub.c b/mm/slub.c >> > index 98d0e6f73ec1..cc4f870677bb 100644 >> > --- a/mm/slub.c >> > +++ b/mm/slub.c >> > @@ -2752,7 +2752,37 @@ EXPORT_SYMBOL(kmem_cache_free); >> > >> > void kmem_cache_free_bulk(struct kmem_cache *s, size_t size, void **p) >> > { >> > - __kmem_cache_free_bulk(s, size, p); >> > + struct kmem_cache_cpu *c; >> > + struct page *page; >> > + int i; >> > + >> > + local_irq_disable(); >> > + c = this_cpu_ptr(s->cpu_slab); >> > + >> > + for (i = 0; i < size; i++) { >> > + void *object = p[i]; >> > + >> > + if (unlikely(!object)) >> > + continue; // HOW ABOUT BUG_ON()??? >> > + >> > + page = virt_to_head_page(object); >> > + BUG_ON(s != page->slab_cache); /* Check if valid slab page */ >> >> You need to use cache_from_objt() to support kmemcg accounting. >> And, slab_free_hook() should be called before free. > > Okay, but Christoph choose to not support kmem_cache_debug() in patch2/7. > > Should we/I try to add kmem cache debugging support? kmem_cache_debug() is the check for slab internal debugging feature. slab_free_hook() and others mentioned from me are also related to external debugging features like as kasan and kmemleak. So, even if debugged kmem_cache isn't supported by bulk API, external debugging feature should be supported. > If adding these, then I would also need to add those on alloc path... Yes, please. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joonsoo Kim <js1304@gmail.com> To: Jesper Dangaard Brouer <brouer@redhat.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>, Linux Memory Management List <linux-mm@kvack.org>, Christoph Lameter <cl@linux.com>, Andrew Morton <akpm@linux-foundation.org>, Linux-Netdev <netdev@vger.kernel.org>, Alexander Duyck <alexander.duyck@gmail.com> Subject: Re: [PATCH 7/7] slub: initial bulk free implementation Date: Tue, 16 Jun 2015 21:00:39 +0900 [thread overview] Message-ID: <CAAmzW4P4kHW4NJv=BFXye4bENv1L7Tdyhuwio3rm5j-3y-tE-g@mail.gmail.com> (raw) In-Reply-To: <20150616112033.0b8bafb8@redhat.com> 2015-06-16 18:20 GMT+09:00 Jesper Dangaard Brouer <brouer@redhat.com>: > On Tue, 16 Jun 2015 16:23:28 +0900 > Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote: > >> On Mon, Jun 15, 2015 at 05:52:56PM +0200, Jesper Dangaard Brouer wrote: >> > This implements SLUB specific kmem_cache_free_bulk(). SLUB allocator >> > now both have bulk alloc and free implemented. >> > >> > Play nice and reenable local IRQs while calling slowpath. >> > >> > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> >> > --- >> > mm/slub.c | 32 +++++++++++++++++++++++++++++++- >> > 1 file changed, 31 insertions(+), 1 deletion(-) >> > >> > diff --git a/mm/slub.c b/mm/slub.c >> > index 98d0e6f73ec1..cc4f870677bb 100644 >> > --- a/mm/slub.c >> > +++ b/mm/slub.c >> > @@ -2752,7 +2752,37 @@ EXPORT_SYMBOL(kmem_cache_free); >> > >> > void kmem_cache_free_bulk(struct kmem_cache *s, size_t size, void **p) >> > { >> > - __kmem_cache_free_bulk(s, size, p); >> > + struct kmem_cache_cpu *c; >> > + struct page *page; >> > + int i; >> > + >> > + local_irq_disable(); >> > + c = this_cpu_ptr(s->cpu_slab); >> > + >> > + for (i = 0; i < size; i++) { >> > + void *object = p[i]; >> > + >> > + if (unlikely(!object)) >> > + continue; // HOW ABOUT BUG_ON()??? >> > + >> > + page = virt_to_head_page(object); >> > + BUG_ON(s != page->slab_cache); /* Check if valid slab page */ >> >> You need to use cache_from_objt() to support kmemcg accounting. >> And, slab_free_hook() should be called before free. > > Okay, but Christoph choose to not support kmem_cache_debug() in patch2/7. > > Should we/I try to add kmem cache debugging support? kmem_cache_debug() is the check for slab internal debugging feature. slab_free_hook() and others mentioned from me are also related to external debugging features like as kasan and kmemleak. So, even if debugged kmem_cache isn't supported by bulk API, external debugging feature should be supported. > If adding these, then I would also need to add those on alloc path... Yes, please. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-16 12:00 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-15 15:51 [PATCH 0/7] slub: bulk alloc and free for slub allocator Jesper Dangaard Brouer 2015-06-15 15:51 ` Jesper Dangaard Brouer 2015-06-15 15:51 ` [PATCH 1/7] slab: infrastructure for bulk object allocation and freeing Jesper Dangaard Brouer 2015-06-15 15:51 ` Jesper Dangaard Brouer 2015-06-15 16:45 ` Alexander Duyck 2015-06-15 16:45 ` Alexander Duyck 2015-06-15 16:50 ` Christoph Lameter 2015-06-16 21:44 ` Andrew Morton 2015-06-16 21:44 ` Andrew Morton 2015-06-15 15:52 ` [PATCH 2/7] slub bulk alloc: extract objects from the per cpu slab Jesper Dangaard Brouer 2015-06-15 15:52 ` Jesper Dangaard Brouer 2015-06-16 7:21 ` Joonsoo Kim 2015-06-16 7:21 ` Joonsoo Kim 2015-06-16 15:05 ` Christoph Lameter 2015-06-16 21:48 ` Andrew Morton 2015-06-16 21:48 ` Andrew Morton 2015-06-17 6:24 ` Jesper Dangaard Brouer 2015-06-15 15:52 ` [PATCH 3/7] slub: reduce indention level in kmem_cache_alloc_bulk() Jesper Dangaard Brouer 2015-06-15 15:52 ` Jesper Dangaard Brouer 2015-06-15 15:52 ` [PATCH 4/7] slub: fix error path bug in kmem_cache_alloc_bulk Jesper Dangaard Brouer 2015-06-15 15:52 ` Jesper Dangaard Brouer 2015-06-16 21:51 ` Andrew Morton 2015-06-17 6:25 ` Jesper Dangaard Brouer 2015-06-15 15:52 ` [PATCH 5/7] slub: kmem_cache_alloc_bulk() move clearing outside IRQ disabled section Jesper Dangaard Brouer 2015-06-15 15:52 ` Jesper Dangaard Brouer 2015-06-15 15:52 ` [PATCH 6/7] slub: improve bulk alloc strategy Jesper Dangaard Brouer 2015-06-15 15:52 ` Jesper Dangaard Brouer 2015-06-15 16:36 ` Christoph Lameter 2015-06-16 21:53 ` Andrew Morton 2015-06-17 6:29 ` Jesper Dangaard Brouer 2015-06-17 6:29 ` Jesper Dangaard Brouer 2015-06-15 15:52 ` [PATCH 7/7] slub: initial bulk free implementation Jesper Dangaard Brouer 2015-06-15 15:52 ` Jesper Dangaard Brouer 2015-06-15 16:34 ` Christoph Lameter 2015-06-16 8:04 ` Jesper Dangaard Brouer 2015-06-15 17:04 ` Alexander Duyck 2015-06-16 7:23 ` Joonsoo Kim 2015-06-16 7:23 ` Joonsoo Kim 2015-06-16 9:20 ` Jesper Dangaard Brouer 2015-06-16 12:00 ` Joonsoo Kim [this message] 2015-06-16 12:00 ` Joonsoo Kim 2015-06-16 13:58 ` Jesper Dangaard Brouer 2015-06-16 15:06 ` Christoph Lameter 2015-06-16 7:28 ` Joonsoo Kim 2015-06-16 8:21 ` Jesper Dangaard Brouer 2015-06-16 8:21 ` Jesper Dangaard Brouer 2015-06-16 8:57 ` Jesper Dangaard Brouer 2015-06-16 12:05 ` Joonsoo Kim 2015-06-16 15:10 ` Christoph Lameter 2015-06-16 15:52 ` Jesper Dangaard Brouer 2015-06-16 15:52 ` Jesper Dangaard Brouer 2015-06-16 16:04 ` Christoph Lameter 2015-06-16 16:04 ` Christoph Lameter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAAmzW4P4kHW4NJv=BFXye4bENv1L7Tdyhuwio3rm5j-3y-tE-g@mail.gmail.com' \ --to=js1304@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=alexander.duyck@gmail.com \ --cc=brouer@redhat.com \ --cc=cl@linux.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=linux-mm@kvack.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.