All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] arm/edk2-firmware: force debug builds when using Clang
@ 2021-12-02 20:28 Ross Burton
  2021-12-02 20:28 ` [PATCH 2/2] CI: also build qemu-generic-arm64 for clang Ross Burton
  2021-12-03 12:35 ` [meta-arm] [PATCH 1/2] arm/edk2-firmware: force debug builds when using Clang Ross Burton
  0 siblings, 2 replies; 3+ messages in thread
From: Ross Burton @ 2021-12-02 20:28 UTC (permalink / raw)
  To: meta-arm

edk2-firmware release builds with clang fail:

MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c:142:15:
error: variable 'Status' set but not used [-Werror,-Wunused-but-set-variable]

This is upstream as https://bugzilla.tianocore.org/show_bug.cgi?id=3758,
but until that is resolved we can just force debug builds with clang.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta-arm/recipes-bsp/uefi/edk2-firmware.inc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta-arm/recipes-bsp/uefi/edk2-firmware.inc b/meta-arm/recipes-bsp/uefi/edk2-firmware.inc
index 7072d1b4..dd428d41 100644
--- a/meta-arm/recipes-bsp/uefi/edk2-firmware.inc
+++ b/meta-arm/recipes-bsp/uefi/edk2-firmware.inc
@@ -26,6 +26,10 @@ COMPATIBLE_MACHINE ?= "invalid"
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
 EDK2_BUILD_RELEASE = "1"
+# Release builds don't work with clang yet:
+# https://bugzilla.tianocore.org/show_bug.cgi?id=3758
+EDK2_BUILD_RELEASE:toolchain-clang = "0"
+
 EDK2_PLATFORM      = "unset"
 # build --platform
 EDK2_PLATFORM_DSC  = "unset"
@@ -110,3 +114,4 @@ do_deploy() {
     cp -rf ${D}/firmware/* ${DEPLOYDIR}/
 }
 addtask deploy after do_install
+TOOLCHAIN = "clang"
\ No newline at end of file
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] CI: also build qemu-generic-arm64 for clang
  2021-12-02 20:28 [PATCH 1/2] arm/edk2-firmware: force debug builds when using Clang Ross Burton
@ 2021-12-02 20:28 ` Ross Burton
  2021-12-03 12:35 ` [meta-arm] [PATCH 1/2] arm/edk2-firmware: force debug builds when using Clang Ross Burton
  1 sibling, 0 replies; 3+ messages in thread
From: Ross Burton @ 2021-12-02 20:28 UTC (permalink / raw)
  To: meta-arm

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .gitlab-ci.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index be522fc8..b2a4c438 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -177,7 +177,8 @@ qemu-generic-arm64:
   extends: .build
   parallel:
     matrix:
-      - TESTING: testimage
+      - TOOLCHAINS: [gcc, clang]
+        TESTING: testimage
 
 qemuarm64-secureboot:
   extends: .build
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [meta-arm] [PATCH 1/2] arm/edk2-firmware: force debug builds when using Clang
  2021-12-02 20:28 [PATCH 1/2] arm/edk2-firmware: force debug builds when using Clang Ross Burton
  2021-12-02 20:28 ` [PATCH 2/2] CI: also build qemu-generic-arm64 for clang Ross Burton
@ 2021-12-03 12:35 ` Ross Burton
  1 sibling, 0 replies; 3+ messages in thread
From: Ross Burton @ 2021-12-03 12:35 UTC (permalink / raw)
  To: meta-arm

Still broken, v2 incoming.

On Thu, 2 Dec 2021 at 20:28, Ross Burton via lists.yoctoproject.org
<ross=burtonini.com@lists.yoctoproject.org> wrote:
>
> edk2-firmware release builds with clang fail:
>
> MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c:142:15:
> error: variable 'Status' set but not used [-Werror,-Wunused-but-set-variable]
>
> This is upstream as https://bugzilla.tianocore.org/show_bug.cgi?id=3758,
> but until that is resolved we can just force debug builds with clang.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta-arm/recipes-bsp/uefi/edk2-firmware.inc | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta-arm/recipes-bsp/uefi/edk2-firmware.inc b/meta-arm/recipes-bsp/uefi/edk2-firmware.inc
> index 7072d1b4..dd428d41 100644
> --- a/meta-arm/recipes-bsp/uefi/edk2-firmware.inc
> +++ b/meta-arm/recipes-bsp/uefi/edk2-firmware.inc
> @@ -26,6 +26,10 @@ COMPATIBLE_MACHINE ?= "invalid"
>  PACKAGE_ARCH = "${MACHINE_ARCH}"
>
>  EDK2_BUILD_RELEASE = "1"
> +# Release builds don't work with clang yet:
> +# https://bugzilla.tianocore.org/show_bug.cgi?id=3758
> +EDK2_BUILD_RELEASE:toolchain-clang = "0"
> +
>  EDK2_PLATFORM      = "unset"
>  # build --platform
>  EDK2_PLATFORM_DSC  = "unset"
> @@ -110,3 +114,4 @@ do_deploy() {
>      cp -rf ${D}/firmware/* ${DEPLOYDIR}/
>  }
>  addtask deploy after do_install
> +TOOLCHAIN = "clang"
> \ No newline at end of file
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#2511): https://lists.yoctoproject.org/g/meta-arm/message/2511
> Mute This Topic: https://lists.yoctoproject.org/mt/87461917/1676615
> Group Owner: meta-arm+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [ross@burtonini.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-03 12:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02 20:28 [PATCH 1/2] arm/edk2-firmware: force debug builds when using Clang Ross Burton
2021-12-02 20:28 ` [PATCH 2/2] CI: also build qemu-generic-arm64 for clang Ross Burton
2021-12-03 12:35 ` [meta-arm] [PATCH 1/2] arm/edk2-firmware: force debug builds when using Clang Ross Burton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.