* [PATCHv2] recipe-graphics/waffle: Add depends on cmake-native
@ 2021-11-11 17:06 Anibal Limon
2021-11-11 17:39 ` [OE-core] " Ross Burton
0 siblings, 1 reply; 4+ messages in thread
From: Anibal Limon @ 2021-11-11 17:06 UTC (permalink / raw)
To: openembedded-core; +Cc: richard.purdie, Aníbal Limón
Fixes,
...
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/site-packages/mesonbuild/modules/cmake.py", line 241, in detect_cmake
p, stdout, stderr = mesonlib.Popen_safe(cmakebin.get_command() + ['--system-information', '-G', 'Ninja'])[0:3]
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/site-packages/mesonbuild/mesonlib/universal.py", line 1397, in Popen_safe
p = subprocess.Popen(args, universal_newlines=True, close_fds=False,
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/subprocess.py", line 966, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/subprocess.py", line 1717, in _execute_child
and os.path.dirname(executable)
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/posixpath.py", line 152, in dirname
p = os.fspath(p)
...
Not inherit cmake class because expects meson-log.txt,
...
File: 'exec_func_python() autogenerated', lineno: 2, function: <module>
0001:
*** 0002:meson_do_qa_configure(d)
0003:
File: '/home/builds/oe-rpb-master/build-410c/conf/../../layers/openembedded-core/meta/classes/meson.bbclass', lineno: 130, function: meson_do_qa_configure
0126:
0127:python meson_do_qa_configure() {
0128: import re
0129: warn_re = re.compile(r"^WARNING: Cross property (.+) is using default value (.+)$", re.MULTILINE)
*** 0130: with open(d.expand("${B}/meson-logs/meson-log.txt")) as logfile:
0131: log = logfile.read()
0132: for (prop, value) in warn_re.findall(log):
0133: bb.warn("Meson cross property %s used without explicit assignment, defaulting to %s" % (prop, value))
0134:}
Exception: FileNotFoundError: [Errno 2] No such file or directory: '/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/build/meson-logs/meson-log.txt'
...
Signed-off-by: Aníbal Limón <anibal.limon@linaro.org>
---
meta/recipes-graphics/waffle/waffle_1.7.0.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/waffle/waffle_1.7.0.bb b/meta/recipes-graphics/waffle/waffle_1.7.0.bb
index 6284af3076..ea11309940 100644
--- a/meta/recipes-graphics/waffle/waffle_1.7.0.bb
+++ b/meta/recipes-graphics/waffle/waffle_1.7.0.bb
@@ -17,7 +17,7 @@ S = "${WORKDIR}/git"
inherit meson features_check lib_package bash-completion pkgconfig
-DEPENDS:append = " python3"
+DEPENDS:append = " python3 cmake-native"
# This should be overridden per-machine to reflect the capabilities of the GL
# stack.
--
2.33.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCHv2] recipe-graphics/waffle: Add depends on cmake-native
2021-11-11 17:06 [PATCHv2] recipe-graphics/waffle: Add depends on cmake-native Anibal Limon
@ 2021-11-11 17:39 ` Ross Burton
2021-11-11 17:45 ` Alexander Kanavin
0 siblings, 1 reply; 4+ messages in thread
From: Ross Burton @ 2021-11-11 17:39 UTC (permalink / raw)
To: Anibal Limon; +Cc: openembedded-core, richard.purdie
On Thu, 11 Nov 2021 at 17:07, Anibal Limon <anibal.limon@linaro.org> wrote:
>
> Fixes,
>
> ...
> File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/site-packages/mesonbuild/modules/cmake.py", line 241, in detect_cmake
> p, stdout, stderr = mesonlib.Popen_safe(cmakebin.get_command() + ['--system-information', '-G', 'Ninja'])[0:3]
> File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/site-packages/mesonbuild/mesonlib/universal.py", line 1397, in Popen_safe
> p = subprocess.Popen(args, universal_newlines=True, close_fds=False,
> File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/subprocess.py", line 966, in __init__
> self._execute_child(args, executable, preexec_fn, close_fds,
> File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/subprocess.py", line 1717, in _execute_child
> and os.path.dirname(executable)
> File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/posixpath.py", line 152, in dirname
> p = os.fspath(p)
> ...
But why does the Meson build want CMake?
> Not inherit cmake class because expects meson-log.txt,
Not inheriting the cmake class as then you're inheriting both cmake
and meson classes, and only one of those will be running the build.
Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCHv2] recipe-graphics/waffle: Add depends on cmake-native
2021-11-11 17:39 ` [OE-core] " Ross Burton
@ 2021-11-11 17:45 ` Alexander Kanavin
2021-11-11 18:07 ` Ross Burton
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Kanavin @ 2021-11-11 17:45 UTC (permalink / raw)
To: Ross Burton; +Cc: Anibal Limon, OE-core, Richard Purdie
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
On Thu, 11 Nov 2021 at 18:40, Ross Burton <ross@burtonini.com> wrote:
>
> But why does the Meson build want CMake?
>
Maybe this?
https://gitlab.freedesktop.org/mesa/waffle/-/blob/master/src/waffle/meson.build#L238
Alex
[-- Attachment #2: Type: text/html, Size: 663 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCHv2] recipe-graphics/waffle: Add depends on cmake-native
2021-11-11 17:45 ` Alexander Kanavin
@ 2021-11-11 18:07 ` Ross Burton
0 siblings, 0 replies; 4+ messages in thread
From: Ross Burton @ 2021-11-11 18:07 UTC (permalink / raw)
To: Alexander Kanavin; +Cc: Anibal Limon, OE-core, Richard Purdie
> Maybe this?
> https://gitlab.freedesktop.org/mesa/waffle/-/blob/master/src/waffle/meson.build#L238
Well that's annoying that it needs cmake just to write a configuration file.
I suggest rewriting the commit message:
waffle: add explicit dependency to cmake-native
cmake-native can get pulled into the sysroot via dependencies, but it
is always needed:
| Program cmake found: NO
| ERROR: meson failed
Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-11 18:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 17:06 [PATCHv2] recipe-graphics/waffle: Add depends on cmake-native Anibal Limon
2021-11-11 17:39 ` [OE-core] " Ross Burton
2021-11-11 17:45 ` Alexander Kanavin
2021-11-11 18:07 ` Ross Burton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.