Re: [kirkstone][OE-core][PATCH] efibootmgr: update compilation with musl

Re: [kirkstone][OE-core][PATCH] efibootmgr: update compilation with musl

[Marta Rybczynska]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

On Wed, Dec 14, 2022 at 3:29 PM Marta Rybczynska via lists.openembedded.org
<rybczynska=gmail.com@lists.openembedded.org> wrote:

> Since the commit 005b6aba89eaf1b79fdd7565dd028fdd9bbfcc7d
> (efivar: add musl libc compatibility) efibootmgr compiles with
> musl too. Update the variable to take that into account.
>
>
Langdale and master versions will follow in a moment, they are building now.

Kind regards,
Marta

[-- Attachment #2: Type: text/html, Size: 852 bytes --]

[kirkstone][OE-core][PATCH] efibootmgr: update compilation with musl

[Marta Rybczynska]

Since the commit 005b6aba89eaf1b79fdd7565dd028fdd9bbfcc7d
(efivar: add musl libc compatibility) efibootmgr compiles with
musl too. Update the variable to take that into account.

Signed-off-by: Marta Rybczynska <marta.rybczynska@linaro.org>
---
 meta/recipes-bsp/efibootmgr/efibootmgr_17.bb | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
index 11d8b9061d..be6571b3fa 100644
--- a/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
+++ b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
@@ -34,6 +34,4 @@ do_install () {
 }
 
 CLEANBROKEN = "1"
-# https://github.com/rhboot/efivar/issues/202
-COMPATIBLE_HOST:libc-musl = 'null'
 
-- 
2.35.1

Re: [kirkstone][OE-core][PATCH] efibootmgr: update compilation with musl

[Steve Sakoman]

On Wed, Dec 14, 2022 at 4:29 AM Marta Rybczynska <rybczynska@gmail.com> wrote:
>
> Since the commit 005b6aba89eaf1b79fdd7565dd028fdd9bbfcc7d
> (efivar: add musl libc compatibility) efibootmgr compiles with
> musl too. Update the variable to take that into account.
>
> Signed-off-by: Marta Rybczynska <marta.rybczynska@linaro.org>
> ---
>  meta/recipes-bsp/efibootmgr/efibootmgr_17.bb | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> index 11d8b9061d..be6571b3fa 100644
> --- a/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> +++ b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> @@ -34,6 +34,4 @@ do_install () {
>  }
>
>  CLEANBROKEN = "1"
> -# https://github.com/rhboot/efivar/issues/202
> -COMPATIBLE_HOST:libc-musl = 'null'

I see that master also has the above -- should it also be removed in
master?  If so, resubmit for master and I will backport to kirkstone.

Thanks!

Steve

> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#174555): https://lists.openembedded.org/g/openembedded-core/message/174555
> Mute This Topic: https://lists.openembedded.org/mt/95667399/3620601
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [steve@sakoman.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [kirkstone][OE-core][PATCH] efibootmgr: update compilation with musl

[Marta Rybczynska]

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Wed, Dec 14, 2022 at 5:08 PM Steve Sakoman <steve@sakoman.com> wrote:

> On Wed, Dec 14, 2022 at 4:29 AM Marta Rybczynska <rybczynska@gmail.com>
> wrote:
> >
> > Since the commit 005b6aba89eaf1b79fdd7565dd028fdd9bbfcc7d
> > (efivar: add musl libc compatibility) efibootmgr compiles with
> > musl too. Update the variable to take that into account.
> >
> > Signed-off-by: Marta Rybczynska <marta.rybczynska@linaro.org>
> > ---
> >  meta/recipes-bsp/efibootmgr/efibootmgr_17.bb | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> > index 11d8b9061d..be6571b3fa 100644
> > --- a/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> > +++ b/meta/recipes-bsp/efibootmgr/efibootmgr_17.bb
> > @@ -34,6 +34,4 @@ do_install () {
> >  }
> >
> >  CLEANBROKEN = "1"
> > -# https://github.com/rhboot/efivar/issues/202
> > -COMPATIBLE_HOST:libc-musl = 'null'
>
> I see that master also has the above -- should it also be removed in
> master?  If so, resubmit for master and I will backport to kirkstone.
>
>
>
Al three branches finished compilation just fine, so all three are
submitted. You can pick it up the moment
it hits master.

Kind regards,
Marta

[-- Attachment #2: Type: text/html, Size: 2451 bytes --]