* [RESEND PATCH] clk: enable hi655x common clk automatically
@ 2018-03-12 10:49 ` riku.voipio at linaro.org
0 siblings, 0 replies; 10+ messages in thread
From: riku.voipio @ 2018-03-12 10:49 UTC (permalink / raw)
To: linux-clk, Michael Turquette, Stephen Boyd
Cc: arnd, linux-arm-kernel, Riku Voipio, John Stultz, Ulf Hansson,
Wei Xu, Daniel Lezcano
From: Riku Voipio <riku.voipio@linaro.org>
Without COMMON_CLK_HI655X Wifi and bluetooth are non-functional on Hikey.
As suggested by Arnd, enable the driver automatically when the parent
driver is selected. With sensible defaults in place, we can leave other
choices for EXPERT.
Cc: John Stultz <john.stultz@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Suggested-by: Arnd Bergmann <arnd@linaro.org>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
Previous discussion at https://patchwork.kernel.org/patch/9767143/
---
drivers/clk/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 98ce9fc6e6c0..448ce83b334d 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -55,8 +55,10 @@ config COMMON_CLK_RK808
by control register.
config COMMON_CLK_HI655X
- tristate "Clock driver for Hi655x"
- depends on MFD_HI655X_PMIC || COMPILE_TEST
+ tristate "Clock driver for Hi655x" if EXPERT
+ depends on (MFD_HI655X_PMIC || COMPILE_TEST)
+ depends on REGMAP
+ default MFD_HI655X_PMIC
---help---
This driver supports the hi655x PMIC clock. This
multi-function device has one fixed-rate oscillator, clocked
--
2.15.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RESEND PATCH] clk: enable hi655x common clk automatically
@ 2018-03-12 10:49 ` riku.voipio at linaro.org
0 siblings, 0 replies; 10+ messages in thread
From: riku.voipio at linaro.org @ 2018-03-12 10:49 UTC (permalink / raw)
To: linux-arm-kernel
From: Riku Voipio <riku.voipio@linaro.org>
Without COMMON_CLK_HI655X Wifi and bluetooth are non-functional on Hikey.
As suggested by Arnd, enable the driver automatically when the parent
driver is selected. With sensible defaults in place, we can leave other
choices for EXPERT.
Cc: John Stultz <john.stultz@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Suggested-by: Arnd Bergmann <arnd@linaro.org>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
Previous discussion at https://patchwork.kernel.org/patch/9767143/
---
drivers/clk/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 98ce9fc6e6c0..448ce83b334d 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -55,8 +55,10 @@ config COMMON_CLK_RK808
by control register.
config COMMON_CLK_HI655X
- tristate "Clock driver for Hi655x"
- depends on MFD_HI655X_PMIC || COMPILE_TEST
+ tristate "Clock driver for Hi655x" if EXPERT
+ depends on (MFD_HI655X_PMIC || COMPILE_TEST)
+ depends on REGMAP
+ default MFD_HI655X_PMIC
---help---
This driver supports the hi655x PMIC clock. This
multi-function device has one fixed-rate oscillator, clocked
--
2.15.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [RESEND PATCH] clk: enable hi655x common clk automatically
2018-03-12 10:49 ` riku.voipio at linaro.org
@ 2018-03-15 13:47 ` Ulf Hansson
-1 siblings, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2018-03-15 13:47 UTC (permalink / raw)
To: Riku Voipio
Cc: linux-clk, Michael Turquette, Stephen Boyd, Arnd Bergmann,
Linux ARM, John Stultz, Wei Xu, Daniel Lezcano
On 12 March 2018 at 11:49, <riku.voipio@linaro.org> wrote:
> From: Riku Voipio <riku.voipio@linaro.org>
>
> Without COMMON_CLK_HI655X Wifi and bluetooth are non-functional on Hikey.
> As suggested by Arnd, enable the driver automatically when the parent
> driver is selected. With sensible defaults in place, we can leave other
> choices for EXPERT.
>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Suggested-by: Arnd Bergmann <arnd@linaro.org>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> Previous discussion at https://patchwork.kernel.org/patch/9767143/
> ---
> drivers/clk/Kconfig | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 98ce9fc6e6c0..448ce83b334d 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -55,8 +55,10 @@ config COMMON_CLK_RK808
> by control register.
>
> config COMMON_CLK_HI655X
> - tristate "Clock driver for Hi655x"
> - depends on MFD_HI655X_PMIC || COMPILE_TEST
> + tristate "Clock driver for Hi655x" if EXPERT
> + depends on (MFD_HI655X_PMIC || COMPILE_TEST)
> + depends on REGMAP
> + default MFD_HI655X_PMIC
> ---help---
> This driver supports the hi655x PMIC clock. This
> multi-function device has one fixed-rate oscillator, clocked
> --
> 2.15.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RESEND PATCH] clk: enable hi655x common clk automatically
@ 2018-03-15 13:47 ` Ulf Hansson
0 siblings, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2018-03-15 13:47 UTC (permalink / raw)
To: linux-arm-kernel
On 12 March 2018 at 11:49, <riku.voipio@linaro.org> wrote:
> From: Riku Voipio <riku.voipio@linaro.org>
>
> Without COMMON_CLK_HI655X Wifi and bluetooth are non-functional on Hikey.
> As suggested by Arnd, enable the driver automatically when the parent
> driver is selected. With sensible defaults in place, we can leave other
> choices for EXPERT.
>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Suggested-by: Arnd Bergmann <arnd@linaro.org>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> Previous discussion at https://patchwork.kernel.org/patch/9767143/
> ---
> drivers/clk/Kconfig | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 98ce9fc6e6c0..448ce83b334d 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -55,8 +55,10 @@ config COMMON_CLK_RK808
> by control register.
>
> config COMMON_CLK_HI655X
> - tristate "Clock driver for Hi655x"
> - depends on MFD_HI655X_PMIC || COMPILE_TEST
> + tristate "Clock driver for Hi655x" if EXPERT
> + depends on (MFD_HI655X_PMIC || COMPILE_TEST)
> + depends on REGMAP
> + default MFD_HI655X_PMIC
> ---help---
> This driver supports the hi655x PMIC clock. This
> multi-function device has one fixed-rate oscillator, clocked
> --
> 2.15.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RESEND PATCH] clk: enable hi655x common clk automatically
2018-03-12 10:49 ` riku.voipio at linaro.org
@ 2018-03-15 17:54 ` Stephen Boyd
-1 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2018-03-15 17:54 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, linux-clk, riku.voipio
Cc: arnd, linux-arm-kernel, Riku Voipio, John Stultz, Ulf Hansson,
Wei Xu, Daniel Lezcano
Quoting riku.voipio@linaro.org (2018-03-12 03:49:45)
> From: Riku Voipio <riku.voipio@linaro.org>
> =
> Without COMMON_CLK_HI655X Wifi and bluetooth are non-functional on Hikey.
> As suggested by Arnd, enable the driver automatically when the parent
> driver is selected. With sensible defaults in place, we can leave other
> choices for EXPERT.
> =
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Suggested-by: Arnd Bergmann <arnd@linaro.org>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
> Previous discussion at https://patchwork.kernel.org/patch/9767143/
> ---
> drivers/clk/Kconfig | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> =
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 98ce9fc6e6c0..448ce83b334d 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -55,8 +55,10 @@ config COMMON_CLK_RK808
> by control register.
> =
> config COMMON_CLK_HI655X
> - tristate "Clock driver for Hi655x"
> - depends on MFD_HI655X_PMIC || COMPILE_TEST
> + tristate "Clock driver for Hi655x" if EXPERT
Hmm. This would be the first EXPERT usage in the clk code. I guess
that's ok.
> + depends on (MFD_HI655X_PMIC || COMPILE_TEST)
> + depends on REGMAP
> + default MFD_HI655X_PMIC
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RESEND PATCH] clk: enable hi655x common clk automatically
@ 2018-03-15 17:54 ` Stephen Boyd
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2018-03-15 17:54 UTC (permalink / raw)
To: linux-arm-kernel
Quoting riku.voipio at linaro.org (2018-03-12 03:49:45)
> From: Riku Voipio <riku.voipio@linaro.org>
>
> Without COMMON_CLK_HI655X Wifi and bluetooth are non-functional on Hikey.
> As suggested by Arnd, enable the driver automatically when the parent
> driver is selected. With sensible defaults in place, we can leave other
> choices for EXPERT.
>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Suggested-by: Arnd Bergmann <arnd@linaro.org>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
> Previous discussion at https://patchwork.kernel.org/patch/9767143/
> ---
> drivers/clk/Kconfig | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 98ce9fc6e6c0..448ce83b334d 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -55,8 +55,10 @@ config COMMON_CLK_RK808
> by control register.
>
> config COMMON_CLK_HI655X
> - tristate "Clock driver for Hi655x"
> - depends on MFD_HI655X_PMIC || COMPILE_TEST
> + tristate "Clock driver for Hi655x" if EXPERT
Hmm. This would be the first EXPERT usage in the clk code. I guess
that's ok.
> + depends on (MFD_HI655X_PMIC || COMPILE_TEST)
> + depends on REGMAP
> + default MFD_HI655X_PMIC
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RESEND PATCH] clk: enable hi655x common clk automatically
2018-03-15 17:54 ` Stephen Boyd
@ 2018-03-16 9:42 ` Riku Voipio
-1 siblings, 0 replies; 10+ messages in thread
From: Riku Voipio @ 2018-03-16 9:42 UTC (permalink / raw)
To: Stephen Boyd
Cc: Michael Turquette, Stephen Boyd, linux-clk, Arnd Bergmann,
linux-arm-kernel, John Stultz, Ulf Hansson, Wei Xu,
Daniel Lezcano
On 15 March 2018 at 19:54, Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting riku.voipio@linaro.org (2018-03-12 03:49:45)
>> From: Riku Voipio <riku.voipio@linaro.org>
>>
>> Without COMMON_CLK_HI655X Wifi and bluetooth are non-functional on Hikey.
>> As suggested by Arnd, enable the driver automatically when the parent
>> driver is selected. With sensible defaults in place, we can leave other
>> choices for EXPERT.
>>
>> Cc: John Stultz <john.stultz@linaro.org>
>> Cc: Ulf Hansson <ulf.hansson@linaro.org>
>> Cc: Wei Xu <xuwei5@hisilicon.com>
>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Suggested-by: Arnd Bergmann <arnd@linaro.org>
>> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
>> ---
>> Previous discussion at https://patchwork.kernel.org/patch/9767143/
>> ---
>> drivers/clk/Kconfig | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
>> index 98ce9fc6e6c0..448ce83b334d 100644
>> --- a/drivers/clk/Kconfig
>> +++ b/drivers/clk/Kconfig
>> @@ -55,8 +55,10 @@ config COMMON_CLK_RK808
>> by control register.
>>
>> config COMMON_CLK_HI655X
>> - tristate "Clock driver for Hi655x"
>> - depends on MFD_HI655X_PMIC || COMPILE_TEST
>> + tristate "Clock driver for Hi655x" if EXPERT
>
> Hmm. This would be the first EXPERT usage in the clk code. I guess
> that's ok.
Put it this way - would you comfortable letting a non-expert fiddle this option?
>> + depends on (MFD_HI655X_PMIC || COMPILE_TEST)
>> + depends on REGMAP
>> + default MFD_HI655X_PMIC
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RESEND PATCH] clk: enable hi655x common clk automatically
@ 2018-03-16 9:42 ` Riku Voipio
0 siblings, 0 replies; 10+ messages in thread
From: Riku Voipio @ 2018-03-16 9:42 UTC (permalink / raw)
To: linux-arm-kernel
On 15 March 2018 at 19:54, Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting riku.voipio at linaro.org (2018-03-12 03:49:45)
>> From: Riku Voipio <riku.voipio@linaro.org>
>>
>> Without COMMON_CLK_HI655X Wifi and bluetooth are non-functional on Hikey.
>> As suggested by Arnd, enable the driver automatically when the parent
>> driver is selected. With sensible defaults in place, we can leave other
>> choices for EXPERT.
>>
>> Cc: John Stultz <john.stultz@linaro.org>
>> Cc: Ulf Hansson <ulf.hansson@linaro.org>
>> Cc: Wei Xu <xuwei5@hisilicon.com>
>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Suggested-by: Arnd Bergmann <arnd@linaro.org>
>> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
>> ---
>> Previous discussion at https://patchwork.kernel.org/patch/9767143/
>> ---
>> drivers/clk/Kconfig | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
>> index 98ce9fc6e6c0..448ce83b334d 100644
>> --- a/drivers/clk/Kconfig
>> +++ b/drivers/clk/Kconfig
>> @@ -55,8 +55,10 @@ config COMMON_CLK_RK808
>> by control register.
>>
>> config COMMON_CLK_HI655X
>> - tristate "Clock driver for Hi655x"
>> - depends on MFD_HI655X_PMIC || COMPILE_TEST
>> + tristate "Clock driver for Hi655x" if EXPERT
>
> Hmm. This would be the first EXPERT usage in the clk code. I guess
> that's ok.
Put it this way - would you comfortable letting a non-expert fiddle this option?
>> + depends on (MFD_HI655X_PMIC || COMPILE_TEST)
>> + depends on REGMAP
>> + default MFD_HI655X_PMIC
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RESEND PATCH] clk: enable hi655x common clk automatically
2018-03-12 10:49 ` riku.voipio at linaro.org
@ 2018-03-19 20:52 ` Stephen Boyd
-1 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2018-03-19 20:52 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, linux-clk, riku.voipio
Cc: arnd, linux-arm-kernel, Riku Voipio, John Stultz, Ulf Hansson,
Wei Xu, Daniel Lezcano
Quoting riku.voipio@linaro.org (2018-03-12 03:49:45)
> From: Riku Voipio <riku.voipio@linaro.org>
> =
> Without COMMON_CLK_HI655X Wifi and bluetooth are non-functional on Hikey.
> As suggested by Arnd, enable the driver automatically when the parent
> driver is selected. With sensible defaults in place, we can leave other
> choices for EXPERT.
> =
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Suggested-by: Arnd Bergmann <arnd@linaro.org>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RESEND PATCH] clk: enable hi655x common clk automatically
@ 2018-03-19 20:52 ` Stephen Boyd
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2018-03-19 20:52 UTC (permalink / raw)
To: linux-arm-kernel
Quoting riku.voipio at linaro.org (2018-03-12 03:49:45)
> From: Riku Voipio <riku.voipio@linaro.org>
>
> Without COMMON_CLK_HI655X Wifi and bluetooth are non-functional on Hikey.
> As suggested by Arnd, enable the driver automatically when the parent
> driver is selected. With sensible defaults in place, we can leave other
> choices for EXPERT.
>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Suggested-by: Arnd Bergmann <arnd@linaro.org>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-03-19 20:52 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-12 10:49 [RESEND PATCH] clk: enable hi655x common clk automatically riku.voipio
2018-03-12 10:49 ` riku.voipio at linaro.org
2018-03-15 13:47 ` Ulf Hansson
2018-03-15 13:47 ` Ulf Hansson
2018-03-15 17:54 ` Stephen Boyd
2018-03-15 17:54 ` Stephen Boyd
2018-03-16 9:42 ` Riku Voipio
2018-03-16 9:42 ` Riku Voipio
2018-03-19 20:52 ` Stephen Boyd
2018-03-19 20:52 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.