All of lore.kernel.org
 help / color / mirror / Atom feed
From: Moritz Fischer <moritz.fischer@ettus.com>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"pawel.moll@arm.com" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	"Vinod Koul" <vinod.koul@intel.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Appana Durga Kedareswara Rao" <appanad@xilinx.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Luis de Bethencourt" <luis@debethencourt.com>,
	"Anirudha Sarangi" <anirudh@xilinx.com>,
	"Punnaiah Choudary Kalluri" <punnaia@xilinx.com>,
	"Devicetree List" <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	dmaengine@vger.kernel.org
Subject: Re: [PATCH 2/2] dmaengine: vdma: Add clock support
Date: Wed, 20 Apr 2016 11:39:02 -0700	[thread overview]
Message-ID: <CAAtXAHd=QER9ukD8LKpHCGdmsv=MzJ4bxkvWVEatpfUhsh98SQ@mail.gmail.com> (raw)
In-Reply-To: <1461136800-20334-2-git-send-email-appanad@xilinx.com>

Hi,

thanks for looking into this.

On Wed, Apr 20, 2016 at 12:20 AM, Kedareswara rao Appana
<appana.durga.rao@xilinx.com> wrote:

> +static int xdma_clk_init(struct xilinx_dma_device *xdev, bool enable)
> +{
> +       int i = 0, ret;
> +
> +       for (i = 0; i < xdev->numclks; i++) {
> +               if (enable) {
> +                       ret = clk_prepare_enable(xdev->clks[i]);
> +                       if (ret) {
> +                               dev_err(xdev->dev,
> +                                       "failed to enable the axidma clock\n");
> +                               return ret;

What happens to the ones you already turned on, if say the third fails?

Cheers,

Moritz

WARNING: multiple messages have this Message-ID (diff)
From: moritz.fischer@ettus.com (Moritz Fischer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] dmaengine: vdma: Add clock support
Date: Wed, 20 Apr 2016 11:39:02 -0700	[thread overview]
Message-ID: <CAAtXAHd=QER9ukD8LKpHCGdmsv=MzJ4bxkvWVEatpfUhsh98SQ@mail.gmail.com> (raw)
In-Reply-To: <1461136800-20334-2-git-send-email-appanad@xilinx.com>

Hi,

thanks for looking into this.

On Wed, Apr 20, 2016 at 12:20 AM, Kedareswara rao Appana
<appana.durga.rao@xilinx.com> wrote:

> +static int xdma_clk_init(struct xilinx_dma_device *xdev, bool enable)
> +{
> +       int i = 0, ret;
> +
> +       for (i = 0; i < xdev->numclks; i++) {
> +               if (enable) {
> +                       ret = clk_prepare_enable(xdev->clks[i]);
> +                       if (ret) {
> +                               dev_err(xdev->dev,
> +                                       "failed to enable the axidma clock\n");
> +                               return ret;

What happens to the ones you already turned on, if say the third fails?

Cheers,

Moritz

  reply	other threads:[~2016-04-20 18:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20  7:19 [PATCH 1/2] Documentation: DT: vdma: Add clock support for vdma Kedareswara rao Appana
2016-04-20  7:19 ` Kedareswara rao Appana
2016-04-20  7:19 ` Kedareswara rao Appana
2016-04-20  7:20 ` [PATCH 2/2] dmaengine: vdma: Add clock support Kedareswara rao Appana
2016-04-20  7:20   ` Kedareswara rao Appana
2016-04-20  7:20   ` Kedareswara rao Appana
2016-04-20 18:39   ` Moritz Fischer [this message]
2016-04-20 18:39     ` Moritz Fischer
2016-04-21  5:17     ` Appana Durga Kedareswara Rao
2016-04-21  5:17       ` Appana Durga Kedareswara Rao
2016-04-21  5:17       ` Appana Durga Kedareswara Rao
2016-04-20  7:59 ` [PATCH 1/2] Documentation: DT: vdma: Add clock support for vdma Shubhrajyoti Datta
2016-04-20  7:59   ` Shubhrajyoti Datta
2016-04-20  7:59   ` Shubhrajyoti Datta
2016-04-20  8:39   ` Appana Durga Kedareswara Rao
2016-04-20  8:39     ` Appana Durga Kedareswara Rao
2016-04-20  8:39     ` Appana Durga Kedareswara Rao
2016-04-20 11:15     ` Lars-Peter Clausen
2016-04-20 11:15       ` Lars-Peter Clausen
2016-04-20 11:15       ` Lars-Peter Clausen
2016-04-20 11:30       ` Appana Durga Kedareswara Rao
2016-04-20 11:30         ` Appana Durga Kedareswara Rao
2016-04-20 11:30         ` Appana Durga Kedareswara Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAtXAHd=QER9ukD8LKpHCGdmsv=MzJ4bxkvWVEatpfUhsh98SQ@mail.gmail.com' \
    --to=moritz.fischer@ettus.com \
    --cc=anirudh@xilinx.com \
    --cc=appana.durga.rao@xilinx.com \
    --cc=appanad@xilinx.com \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luis@debethencourt.com \
    --cc=mark.rutland@arm.com \
    --cc=michal.simek@xilinx.com \
    --cc=pawel.moll@arm.com \
    --cc=punnaia@xilinx.com \
    --cc=robh+dt@kernel.org \
    --cc=soren.brinkmann@xilinx.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.