* [PATCH] Make FPGA a menuconfig to ease disabling it all
@ 2017-04-14 9:06 Vincent Legoll
2017-04-14 15:26 ` Randy Dunlap
0 siblings, 1 reply; 7+ messages in thread
From: Vincent Legoll @ 2017-04-14 9:06 UTC (permalink / raw)
To: linux-kernel, atull, moritz.fischer, linux-fpga; +Cc: Vincent Legoll
No need to get into the submenu to disable all FPGA-related config entries
Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
drivers/fpga/Kconfig | 21 ++++++++-------------
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index ce861a2..fa1a95e 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -2,32 +2,30 @@
# FPGA framework configuration
#
-menu "FPGA Configuration Support"
-
-config FPGA
+menuconfig FPGA
tristate "FPGA Configuration Framework"
help
Say Y here if you want support for configuring FPGAs from the
kernel. The FPGA framework adds a FPGA manager class and FPGA
manager drivers.
-if FPGA
-
config FPGA_REGION
tristate "FPGA Region"
- depends on OF && FPGA_BRIDGE
+ depends on FPGA && OF && FPGA_BRIDGE
help
FPGA Regions allow loading FPGA images under control of
the Device Tree.
config FPGA_MGR_SOCFPGA
tristate "Altera SOCFPGA FPGA Manager"
+ depends on FPGA
depends on ARCH_SOCFPGA || COMPILE_TEST
help
FPGA manager driver support for Altera SOCFPGA.
config FPGA_MGR_SOCFPGA_A10
tristate "Altera SoCFPGA Arria10"
+ depends on FPGA
depends on ARCH_SOCFPGA || COMPILE_TEST
select REGMAP_MMIO
help
@@ -35,6 +33,7 @@ config FPGA_MGR_SOCFPGA_A10
config FPGA_MGR_ZYNQ_FPGA
tristate "Xilinx Zynq FPGA"
+ depends on FPGA
depends on ARCH_ZYNQ || COMPILE_TEST
depends on HAS_DMA
help
@@ -42,27 +41,23 @@ config FPGA_MGR_ZYNQ_FPGA
config FPGA_BRIDGE
tristate "FPGA Bridge Framework"
- depends on OF
+ depends on FPGA && OF
help
Say Y here if you want to support bridges connected between host
processors and FPGAs or between FPGAs.
config SOCFPGA_FPGA_BRIDGE
tristate "Altera SoCFPGA FPGA Bridges"
- depends on ARCH_SOCFPGA && FPGA_BRIDGE
+ depends on FPGA && ARCH_SOCFPGA && FPGA_BRIDGE
help
Say Y to enable drivers for FPGA bridges for Altera SOCFPGA
devices.
config ALTERA_FREEZE_BRIDGE
tristate "Altera FPGA Freeze Bridge"
- depends on ARCH_SOCFPGA && FPGA_BRIDGE
+ depends on FPGA && ARCH_SOCFPGA && FPGA_BRIDGE
help
Say Y to enable drivers for Altera FPGA Freeze bridges. A
freeze bridge is a bridge that exists in the FPGA fabric to
isolate one region of the FPGA from the busses while that
region is being reprogrammed.
-
-endif # FPGA
-
-endmenu
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Make FPGA a menuconfig to ease disabling it all
2017-04-14 9:06 [PATCH] Make FPGA a menuconfig to ease disabling it all Vincent Legoll
@ 2017-04-14 15:26 ` Randy Dunlap
2017-04-14 22:39 ` Vincent Legoll
0 siblings, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2017-04-14 15:26 UTC (permalink / raw)
To: Vincent Legoll, linux-kernel, atull, moritz.fischer, linux-fpga
On 04/14/17 02:06, Vincent Legoll wrote:
> No need to get into the submenu to disable all FPGA-related config entries
>
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
> ---
> drivers/fpga/Kconfig | 21 ++++++++-------------
> 1 file changed, 8 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index ce861a2..fa1a95e 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -2,32 +2,30 @@
> # FPGA framework configuration
> #
>
> -menu "FPGA Configuration Support"
> -
> -config FPGA
> +menuconfig FPGA
> tristate "FPGA Configuration Framework"
> help
> Say Y here if you want support for configuring FPGAs from the
> kernel. The FPGA framework adds a FPGA manager class and FPGA
> manager drivers.
>
> -if FPGA
> -
why not leave the "if FPGA" end "endif # FPGA" lines
and not add "depends on FPGA" to each entry?
> config FPGA_REGION
> tristate "FPGA Region"
> - depends on OF && FPGA_BRIDGE
> + depends on FPGA && OF && FPGA_BRIDGE
> help
> FPGA Regions allow loading FPGA images under control of
> the Device Tree.
>
> config FPGA_MGR_SOCFPGA
> tristate "Altera SOCFPGA FPGA Manager"
> + depends on FPGA
> depends on ARCH_SOCFPGA || COMPILE_TEST
> help
> FPGA manager driver support for Altera SOCFPGA.
>
> config FPGA_MGR_SOCFPGA_A10
> tristate "Altera SoCFPGA Arria10"
> + depends on FPGA
> depends on ARCH_SOCFPGA || COMPILE_TEST
> select REGMAP_MMIO
> help
> @@ -35,6 +33,7 @@ config FPGA_MGR_SOCFPGA_A10
>
> config FPGA_MGR_ZYNQ_FPGA
> tristate "Xilinx Zynq FPGA"
> + depends on FPGA
> depends on ARCH_ZYNQ || COMPILE_TEST
> depends on HAS_DMA
> help
> @@ -42,27 +41,23 @@ config FPGA_MGR_ZYNQ_FPGA
>
> config FPGA_BRIDGE
> tristate "FPGA Bridge Framework"
> - depends on OF
> + depends on FPGA && OF
> help
> Say Y here if you want to support bridges connected between host
> processors and FPGAs or between FPGAs.
>
> config SOCFPGA_FPGA_BRIDGE
> tristate "Altera SoCFPGA FPGA Bridges"
> - depends on ARCH_SOCFPGA && FPGA_BRIDGE
> + depends on FPGA && ARCH_SOCFPGA && FPGA_BRIDGE
> help
> Say Y to enable drivers for FPGA bridges for Altera SOCFPGA
> devices.
>
> config ALTERA_FREEZE_BRIDGE
> tristate "Altera FPGA Freeze Bridge"
> - depends on ARCH_SOCFPGA && FPGA_BRIDGE
> + depends on FPGA && ARCH_SOCFPGA && FPGA_BRIDGE
> help
> Say Y to enable drivers for Altera FPGA Freeze bridges. A
> freeze bridge is a bridge that exists in the FPGA fabric to
> isolate one region of the FPGA from the busses while that
> region is being reprogrammed.
> -
> -endif # FPGA
> -
> -endmenu
>
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Make FPGA a menuconfig to ease disabling it all
2017-04-14 15:26 ` Randy Dunlap
@ 2017-04-14 22:39 ` Vincent Legoll
2017-04-14 22:39 ` Vincent Legoll
2017-04-14 23:05 ` Randy Dunlap
0 siblings, 2 replies; 7+ messages in thread
From: Vincent Legoll @ 2017-04-14 22:39 UTC (permalink / raw)
To: linux-kernel, atull, moritz.fischer, linux-fpga
Hello Randy,
you mean like the following ?
Looks like this is working as intended and much simpler, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Make FPGA a menuconfig to ease disabling it all
2017-04-14 22:39 ` Vincent Legoll
@ 2017-04-14 22:39 ` Vincent Legoll
2017-05-24 15:35 ` Alan Tull
2017-04-14 23:05 ` Randy Dunlap
1 sibling, 1 reply; 7+ messages in thread
From: Vincent Legoll @ 2017-04-14 22:39 UTC (permalink / raw)
To: linux-kernel, atull, moritz.fischer, linux-fpga; +Cc: Vincent Legoll
No need to get into the submenu to disable all FPGA-related config entries
Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
drivers/fpga/Kconfig | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index ce861a2..2cb9b81 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -2,9 +2,7 @@
# FPGA framework configuration
#
-menu "FPGA Configuration Support"
-
-config FPGA
+menuconfig FPGA
tristate "FPGA Configuration Framework"
help
Say Y here if you want support for configuring FPGAs from the
@@ -64,5 +62,3 @@ config ALTERA_FREEZE_BRIDGE
region is being reprogrammed.
endif # FPGA
-
-endmenu
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Make FPGA a menuconfig to ease disabling it all
2017-04-14 22:39 ` Vincent Legoll
2017-04-14 22:39 ` Vincent Legoll
@ 2017-04-14 23:05 ` Randy Dunlap
1 sibling, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2017-04-14 23:05 UTC (permalink / raw)
To: Vincent Legoll, linux-kernel, atull, moritz.fischer, linux-fpga
On 04/14/17 15:39, Vincent Legoll wrote:
> Hello Randy,
>
> you mean like the following ?
>
> Looks like this is working as intended and much simpler, thanks.
>
Yes, like that. Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Make FPGA a menuconfig to ease disabling it all
2017-04-14 22:39 ` Vincent Legoll
@ 2017-05-24 15:35 ` Alan Tull
2017-05-24 19:11 ` Moritz Fischer
0 siblings, 1 reply; 7+ messages in thread
From: Alan Tull @ 2017-05-24 15:35 UTC (permalink / raw)
To: Vincent Legoll; +Cc: linux-kernel, atull, Moritz Fischer, linux-fpga
On Fri, Apr 14, 2017 at 5:39 PM, Vincent Legoll
<vincent.legoll@gmail.com> wrote:
Hi Vincent,
Thanks!
Alan
> No need to get into the submenu to disable all FPGA-related config entries
>
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
Signed-off-by: Alan Tull <atull@kernel.org>
> ---
> drivers/fpga/Kconfig | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index ce861a2..2cb9b81 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -2,9 +2,7 @@
> # FPGA framework configuration
> #
>
> -menu "FPGA Configuration Support"
> -
> -config FPGA
> +menuconfig FPGA
> tristate "FPGA Configuration Framework"
> help
> Say Y here if you want support for configuring FPGAs from the
> @@ -64,5 +62,3 @@ config ALTERA_FREEZE_BRIDGE
> region is being reprogrammed.
>
> endif # FPGA
> -
> -endmenu
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Make FPGA a menuconfig to ease disabling it all
2017-05-24 15:35 ` Alan Tull
@ 2017-05-24 19:11 ` Moritz Fischer
0 siblings, 0 replies; 7+ messages in thread
From: Moritz Fischer @ 2017-05-24 19:11 UTC (permalink / raw)
To: Alan Tull; +Cc: Vincent Legoll, linux-kernel, atull, linux-fpga
On Wed, May 24, 2017 at 8:35 AM, Alan Tull <atull@kernel.org> wrote:
> On Fri, Apr 14, 2017 at 5:39 PM, Vincent Legoll
> <vincent.legoll@gmail.com> wrote:
>
> Hi Vincent,
>
> Thanks!
>
> Alan
>
>> No need to get into the submenu to disable all FPGA-related config entries
>>
>> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
Acked-by: Moritz Fischer <mdf@kernel.org>
>
> Signed-off-by: Alan Tull <atull@kernel.org>
>
>> ---
>> drivers/fpga/Kconfig | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
>> index ce861a2..2cb9b81 100644
>> --- a/drivers/fpga/Kconfig
>> +++ b/drivers/fpga/Kconfig
>> @@ -2,9 +2,7 @@
>> # FPGA framework configuration
>> #
>>
>> -menu "FPGA Configuration Support"
>> -
>> -config FPGA
>> +menuconfig FPGA
>> tristate "FPGA Configuration Framework"
>> help
>> Say Y here if you want support for configuring FPGAs from the
>> @@ -64,5 +62,3 @@ config ALTERA_FREEZE_BRIDGE
>> region is being reprogrammed.
>>
>> endif # FPGA
>> -
>> -endmenu
>> --
>> 2.9.3
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-05-24 19:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-14 9:06 [PATCH] Make FPGA a menuconfig to ease disabling it all Vincent Legoll
2017-04-14 15:26 ` Randy Dunlap
2017-04-14 22:39 ` Vincent Legoll
2017-04-14 22:39 ` Vincent Legoll
2017-05-24 15:35 ` Alan Tull
2017-05-24 19:11 ` Moritz Fischer
2017-04-14 23:05 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.