From: Blue Swirl <blauwirbel@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types
Date: Tue, 10 Jul 2012 19:18:55 +0000 [thread overview]
Message-ID: <CAAu8pHskVwouoedsZmvtWFo2SghxA-B6unhn5w16fsr8Mzjgpg@mail.gmail.com> (raw)
In-Reply-To: <m3wr2dz84x.fsf@blackfin.pond.sub.org>
On Mon, Jul 9, 2012 at 7:49 AM, Markus Armbruster <armbru@redhat.com> wrote:
> blauwirbel@gmail.com writes:
>
>> From: Blue Swirl <blauwirbel@gmail.com>
>>
>> Use 'unsigned int' for bit numbers instead of 'unsigned long' or
>> 'int'. Adjust asserts.
>
> I'd like to lodge a formal objection to this part.
>
> There is no consensus. I recognize the power of maintainers to force a
> change even without consensus. Use it wisely.
I thought I refuted all concrete arguments except performance.
However, Avi kindly provided this part.
next prev parent reply other threads:[~2012-07-10 19:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 19:22 [Qemu-devel] [PATCH v2 0/3] bitops patches blauwirbel
2012-07-08 19:22 ` [Qemu-devel] [PATCH v2 1/3] bitops: fix types blauwirbel
2012-07-09 7:49 ` Markus Armbruster
2012-07-10 19:18 ` Blue Swirl [this message]
2012-07-10 19:37 ` Peter Maydell
2012-07-10 20:01 ` Blue Swirl
2012-07-10 21:36 ` Peter Maydell
2012-07-12 20:18 ` Blue Swirl
2012-07-12 21:05 ` Peter Maydell
2012-07-11 12:49 ` Kevin Wolf
2012-07-12 20:21 ` Blue Swirl
2012-07-13 8:59 ` Kevin Wolf
2012-07-08 19:22 ` [Qemu-devel] [PATCH v2 2/3] bitops: drop volatile qualifier blauwirbel
2012-07-09 7:46 ` Peter Maydell
2012-07-08 19:22 ` [Qemu-devel] [PATCH v2 3/3] bitops: use bool blauwirbel
2012-07-09 7:43 ` Markus Armbruster
2012-07-10 19:32 ` Blue Swirl
2012-07-09 8:14 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAu8pHskVwouoedsZmvtWFo2SghxA-B6unhn5w16fsr8Mzjgpg@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.