From: Peter Maydell <peter.maydell@linaro.org>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Markus Armbruster <armbru@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types
Date: Tue, 10 Jul 2012 22:36:39 +0100 [thread overview]
Message-ID: <CAFEAcA8_ghp5k4eV81aZqPrnWyjpkmS1+wOnaSi-mwWhN70K-Q@mail.gmail.com> (raw)
In-Reply-To: <CAAu8pHsHuPkJjWL9Rvh1zu67drDXZ9734f+Mh8Pg3WbJrA4dxg@mail.gmail.com>
On 10 July 2012 21:01, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Tue, Jul 10, 2012 at 7:37 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 10 July 2012 20:18, Blue Swirl <blauwirbel@gmail.com> wrote:
>>> On Mon, Jul 9, 2012 at 7:49 AM, Markus Armbruster <armbru@redhat.com> wrote:
>>>> There is no consensus. I recognize the power of maintainers to force a
>>>> change even without consensus. Use it wisely.
>>>
>>> I thought I refuted all concrete arguments except performance.
>>
>> No, you made various claims that Markus and I at least
>> disagreed with. (Conversely, we have made various claims
>> that you disagree with -- this is what "no consensus" means...)
>
> You did not present any concrete arguments. In this review you have
> pointed at bugs in the assert() expression, thanks.
No, a bug in your assert is an indication of why there are
downsides to making random changes, not a concrete argument
against making the changes. The major problem here
is (a) there is no really good reason to make this change
(b) it's moving away from the existing tested code we have
(and that the kernel has). Basically 'int' has more natural
behaviour for reasoning about than 'unsigned' in ranges
where it's usually used (ie small ones).
-- PMM
next prev parent reply other threads:[~2012-07-10 21:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 19:22 [Qemu-devel] [PATCH v2 0/3] bitops patches blauwirbel
2012-07-08 19:22 ` [Qemu-devel] [PATCH v2 1/3] bitops: fix types blauwirbel
2012-07-09 7:49 ` Markus Armbruster
2012-07-10 19:18 ` Blue Swirl
2012-07-10 19:37 ` Peter Maydell
2012-07-10 20:01 ` Blue Swirl
2012-07-10 21:36 ` Peter Maydell [this message]
2012-07-12 20:18 ` Blue Swirl
2012-07-12 21:05 ` Peter Maydell
2012-07-11 12:49 ` Kevin Wolf
2012-07-12 20:21 ` Blue Swirl
2012-07-13 8:59 ` Kevin Wolf
2012-07-08 19:22 ` [Qemu-devel] [PATCH v2 2/3] bitops: drop volatile qualifier blauwirbel
2012-07-09 7:46 ` Peter Maydell
2012-07-08 19:22 ` [Qemu-devel] [PATCH v2 3/3] bitops: use bool blauwirbel
2012-07-09 7:43 ` Markus Armbruster
2012-07-10 19:32 ` Blue Swirl
2012-07-09 8:14 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA8_ghp5k4eV81aZqPrnWyjpkmS1+wOnaSi-mwWhN70K-Q@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.