All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] ppc: remove unused variables
@ 2012-02-04 11:49 Blue Swirl
  2012-02-06 15:21 ` Andreas Färber
  0 siblings, 1 reply; 4+ messages in thread
From: Blue Swirl @ 2012-02-04 11:49 UTC (permalink / raw)
  To: Alexander Graf, qemu-ppc, qemu-devel

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

Fix this error:
/src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size':
/src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set
but not used [-Werror=unused-but-set-variable]

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 target-ppc/helper.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/target-ppc/helper.c b/target-ppc/helper.c
index e56fac8..928fbcf 100644
--- a/target-ppc/helper.c
+++ b/target-ppc/helper.c
@@ -1293,11 +1293,8 @@ void booke206_flush_tlb(CPUState *env, int
flags, const int check_iprot)

 target_phys_addr_t booke206_tlb_to_page_size(CPUState *env, ppcmas_tlb_t *tlb)
 {
-    uint32_t tlbncfg;
-    int tlbn = booke206_tlbm_to_tlbn(env, tlb);
     int tlbm_size;

-    tlbncfg = env->spr[SPR_BOOKE_TLB0CFG + tlbn];
     tlbm_size = (tlb->mas1 & MAS1_TSIZE_MASK) >> MAS1_TSIZE_SHIFT;

     return 1024ULL << tlbm_size;
-- 
1.7.9.rc0

[-- Attachment #2: 0001-ppc-remove-unused-variables.patch --]
[-- Type: text/x-patch, Size: 1207 bytes --]

From 410e82944dbec49e3c21806dd4d54eb46bd264f3 Mon Sep 17 00:00:00 2001
Message-Id: <410e82944dbec49e3c21806dd4d54eb46bd264f3.1328356075.git.blauwirbel@gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 4 Feb 2012 11:47:17 +0000
Subject: [PATCH] ppc: remove unused variables

Fix this error:
/src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size':
/src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set but not used [-Werror=unused-but-set-variable]

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 target-ppc/helper.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/target-ppc/helper.c b/target-ppc/helper.c
index e56fac8..928fbcf 100644
--- a/target-ppc/helper.c
+++ b/target-ppc/helper.c
@@ -1293,11 +1293,8 @@ void booke206_flush_tlb(CPUState *env, int flags, const int check_iprot)
 
 target_phys_addr_t booke206_tlb_to_page_size(CPUState *env, ppcmas_tlb_t *tlb)
 {
-    uint32_t tlbncfg;
-    int tlbn = booke206_tlbm_to_tlbn(env, tlb);
     int tlbm_size;
 
-    tlbncfg = env->spr[SPR_BOOKE_TLB0CFG + tlbn];
     tlbm_size = (tlb->mas1 & MAS1_TSIZE_MASK) >> MAS1_TSIZE_SHIFT;
 
     return 1024ULL << tlbm_size;
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH] ppc: remove unused variables
  2012-02-04 11:49 [Qemu-devel] [PATCH] ppc: remove unused variables Blue Swirl
@ 2012-02-06 15:21 ` Andreas Färber
  2012-02-06 15:57   ` Alexander Graf
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2012-02-06 15:21 UTC (permalink / raw)
  To: Alexander Graf; +Cc: Blue Swirl, qemu-ppc, qemu-devel

Am 04.02.2012 12:49, schrieb Blue Swirl:
> Fix this error:
> /src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size':
> /src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set
> but not used [-Werror=unused-but-set-variable]
> 
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>

Tested-by: Andreas Färber <afaerber@suse.de>

Alex?

Andreas

> ---
>  target-ppc/helper.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/target-ppc/helper.c b/target-ppc/helper.c
> index e56fac8..928fbcf 100644
> --- a/target-ppc/helper.c
> +++ b/target-ppc/helper.c
> @@ -1293,11 +1293,8 @@ void booke206_flush_tlb(CPUState *env, int
> flags, const int check_iprot)
> 
>  target_phys_addr_t booke206_tlb_to_page_size(CPUState *env, ppcmas_tlb_t *tlb)
>  {
> -    uint32_t tlbncfg;
> -    int tlbn = booke206_tlbm_to_tlbn(env, tlb);
>      int tlbm_size;
> 
> -    tlbncfg = env->spr[SPR_BOOKE_TLB0CFG + tlbn];
>      tlbm_size = (tlb->mas1 & MAS1_TSIZE_MASK) >> MAS1_TSIZE_SHIFT;
> 
>      return 1024ULL << tlbm_size;

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH] ppc: remove unused variables
  2012-02-06 15:21 ` Andreas Färber
@ 2012-02-06 15:57   ` Alexander Graf
  2012-02-11 11:07     ` Blue Swirl
  0 siblings, 1 reply; 4+ messages in thread
From: Alexander Graf @ 2012-02-06 15:57 UTC (permalink / raw)
  To: Andreas Färber; +Cc: Blue Swirl, qemu-ppc, qemu-devel


On 06.02.2012, at 16:21, Andreas Färber wrote:

> Am 04.02.2012 12:49, schrieb Blue Swirl:
>> Fix this error:
>> /src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size':
>> /src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set
>> but not used [-Werror=unused-but-set-variable]
>> 
>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> 
> Tested-by: Andreas Färber <afaerber@suse.de>

Yes, Blue, can you push it please?


Alex

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Qemu-devel] [PATCH] ppc: remove unused variables
  2012-02-06 15:57   ` Alexander Graf
@ 2012-02-11 11:07     ` Blue Swirl
  0 siblings, 0 replies; 4+ messages in thread
From: Blue Swirl @ 2012-02-11 11:07 UTC (permalink / raw)
  To: Alexander Graf; +Cc: qemu-ppc, Andreas Färber, qemu-devel

On Mon, Feb 6, 2012 at 15:57, Alexander Graf <agraf@suse.de> wrote:
>
> On 06.02.2012, at 16:21, Andreas Färber wrote:
>
>> Am 04.02.2012 12:49, schrieb Blue Swirl:
>>> Fix this error:
>>> /src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size':
>>> /src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set
>>> but not used [-Werror=unused-but-set-variable]
>>>
>>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>>
>> Tested-by: Andreas Färber <afaerber@suse.de>
>
> Yes, Blue, can you push it please?

Pushed.

>
>
> Alex
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-02-11 11:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-04 11:49 [Qemu-devel] [PATCH] ppc: remove unused variables Blue Swirl
2012-02-06 15:21 ` Andreas Färber
2012-02-06 15:57   ` Alexander Graf
2012-02-11 11:07     ` Blue Swirl

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.