All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/4] support/testing: add lzlib test
@ 2019-09-29 12:55 Francois Perrad
  2019-09-29 12:55 ` [Buildroot] [PATCH 2/4] support/testing: add lua-gd test Francois Perrad
                   ` (4 more replies)
  0 siblings, 5 replies; 15+ messages in thread
From: Francois Perrad @ 2019-09-29 12:55 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 .gitlab-ci.yml                              |  1 +
 support/testing/tests/package/test_lzlib.py | 14 ++++++++++++++
 2 files changed, 15 insertions(+)
 create mode 100644 support/testing/tests/package/test_lzlib.py

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 33db89331..fc6628455 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -399,6 +399,7 @@ tests.package.test_luasocket.TestLuaLuaSocket: { extends: .runtime_test }
 tests.package.test_luasocket.TestLuajitLuaSocket: { extends: .runtime_test }
 tests.package.test_luasyslog.TestLuaLuasyslog: { extends: .runtime_test }
 tests.package.test_luasyslog.TestLuajitLuasyslog: { extends: .runtime_test }
+tests.package.test_lzlib.TestLuaLzlib: { extends: .runtime_test }
 tests.package.test_openjdk.TestOpenJdk: { extends: .runtime_test }
 tests.package.test_perl.TestPerl: { extends: .runtime_test }
 tests.package.test_perl_class_load.TestPerlClassLoad: { extends: .runtime_test }
diff --git a/support/testing/tests/package/test_lzlib.py b/support/testing/tests/package/test_lzlib.py
new file mode 100644
index 000000000..84e767913
--- /dev/null
+++ b/support/testing/tests/package/test_lzlib.py
@@ -0,0 +1,14 @@
+from tests.package.test_lua import TestLuaBase
+
+
+class TestLuaLzlib(TestLuaBase):
+    config = TestLuaBase.config + \
+        """
+        BR2_PACKAGE_LUA=y
+        BR2_PACKAGE_LZLIB=y
+        """
+
+    def test_run(self):
+        self.login()
+        self.module_test("zlib")
+        self.module_test("gzip")
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 2/4] support/testing: add lua-gd test
  2019-09-29 12:55 [Buildroot] [PATCH 1/4] support/testing: add lzlib test Francois Perrad
@ 2019-09-29 12:55 ` Francois Perrad
  2019-10-07  0:27   ` Ricardo Martincoski
  2019-09-29 12:55 ` [Buildroot] [PATCH 3/4] support/testing: add lua-sdl2 test Francois Perrad
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 15+ messages in thread
From: Francois Perrad @ 2019-09-29 12:55 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 .gitlab-ci.yml                               |  2 ++
 support/testing/tests/package/test_lua_gd.py | 31 ++++++++++++++++++++
 2 files changed, 33 insertions(+)
 create mode 100644 support/testing/tests/package/test_lua_gd.py

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index fc6628455..a1e309b50 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -381,6 +381,8 @@ tests.package.test_lua_cqueues.TestLuaLuaCqueues: { extends: .runtime_test }
 tests.package.test_lua_cqueues.TestLuajitLuaCqueues: { extends: .runtime_test }
 tests.package.test_lua_curl.TestLuaLuacURL: { extends: .runtime_test }
 tests.package.test_lua_curl.TestLuajitLuacURL: { extends: .runtime_test }
+tests.package.test_lua_gd.TestLuaLuaGD: { extends: .runtime_test }
+tests.package.test_lua_gd.TestLuajitLuaGD: { extends: .runtime_test }
 tests.package.test_lua_http.TestLuaHttp: { extends: .runtime_test }
 tests.package.test_lua_http.TestLuajitHttp: { extends: .runtime_test }
 tests.package.test_lua_utf8.TestLuaUtf8: { extends: .runtime_test }
diff --git a/support/testing/tests/package/test_lua_gd.py b/support/testing/tests/package/test_lua_gd.py
new file mode 100644
index 000000000..f79f2086a
--- /dev/null
+++ b/support/testing/tests/package/test_lua_gd.py
@@ -0,0 +1,31 @@
+from tests.package.test_lua import TestLuaBase
+
+
+class TestLuaLuaGD(TestLuaBase):
+    config = TestLuaBase.config + \
+        """
+        BR2_PACKAGE_LUA=y
+        BR2_PACKAGE_LUA_GD=y
+        BR2_PACKAGE_FONTCONFIG=y
+        BR2_PACKAGE_JPEG=y
+        BR2_PACKAGE_LIBPNG=y
+        """
+
+    def test_run(self):
+        self.login()
+        self.module_test("gd")
+
+
+class TestLuajitLuaGD(TestLuaBase):
+    config = TestLuaBase.config + \
+        """
+        BR2_PACKAGE_LUAJIT=y
+        BR2_PACKAGE_LUA_GD=y
+        BR2_PACKAGE_FONTCONFIG=y
+        BR2_PACKAGE_JPEG=y
+        BR2_PACKAGE_LIBPNG=y
+        """
+
+    def test_run(self):
+        self.login()
+        self.module_test("gd")
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 3/4] support/testing: add lua-sdl2 test
  2019-09-29 12:55 [Buildroot] [PATCH 1/4] support/testing: add lzlib test Francois Perrad
  2019-09-29 12:55 ` [Buildroot] [PATCH 2/4] support/testing: add lua-gd test Francois Perrad
@ 2019-09-29 12:55 ` Francois Perrad
  2019-10-07  0:07   ` Ricardo Martincoski
  2019-10-07 23:31   ` Ricardo Martincoski
  2019-09-29 12:55 ` [Buildroot] [PATCH 4/4] support/testing: add luvi test Francois Perrad
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 15+ messages in thread
From: Francois Perrad @ 2019-09-29 12:55 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 .gitlab-ci.yml                                |  2 +
 .../testing/tests/package/test_lua_sdl2.py    | 41 +++++++++++++++++++
 2 files changed, 43 insertions(+)
 create mode 100644 support/testing/tests/package/test_lua_sdl2.py

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index a1e309b50..ecbcbcb78 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -385,6 +385,8 @@ tests.package.test_lua_gd.TestLuaLuaGD: { extends: .runtime_test }
 tests.package.test_lua_gd.TestLuajitLuaGD: { extends: .runtime_test }
 tests.package.test_lua_http.TestLuaHttp: { extends: .runtime_test }
 tests.package.test_lua_http.TestLuajitHttp: { extends: .runtime_test }
+tests.package.test_lua_sdl2.TestLuaLuaSDL2: { extends: .runtime_test }
+tests.package.test_lua_sdl2.TestLuajitLuaSDL2: { extends: .runtime_test }
 tests.package.test_lua_utf8.TestLuaUtf8: { extends: .runtime_test }
 tests.package.test_lua_utf8.TestLuajitUtf8: { extends: .runtime_test }
 tests.package.test_luaexpat.TestLuaLuaExpat: { extends: .runtime_test }
diff --git a/support/testing/tests/package/test_lua_sdl2.py b/support/testing/tests/package/test_lua_sdl2.py
new file mode 100644
index 000000000..22c4087f5
--- /dev/null
+++ b/support/testing/tests/package/test_lua_sdl2.py
@@ -0,0 +1,41 @@
+from tests.package.test_lua import TestLuaBase
+
+
+class TestLuaLuaSDL2(TestLuaBase):
+    config = TestLuaBase.config + \
+        """
+        BR2_PACKAGE_LUA=y
+        BR2_PACKAGE_LUA_SDL2=y
+        BR2_PACKAGE_SDL2_IMAGE=y
+        BR2_PACKAGE_SDL2_MIXER=y
+        BR2_PACKAGE_SDL2_NET=y
+        BR2_PACKAGE_SDL2_TTF=y
+        """
+
+    def test_run(self):
+        self.login()
+        self.module_test("SDL")
+        self.module_test("SDL.image")
+        self.module_test("SDL.mixer")
+        self.module_test("SDL.net")
+        self.module_test("SDL.ttf")
+
+
+class TestLuajitLuaSDL2(TestLuaBase):
+    config = TestLuaBase.config + \
+        """
+        BR2_PACKAGE_LUAJIT=y
+        BR2_PACKAGE_LUA_SDL2=y
+        BR2_PACKAGE_SDL2_IMAGE=y
+        BR2_PACKAGE_SDL2_MIXER=y
+        BR2_PACKAGE_SDL2_NET=y
+        BR2_PACKAGE_SDL2_TTF=y
+        """
+
+    def test_run(self):
+        self.login()
+        self.module_test("SDL")
+        self.module_test("SDL.image")
+        self.module_test("SDL.mixer")
+        self.module_test("SDL.net")
+        self.module_test("SDL.ttf")
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 4/4] support/testing: add luvi test
  2019-09-29 12:55 [Buildroot] [PATCH 1/4] support/testing: add lzlib test Francois Perrad
  2019-09-29 12:55 ` [Buildroot] [PATCH 2/4] support/testing: add lua-gd test Francois Perrad
  2019-09-29 12:55 ` [Buildroot] [PATCH 3/4] support/testing: add lua-sdl2 test Francois Perrad
@ 2019-09-29 12:55 ` Francois Perrad
  2019-10-07 23:38   ` Ricardo Martincoski
  2019-10-08 23:28   ` Ricardo Martincoski
  2019-10-07  0:27 ` [Buildroot] [PATCH 1/4] support/testing: add lzlib test Ricardo Martincoski
  2019-10-26 14:35 ` Thomas Petazzoni
  4 siblings, 2 replies; 15+ messages in thread
From: Francois Perrad @ 2019-09-29 12:55 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 .gitlab-ci.yml                             |  1 +
 support/testing/tests/package/test_luvi.py | 36 ++++++++++++++++++++++
 2 files changed, 37 insertions(+)
 create mode 100644 support/testing/tests/package/test_luvi.py

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index ecbcbcb78..2f73644e3 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -403,6 +403,7 @@ tests.package.test_luasocket.TestLuaLuaSocket: { extends: .runtime_test }
 tests.package.test_luasocket.TestLuajitLuaSocket: { extends: .runtime_test }
 tests.package.test_luasyslog.TestLuaLuasyslog: { extends: .runtime_test }
 tests.package.test_luasyslog.TestLuajitLuasyslog: { extends: .runtime_test }
+tests.package.test_luvi.TestLuvi: { extends: .runtime_test }
 tests.package.test_lzlib.TestLuaLzlib: { extends: .runtime_test }
 tests.package.test_openjdk.TestOpenJdk: { extends: .runtime_test }
 tests.package.test_perl.TestPerl: { extends: .runtime_test }
diff --git a/support/testing/tests/package/test_luvi.py b/support/testing/tests/package/test_luvi.py
new file mode 100644
index 000000000..a85a6f4d2
--- /dev/null
+++ b/support/testing/tests/package/test_luvi.py
@@ -0,0 +1,36 @@
+import os
+
+import infra.basetest
+
+
+class TestLuvi(infra.basetest.BRTest):
+    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
+        """
+        BR2_TARGET_ROOTFS_CPIO=y
+        # BR2_TARGET_ROOTFS_TAR is not set
+        BR2_PACKAGE_LUAJIT=y
+        BR2_PACKAGE_LUVI=y
+        BR2_PACKAGE_OPENSSL=y
+        BR2_PACKAGE_PCRE=y
+        BR2_PACKAGE_ZLIB=y
+        """
+
+    def login(self):
+        cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio")
+        self.emulator.boot(arch="armv7",
+                           kernel="builtin",
+                           options=["-initrd", cpio_file])
+        self.emulator.login()
+
+    def version_test(self):
+        cmd = "luvi -v"
+        output, exit_code = self.emulator.run(cmd)
+        self.assertIn('luvi', output[0])
+        self.assertIn('zlib', output[1])
+        self.assertIn('rex', output[2])
+        self.assertIn('libuv', output[3])
+        self.assertIn('ssl', output[4])
+
+    def test_run(self):
+        self.login()
+        self.version_test()
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 3/4] support/testing: add lua-sdl2 test
  2019-09-29 12:55 ` [Buildroot] [PATCH 3/4] support/testing: add lua-sdl2 test Francois Perrad
@ 2019-10-07  0:07   ` Ricardo Martincoski
  2019-10-07  4:06     ` François Perrad
  2019-10-07 23:31   ` Ricardo Martincoski
  1 sibling, 1 reply; 15+ messages in thread
From: Ricardo Martincoski @ 2019-10-07  0:07 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, Sep 29, 2019 at 09:55 AM, Francois Perrad wrote:

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  .gitlab-ci.yml                                |  2 +
>  .../testing/tests/package/test_lua_sdl2.py    | 41 +++++++++++++++++++
>  2 files changed, 43 insertions(+)
>  create mode 100644 support/testing/tests/package/test_lua_sdl2.py
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index a1e309b50..ecbcbcb78 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -385,6 +385,8 @@ tests.package.test_lua_gd.TestLuaLuaGD: { extends: .runtime_test }
>  tests.package.test_lua_gd.TestLuajitLuaGD: { extends: .runtime_test }
>  tests.package.test_lua_http.TestLuaHttp: { extends: .runtime_test }
>  tests.package.test_lua_http.TestLuajitHttp: { extends: .runtime_test }
> +tests.package.test_lua_sdl2.TestLuaLuaSDL2: { extends: .runtime_test }
> +tests.package.test_lua_sdl2.TestLuajitLuaSDL2: { extends: .runtime_test }

These 2 test cases failed for me:
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/312517926
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/312517929

with this output:
# lua -l SDL -e 'a=1'
lua: module 'SDL' not found:
	no field package.preload['SDL']
	no file './SDL.lua'
	no file '/usr/share/luajit-2.0.5/SDL.lua'
	no file '/usr/local/share/lua/5.1/SDL.lua'
	no file '/usr/local/share/lua/5.1/SDL/init.lua'
	no file '/usr/share/lua/5.1/SDL.lua'
	no file '/usr/share/lua/5.1/SDL/init.lua'
	no file './SDL.so'
	no file '/usr/local/lib/lua/5.1/SDL.so'
	no file '/usr/lib/lua/5.1/SDL.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
	[C]: at 0xb6f51bb0
	[C]: at 0x00011af8
# echo $?
1
# 


Regards,
Ricardo

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/4] support/testing: add lzlib test
  2019-09-29 12:55 [Buildroot] [PATCH 1/4] support/testing: add lzlib test Francois Perrad
                   ` (2 preceding siblings ...)
  2019-09-29 12:55 ` [Buildroot] [PATCH 4/4] support/testing: add luvi test Francois Perrad
@ 2019-10-07  0:27 ` Ricardo Martincoski
  2019-10-26 14:35 ` Thomas Petazzoni
  4 siblings, 0 replies; 15+ messages in thread
From: Ricardo Martincoski @ 2019-10-07  0:27 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, Sep 29, 2019 at 09:55 AM, Francois Perrad wrote:

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

Reviewed-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Tested-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>


Regards,
Ricardo

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 2/4] support/testing: add lua-gd test
  2019-09-29 12:55 ` [Buildroot] [PATCH 2/4] support/testing: add lua-gd test Francois Perrad
@ 2019-10-07  0:27   ` Ricardo Martincoski
  0 siblings, 0 replies; 15+ messages in thread
From: Ricardo Martincoski @ 2019-10-07  0:27 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, Sep 29, 2019 at 09:55 AM, Francois Perrad wrote:

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

Reviewed-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Tested-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>


Regards,
Ricardo

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 3/4] support/testing: add lua-sdl2 test
  2019-10-07  0:07   ` Ricardo Martincoski
@ 2019-10-07  4:06     ` François Perrad
  2019-10-07 23:30       ` Ricardo Martincoski
  0 siblings, 1 reply; 15+ messages in thread
From: François Perrad @ 2019-10-07  4:06 UTC (permalink / raw)
  To: buildroot

Le lun. 7 oct. 2019 ? 02:07, Ricardo Martincoski <
ricardo.martincoski@gmail.com> a ?crit :

> Hello,
>
> On Sun, Sep 29, 2019 at 09:55 AM, Francois Perrad wrote:
>
> > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> > ---
> >  .gitlab-ci.yml                                |  2 +
> >  .../testing/tests/package/test_lua_sdl2.py    | 41 +++++++++++++++++++
> >  2 files changed, 43 insertions(+)
> >  create mode 100644 support/testing/tests/package/test_lua_sdl2.py
> >
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index a1e309b50..ecbcbcb78 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -385,6 +385,8 @@ tests.package.test_lua_gd.TestLuaLuaGD: { extends:
> .runtime_test }
> >  tests.package.test_lua_gd.TestLuajitLuaGD: { extends: .runtime_test }
> >  tests.package.test_lua_http.TestLuaHttp: { extends: .runtime_test }
> >  tests.package.test_lua_http.TestLuajitHttp: { extends: .runtime_test }
> > +tests.package.test_lua_sdl2.TestLuaLuaSDL2: { extends: .runtime_test }
> > +tests.package.test_lua_sdl2.TestLuajitLuaSDL2: { extends: .runtime_test
> }
>
> These 2 test cases failed for me:
> https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/312517926
> https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/312517929
>
>
Ricardo,

you need this fix https://patchwork.ozlabs.org/patch/1172611/

Fran?ois


> with this output:
> # lua -l SDL -e 'a=1'
> lua: module 'SDL' not found:
>         no field package.preload['SDL']
>         no file './SDL.lua'
>         no file '/usr/share/luajit-2.0.5/SDL.lua'
>         no file '/usr/local/share/lua/5.1/SDL.lua'
>         no file '/usr/local/share/lua/5.1/SDL/init.lua'
>         no file '/usr/share/lua/5.1/SDL.lua'
>         no file '/usr/share/lua/5.1/SDL/init.lua'
>         no file './SDL.so'
>         no file '/usr/local/lib/lua/5.1/SDL.so'
>         no file '/usr/lib/lua/5.1/SDL.so'
>         no file '/usr/local/lib/lua/5.1/loadall.so'
> stack traceback:
>         [C]: at 0xb6f51bb0
>         [C]: at 0x00011af8
> # echo $?
> 1
> #
>
>
> Regards,
> Ricardo_______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191007/58db83b4/attachment.html>

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 3/4] support/testing: add lua-sdl2 test
  2019-10-07  4:06     ` François Perrad
@ 2019-10-07 23:30       ` Ricardo Martincoski
  0 siblings, 0 replies; 15+ messages in thread
From: Ricardo Martincoski @ 2019-10-07 23:30 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, Oct 07, 2019 at 01:06 AM, Fran?ois Perrad wrote:

> Le lun. 7 oct. 2019 ? 02:07, Ricardo Martincoski <
> ricardo.martincoski at gmail.com> a ?crit :
> 
>> Hello,
>>
>> On Sun, Sep 29, 2019 at 09:55 AM, Francois Perrad wrote:
[snip]
>> > +tests.package.test_lua_sdl2.TestLuaLuaSDL2: { extends: .runtime_test }
>> > +tests.package.test_lua_sdl2.TestLuajitLuaSDL2: { extends: .runtime_test
>> }
>>
>> These 2 test cases failed for me:
>> https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/312517926
>> https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/312517929
>>
>>
> Ricardo,
> 
> you need this fix https://patchwork.ozlabs.org/patch/1172611/

Thank you, I will reply with my tags to both patches.


Regards,
Ricardo

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 3/4] support/testing: add lua-sdl2 test
  2019-09-29 12:55 ` [Buildroot] [PATCH 3/4] support/testing: add lua-sdl2 test Francois Perrad
  2019-10-07  0:07   ` Ricardo Martincoski
@ 2019-10-07 23:31   ` Ricardo Martincoski
  1 sibling, 0 replies; 15+ messages in thread
From: Ricardo Martincoski @ 2019-10-07 23:31 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, Sep 29, 2019 at 09:55 AM, Francois Perrad wrote:

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

Reviewed-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Tested-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

These test cases fail on current master:
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/312517926
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/312517929

The same test cases pass after applying a fix:
https://patchwork.ozlabs.org/patch/1172611/
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/314232922
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/314232995


Regards,
Ricardo

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 4/4] support/testing: add luvi test
  2019-09-29 12:55 ` [Buildroot] [PATCH 4/4] support/testing: add luvi test Francois Perrad
@ 2019-10-07 23:38   ` Ricardo Martincoski
  2019-10-08 19:12     ` François Perrad
  2019-10-08 23:28   ` Ricardo Martincoski
  1 sibling, 1 reply; 15+ messages in thread
From: Ricardo Martincoski @ 2019-10-07 23:38 UTC (permalink / raw)
  To: buildroot

Hello,

I did not find anything really wrong with this patch, but I think we can reuse
more code.

Did you find any issue using the armv5 kernel?
For me it seems to work fine:
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/313198399

In the case we can use the armv5 kernel, we can also use TestLuaBase, by doing
3 changes I propose below.
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/314234461

On Sun, Sep 29, 2019 at 09:55 AM, Francois Perrad wrote:

[snip]
> diff --git a/support/testing/tests/package/test_luvi.py b/support/testing/tests/package/test_luvi.py
> new file mode 100644
> index 000000000..a85a6f4d2
> --- /dev/null
> +++ b/support/testing/tests/package/test_luvi.py
> @@ -0,0 +1,36 @@

> +import os
> +
> +import infra.basetest

These would become:
from tests.package.test_lua import TestLuaBase

> +
> +

> +class TestLuvi(infra.basetest.BRTest):
> +    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
> +        """
> +        BR2_TARGET_ROOTFS_CPIO=y
> +        # BR2_TARGET_ROOTFS_TAR is not set

These would become:
class TestLuvi(TestLuaBase):
    config = TestLuaBase.config + \
        """

> +        BR2_PACKAGE_LUAJIT=y
> +        BR2_PACKAGE_LUVI=y
> +        BR2_PACKAGE_OPENSSL=y
> +        BR2_PACKAGE_PCRE=y
> +        BR2_PACKAGE_ZLIB=y
> +        """
> +

> +    def login(self):
> +        cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio")
> +        self.emulator.boot(arch="armv7",
> +                           kernel="builtin",
> +                           options=["-initrd", cpio_file])
> +        self.emulator.login()
> +

And login() would not be defined, reusing the implementation from the parent
class.

> +    def version_test(self):
> +        cmd = "luvi -v"
> +        output, exit_code = self.emulator.run(cmd)
> +        self.assertIn('luvi', output[0])
> +        self.assertIn('zlib', output[1])
> +        self.assertIn('rex', output[2])
> +        self.assertIn('libuv', output[3])
> +        self.assertIn('ssl', output[4])
> +
> +    def test_run(self):
> +        self.login()
> +        self.version_test()
> -- 

Regards,
Ricardo

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 4/4] support/testing: add luvi test
  2019-10-07 23:38   ` Ricardo Martincoski
@ 2019-10-08 19:12     ` François Perrad
  2019-10-08 23:27       ` Ricardo Martincoski
  0 siblings, 1 reply; 15+ messages in thread
From: François Perrad @ 2019-10-08 19:12 UTC (permalink / raw)
  To: buildroot

Le mar. 8 oct. 2019 ? 01:38, Ricardo Martincoski <
ricardo.martincoski@gmail.com> a ?crit :

> Hello,
>
> I did not find anything really wrong with this patch, but I think we can
> reuse
> more code.
>
>
I disagree.
luvi is related to lua, but it is not a Lua module (like NodeJS which is an
JavaScript interpreter, is not a JavaScript library/module).
so, it is a choice to not use TestLuaBase.

In my todo list, I want remove luvi from the Lua modules section in
package/Config.in, and find its real location.

Fran?ois


> Did you find any issue using the armv5 kernel?
> For me it seems to work fine:
> https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/313198399
>
> In the case we can use the armv5 kernel, we can also use TestLuaBase, by
> doing
> 3 changes I propose below.
> https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/314234461
>
> On Sun, Sep 29, 2019 at 09:55 AM, Francois Perrad wrote:
>
> [snip]
> > diff --git a/support/testing/tests/package/test_luvi.py
> b/support/testing/tests/package/test_luvi.py
> > new file mode 100644
> > index 000000000..a85a6f4d2
> > --- /dev/null
> > +++ b/support/testing/tests/package/test_luvi.py
> > @@ -0,0 +1,36 @@
>
> > +import os
> > +
> > +import infra.basetest
>
> These would become:
> from tests.package.test_lua import TestLuaBase
>
> > +
> > +
>
> > +class TestLuvi(infra.basetest.BRTest):
> > +    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
> > +        """
> > +        BR2_TARGET_ROOTFS_CPIO=y
> > +        # BR2_TARGET_ROOTFS_TAR is not set
>
> These would become:
> class TestLuvi(TestLuaBase):
>     config = TestLuaBase.config + \
>         """
>
> > +        BR2_PACKAGE_LUAJIT=y
> > +        BR2_PACKAGE_LUVI=y
> > +        BR2_PACKAGE_OPENSSL=y
> > +        BR2_PACKAGE_PCRE=y
> > +        BR2_PACKAGE_ZLIB=y
> > +        """
> > +
>
> > +    def login(self):
> > +        cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio")
> > +        self.emulator.boot(arch="armv7",
> > +                           kernel="builtin",
> > +                           options=["-initrd", cpio_file])
> > +        self.emulator.login()
> > +
>
> And login() would not be defined, reusing the implementation from the
> parent
> class.
>
> > +    def version_test(self):
> > +        cmd = "luvi -v"
> > +        output, exit_code = self.emulator.run(cmd)
> > +        self.assertIn('luvi', output[0])
> > +        self.assertIn('zlib', output[1])
> > +        self.assertIn('rex', output[2])
> > +        self.assertIn('libuv', output[3])
> > +        self.assertIn('ssl', output[4])
> > +
> > +    def test_run(self):
> > +        self.login()
> > +        self.version_test()
> > --
>
> Regards,
> Ricardo_______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191008/1bd9498d/attachment.html>

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 4/4] support/testing: add luvi test
  2019-10-08 19:12     ` François Perrad
@ 2019-10-08 23:27       ` Ricardo Martincoski
  0 siblings, 0 replies; 15+ messages in thread
From: Ricardo Martincoski @ 2019-10-08 23:27 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, Oct 08, 2019 at 04:12 PM, Fran?ois Perrad wrote:

> Le mar. 8 oct. 2019 ? 01:38, Ricardo Martincoski <
> ricardo.martincoski at gmail.com> a ?crit :
> 
>> Hello,
>>
>> I did not find anything really wrong with this patch, but I think we can
>> reuse
>> more code.
>>
>>
> I disagree.
> luvi is related to lua, but it is not a Lua module (like NodeJS which is an
> JavaScript interpreter, is not a JavaScript library/module).
> so, it is a choice to not use TestLuaBase.

You are right. Thank you for your explanation.


Regards,
Ricardo

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 4/4] support/testing: add luvi test
  2019-09-29 12:55 ` [Buildroot] [PATCH 4/4] support/testing: add luvi test Francois Perrad
  2019-10-07 23:38   ` Ricardo Martincoski
@ 2019-10-08 23:28   ` Ricardo Martincoski
  1 sibling, 0 replies; 15+ messages in thread
From: Ricardo Martincoski @ 2019-10-08 23:28 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, Sep 29, 2019 at 09:55 AM, Francois Perrad wrote:

Perhaps when applying this patch the commit message could be extended,
something like this:

Do not import TestLuaBase since luvi is related to lua, but it is not a
Lua module.

> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

Reviewed-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Tested-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>


Regards,
Ricardo

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Buildroot] [PATCH 1/4] support/testing: add lzlib test
  2019-09-29 12:55 [Buildroot] [PATCH 1/4] support/testing: add lzlib test Francois Perrad
                   ` (3 preceding siblings ...)
  2019-10-07  0:27 ` [Buildroot] [PATCH 1/4] support/testing: add lzlib test Ricardo Martincoski
@ 2019-10-26 14:35 ` Thomas Petazzoni
  4 siblings, 0 replies; 15+ messages in thread
From: Thomas Petazzoni @ 2019-10-26 14:35 UTC (permalink / raw)
  To: buildroot

On Sun, 29 Sep 2019 14:55:17 +0200
Francois Perrad <fperrad@gmail.com> wrote:

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  .gitlab-ci.yml                              |  1 +
>  support/testing/tests/package/test_lzlib.py | 14 ++++++++++++++
>  2 files changed, 15 insertions(+)
>  create mode 100644 support/testing/tests/package/test_lzlib.py

Series applied. Thanks! And thanks to Ricardo for the review.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-10-26 14:35 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-29 12:55 [Buildroot] [PATCH 1/4] support/testing: add lzlib test Francois Perrad
2019-09-29 12:55 ` [Buildroot] [PATCH 2/4] support/testing: add lua-gd test Francois Perrad
2019-10-07  0:27   ` Ricardo Martincoski
2019-09-29 12:55 ` [Buildroot] [PATCH 3/4] support/testing: add lua-sdl2 test Francois Perrad
2019-10-07  0:07   ` Ricardo Martincoski
2019-10-07  4:06     ` François Perrad
2019-10-07 23:30       ` Ricardo Martincoski
2019-10-07 23:31   ` Ricardo Martincoski
2019-09-29 12:55 ` [Buildroot] [PATCH 4/4] support/testing: add luvi test Francois Perrad
2019-10-07 23:38   ` Ricardo Martincoski
2019-10-08 19:12     ` François Perrad
2019-10-08 23:27       ` Ricardo Martincoski
2019-10-08 23:28   ` Ricardo Martincoski
2019-10-07  0:27 ` [Buildroot] [PATCH 1/4] support/testing: add lzlib test Ricardo Martincoski
2019-10-26 14:35 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.