* [Buildroot] [Lua 1/2] package/lua-msgpack-native: remove it
2019-06-08 21:18 [Buildroot] [Lua 0/2] Lua modules removal Francois Perrad
@ 2019-06-08 21:18 ` Francois Perrad
2019-06-08 21:18 ` [Buildroot] [Lua 2/2] package/orbit: " Francois Perrad
2019-06-09 20:36 ` [Buildroot] [Lua 0/2] Lua modules removal Arnout Vandecappelle
2 siblings, 0 replies; 8+ messages in thread
From: Francois Perrad @ 2019-06-08 21:18 UTC (permalink / raw)
To: buildroot
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
Config.in.legacy | 8 +++++++
package/Config.in | 1 -
package/lua-msgpack-native/Config.in | 12 ----------
.../lua-msgpack-native.hash | 2 --
.../lua-msgpack-native/lua-msgpack-native.mk | 22 -------------------
5 files changed, 8 insertions(+), 37 deletions(-)
delete mode 100644 package/lua-msgpack-native/Config.in
delete mode 100644 package/lua-msgpack-native/lua-msgpack-native.hash
delete mode 100644 package/lua-msgpack-native/lua-msgpack-native.mk
diff --git a/Config.in.legacy b/Config.in.legacy
index a32cbcb6f..744b1ca4d 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -144,6 +144,14 @@ endif
###############################################################################
+comment "Legacy options removed in 2019.08"
+
+config BR2_PACKAGE_LUA_MSGPACK_NATIVE
+ bool "lua-msgpack-native package removed"
+ select BR2_LEGACY
+ help
+ The lua-msgpack-native package was removed.
+
comment "Legacy options removed in 2019.05"
config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_COMPOSITOR
diff --git a/package/Config.in b/package/Config.in
index f592e74a9..29cfc11c3 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -627,7 +627,6 @@ menu "Lua libraries/modules"
source "package/lua-lunitx/Config.in"
source "package/lua-markdown/Config.in"
source "package/lua-messagepack/Config.in"
- source "package/lua-msgpack-native/Config.in"
source "package/lua-periphery/Config.in"
source "package/lua-sdl2/Config.in"
source "package/lua-std-debug/Config.in"
diff --git a/package/lua-msgpack-native/Config.in b/package/lua-msgpack-native/Config.in
deleted file mode 100644
index 8af508dd9..000000000
--- a/package/lua-msgpack-native/Config.in
+++ /dev/null
@@ -1,12 +0,0 @@
-config BR2_PACKAGE_LUA_MSGPACK_NATIVE
- bool "lua-msgpack-native"
- depends on BR2_PACKAGE_LUA_5_1 || BR2_PACKAGE_LUAJIT
- help
- This is a native, C language implementation of msgpack
- (http://msgpack.org) library/protocol for Lua language
-
- https://github.com/kengonakajima/lua-msgpack-native
-
-comment "lua-msgpack-native needs Lua 5.1 or LuaJIT"
- depends on !BR2_PACKAGE_LUA_5_1
- depends on !BR2_PACKAGE_LUAJIT
diff --git a/package/lua-msgpack-native/lua-msgpack-native.hash b/package/lua-msgpack-native/lua-msgpack-native.hash
deleted file mode 100644
index cfc598319..000000000
--- a/package/lua-msgpack-native/lua-msgpack-native.hash
+++ /dev/null
@@ -1,2 +0,0 @@
-# locally computed
-sha256 025cf91d509fa3985869d18ef9b8eaeb875ff3c9fcf6467beeed6eab3bb35c93 lua-msgpack-native-41a91b994c70389dc9daa1a15678741d8ec41749.tar.gz
diff --git a/package/lua-msgpack-native/lua-msgpack-native.mk b/package/lua-msgpack-native/lua-msgpack-native.mk
deleted file mode 100644
index acd3a0e1c..000000000
--- a/package/lua-msgpack-native/lua-msgpack-native.mk
+++ /dev/null
@@ -1,22 +0,0 @@
-################################################################################
-#
-# lua-msgpack-native
-#
-################################################################################
-
-LUA_MSGPACK_NATIVE_VERSION = 41a91b994c70389dc9daa1a15678741d8ec41749
-LUA_MSGPACK_NATIVE_SITE = $(call github,kengonakajima,lua-msgpack-native,$(LUA_MSGPACK_NATIVE_VERSION))
-LUA_MSGPACK_NATIVE_DEPENDENCIES = luainterpreter
-LUA_MSGPACK_NATIVE_LICENSE = Apache-2.0
-LUA_MSGPACK_NATIVE_LICENSE_FILES = LICENSE.txt
-
-define LUA_MSGPACK_NATIVE_BUILD_CMDS
- $(TARGET_CC) $(TARGET_CFLAGS) -fPIC -shared -o $(@D)/msgpack.so $(@D)/mp.c
-endef
-
-define LUA_MSGPACK_NATIVE_INSTALL_TARGET_CMDS
- $(INSTALL) -m 755 -D $(@D)/msgpack.so \
- $(TARGET_DIR)/usr/lib/lua/$(LUAINTERPRETER_ABIVER)/msgpack.so
-endef
-
-$(eval $(generic-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [Lua 2/2] package/orbit: remove it
2019-06-08 21:18 [Buildroot] [Lua 0/2] Lua modules removal Francois Perrad
2019-06-08 21:18 ` [Buildroot] [Lua 1/2] package/lua-msgpack-native: remove it Francois Perrad
@ 2019-06-08 21:18 ` Francois Perrad
2019-06-09 20:36 ` [Buildroot] [Lua 0/2] Lua modules removal Arnout Vandecappelle
2 siblings, 0 replies; 8+ messages in thread
From: Francois Perrad @ 2019-06-08 21:18 UTC (permalink / raw)
To: buildroot
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
Config.in.legacy | 6 ++++++
DEVELOPERS | 1 -
package/Config.in | 1 -
package/orbit/Config.in | 15 ---------------
package/orbit/orbit.hash | 4 ----
package/orbit/orbit.mk | 14 --------------
6 files changed, 6 insertions(+), 35 deletions(-)
delete mode 100644 package/orbit/Config.in
delete mode 100644 package/orbit/orbit.hash
delete mode 100644 package/orbit/orbit.mk
diff --git a/Config.in.legacy b/Config.in.legacy
index 744b1ca4d..42656b5a0 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -152,6 +152,12 @@ config BR2_PACKAGE_LUA_MSGPACK_NATIVE
help
The lua-msgpack-native package was removed.
+config BR2_PACKAGE_ORBIT
+ bool "orbit package removed"
+ select BR2_LEGACY
+ help
+ The orbit package was removed.
+
comment "Legacy options removed in 2019.05"
config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_COMPOSITOR
diff --git a/DEVELOPERS b/DEVELOPERS
index e36f1c410..83bdb48d8 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -236,7 +236,6 @@ F: package/luaexpatutils/
F: package/luaposix/
F: package/luasec/
F: package/lua-ev/
-F: package/orbit/
N: Bartosz Bilas <b.bilas@grinn-global.com>
F: package/qt5/qt5scxml/
diff --git a/package/Config.in b/package/Config.in
index 29cfc11c3..0ad92820b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -654,7 +654,6 @@ menu "Lua libraries/modules"
source "package/luv/Config.in"
source "package/luvi/Config.in"
source "package/lzlib/Config.in"
- source "package/orbit/Config.in"
source "package/rings/Config.in"
source "package/turbolua/Config.in"
source "package/wsapi/Config.in"
diff --git a/package/orbit/Config.in b/package/orbit/Config.in
deleted file mode 100644
index 7b6e9a43f..000000000
--- a/package/orbit/Config.in
+++ /dev/null
@@ -1,15 +0,0 @@
-config BR2_PACKAGE_ORBIT
- bool "orbit"
- depends on BR2_PACKAGE_LUA_5_1 || BR2_PACKAGE_LUAJIT
- select BR2_PACKAGE_LPEG # runtime
- select BR2_PACKAGE_LUAFILESYSTEM # runtime
- select BR2_PACKAGE_WSAPI_XAVANTE # runtime
- help
- An MVC web framework for Lua. The design is inspired by
- lightweight Ruby frameworks such as Camping
-
- http://keplerproject.github.com/orbit
-
-comment "orbit needs a Lua 5.1 interpreter"
- depends on !BR2_PACKAGE_LUA_5_1
- depends on !BR2_PACKAGE_LUAJIT
diff --git a/package/orbit/orbit.hash b/package/orbit/orbit.hash
deleted file mode 100644
index eb427b63b..000000000
--- a/package/orbit/orbit.hash
+++ /dev/null
@@ -1,4 +0,0 @@
-# computed by luarocks/buildroot
-sha256 91e3c514d5b86918db83666c8889635bb2d50c71d1ab3aeb69c6469c9424089b orbit-2.2.4-1.src.rock
-sha256 dd7d37caed0f4ee994e9e64ea4ab292dce549bb609412c84fc47ed079275ae98 orbit/doc/us/license.html
-sha256 140134369c1f041abf7d8cd39a5b0c42f8b5e827695ce7c1ef5ca8f0911a0246 orbit/doc/us/license.md
diff --git a/package/orbit/orbit.mk b/package/orbit/orbit.mk
deleted file mode 100644
index 5cf7ac643..000000000
--- a/package/orbit/orbit.mk
+++ /dev/null
@@ -1,14 +0,0 @@
-################################################################################
-#
-# orbit
-#
-################################################################################
-
-ORBIT_VERSION = 2.2.4-1
-ORBIT_SUBDIR = orbit
-ORBIT_LICENSE = MIT
-ORBIT_LICENSE_FILES = \
- $(ORBIT_SUBDIR)/doc/us/license.html \
- $(ORBIT_SUBDIR)/doc/us/license.md
-
-$(eval $(luarocks-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [Lua 0/2] Lua modules removal
2019-06-08 21:18 [Buildroot] [Lua 0/2] Lua modules removal Francois Perrad
2019-06-08 21:18 ` [Buildroot] [Lua 1/2] package/lua-msgpack-native: remove it Francois Perrad
2019-06-08 21:18 ` [Buildroot] [Lua 2/2] package/orbit: " Francois Perrad
@ 2019-06-09 20:36 ` Arnout Vandecappelle
2019-06-10 8:31 ` François Perrad
2 siblings, 1 reply; 8+ messages in thread
From: Arnout Vandecappelle @ 2019-06-09 20:36 UTC (permalink / raw)
To: buildroot
On 08/06/2019 23:18, Francois Perrad wrote:
> This serie removes 2 Lua modules which are Lua 5.1 only
> and not actively maintained by upstream.
This needs a bit more context though... Is the intention to remove Lua 5.1? And
what about luajit?
We tend to not remove unmaintained packages unless there is a good reason for it.
Regards,
Arnout
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [Lua 0/2] Lua modules removal
2019-06-09 20:36 ` [Buildroot] [Lua 0/2] Lua modules removal Arnout Vandecappelle
@ 2019-06-10 8:31 ` François Perrad
2019-06-10 13:17 ` Arnout Vandecappelle
0 siblings, 1 reply; 8+ messages in thread
From: François Perrad @ 2019-06-10 8:31 UTC (permalink / raw)
To: buildroot
Le dim. 9 juin 2019 ? 22:37, Arnout Vandecappelle <arnout@mind.be> a ?crit :
>
>
> On 08/06/2019 23:18, Francois Perrad wrote:
> > This serie removes 2 Lua modules which are Lua 5.1 only
> > and not actively maintained by upstream.
>
> This needs a bit more context though... Is the intention to remove Lua
> 5.1? And
> what about luajit?
>
>
This is a step in order to remove Lua 5.1, but not LuaJIT which stay as is.
In otherways, Lua evolves :
- Lua 5.3.5 will be the last one of its serie
- Lua 5.4 is up coming (lua-5.4.0-alpha is already available)
- Lua 5.2.4 was released on 2015
- Lua 5.1.5 was released on 2012.
Lua has two sides :
- an interpreter which could be used with various modules
- a library used as optional dependency
This serie handles only the interpreter side.
Fran?ois
We tend to not remove unmaintained packages unless there is a good reason
> for it.
>
> Regards,
> Arnout
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190610/89399ced/attachment.html>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [Lua 0/2] Lua modules removal
2019-06-10 8:31 ` François Perrad
@ 2019-06-10 13:17 ` Arnout Vandecappelle
2019-06-10 17:02 ` François Perrad
0 siblings, 1 reply; 8+ messages in thread
From: Arnout Vandecappelle @ 2019-06-10 13:17 UTC (permalink / raw)
To: buildroot
On 10/06/2019 10:31, Fran?ois Perrad wrote:
>
>
> Le?dim. 9 juin 2019 ??22:37, Arnout Vandecappelle <arnout@mind.be
> <mailto:arnout@mind.be>> a ?crit?:
>
>
>
> On 08/06/2019 23:18, Francois Perrad wrote:
> > This serie removes 2 Lua modules which are Lua 5.1 only
> > and not actively maintained by upstream.
>
> ?This needs a bit more context though... Is the intention to remove Lua 5.1? And
> what about luajit?
>
>
> This is a step in order to remove Lua 5.1, but not LuaJIT which stay as is.
So, aren't these two packages relevant for LuaJIT then?
Regards,
Arnout
> In otherways, Lua evolves :
> - Lua 5.3.5 will be the last one of its serie
> - Lua 5.4 is up coming (lua-5.4.0-alpha is already available)
> - Lua 5.2.4 was released on 2015
> - Lua 5.1.5 was released on 2012.
>
> Lua has two sides :
> - an interpreter which could be used with various modules
> - a library used as optional dependency
> This serie handles only the interpreter side.
>
> Fran?ois
>
> ?We tend to not remove unmaintained packages unless there is a good reason
> for it.
>
> ?Regards,
> ?Arnout
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net <mailto:buildroot@busybox.net>
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [Lua 0/2] Lua modules removal
2019-06-10 13:17 ` Arnout Vandecappelle
@ 2019-06-10 17:02 ` François Perrad
2019-08-03 8:29 ` Thomas Petazzoni
0 siblings, 1 reply; 8+ messages in thread
From: François Perrad @ 2019-06-10 17:02 UTC (permalink / raw)
To: buildroot
Le lun. 10 juin 2019 ? 15:17, Arnout Vandecappelle <arnout@mind.be> a
?crit :
>
>
> On 10/06/2019 10:31, Fran?ois Perrad wrote:
> >
> >
> > Le dim. 9 juin 2019 ? 22:37, Arnout Vandecappelle <arnout@mind.be
> > <mailto:arnout@mind.be>> a ?crit :
> >
> >
> >
> > On 08/06/2019 23:18, Francois Perrad wrote:
> > > This serie removes 2 Lua modules which are Lua 5.1 only
> > > and not actively maintained by upstream.
> >
> > This needs a bit more context though... Is the intention to remove
> Lua 5.1? And
> > what about luajit?
> >
> >
> > This is a step in order to remove Lua 5.1, but not LuaJIT which stay as
> is.
>
> So, aren't these two packages relevant for LuaJIT then?
>
>
These two modules could be loaded/used by LuaJIT, but in practice, I don't
think they are.
Fran?ois
> Regards,
> Arnout
>
> > In otherways, Lua evolves :
> > - Lua 5.3.5 will be the last one of its serie
> > - Lua 5.4 is up coming (lua-5.4.0-alpha is already available)
> > - Lua 5.2.4 was released on 2015
> > - Lua 5.1.5 was released on 2012.
> >
> > Lua has two sides :
> > - an interpreter which could be used with various modules
> > - a library used as optional dependency
> > This serie handles only the interpreter side.
> >
> > Fran?ois
> >
> > We tend to not remove unmaintained packages unless there is a good
> reason
> > for it.
> >
> > Regards,
> > Arnout
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net <mailto:buildroot@busybox.net>
> > http://lists.busybox.net/mailman/listinfo/buildroot
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190610/65dd322d/attachment.html>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [Lua 0/2] Lua modules removal
2019-06-10 17:02 ` François Perrad
@ 2019-08-03 8:29 ` Thomas Petazzoni
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Petazzoni @ 2019-08-03 8:29 UTC (permalink / raw)
To: buildroot
Hello Fran?ois,
On Mon, 10 Jun 2019 19:02:58 +0200
Fran?ois Perrad <francois.perrad@gadz.org> wrote:
> > So, aren't these two packages relevant for LuaJIT then?
> >
> These two modules could be loaded/used by LuaJIT, but in practice, I don't
> think they are.
This is not a very convincing argument. If you really want those
packages to be removed, could you send a new iteration of the series
that clearly explains in the commit log why the package is removed. Or
perhaps they should be kept, and just the "depends on
BR2_PACKAGE_LUA_5_1" be removed when you remove Lua 5.1 ?
In the mean time, I'll mark the series as Changes Requested in
patchwork.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread