All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/11] Minor DT comment cleanups
@ 2022-11-07 14:55 Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 01/11] arm64: dts: qcom: msm/apq8x16-*: Fix up comments Konrad Dybcio
                   ` (12 more replies)
  0 siblings, 13 replies; 15+ messages in thread
From: Konrad Dybcio @ 2022-11-07 14:55 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio

Ensure the usage of C-style (/* */) comments instead of '//'.
Make sure all multiline C-style commends begin with just '/*' with
the comment text starting on a new line.

I also capitalized some comments differently and trimmed some fluff.

This patchset brings no functional change, purely for cosmetic and
code style purposes.

I also caught a single sneaky raw value with a proper #define constant
sitting next to it in the comment..


Konrad Dybcio (11):
  arm64: dts: qcom: msm/apq8x16-*: Fix up comments
  arm64: dts: qcom: msm/apq8x96-*: Fix up comments
  arm64: dts: qcom: msm8953: Fix up comments
  arm64: dts: qcom: msm8998-*: Fix up comments
  arm64: dts: qcom: sc8280xp-x13s: Fix up comments
  arm64: dts: qcom: sdm845-*: Fix up comments
  arm64: dts: qcom: ipq8074-*: Fix up comments
  arm64: dts: qcom: msm8992-*: Fix up comments
  arm64: dts: qcom: msm8994-*: Fix up comments
  arm64: dts: qcom: qcs404-*: Fix up comments
  arm64: dts: qcom: pm6150/l/pm7325/pms405: Fix up comments

 arch/arm64/boot/dts/qcom/apq8016-sbc.dts      |  2 +-
 arch/arm64/boot/dts/qcom/apq8096-db820c.dts   | 14 +++----
 arch/arm64/boot/dts/qcom/ipq8074-hk01.dts     |  3 +-
 arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dts  |  3 +-
 arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dts  |  3 +-
 arch/arm64/boot/dts/qcom/ipq8074.dtsi         | 12 +++---
 .../arm64/boot/dts/qcom/msm8916-huawei-g7.dts |  4 +-
 .../boot/dts/qcom/msm8916-longcheer-l8150.dts |  6 +--
 arch/arm64/boot/dts/qcom/msm8916-pins.dtsi    |  2 +-
 .../dts/qcom/msm8916-samsung-serranove.dts    |  4 +-
 .../dts/qcom/msm8916-wingtech-wt88047.dts     |  4 +-
 arch/arm64/boot/dts/qcom/msm8916.dtsi         | 10 ++---
 arch/arm64/boot/dts/qcom/msm8953.dtsi         |  6 +--
 .../dts/qcom/msm8992-lg-bullhead-rev-10.dts   |  3 +-
 .../dts/qcom/msm8992-lg-bullhead-rev-101.dts  |  3 +-
 .../boot/dts/qcom/msm8992-lg-bullhead.dtsi    | 41 ++++++++++---------
 arch/arm64/boot/dts/qcom/msm8992.dtsi         |  3 +-
 .../qcom/msm8994-huawei-angler-rev-101.dts    |  3 +-
 arch/arm64/boot/dts/qcom/msm8994.dtsi         |  3 +-
 arch/arm64/boot/dts/qcom/msm8996.dtsi         |  3 +-
 .../boot/dts/qcom/msm8998-fxtec-pro1.dts      |  8 +---
 arch/arm64/boot/dts/qcom/msm8998-mtp.dts      |  8 +---
 arch/arm64/boot/dts/qcom/pm6150.dtsi          |  4 +-
 arch/arm64/boot/dts/qcom/pm6150l.dtsi         |  4 +-
 arch/arm64/boot/dts/qcom/pm7325.dtsi          |  4 +-
 arch/arm64/boot/dts/qcom/pms405.dtsi          |  4 +-
 arch/arm64/boot/dts/qcom/qcs404-evb-1000.dts  |  4 +-
 arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts  |  4 +-
 arch/arm64/boot/dts/qcom/qcs404-evb.dtsi      |  4 +-
 arch/arm64/boot/dts/qcom/qcs404.dtsi          |  4 +-
 .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |  2 +-
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts    | 38 ++++++++++-------
 .../boot/dts/qcom/sdm845-oneplus-common.dtsi  |  5 ++-
 .../boot/dts/qcom/sdm850-samsung-w737.dts     |  2 +-
 34 files changed, 131 insertions(+), 96 deletions(-)

-- 
2.38.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 01/11] arm64: dts: qcom: msm/apq8x16-*: Fix up comments
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
@ 2022-11-07 14:55 ` Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 02/11] arm64: dts: qcom: msm/apq8x96-*: " Konrad Dybcio
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Konrad Dybcio @ 2022-11-07 14:55 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

Switch '//' comments to C-style /* */ and fix up the contents of some.
Make sure all multiline C-style commends begin with just '/*' with
the comment text starting on a new line.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8016-sbc.dts               |  2 +-
 arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dts         |  4 +++-
 arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts   |  6 +++---
 arch/arm64/boot/dts/qcom/msm8916-pins.dtsi             |  2 +-
 arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts |  4 +++-
 arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts  |  4 +++-
 arch/arm64/boot/dts/qcom/msm8916.dtsi                  | 10 +++++-----
 7 files changed, 19 insertions(+), 13 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index 1b613098fb4a..334f28385716 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -839,7 +839,7 @@ ls_exp_gpio_f: pm8916-mpp4-state {
 		function = "digital";
 
 		output-low;
-		power-source = <PM8916_MPP_L5>;	// 1.8V
+		power-source = <PM8916_MPP_L5>;	/* 1.8V */
 	};
 
 	pm8916_mpps_leds: pm8916-mpps-state {
diff --git a/arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dts b/arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dts
index 9e470c67274e..93e95ff41d08 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dts
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-only
-// Copyright (C) 2021 Stephan Gerhold
+/*
+ * Copyright (C) 2021 Stephan Gerhold
+ */
 
 /dts-v1/;
 
diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
index d85e7f7c0835..c158f884d29e 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
@@ -22,7 +22,7 @@ chosen {
 	};
 
 	reserved-memory {
-		// wcnss.mdt is not relocatable, so it must be loaded at 0x8b600000
+		/* wcnss.mdt is not relocatable, so it must be loaded at 0x8b600000 */
 		/delete-node/ wcnss@89300000;
 
 		wcnss_mem: wcnss@8b600000 {
@@ -204,12 +204,12 @@ rmi4@20 {
 
 		rmi4-f01@1 {
 			reg = <0x1>;
-			syna,nosleep-mode = <1>; // Allow sleeping
+			syna,nosleep-mode = <1>; /* Allow sleeping */
 		};
 
 		rmi4-f12@12 {
 			reg = <0x12>;
-			syna,sensor-type = <1>; // Touchscreen
+			syna,sensor-type = <1>; /* Touchscreen */
 		};
 	};
 };
diff --git a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
index 7dedb91b9930..1bb7df185ac4 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi
@@ -6,7 +6,7 @@
 &msmgpio {
 
 	blsp1_uart1_default: blsp1-uart1-default {
-		//	TX, RX, CTS_N, RTS_N
+		/* TX, RX, CTS_N, RTS_N */
 		pins = "gpio0", "gpio1", "gpio2", "gpio3";
 		function = "blsp_uart1";
 
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts
index bbd6bb3f4fd7..73f980a4b213 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-only
-// Copyright (C) 2019 Stephan Gerhold
+/*
+ * Copyright (C) 2019 Stephan Gerhold
+ */
 
 /dts-v1/;
 
diff --git a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts
index 84a352dcf9a2..147e187fc403 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-only
-// Copyright (C) 2020 Stephan Gerhold
+/*
+ * Copyright (C) 2020 Stephan Gerhold
+ */
 
 /dts-v1/;
 
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index a60eb8a59dca..d7af9318b1cc 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -1263,21 +1263,21 @@ apps_iommu: iommu@1ef0000 {
 			clock-names = "iface", "bus";
 			qcom,iommu-secure-id = <17>;
 
-			// vfe:
+			/* VFE */
 			iommu-ctx@3000 {
 				compatible = "qcom,msm-iommu-v1-sec";
 				reg = <0x3000 0x1000>;
 				interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
 			};
 
-			// mdp_0:
+			/* MDP_0 */
 			iommu-ctx@4000 {
 				compatible = "qcom,msm-iommu-v1-ns";
 				reg = <0x4000 0x1000>;
 				interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
 			};
 
-			// venus_ns:
+			/* VENUS_NS */
 			iommu-ctx@5000 {
 				compatible = "qcom,msm-iommu-v1-sec";
 				reg = <0x5000 0x1000>;
@@ -1296,14 +1296,14 @@ gpu_iommu: iommu@1f08000 {
 			clock-names = "iface", "bus";
 			qcom,iommu-secure-id = <18>;
 
-			// gfx3d_user:
+			/* GFX3D_USER */
 			iommu-ctx@1000 {
 				compatible = "qcom,msm-iommu-v1-ns";
 				reg = <0x1000 0x1000>;
 				interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>;
 			};
 
-			// gfx3d_priv:
+			/* GFX3D_PRIV */
 			iommu-ctx@2000 {
 				compatible = "qcom,msm-iommu-v1-ns";
 				reg = <0x2000 0x1000>;
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 02/11] arm64: dts: qcom: msm/apq8x96-*: Fix up comments
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 01/11] arm64: dts: qcom: msm/apq8x16-*: Fix up comments Konrad Dybcio
@ 2022-11-07 14:55 ` Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 03/11] arm64: dts: qcom: msm8953: " Konrad Dybcio
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Konrad Dybcio @ 2022-11-07 14:55 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

Switch '//' comments to C-style /* */ and fix up the contents of some.
Make sure all multiline C-style commends begin with just '/*' with
the comment text starting on a new line.
Also, fix up a single raw '2' to PM8994_GPIO_S4 while at it.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 14 +++++++-------
 arch/arm64/boot/dts/qcom/msm8996.dtsi       |  3 ++-
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
index 7f10372178d6..6ad7e5c78ae1 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
@@ -560,7 +560,7 @@ pinconf {
 			pins = "gpio5";
 			function = PMIC_GPIO_FUNC_NORMAL;
 			output-low;
-			power-source = <2>; // PM8994_GPIO_S4, 1.8V
+			power-source = <PM8994_GPIO_S4>; /* 1.8V */
 		};
 	};
 
@@ -569,7 +569,7 @@ pinconf {
 			pins = "gpio19";
 			function = PMIC_GPIO_FUNC_NORMAL;
 			output-low;
-			power-source = <PM8994_GPIO_S4>; // 1.8V
+			power-source = <PM8994_GPIO_S4>; /* 1.8V */
 			qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>;
 			bias-pull-down;
 		};
@@ -580,7 +580,7 @@ pinconf {
 			pins = "gpio8";
 			function = PMIC_GPIO_FUNC_NORMAL;
 			output-low;
-			power-source = <PM8994_GPIO_S4>; // 1.8V
+			power-source = <PM8994_GPIO_S4>; /* 1.8V */
 			qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>;
 			bias-pull-down;
 		};
@@ -590,7 +590,7 @@ audio_mclk: clk-div1-state {
 		pinconf {
 			pins = "gpio15";
 			function = "func1";
-			power-source = <PM8994_GPIO_S4>; // 1.8V
+			power-source = <PM8994_GPIO_S4>; /* 1.8V */
 		};
 	};
 
@@ -602,7 +602,7 @@ pinconf {
 			drive-push-pull;
 			bias-pull-up;
 			qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
-			power-source = <PM8994_GPIO_S4>; // 1.8V
+			power-source = <PM8994_GPIO_S4>; /* 1.8V */
 		};
 	};
 
@@ -623,7 +623,7 @@ pinconf {
 			input-enable;
 			bias-pull-down;
 			qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
-			power-source = <PM8994_GPIO_S4>; // 1.8V
+			power-source = <PM8994_GPIO_S4>; /* 1.8V */
 		};
 	};
 };
@@ -679,7 +679,7 @@ pinconf {
 			input-enable;
 			bias-pull-down;
 			qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
-			power-source = <PM8994_GPIO_S4>; // 1.8V
+			power-source = <PM8994_GPIO_S4>; /* 1.8V */
 		};
 	};
 };
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index df0f67c223bb..4dccde54dd2f 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/* Copyright (c) 2014-2015, The Linux Foundation. All rights reserved.
+/*
+ * Copyright (c) 2014-2015, The Linux Foundation. All rights reserved.
  */
 
 #include <dt-bindings/interrupt-controller/arm-gic.h>
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 03/11] arm64: dts: qcom: msm8953: Fix up comments
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 01/11] arm64: dts: qcom: msm/apq8x16-*: Fix up comments Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 02/11] arm64: dts: qcom: msm/apq8x96-*: " Konrad Dybcio
@ 2022-11-07 14:55 ` Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 04/11] arm64: dts: qcom: msm8998-*: " Konrad Dybcio
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Konrad Dybcio @ 2022-11-07 14:55 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

Switch '//' comments to C-style /* */ and fix up the contents of some.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8953.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
index f2ff18ac9141..32349174c4bd 100644
--- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
@@ -948,21 +948,21 @@ apps_iommu: iommu@1e00000 {
 			#iommu-cells = <1>;
 			#size-cells = <1>;
 
-			// vfe
+			/* VFE */
 			iommu-ctx@14000 {
 				compatible = "qcom,msm-iommu-v1-ns";
 				reg = <0x14000 0x1000>;
 				interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
 			};
 
-			// mdp_0
+			/* MDP_0 */
 			iommu-ctx@15000 {
 				compatible = "qcom,msm-iommu-v1-ns";
 				reg = <0x15000 0x1000>;
 				interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
 			};
 
-			// venus_ns
+			/* VENUS_NS */
 			iommu-ctx@16000 {
 				compatible = "qcom,msm-iommu-v1-ns";
 				reg = <0x16000 0x1000>;
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 04/11] arm64: dts: qcom: msm8998-*: Fix up comments
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
                   ` (2 preceding siblings ...)
  2022-11-07 14:55 ` [PATCH 03/11] arm64: dts: qcom: msm8953: " Konrad Dybcio
@ 2022-11-07 14:55 ` Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 05/11] arm64: dts: qcom: sc8280xp-x13s: " Konrad Dybcio
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Konrad Dybcio @ 2022-11-07 14:55 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

Switch '//' comments to C-style /* */ and fix up the contents of some.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts | 8 ++------
 arch/arm64/boot/dts/qcom/msm8998-mtp.dts        | 8 ++------
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts b/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
index 2aee2fd29a07..310f7a2df1e8 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
+++ b/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
@@ -310,15 +310,11 @@ &funnel3 {
 };
 
 &funnel4 {
-	// FIXME: Figure out why clock late_initcall crashes the board with
-	// this enabled.
-	// status = "okay";
+	/* FIXME: Figure out why clock late_initcall crashes the board with this enabled. */
 };
 
 &funnel5 {
-	// FIXME: Figure out why clock late_initcall crashes the board with
-	// this enabled.
-	// status = "okay";
+	/* FIXME: Figure out why clock late_initcall crashes the board with this enabled. */
 };
 
 &pcie0 {
diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dts b/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
index 00032ed3f4aa..453a1c9e9808 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
@@ -124,15 +124,11 @@ &funnel3 {
 };
 
 &funnel4 {
-	// FIXME: Figure out why clock late_initcall crashes the board with
-	// this enabled.
-	// status = "okay";
+	/* FIXME: Figure out why clock late_initcall crashes the board with this enabled. */
 };
 
 &funnel5 {
-	// FIXME: Figure out why clock late_initcall crashes the board with
-	// this enabled.
-	// status = "okay";
+	/* FIXME: Figure out why clock late_initcall crashes the board with this enabled. */
 };
 
 &pcie0 {
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 05/11] arm64: dts: qcom: sc8280xp-x13s: Fix up comments
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
                   ` (3 preceding siblings ...)
  2022-11-07 14:55 ` [PATCH 04/11] arm64: dts: qcom: msm8998-*: " Konrad Dybcio
@ 2022-11-07 14:55 ` Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 06/11] arm64: dts: qcom: sdm845-*: " Konrad Dybcio
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Konrad Dybcio @ 2022-11-07 14:55 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

Switch '//' comments to C-style /* */.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 68b61e8d03c0..381d521d2ba0 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -95,7 +95,7 @@ vreg_l6b: ldo6 {
 			regulator-max-microvolt = <880000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-boot-on;
-			regulator-always-on;	// FIXME: VDD_A_EDP_0_0P9
+			regulator-always-on;	/* FIXME: VDD_A_EDP_0_0P9 */
 		};
 	};
 
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 06/11] arm64: dts: qcom: sdm845-*: Fix up comments
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
                   ` (4 preceding siblings ...)
  2022-11-07 14:55 ` [PATCH 05/11] arm64: dts: qcom: sc8280xp-x13s: " Konrad Dybcio
@ 2022-11-07 14:55 ` Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 07/11] arm64: dts: qcom: ipq8074-*: " Konrad Dybcio
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Konrad Dybcio @ 2022-11-07 14:55 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

Switch '//' comments to C-style /* */.
Make sure all multiline C-style commends begin with just '/*' with
the comment text starting on a new line.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts    | 38 +++++++++++--------
 .../boot/dts/qcom/sdm845-oneplus-common.dtsi  |  5 ++-
 .../boot/dts/qcom/sdm850-samsung-w737.dts     |  2 +-
 3 files changed, 27 insertions(+), 18 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index 8ba3188ac4c3..ea092e884b45 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -120,9 +120,11 @@ lt9611_3v3: lt9611-3v3 {
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 
-		// TODO: make it possible to drive same GPIO from two clients
-		// gpio = <&tlmm 89 GPIO_ACTIVE_HIGH>;
-		// enable-active-high;
+		/*
+		 * TODO: make it possible to drive same GPIO from two clients
+		 * gpio = <&tlmm 89 GPIO_ACTIVE_HIGH>;
+		 * enable-active-high;
+		 */
 	};
 
 	pcie0_1p05v: pcie-0-1p05v-regulator {
@@ -133,9 +135,11 @@ pcie0_1p05v: pcie-0-1p05v-regulator {
 		regulator-min-microvolt = <1050000>;
 		regulator-max-microvolt = <1050000>;
 
-		// TODO: make it possible to drive same GPIO from two clients
-		// gpio = <&tlmm 90 GPIO_ACTIVE_HIGH>;
-		// enable-active-high;
+		/*
+		 * TODO: make it possible to drive same GPIO from two clients
+		 * gpio = <&tlmm 90 GPIO_ACTIVE_HIGH>;
+		 * enable-active-high;
+		 */
 	};
 
 	cam0_dvdd_1v2: reg_cam0_dvdd_1v2 {
@@ -195,9 +199,11 @@ v5p0_hdmiout: v5p0-hdmiout-regulator {
 		regulator-min-microvolt = <500000>;
 		regulator-max-microvolt = <500000>;
 
-		// TODO: make it possible to drive same GPIO from two clients
-		// gpio = <&tlmm 89 GPIO_ACTIVE_HIGH>;
-		// enable-active-high;
+		/*
+		 * TODO: make it possible to drive same GPIO from two clients
+		 * gpio = <&tlmm 89 GPIO_ACTIVE_HIGH>;
+		 * enable-active-high;
+		 */
 	};
 
 	vbat: vbat-regulator {
@@ -1192,7 +1198,7 @@ camera@10 {
 		compatible = "ovti,ov8856";
 		reg = <0x10>;
 
-		// CAM0_RST_N
+		/* CAM0_RST_N */
 		reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&cam0_default>;
@@ -1201,7 +1207,8 @@ camera@10 {
 		clock-names = "xvclk";
 		clock-frequency = <19200000>;
 
-		/* The &vreg_s4a_1p8 trace is powered on as a,
+		/*
+		 * The &vreg_s4a_1p8 trace is powered on as a,
 		 * so it is represented by a fixed regulator.
 		 *
 		 * The 2.8V vdda-supply and 1.2V vddd-supply regulators
@@ -1229,10 +1236,10 @@ &cci_i2c1 {
 	camera@60 {
 		compatible = "ovti,ov7251";
 
-		// I2C address as per ov7251.txt linux documentation
+		/* I2C address as per ov7251.txt linux documentation */
 		reg = <0x60>;
 
-		// CAM3_RST_N
+		/* CAM3_RST_N */
 		enable-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&cam3_default>;
@@ -1241,7 +1248,8 @@ camera@60 {
 		clock-names = "xclk";
 		clock-frequency = <24000000>;
 
-		/* The &vreg_s4a_1p8 trace always powered on.
+		/*
+		 * The &vreg_s4a_1p8 trace always powered on.
 		 *
 		 * The 2.8V vdda-supply regulator is enabled when the
 		 * vreg_s4a_1p8 trace is pulled high.
@@ -1257,7 +1265,7 @@ camera@60 {
 		port {
 			ov7251_ep: endpoint {
 				data-lanes = <0 1>;
-//				remote-endpoint = <&csiphy3_ep>;
+/*				remote-endpoint = <&csiphy3_ep>; */
 			};
 		};
 	};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index 5d99908d4628..a51ec7fb1746 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -50,7 +50,8 @@ key-vol-up {
 	};
 
 	reserved-memory {
-		/* The rmtfs_mem needs to be guarded due to "XPU limitations"
+		/*
+		 * The rmtfs_mem needs to be guarded due to "XPU limitations"
 		 * it is otherwise possible for an allocation adjacent to the
 		 * rmtfs_mem region to trigger an XPU violation, causing a crash.
 		 */
@@ -433,7 +434,7 @@ &mdss {
 	status = "okay";
 };
 
-/* Modem/wifi*/
+/* Modem/wifi */
 &mss_pil {
 	status = "okay";
 	firmware-name = "qcom/sdm845/oneplus6/mba.mbn", "qcom/sdm845/oneplus6/modem.mbn";
diff --git a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
index f93d748e2c94..b712834a5d64 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
@@ -43,7 +43,7 @@ chosen {
 		#size-cells = <2>;
 		ranges;
 
-		// Firmware initialized the display at 1280p instead of 1440p
+		/* Firmware initialized the display at 1280p instead of 1440p */
 		framebuffer0: framebuffer@80400000 {
 			compatible = "simple-framebuffer";
 			reg = <0 0x80400000 0 (1920 * 1280 * 4)>;
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 07/11] arm64: dts: qcom: ipq8074-*: Fix up comments
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
                   ` (5 preceding siblings ...)
  2022-11-07 14:55 ` [PATCH 06/11] arm64: dts: qcom: sdm845-*: " Konrad Dybcio
@ 2022-11-07 14:55 ` Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 08/11] arm64: dts: qcom: msm8992-*: " Konrad Dybcio
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Konrad Dybcio @ 2022-11-07 14:55 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

Make sure all multiline C-style commends begin with just '/*' with
the comment text starting on a new line.

Also, fix up some whitespace within comments.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/ipq8074-hk01.dts    |  3 ++-
 arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dts |  3 ++-
 arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dts |  3 ++-
 arch/arm64/boot/dts/qcom/ipq8074.dtsi        | 12 ++++++------
 4 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
index b60b2d4c2ea5..b918543f6bb4 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
+++ b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /dts-v1/;
-/* Copyright (c) 2017, The Linux Foundation. All rights reserved.
+/*
+ * Copyright (c) 2017, The Linux Foundation. All rights reserved.
  */
 #include "ipq8074.dtsi"
 #include "pmp8074.dtsi"
diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dts b/arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dts
index 2bfcf42aeabc..cc1992ca0519 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dts
+++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dts
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/* Copyright (c) 2020 The Linux Foundation. All rights reserved.
+/*
+ * Copyright (c) 2020 The Linux Foundation. All rights reserved.
  */
 /dts-v1/;
 
diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dts b/arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dts
index 7da39f1d979b..d7f0efda6b8e 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dts
+++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dts
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /dts-v1/;
-/* Copyright (c) 2020 The Linux Foundation. All rights reserved.
+/*
+ * Copyright (c) 2020 The Linux Foundation. All rights reserved.
  */
 #include "ipq8074-hk10.dtsi"
 
diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index d3d9e7eb5837..8fd69a7b13dc 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -129,10 +129,10 @@ ssphy_1: phy@58000 {
 			status = "disabled";
 
 			usb1_ssphy: phy@58200 {
-				reg = <0x00058200 0x130>,       /* Tx */
+				reg = <0x00058200 0x130>,     /* Tx */
 				      <0x00058400 0x200>,     /* Rx */
-				      <0x00058800 0x1f8>,     /* PCS  */
-				      <0x00058600 0x044>;     /* PCS misc*/
+				      <0x00058800 0x1f8>,     /* PCS */
+				      <0x00058600 0x044>;     /* PCS misc */
 				#phy-cells = <0>;
 				#clock-cells = <0>;
 				clocks = <&gcc GCC_USB1_PIPE_CLK>;
@@ -172,10 +172,10 @@ ssphy_0: phy@78000 {
 			status = "disabled";
 
 			usb0_ssphy: phy@78200 {
-				reg = <0x00078200 0x130>,       /* Tx */
+				reg = <0x00078200 0x130>,     /* Tx */
 				      <0x00078400 0x200>,     /* Rx */
-				      <0x00078800 0x1f8>,     /* PCS  */
-				      <0x00078600 0x044>;     /* PCS misc*/
+				      <0x00078800 0x1f8>,     /* PCS */
+				      <0x00078600 0x044>;     /* PCS misc */
 				#phy-cells = <0>;
 				#clock-cells = <0>;
 				clocks = <&gcc GCC_USB0_PIPE_CLK>;
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 08/11] arm64: dts: qcom: msm8992-*: Fix up comments
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
                   ` (6 preceding siblings ...)
  2022-11-07 14:55 ` [PATCH 07/11] arm64: dts: qcom: ipq8074-*: " Konrad Dybcio
@ 2022-11-07 14:55 ` Konrad Dybcio
  2022-11-07 23:35   ` Petr Vorel
  2022-11-07 14:55 ` [PATCH 09/11] arm64: dts: qcom: msm8994-*: " Konrad Dybcio
                   ` (4 subsequent siblings)
  12 siblings, 1 reply; 15+ messages in thread
From: Konrad Dybcio @ 2022-11-07 14:55 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

Make sure all multiline C-style commends begin with just '/*' with
the comment text starting on a new line.

Also, trim off downstream regulator properties from comments to prevent
them from accidentally landing into mainline one day..

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 .../dts/qcom/msm8992-lg-bullhead-rev-10.dts   |  3 +-
 .../dts/qcom/msm8992-lg-bullhead-rev-101.dts  |  3 +-
 .../boot/dts/qcom/msm8992-lg-bullhead.dtsi    | 41 ++++++++++---------
 arch/arm64/boot/dts/qcom/msm8992.dtsi         |  3 +-
 4 files changed, 28 insertions(+), 22 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts
index 7e6bce4af441..4159fc35571a 100644
--- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts
+++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dts
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/* Copyright (c) Jean Thomas <virgule@jeanthomas.me>
+/*
+ * Copyright (c) Jean Thomas <virgule@jeanthomas.me>
  */
 
 /dts-v1/;
diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts
index e6a5ebd30e2f..ad9702dd171b 100644
--- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts
+++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/* Copyright (c) Jean Thomas <virgule@jeanthomas.me>
+/*
+ * Copyright (c) Jean Thomas <virgule@jeanthomas.me>
  */
 
 /dts-v1/;
diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
index aef92f3c49da..87c90e93667f 100644
--- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/* Copyright (c) 2015, LGE Inc. All rights reserved.
+/*
+ * Copyright (c) 2015, LGE Inc. All rights reserved.
  * Copyright (c) 2016, The Linux Foundation. All rights reserved.
  * Copyright (c) 2021, Petr Vorel <petr.vorel@gmail.com>
  */
@@ -236,9 +237,11 @@ pm8994_l25: l25 {
 		};
 
 		pm8994_l26: l26 {
-			/* TODO: value from downstream
-			regulator-min-microvolt = <987500>;
-			fails to apply */
+			/*
+			 * TODO: value from downstream
+			 * regulator-min-microvolt = <987500>;
+			 * fails to apply
+			 */
 		};
 
 		pm8994_l27: l27 {
@@ -252,19 +255,19 @@ pm8994_l28: l28 {
 		};
 
 		pm8994_l29: l29 {
-			/* TODO: Unsupported voltage range.
-			regulator-min-microvolt = <2800000>;
-			regulator-max-microvolt = <2800000>;
-			qcom,init-voltage = <2800000>;
-			*/
+			/*
+			 * TODO: Unsupported voltage range.
+			 * regulator-min-microvolt = <2800000>;
+			 * regulator-max-microvolt = <2800000>;
+			 */
 		};
 
 		pm8994_l30: l30 {
-			/* TODO: get this verified
-			regulator-min-microvolt = <1800000>;
-			regulator-max-microvolt = <1800000>;
-			qcom,init-voltage = <1800000>;
-			*/
+			/*
+			 * TODO: get this verified
+			 * regulator-min-microvolt = <1800000>;
+			 * regulator-max-microvolt = <1800000>;
+			 */
 		};
 
 		pm8994_l31: l31 {
@@ -273,11 +276,11 @@ pm8994_l31: l31 {
 		};
 
 		pm8994_l32: l32 {
-			/* TODO: get this verified
-			regulator-min-microvolt = <1800000>;
-			regulator-max-microvolt = <1800000>;
-			qcom,init-voltage = <1800000>;
-			*/
+			/*
+			 * TODO: get this verified
+			 * regulator-min-microvolt = <1800000>;
+			 * regulator-max-microvolt = <1800000>;
+			 */
 		};
 	};
 
diff --git a/arch/arm64/boot/dts/qcom/msm8992.dtsi b/arch/arm64/boot/dts/qcom/msm8992.dtsi
index 750643763a76..10adb4986ef1 100644
--- a/arch/arm64/boot/dts/qcom/msm8992.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8992.dtsi
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/* Copyright (c) 2013-2016, The Linux Foundation. All rights reserved.
+/*
+ * Copyright (c) 2013-2016, The Linux Foundation. All rights reserved.
  */
 
 #include "msm8994.dtsi"
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 09/11] arm64: dts: qcom: msm8994-*: Fix up comments
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
                   ` (7 preceding siblings ...)
  2022-11-07 14:55 ` [PATCH 08/11] arm64: dts: qcom: msm8992-*: " Konrad Dybcio
@ 2022-11-07 14:55 ` Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 10/11] arm64: dts: qcom: qcs404-*: " Konrad Dybcio
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Konrad Dybcio @ 2022-11-07 14:55 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

Make sure all multiline C-style commends begin with just '/*' with
the comment text starting on a new line.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts | 3 ++-
 arch/arm64/boot/dts/qcom/msm8994.dtsi                      | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts
index dbfbb77e9ff5..85abff0e9b3f 100644
--- a/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts
+++ b/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/* Copyright (c) 2015, Huawei Inc. All rights reserved.
+/*
+ * Copyright (c) 2015, Huawei Inc. All rights reserved.
  * Copyright (c) 2016, The Linux Foundation. All rights reserved.
  * Copyright (c) 2021-2022, Petr Vorel <petr.vorel@gmail.com>
  */
diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi
index ded5b7ceeaf9..8e6c24782ad7 100644
--- a/arch/arm64/boot/dts/qcom/msm8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/* Copyright (c) 2013-2016, The Linux Foundation. All rights reserved.
+/*
+ * Copyright (c) 2013-2016, The Linux Foundation. All rights reserved.
  */
 
 #include <dt-bindings/interrupt-controller/arm-gic.h>
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 10/11] arm64: dts: qcom: qcs404-*: Fix up comments
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
                   ` (8 preceding siblings ...)
  2022-11-07 14:55 ` [PATCH 09/11] arm64: dts: qcom: msm8994-*: " Konrad Dybcio
@ 2022-11-07 14:55 ` Konrad Dybcio
  2022-11-07 14:55 ` [PATCH 11/11] arm64: dts: qcom: pm6150/l/pm7325/pms405: " Konrad Dybcio
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Konrad Dybcio @ 2022-11-07 14:55 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

Switch '//' comments to C-style /* */.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/qcs404-evb-1000.dts | 4 +++-
 arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts | 4 +++-
 arch/arm64/boot/dts/qcom/qcs404-evb.dtsi     | 4 +++-
 arch/arm64/boot/dts/qcom/qcs404.dtsi         | 4 +++-
 4 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb-1000.dts b/arch/arm64/boot/dts/qcom/qcs404-evb-1000.dts
index 937eb4555ffe..fc29b194cd34 100644
--- a/arch/arm64/boot/dts/qcom/qcs404-evb-1000.dts
+++ b/arch/arm64/boot/dts/qcom/qcs404-evb-1000.dts
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
-// Copyright (c) 2018, Linaro Limited
+/*
+ * Copyright (c) 2018, Linaro Limited
+ */
 
 /dts-v1/;
 
diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts b/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts
index 08d5d51221cf..047b74d912a1 100644
--- a/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts
+++ b/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
-// Copyright (c) 2018, Linaro Limited
+/*
+ * Copyright (c) 2018, Linaro Limited
+ */
 
 /dts-v1/;
 
diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
index dbbe1653718b..c6f8b5b15825 100644
--- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
-// Copyright (c) 2018, Linaro Limited
+/*
+ * Copyright (c) 2018, Linaro Limited
+ */
 
 #include <dt-bindings/gpio/gpio.h>
 #include "qcs404.dtsi"
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index 80f2d05595fa..b4b89346b492 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
-// Copyright (c) 2018, Linaro Limited
+/*
+ * Copyright (c) 2018, Linaro Limited
+ */
 
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/clock/qcom,gcc-qcs404.h>
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 11/11] arm64: dts: qcom: pm6150/l/pm7325/pms405: Fix up comments
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
                   ` (9 preceding siblings ...)
  2022-11-07 14:55 ` [PATCH 10/11] arm64: dts: qcom: qcs404-*: " Konrad Dybcio
@ 2022-11-07 14:55 ` Konrad Dybcio
  2022-11-07 23:38 ` [PATCH 00/11] Minor DT comment cleanups Petr Vorel
  2022-11-08  1:27 ` Bjorn Andersson
  12 siblings, 0 replies; 15+ messages in thread
From: Konrad Dybcio @ 2022-11-07 14:55 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: patches, Konrad Dybcio, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, devicetree, linux-kernel

Make sure all multiline C-style commends begin with just '/*' with
the comment text starting on a new line.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/pm6150.dtsi  | 4 +++-
 arch/arm64/boot/dts/qcom/pm6150l.dtsi | 4 +++-
 arch/arm64/boot/dts/qcom/pm7325.dtsi  | 4 +++-
 arch/arm64/boot/dts/qcom/pms405.dtsi  | 4 +++-
 4 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/pm6150.dtsi b/arch/arm64/boot/dts/qcom/pm6150.dtsi
index 3cfd3eadccbf..3d91fb405ca2 100644
--- a/arch/arm64/boot/dts/qcom/pm6150.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm6150.dtsi
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: BSD-3-Clause
-// Copyright (c) 2019, The Linux Foundation. All rights reserved.
+/*
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
 
 #include <dt-bindings/iio/qcom,spmi-vadc.h>
 #include <dt-bindings/input/linux-event-codes.h>
diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
index 8a7c18b134c7..bab2e22835df 100644
--- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: BSD-3-Clause
-// Copyright (c) 2019, The Linux Foundation. All rights reserved.
+/*
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
 
 #include <dt-bindings/iio/qcom,spmi-vadc.h>
 #include <dt-bindings/interrupt-controller/irq.h>
diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
index cfd4b80c6e35..d1c5476af5ee 100644
--- a/arch/arm64/boot/dts/qcom/pm7325.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: BSD-3-Clause
-// Copyright (c) 2021, The Linux Foundation. All rights reserved.
+/*
+ * Copyright (c) 2021, The Linux Foundation. All rights reserved.
+ */
 
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/spmi/spmi.h>
diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi
index 634b0681d04c..ffe9e33808d0 100644
--- a/arch/arm64/boot/dts/qcom/pms405.dtsi
+++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
-// Copyright (c) 2018, Linaro Limited
+/*
+ * Copyright (c) 2018, Linaro Limited
+ */
 
 #include <dt-bindings/spmi/spmi.h>
 #include <dt-bindings/input/linux-event-codes.h>
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH 08/11] arm64: dts: qcom: msm8992-*: Fix up comments
  2022-11-07 14:55 ` [PATCH 08/11] arm64: dts: qcom: msm8992-*: " Konrad Dybcio
@ 2022-11-07 23:35   ` Petr Vorel
  0 siblings, 0 replies; 15+ messages in thread
From: Petr Vorel @ 2022-11-07 23:35 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: linux-arm-msm, andersson, agross, krzysztof.kozlowski, patches,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, devicetree,
	linux-kernel

Hi Konrad,

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 00/11] Minor DT comment cleanups
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
                   ` (10 preceding siblings ...)
  2022-11-07 14:55 ` [PATCH 11/11] arm64: dts: qcom: pm6150/l/pm7325/pms405: " Konrad Dybcio
@ 2022-11-07 23:38 ` Petr Vorel
  2022-11-08  1:27 ` Bjorn Andersson
  12 siblings, 0 replies; 15+ messages in thread
From: Petr Vorel @ 2022-11-07 23:38 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: linux-arm-msm, andersson, agross, krzysztof.kozlowski, patches

Hi Konrad,

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
for whole patchset.

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 00/11] Minor DT comment cleanups
  2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
                   ` (11 preceding siblings ...)
  2022-11-07 23:38 ` [PATCH 00/11] Minor DT comment cleanups Petr Vorel
@ 2022-11-08  1:27 ` Bjorn Andersson
  12 siblings, 0 replies; 15+ messages in thread
From: Bjorn Andersson @ 2022-11-08  1:27 UTC (permalink / raw)
  To: krzysztof.kozlowski, konrad.dybcio, linux-arm-msm, agross; +Cc: patches

On Mon, 7 Nov 2022 15:55:10 +0100, Konrad Dybcio wrote:
> Ensure the usage of C-style (/* */) comments instead of '//'.
> Make sure all multiline C-style commends begin with just '/*' with
> the comment text starting on a new line.
> 
> I also capitalized some comments differently and trimmed some fluff.
> 
> This patchset brings no functional change, purely for cosmetic and
> code style purposes.
> 
> [...]

Applied, thanks!

[01/11] arm64: dts: qcom: msm/apq8x16-*: Fix up comments
        commit: 4bb376f6cc715fb9182942df08d492965d5f0127
[02/11] arm64: dts: qcom: msm/apq8x96-*: Fix up comments
        commit: bd95b48a591cc0fd767b3c737b8d59cea5ff428d
[03/11] arm64: dts: qcom: msm8953: Fix up comments
        commit: 83e8692144fbda4a8f86087170d9ce26e64993d7
[04/11] arm64: dts: qcom: msm8998-*: Fix up comments
        commit: 689469ea4ce0fc17f1ddf2f5f730cb565bb5ef9c
[05/11] arm64: dts: qcom: sc8280xp-x13s: Fix up comments
        commit: b47fac7ab95b2567b6b39dae8dd66926368f2713
[06/11] arm64: dts: qcom: sdm845-*: Fix up comments
        commit: 108162894a5db9d1eba20650d050de27e730d818
[07/11] arm64: dts: qcom: ipq8074-*: Fix up comments
        commit: d5d8e59f356d426ba164ea37adfa629196b4fbd0
[08/11] arm64: dts: qcom: msm8992-*: Fix up comments
        commit: 290d43062d261cebd17ff590dc91f1d1e3fe6eed
[09/11] arm64: dts: qcom: msm8994-*: Fix up comments
        commit: 79b185d055703004aeb9252f2aa60ab03c868803
[10/11] arm64: dts: qcom: qcs404-*: Fix up comments
        commit: 3e3a2be79035a9e554ee5f62faf955601f85fca9
[11/11] arm64: dts: qcom: pm6150/l/pm7325/pms405: Fix up comments
        commit: 5d9bf21088fddefe681a70d061b78b9b58fb764b

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-11-08  1:27 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 14:55 [PATCH 00/11] Minor DT comment cleanups Konrad Dybcio
2022-11-07 14:55 ` [PATCH 01/11] arm64: dts: qcom: msm/apq8x16-*: Fix up comments Konrad Dybcio
2022-11-07 14:55 ` [PATCH 02/11] arm64: dts: qcom: msm/apq8x96-*: " Konrad Dybcio
2022-11-07 14:55 ` [PATCH 03/11] arm64: dts: qcom: msm8953: " Konrad Dybcio
2022-11-07 14:55 ` [PATCH 04/11] arm64: dts: qcom: msm8998-*: " Konrad Dybcio
2022-11-07 14:55 ` [PATCH 05/11] arm64: dts: qcom: sc8280xp-x13s: " Konrad Dybcio
2022-11-07 14:55 ` [PATCH 06/11] arm64: dts: qcom: sdm845-*: " Konrad Dybcio
2022-11-07 14:55 ` [PATCH 07/11] arm64: dts: qcom: ipq8074-*: " Konrad Dybcio
2022-11-07 14:55 ` [PATCH 08/11] arm64: dts: qcom: msm8992-*: " Konrad Dybcio
2022-11-07 23:35   ` Petr Vorel
2022-11-07 14:55 ` [PATCH 09/11] arm64: dts: qcom: msm8994-*: " Konrad Dybcio
2022-11-07 14:55 ` [PATCH 10/11] arm64: dts: qcom: qcs404-*: " Konrad Dybcio
2022-11-07 14:55 ` [PATCH 11/11] arm64: dts: qcom: pm6150/l/pm7325/pms405: " Konrad Dybcio
2022-11-07 23:38 ` [PATCH 00/11] Minor DT comment cleanups Petr Vorel
2022-11-08  1:27 ` Bjorn Andersson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.