[PATCH v2] recipes-support: gperftools: RDEPENDS for pprof

[PATCH v2] recipes-support: gperftools: RDEPENDS for pprof

[Cengiz Can]

gperftools comes with pprof tool that usually needs to be run at target
machine to aggregate CPUPROFILE data.

However since we were not shipping objdump (binutils), Getopt::long
and POSIX perl5 modules, it was failing.

I've extended RDEPENDS_${PN} with those so that whenever someone
installs gperftools, those dependencies are fulfilled as well.

Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
---
 meta-oe/recipes-support/gperftools/gperftools_2.7.bb | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta-oe/recipes-support/gperftools/gperftools_2.7.bb b/meta-oe/recipes-support/gperftools/gperftools_2.7.bb
index 731c83516..ee34acec2 100644
--- a/meta-oe/recipes-support/gperftools/gperftools_2.7.bb
+++ b/meta-oe/recipes-support/gperftools/gperftools_2.7.bb
@@ -35,5 +35,10 @@ PACKAGECONFIG[static] = "--enable-static,--disable-static,"

 PACKAGE_BEFORE_PN += "libtcmalloc-minimal"
 FILES_libtcmalloc-minimal = "${libdir}/libtcmalloc_minimal*${SOLIBS} ${libdir}/libtcmalloc_minimal_debug*${SOLIBS}"
+
+# pprof tool requires Getopt::long and POSIX perl5 modules.
+# Also runs `objdump` on each cpuprofile data file
+RDEPENDS_${PN} += "binutils perl-module-getopt-long perl-module-posix"
+
 RDEPENDS_${PN} += "libtcmalloc-minimal (= ${EXTENDPKGV})"

--
2.24.0

Re: [oe] [PATCH v2] recipes-support: gperftools: RDEPENDS for pprof

[nefethael]

Hi all,

I'm using mongodb with tcmalloc PACKAGECONFIG so it rdepends on gperftools.
Before this commit, my image didn't need perl, so I'm wondering if we
cannot split tcmalloc library or pprof tool in separate
gperftools-{tcmalloc,pprof} package?

Kind regards,
Vincent

Le jeu. 28 nov. 2019 à 16:38, Cengiz Can <cengiz@kernel.wtf> a écrit :
>
> gperftools comes with pprof tool that usually needs to be run at target
> machine to aggregate CPUPROFILE data.
>
> However since we were not shipping objdump (binutils), Getopt::long
> and POSIX perl5 modules, it was failing.
>
> I've extended RDEPENDS_${PN} with those so that whenever someone
> installs gperftools, those dependencies are fulfilled as well.
>
> Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
> ---
>  meta-oe/recipes-support/gperftools/gperftools_2.7.bb | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta-oe/recipes-support/gperftools/gperftools_2.7.bb b/meta-oe/recipes-support/gperftools/gperftools_2.7.bb
> index 731c83516..ee34acec2 100644
> --- a/meta-oe/recipes-support/gperftools/gperftools_2.7.bb
> +++ b/meta-oe/recipes-support/gperftools/gperftools_2.7.bb
> @@ -35,5 +35,10 @@ PACKAGECONFIG[static] = "--enable-static,--disable-static,"
>
>  PACKAGE_BEFORE_PN += "libtcmalloc-minimal"
>  FILES_libtcmalloc-minimal = "${libdir}/libtcmalloc_minimal*${SOLIBS} ${libdir}/libtcmalloc_minimal_debug*${SOLIBS}"
> +
> +# pprof tool requires Getopt::long and POSIX perl5 modules.
> +# Also runs `objdump` on each cpuprofile data file
> +RDEPENDS_${PN} += "binutils perl-module-getopt-long perl-module-posix"
> +
>  RDEPENDS_${PN} += "libtcmalloc-minimal (= ${EXTENDPKGV})"
>
> --
> 2.24.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel