* [U-Boot] [U-boot][SDP] Trigger watchdog before calling usb_gadget_handle_interrupts
@ 2017-10-23 9:16 Vincent Prince
2017-10-23 9:16 ` Vincent Prince
0 siblings, 1 reply; 6+ messages in thread
From: Vincent Prince @ 2017-10-23 9:16 UTC (permalink / raw)
To: u-boot
This prevents board resets when calling sdp command on boards which have a watchdog.
Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
---
drivers/usb/gadget/f_sdp.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c
index 0fae66b..c3eba6d 100644
--- a/drivers/usb/gadget/f_sdp.c
+++ b/drivers/usb/gadget/f_sdp.c
@@ -32,6 +32,7 @@
#include <spl.h>
#include <image.h>
#include <imximage.h>
+#include <watchdog.h>
#define HID_REPORT_ID_MASK 0x000000ff
@@ -602,6 +603,8 @@ int sdp_init(int controller_index)
puts("\rCTRL+C - Operation aborted.\n");
return 1;
}
+
+ WATCHDOG_RESET();
usb_gadget_handle_interrupts(controller_index);
}
@@ -712,6 +715,7 @@ void sdp_handle(int controller_index)
return;
}
+ WATCHDOG_RESET();
usb_gadget_handle_interrupts(controller_index);
sdp_handle_in_ep();
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [U-boot][SDP] Trigger watchdog before calling usb_gadget_handle_interrupts
2017-10-23 9:16 [U-Boot] [U-boot][SDP] Trigger watchdog before calling usb_gadget_handle_interrupts Vincent Prince
@ 2017-10-23 9:16 ` Vincent Prince
2017-10-26 11:25 ` Lukasz Majewski
0 siblings, 1 reply; 6+ messages in thread
From: Vincent Prince @ 2017-10-23 9:16 UTC (permalink / raw)
To: u-boot
This prevents board resets when calling sdp command on boards which have a watchdog.
Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
---
drivers/usb/gadget/f_sdp.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c
index 0fae66b..c3eba6d 100644
--- a/drivers/usb/gadget/f_sdp.c
+++ b/drivers/usb/gadget/f_sdp.c
@@ -32,6 +32,7 @@
#include <spl.h>
#include <image.h>
#include <imximage.h>
+#include <watchdog.h>
#define HID_REPORT_ID_MASK 0x000000ff
@@ -602,6 +603,8 @@ int sdp_init(int controller_index)
puts("\rCTRL+C - Operation aborted.\n");
return 1;
}
+
+ WATCHDOG_RESET();
usb_gadget_handle_interrupts(controller_index);
}
@@ -712,6 +715,7 @@ void sdp_handle(int controller_index)
return;
}
+ WATCHDOG_RESET();
usb_gadget_handle_interrupts(controller_index);
sdp_handle_in_ep();
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [U-boot][SDP] Trigger watchdog before calling usb_gadget_handle_interrupts
2017-10-23 9:16 ` Vincent Prince
@ 2017-10-26 11:25 ` Lukasz Majewski
2017-10-26 11:52 ` Stefan Agner
0 siblings, 1 reply; 6+ messages in thread
From: Lukasz Majewski @ 2017-10-26 11:25 UTC (permalink / raw)
To: u-boot
Hi Vincent,
> This prevents board resets when calling sdp command on boards which
> have a watchdog.
>
> Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
> ---
> drivers/usb/gadget/f_sdp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c
> index 0fae66b..c3eba6d 100644
> --- a/drivers/usb/gadget/f_sdp.c
> +++ b/drivers/usb/gadget/f_sdp.c
> @@ -32,6 +32,7 @@
> #include <spl.h>
> #include <image.h>
> #include <imximage.h>
> +#include <watchdog.h>
>
> #define HID_REPORT_ID_MASK 0x000000ff
>
> @@ -602,6 +603,8 @@ int sdp_init(int controller_index)
> puts("\rCTRL+C - Operation aborted.\n");
> return 1;
> }
> +
> + WATCHDOG_RESET();
> usb_gadget_handle_interrupts(controller_index);
> }
>
> @@ -712,6 +715,7 @@ void sdp_handle(int controller_index)
> return;
> }
>
> + WATCHDOG_RESET();
> usb_gadget_handle_interrupts(controller_index);
>
> sdp_handle_in_ep();
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [U-boot][SDP] Trigger watchdog before calling usb_gadget_handle_interrupts
2017-10-26 11:25 ` Lukasz Majewski
@ 2017-10-26 11:52 ` Stefan Agner
2017-11-07 13:26 ` Vincent Prince
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Agner @ 2017-10-26 11:52 UTC (permalink / raw)
To: u-boot
On 26.10.2017 13:25, Lukasz Majewski wrote:
> Hi Vincent,
>
>> This prevents board resets when calling sdp command on boards which
>> have a watchdog.
>>
>> Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
>> ---
>> drivers/usb/gadget/f_sdp.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c
>> index 0fae66b..c3eba6d 100644
>> --- a/drivers/usb/gadget/f_sdp.c
>> +++ b/drivers/usb/gadget/f_sdp.c
>> @@ -32,6 +32,7 @@
>> #include <spl.h>
>> #include <image.h>
>> #include <imximage.h>
>> +#include <watchdog.h>
>>
>> #define HID_REPORT_ID_MASK 0x000000ff
>>
>> @@ -602,6 +603,8 @@ int sdp_init(int controller_index)
>> puts("\rCTRL+C - Operation aborted.\n");
>> return 1;
>> }
>> +
>> + WATCHDOG_RESET();
>> usb_gadget_handle_interrupts(controller_index);
>> }
>>
>> @@ -712,6 +715,7 @@ void sdp_handle(int controller_index)
>> return;
>> }
>>
>> + WATCHDOG_RESET();
>> usb_gadget_handle_interrupts(controller_index);
>>
>> sdp_handle_in_ep();
> Reviewed-by: Lukasz Majewski <lukma@denx.de>
Thanks for the patch! Looks good to me too.
Reviewed-by: Stefan Agner <stefan.agner@toradex.com>
Best regards,
Stefan
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [U-boot][SDP] Trigger watchdog before calling usb_gadget_handle_interrupts
2017-10-26 11:52 ` Stefan Agner
@ 2017-11-07 13:26 ` Vincent Prince
2017-11-07 14:36 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Vincent Prince @ 2017-11-07 13:26 UTC (permalink / raw)
To: u-boot
Hi all,
It's my first patch contribution, do I need to do anything more ?
Best regards,
Vincent
2017-10-26 13:52 GMT+02:00 Stefan Agner <stefan.agner@toradex.com>:
>
>
> On 26.10.2017 13:25, Lukasz Majewski wrote:
> > Hi Vincent,
> >
> >> This prevents board resets when calling sdp command on boards which
> >> have a watchdog.
> >>
> >> Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
> >> ---
> >> drivers/usb/gadget/f_sdp.c | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c
> >> index 0fae66b..c3eba6d 100644
> >> --- a/drivers/usb/gadget/f_sdp.c
> >> +++ b/drivers/usb/gadget/f_sdp.c
> >> @@ -32,6 +32,7 @@
> >> #include <spl.h>
> >> #include <image.h>
> >> #include <imximage.h>
> >> +#include <watchdog.h>
> >>
> >> #define HID_REPORT_ID_MASK 0x000000ff
> >>
> >> @@ -602,6 +603,8 @@ int sdp_init(int controller_index)
> >> puts("\rCTRL+C - Operation aborted.\n");
> >> return 1;
> >> }
> >> +
> >> + WATCHDOG_RESET();
> >> usb_gadget_handle_interrupts(controller_index);
> >> }
> >>
> >> @@ -712,6 +715,7 @@ void sdp_handle(int controller_index)
> >> return;
> >> }
> >>
> >> + WATCHDOG_RESET();
> >> usb_gadget_handle_interrupts(controller_index);
> >>
> >> sdp_handle_in_ep();
> > Reviewed-by: Lukasz Majewski <lukma@denx.de>
>
> Thanks for the patch! Looks good to me too.
> Reviewed-by: Stefan Agner <stefan.agner@toradex.com>
>
> Best regards,
> Stefan
>
> >
> >
> > Best regards,
> >
> > Lukasz Majewski
> >
> > --
> >
> > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [U-boot][SDP] Trigger watchdog before calling usb_gadget_handle_interrupts
2017-11-07 13:26 ` Vincent Prince
@ 2017-11-07 14:36 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2017-11-07 14:36 UTC (permalink / raw)
To: u-boot
Hi Vincent,
On Tue, Nov 7, 2017 at 11:26 AM, Vincent Prince
<vincent.prince.fr@gmail.com> wrote:
> Hi all,
>
> It's my first patch contribution, do I need to do anything more ?
Your patch looks good.
Maybe Stefano can apply it for 2017.11.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-07 14:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-23 9:16 [U-Boot] [U-boot][SDP] Trigger watchdog before calling usb_gadget_handle_interrupts Vincent Prince
2017-10-23 9:16 ` Vincent Prince
2017-10-26 11:25 ` Lukasz Majewski
2017-10-26 11:52 ` Stefan Agner
2017-11-07 13:26 ` Vincent Prince
2017-11-07 14:36 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.