[PATCH] Staging: comedi: comedidev.h: fixed a warning

[PATCH] Staging: comedi: comedidev.h: fixed a warning

[srishti]

Fixed a warning : struct comedi_lrange is generally constant.

Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
 drivers/staging/comedi/comedidev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 1bb9986..82df090 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -623,7 +623,7 @@ extern const struct comedi_lrange range_unknown;
  * There may also be a flag that indicates the minimum and maximum are merely
  * scale factors for an unknown, external reference.
  */
-struct comedi_lrange {
+const struct comedi_lrange {
 	int length;
 	struct comedi_krange range[];
 };
-- 
2.7.4

Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning

[Dan Carpenter]

Compile test your patches.

regards,
dan carpenter

Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning

[Greg KH]

On Tue, May 16, 2017 at 02:00:23PM +0530, srishti wrote:
> Fixed a warning : struct comedi_lrange is generally constant.
> 
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>

As Dan pointed out, you _HAVE_ to test-build your changes.

Also, your "From:" line didn't match your signed-off-by line, so I
couldn't accept this anyway.

thanks,

greg k-h

Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning

[srishti sharma]

On Tue, May 16, 2017 at 2:45 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, May 16, 2017 at 02:00:23PM +0530, srishti wrote:
>> Fixed a warning : struct comedi_lrange is generally constant.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>
> As Dan pointed out, you _HAVE_ to test-build your changes.
>
> Also, your "From:" line didn't match your signed-off-by line, so I
> couldn't accept this anyway.
>
> thanks,
>
> greg k-h

Thanks for pointing out the error , but this patch is not needed as it
was for fixing a warning produced by checkpatch.pl that says struct
comedi_lrange is usually constant . But on building the code I get
another warning which says that the type qualifier is useless.

Regards,
Srishti