[PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Srishti Sharma]

Correct spelling of counter in comment .

Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
 drivers/staging/ccree/ssi_cipher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
index 8d31a93..99232b2 100644
--- a/drivers/staging/ccree/ssi_cipher.c
+++ b/drivers/staging/ccree/ssi_cipher.c
@@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,

 	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);

-	/*Set the inflight couter value to local variable*/
+	/*Set the inflight counter value to local variable*/
 	inflight_counter =  ctx_p->drvdata->inflight_counter;
 	/*Decrease the inflight counter*/
 	if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
--
2.7.4

[PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Srishti Sharma]

Correct spelling of counter in comment .

Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
 drivers/staging/ccree/ssi_cipher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
index 8d31a93..99232b2 100644
--- a/drivers/staging/ccree/ssi_cipher.c
+++ b/drivers/staging/ccree/ssi_cipher.c
@@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,

 	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);

-	/*Set the inflight couter value to local variable*/
+	/*Set the inflight counter value to local variable*/
 	inflight_counter =  ctx_p->drvdata->inflight_counter;
 	/*Decrease the inflight counter*/
 	if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
--
2.7.4

[PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Srishti Sharma]

Correct spelling of counter in comment .

Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
 drivers/staging/ccree/ssi_cipher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
index 8d31a93..99232b2 100644
--- a/drivers/staging/ccree/ssi_cipher.c
+++ b/drivers/staging/ccree/ssi_cipher.c
@@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,

 	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);

-	/*Set the inflight couter value to local variable*/
+	/*Set the inflight counter value to local variable*/
 	inflight_counter =  ctx_p->drvdata->inflight_counter;
 	/*Decrease the inflight counter*/
 	if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
--
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [Outreachy kernel] [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Julia Lawall]

On Thu, 7 Sep 2017, Srishti Sharma wrote:

> Correct spelling of counter in comment .


Welcome, and congratulations on submitting the first patch for this round
:)

> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
>  drivers/staging/ccree/ssi_cipher.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
> index 8d31a93..99232b2 100644
> --- a/drivers/staging/ccree/ssi_cipher.c
> +++ b/drivers/staging/ccree/ssi_cipher.c
> @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,
>
>  	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>
> -	/*Set the inflight couter value to local variable*/
> +	/*Set the inflight counter value to local variable*/

The change in itself looks fine, but actually the comment is kind of
incomprehensible.  It could be better as "Store ... in a local variable".
Also, the comment doesn't follow the kernel style.  Look at other comments
in this file or comments in other files to see what is wrong.

julia


>  	inflight_counter =  ctx_p->drvdata->inflight_counter;
>  	/*Decrease the inflight counter*/
>  	if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504725863-8495-1-git-send-email-srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Srishti Sharma]

[-- Attachment #1.1: Type: text/plain, Size: 1085 bytes --]



On Thursday, September 7, 2017 at 12:54:49 AM UTC+5:30, Srishti Sharma 
wrote:
>
> Correct spelling of counter in comment . 
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com> 
> --- 
>  drivers/staging/ccree/ssi_cipher.c | 2 +- 
>  1 file changed, 1 insertion(+), 1 deletion(-) 
>
> diff --git a/drivers/staging/ccree/ssi_cipher.c 
> b/drivers/staging/ccree/ssi_cipher.c 
> index 8d31a93..99232b2 100644 
> --- a/drivers/staging/ccree/ssi_cipher.c 
> +++ b/drivers/staging/ccree/ssi_cipher.c 
> @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev, 
>
>          ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, 
> dst); 
>
> -        /*Set the inflight couter value to local variable*/ 
> +        /*Set the inflight counter value to local variable*/ 
>          inflight_counter =  ctx_p->drvdata->inflight_counter; 
>          /*Decrease the inflight counter*/ 
>          if (ctx_p->flow_mode == BYPASS && 
> ctx_p->drvdata->inflight_counter > 0) 
> -- 
> 2.7.4 
>


Thanks for the feedback :) , I'll work on it ! 

Regards,
Srishti 

[-- Attachment #1.2: Type: text/html, Size: 1705 bytes --]

Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Srishti Sharma]

[-- Attachment #1.1: Type: text/plain, Size: 1202 bytes --]



On Thursday, September 7, 2017 at 12:54:49 AM UTC+5:30, Srishti Sharma 
wrote:
>
> Correct spelling of counter in comment . 
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com> 
> --- 
>  drivers/staging/ccree/ssi_cipher.c | 2 +- 
>  1 file changed, 1 insertion(+), 1 deletion(-) 
>
> diff --git a/drivers/staging/ccree/ssi_cipher.c 
> b/drivers/staging/ccree/ssi_cipher.c 
> index 8d31a93..99232b2 100644 
> --- a/drivers/staging/ccree/ssi_cipher.c 
> +++ b/drivers/staging/ccree/ssi_cipher.c 
> @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev, 
>
>          ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, 
> dst); 
>
> -        /*Set the inflight couter value to local variable*/ 
> +        /*Set the inflight counter value to local variable*/ 
>          inflight_counter =  ctx_p->drvdata->inflight_counter; 
>          /*Decrease the inflight counter*/ 
>          if (ctx_p->flow_mode == BYPASS && 
> ctx_p->drvdata->inflight_counter > 0) 
> -- 
> 2.7.4 
>

  Hey,

  Can I say , /* store the value of inflight_counter variable from  driver 
private data context to a local variable */  , to make it more 
comprehensible ? 

Regards,
Srishti 

[-- Attachment #1.2: Type: text/html, Size: 1830 bytes --]

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 2383 bytes --]



On Wed, 6 Sep 2017, Srishti Sharma wrote:

>
>
> On Thursday, September 7, 2017 at 12:54:49 AM UTC+5:30, Srishti Sharma
> wrote:
>       Correct spelling of counter in comment .
>
>       Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>       ---
>        drivers/staging/ccree/ssi_cipher.c | 2 +-
>        1 file changed, 1 insertion(+), 1 deletion(-)
>
>       diff --git a/drivers/staging/ccree/ssi_cipher.c
>       b/drivers/staging/ccree/ssi_cipher.c
>       index 8d31a93..99232b2 100644
>       --- a/drivers/staging/ccree/ssi_cipher.c
>       +++ b/drivers/staging/ccree/ssi_cipher.c
>       @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct
>       device *dev,
>
>                ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx,
>       ivsize, src, dst);
>
>       -        /*Set the inflight couter value to local variable*/
>       +        /*Set the inflight counter value to local variable*/
>                inflight_counter =  ctx_p->drvdata->inflight_counter;
>                /*Decrease the inflight counter*/
>                if (ctx_p->flow_mode == BYPASS &&
>       ctx_p->drvdata->inflight_counter > 0)
>       --
>       2.7.4
>
>
>   Hey,
>
>   Can I say , /* store the value of inflight_counter variable from  driver
> private data context to a local variable */  , to make it more
> comprehensible ? 

I think it could be a bit of overkill.  The "driver private data context"
part can be seen from a quick glance at the code.  Also, it could be good
to bring out the purpose rather than just what the code does.  So "save
inflight_counter in a a local variable" could be better, because it
focuses on the idea of saving some information for later use.  Good job on
figuring out the formatting problem.

julia

>
> Regards,
> Srishti 
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/2b8bde9c-6e84-48c5-ab93-
> 76127f314429%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Srishti Sharma]

[-- Attachment #1.1: Type: text/plain, Size: 1083 bytes --]



On Thursday, September 7, 2017 at 12:54:49 AM UTC+5:30, Srishti Sharma 
wrote:
>
> Correct spelling of counter in comment . 
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com> 
> --- 
>  drivers/staging/ccree/ssi_cipher.c | 2 +- 
>  1 file changed, 1 insertion(+), 1 deletion(-) 
>
> diff --git a/drivers/staging/ccree/ssi_cipher.c 
> b/drivers/staging/ccree/ssi_cipher.c 
> index 8d31a93..99232b2 100644 
> --- a/drivers/staging/ccree/ssi_cipher.c 
> +++ b/drivers/staging/ccree/ssi_cipher.c 
> @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev, 
>
>          ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, 
> dst); 
>
> -        /*Set the inflight couter value to local variable*/ 
> +        /*Set the inflight counter value to local variable*/ 
>          inflight_counter =  ctx_p->drvdata->inflight_counter; 
>          /*Decrease the inflight counter*/ 
>          if (ctx_p->flow_mode == BYPASS && 
> ctx_p->drvdata->inflight_counter > 0) 
> -- 
> 2.7.4 
>

Thanks a lot for this , I have re-sent a v2 !

Regards, 
Srishti 

[-- Attachment #1.2: Type: text/html, Size: 1685 bytes --]

Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Dan Carpenter]

On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote:
> Correct spelling of counter in comment .
> 
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
>  drivers/staging/ccree/ssi_cipher.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
> index 8d31a93..99232b2 100644
> --- a/drivers/staging/ccree/ssi_cipher.c
> +++ b/drivers/staging/ccree/ssi_cipher.c
> @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,
> 
>  	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
> 
> -	/*Set the inflight couter value to local variable*/
> +	/*Set the inflight counter value to local variable*/
>  	inflight_counter =  ctx_p->drvdata->inflight_counter;

Sure, but it would be better to just delete the comment.  It's obvious.
But really just delete the local inflight_counter variable as well
because that's never used.

regards,
dan carpenter

Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Dan Carpenter]

On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote:
> Correct spelling of counter in comment .
> 
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
>  drivers/staging/ccree/ssi_cipher.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
> index 8d31a93..99232b2 100644
> --- a/drivers/staging/ccree/ssi_cipher.c
> +++ b/drivers/staging/ccree/ssi_cipher.c
> @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,
> 
>  	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
> 
> -	/*Set the inflight couter value to local variable*/
> +	/*Set the inflight counter value to local variable*/
>  	inflight_counter =  ctx_p->drvdata->inflight_counter;

Sure, but it would be better to just delete the comment.  It's obvious.
But really just delete the local inflight_counter variable as well
because that's never used.

regards,
dan carpenter

Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Dan Carpenter]

On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote:
> Correct spelling of counter in comment .
> 
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
>  drivers/staging/ccree/ssi_cipher.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
> index 8d31a93..99232b2 100644
> --- a/drivers/staging/ccree/ssi_cipher.c
> +++ b/drivers/staging/ccree/ssi_cipher.c
> @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,
> 
>  	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
> 
> -	/*Set the inflight couter value to local variable*/
> +	/*Set the inflight counter value to local variable*/
>  	inflight_counter =  ctx_p->drvdata->inflight_counter;

Sure, but it would be better to just delete the comment.  It's obvious.
But really just delete the local inflight_counter variable as well
because that's never used.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Srishti Sharma]

On Thu, Sep 7, 2017 at 2:29 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote:
>> Correct spelling of counter in comment .
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>> ---
>>  drivers/staging/ccree/ssi_cipher.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
>> index 8d31a93..99232b2 100644
>> --- a/drivers/staging/ccree/ssi_cipher.c
>> +++ b/drivers/staging/ccree/ssi_cipher.c
>> @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,
>>
>>       ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>>
>> -     /*Set the inflight couter value to local variable*/
>> +     /*Set the inflight counter value to local variable*/
>>       inflight_counter =  ctx_p->drvdata->inflight_counter;
>
> Sure, but it would be better to just delete the comment.  It's obvious.
> But really just delete the local inflight_counter variable as well
> because that's never used.

  Okay, I'll delete it .
>
> regards,
> dan carpenter
>

Regards,
Srishti

Re: [PATCH] Staging: ccree: ssi_cipher.c: Correct spelling mistake.

[Srishti Sharma]

On Thu, Sep 7, 2017 at 2:29 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote:
>> Correct spelling of counter in comment .
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>> ---
>>  drivers/staging/ccree/ssi_cipher.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
>> index 8d31a93..99232b2 100644
>> --- a/drivers/staging/ccree/ssi_cipher.c
>> +++ b/drivers/staging/ccree/ssi_cipher.c
>> @@ -702,7 +702,7 @@ static int ssi_blkcipher_complete(struct device *dev,
>>
>>       ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>>
>> -     /*Set the inflight couter value to local variable*/
>> +     /*Set the inflight counter value to local variable*/
>>       inflight_counter =  ctx_p->drvdata->inflight_counter;
>
> Sure, but it would be better to just delete the comment.  It's obvious.
> But really just delete the local inflight_counter variable as well
> because that's never used.

  Okay, I'll delete it .
>
> regards,
> dan carpenter
>

Regards,
Srishti
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel