[PATCH v3 0/3] ARM:i.MX fix compile errors and warnings

[PATCH v3 0/3] ARM:i.MX fix compile errors and warnings

[Jason Liu]

This patch-set fix the compile errors and warnings on i.MX

Jason Liu (3):
  ARM:i.MX: fix build error in tzic/avic.c
  ARM:i.MX: fix the build error in clock-mx51-mx53.c
  ARM:i.MX: fix the compile warnings in clock-mx51-mx53.c

 arch/arm/mach-mx5/clock-mx51-mx53.c |    4 ++++
 arch/arm/plat-mxc/avic.c            |    1 +
 arch/arm/plat-mxc/tzic.c            |    1 +
 3 files changed, 6 insertions(+), 0 deletions(-)

-- 
1.7.4.1

[PATCH v3 1/3] ARM:i.MX: fix build error in tzic/avic.c

[Jason Liu]

arch/arm/plat-mxc/tzic.c:105: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'tzic_handle_irq'

Signed-off-by: Jason Liu <jason.hui@linaro.org>
---
 arch/arm/plat-mxc/avic.c |    1 +
 arch/arm/plat-mxc/tzic.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-mxc/avic.c b/arch/arm/plat-mxc/avic.c
index 8875fb4..55f1569 100644
--- a/arch/arm/plat-mxc/avic.c
+++ b/arch/arm/plat-mxc/avic.c
@@ -22,6 +22,7 @@
 #include <linux/io.h>
 #include <mach/common.h>
 #include <asm/mach/irq.h>
+#include <asm/exception.h>
 #include <mach/hardware.h>
 
 #include "irq-common.h"
diff --git a/arch/arm/plat-mxc/tzic.c b/arch/arm/plat-mxc/tzic.c
index e993a18..a3c164c 100644
--- a/arch/arm/plat-mxc/tzic.c
+++ b/arch/arm/plat-mxc/tzic.c
@@ -17,6 +17,7 @@
 #include <linux/io.h>
 
 #include <asm/mach/irq.h>
+#include <asm/exception.h>
 
 #include <mach/hardware.h>
 #include <mach/common.h>
-- 
1.7.4.1

[PATCH] ARM: mx25: Add the missing IIM base definition

[Jason Liu]

This fix the mx25 building issue of no IIM base definition

Signed-off-by: Jason Liu <jason.hui@linaro.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/plat-mxc/include/mach/mx25.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-mxc/include/mach/mx25.h b/arch/arm/plat-mxc/include/mach/mx25.h
index 8dcab80..ccebf5b 100644
--- a/arch/arm/plat-mxc/include/mach/mx25.h
+++ b/arch/arm/plat-mxc/include/mach/mx25.h
@@ -41,6 +41,7 @@
 #define MX25_SSI2_BASE_ADDR		0x50014000
 #define MX25_SSI1_BASE_ADDR		0x50034000
 #define MX25_NFC_BASE_ADDR		0xbb000000
+#define MX25_IIM_BASE_ADDR		0x53ff0000
 #define MX25_DRYICE_BASE_ADDR		0x53ffc000
 #define MX25_ESDHC1_BASE_ADDR		0x53fb4000
 #define MX25_ESDHC2_BASE_ADDR		0x53fb8000
-- 
1.7.4.1

[PATCH] slub: doc: update the slabinfo.c file path

[Jason Liu]

slabinfo.c has been moved from Documentaion/vm/ to
tools/slub/ by commit:0d24db337e6d81c0c620ab65cc6947bd6553f742

Update the slub.txt doc to reflect this change too.

Signed-off-by: Jason Liu <jason.hui@linaro.org>
Cc: Christoph Lameter <cl@linux-foundation.org>
---
 Documentation/vm/00-INDEX |    2 --
 Documentation/vm/slub.txt |    2 +-
 2 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/Documentation/vm/00-INDEX b/Documentation/vm/00-INDEX
index dca82d7..5481c8b 100644
--- a/Documentation/vm/00-INDEX
+++ b/Documentation/vm/00-INDEX
@@ -30,8 +30,6 @@ page_migration
 	- description of page migration in NUMA systems.
 pagemap.txt
 	- pagemap, from the userspace perspective
-slabinfo.c
-	- source code for a tool to get reports about slabs.
 slub.txt
 	- a short users guide for SLUB.
 unevictable-lru.txt
diff --git a/Documentation/vm/slub.txt b/Documentation/vm/slub.txt
index 07375e7..f464f47 100644
--- a/Documentation/vm/slub.txt
+++ b/Documentation/vm/slub.txt
@@ -17,7 +17,7 @@ data and perform operation on the slabs. By default slabinfo only lists
 slabs that have data in them. See "slabinfo -h" for more options when
 running the command. slabinfo can be compiled with
 
-gcc -o slabinfo Documentation/vm/slabinfo.c
+gcc -o slabinfo tools/slub/slabinfo.c
 
 Some of the modes of operation of slabinfo require that slub debugging
 be enabled on the command line. F.e. no tracking information will be
-- 
1.7.4.1

[PATCH v3 2/3] ARM:i.MX: fix the build error in clock-mx51-mx53.c

[Jason Liu]

arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'clk_get_freq_dt':
arch/arm/mach-mx5/clock-mx51-mx53.c:1643: error: implicit declaration of function 'for_each_compatible_node'
arch/arm/mach-mx5/clock-mx51-mx53.c:1643: error: expected ';' before '{' token

Signed-off-by: Jason Liu <jason.hui@linaro.org>
---
 arch/arm/mach-mx5/clock-mx51-mx53.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c
index 2aacf41..7c373b83 100644
--- a/arch/arm/mach-mx5/clock-mx51-mx53.c
+++ b/arch/arm/mach-mx5/clock-mx51-mx53.c
@@ -1637,6 +1637,7 @@ int __init mx53_clocks_init(unsigned long ckil, unsigned long osc,
 static void __init clk_get_freq_dt(unsigned long *ckil, unsigned long *osc,
 				   unsigned long *ckih1, unsigned long *ckih2)
 {
+#ifdef CONFIG_OF
 	struct device_node *np;
 
 	/* retrieve the freqency of fixed clocks from device tree */
@@ -1654,6 +1655,7 @@ static void __init clk_get_freq_dt(unsigned long *ckil, unsigned long *osc,
 		else if (of_device_is_compatible(np, "fsl,imx-ckih2"))
 			*ckih2 = rate;
 	}
+#endif
 }
 
 int __init mx51_clocks_init_dt(void)
-- 
1.7.4.1

[PATCH v3 3/3] ARM:i.MX: fix the compile warnings in clock-mx51-mx53.c

[Jason Liu]

arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'clk_get_freq_dt':
arch/arm/mach-mx5/clock-mx51-mx53.c:1640: warning: unused variable 'np'
arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'mx53_clocks_init_dt':
arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckil' is used uninitialized in this function
arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'osc' is used uninitialized in this function
arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckih1' is used uninitialized in this function
arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckih2' is used uninitialized in this function
arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'mx51_clocks_init_dt':
arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckil' is used uninitialized in this function
arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'osc' is used uninitialized in this function
arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckih1' is used uninitialized in this function
arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckih2' is used uninitialized in this function

Signed-off-by: Jason Liu <jason.hui@linaro.org>
---
 arch/arm/mach-mx5/clock-mx51-mx53.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c
index 7c373b83..e352a5a 100644
--- a/arch/arm/mach-mx5/clock-mx51-mx53.c
+++ b/arch/arm/mach-mx5/clock-mx51-mx53.c
@@ -1662,6 +1662,7 @@ int __init mx51_clocks_init_dt(void)
 {
 	unsigned long ckil, osc, ckih1, ckih2;
 
+	ckil = osc = ckih1 = ckih2 = 0;
 	clk_get_freq_dt(&ckil, &osc, &ckih1, &ckih2);
 	return mx51_clocks_init(ckil, osc, ckih1, ckih2);
 }
@@ -1670,6 +1671,7 @@ int __init mx53_clocks_init_dt(void)
 {
 	unsigned long ckil, osc, ckih1, ckih2;
 
+	ckil = osc = ckih1 = ckih2 = 0;
 	clk_get_freq_dt(&ckil, &osc, &ckih1, &ckih2);
 	return mx53_clocks_init(ckil, osc, ckih1, ckih2);
 }
-- 
1.7.4.1

[PATCH] slub: doc: update the slabinfo.c file path

[Russell King - ARM Linux]

On Wed, Nov 02, 2011 at 07:03:54PM +0800, Jason Liu wrote:
> slabinfo.c has been moved from Documentaion/vm/ to
> tools/slub/ by commit:0d24db337e6d81c0c620ab65cc6947bd6553f742
> 
> Update the slub.txt doc to reflect this change too.
> 
> Signed-off-by: Jason Liu <jason.hui@linaro.org>
> Cc: Christoph Lameter <cl@linux-foundation.org>

This patch shouldn't be part of this patch set; there is nothing IMX
specific with it.  It is purely a stand-alone bug fix and, therefore,
it should stand completely alone as its own patch.

You're not even copying it to those who you claim to be doing so in the
commit log above.

It should be copied to the appropriate people and mailing lists.

[PATCH] slub: doc: update the slabinfo.c file path

[Jason Liu]

2011/11/2 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> On Wed, Nov 02, 2011 at 07:03:54PM +0800, Jason Liu wrote:
>> slabinfo.c has been moved from Documentaion/vm/ to
>> tools/slub/ by commit:0d24db337e6d81c0c620ab65cc6947bd6553f742
>>
>> Update the slub.txt doc to reflect this change too.
>>
>> Signed-off-by: Jason Liu <jason.hui@linaro.org>
>> Cc: Christoph Lameter <cl@linux-foundation.org>
>
> This patch shouldn't be part of this patch set; there is nothing IMX
> specific with it. ?It is purely a stand-alone bug fix and, therefore,
> it should stand completely alone as its own patch.
>
> You're not even copying it to those who you claim to be doing so in the
> commit log above.
>
> It should be copied to the appropriate people and mailing lists.

Please ignore this patch since this patch has already gone to the next.
Sorry for that.

Jason Liu

>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

[PATCH] ARM: mx25: Add the missing IIM base definition

[Jason Liu]

Hi, Sascha

2011/11/2 Jason Liu <jason.hui@linaro.org>:
> This fix the mx25 building issue of no IIM base definition
>
> Signed-off-by: Jason Liu <jason.hui@linaro.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> ?arch/arm/plat-mxc/include/mach/mx25.h | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-mxc/include/mach/mx25.h b/arch/arm/plat-mxc/include/mach/mx25.h
> index 8dcab80..ccebf5b 100644
> --- a/arch/arm/plat-mxc/include/mach/mx25.h
> +++ b/arch/arm/plat-mxc/include/mach/mx25.h
> @@ -41,6 +41,7 @@
> ?#define MX25_SSI2_BASE_ADDR ? ? ? ? ? ?0x50014000
> ?#define MX25_SSI1_BASE_ADDR ? ? ? ? ? ?0x50034000
> ?#define MX25_NFC_BASE_ADDR ? ? ? ? ? ? 0xbb000000
> +#define MX25_IIM_BASE_ADDR ? ? ? ? ? ? 0x53ff0000
> ?#define MX25_DRYICE_BASE_ADDR ? ? ? ? ?0x53ffc000
> ?#define MX25_ESDHC1_BASE_ADDR ? ? ? ? ?0x53fb4000
> ?#define MX25_ESDHC2_BASE_ADDR ? ? ? ? ?0x53fb8000

Please ignore this patch, sorry for that.

Jason Liu
> --
> 1.7.4.1
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

[PATCH v3 3/3] ARM:i.MX: fix the compile warnings in clock-mx51-mx53.c

[Sascha Hauer]

On Wed, Nov 02, 2011 at 07:03:56PM +0800, Jason Liu wrote:
> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'clk_get_freq_dt':
> arch/arm/mach-mx5/clock-mx51-mx53.c:1640: warning: unused variable 'np'
> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'mx53_clocks_init_dt':
> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckil' is used uninitialized in this function
> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'osc' is used uninitialized in this function
> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckih1' is used uninitialized in this function
> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckih2' is used uninitialized in this function
> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'mx51_clocks_init_dt':
> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckil' is used uninitialized in this function
> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'osc' is used uninitialized in this function
> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckih1' is used uninitialized in this function
> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckih2' is used uninitialized in this function

You only get this warning because you have put the code in
clk_get_freq_dt into #ifdef CONFIG_OF in the last patch. Instead please
put the whole block including clk_get_freq_dt, mx51_clocks_init_dt and
mx53_clocks_init_dt into #ifdef CONFIG_OF.

Sascha

> 
> Signed-off-by: Jason Liu <jason.hui@linaro.org>
> ---
>  arch/arm/mach-mx5/clock-mx51-mx53.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c
> index 7c373b83..e352a5a 100644
> --- a/arch/arm/mach-mx5/clock-mx51-mx53.c
> +++ b/arch/arm/mach-mx5/clock-mx51-mx53.c
> @@ -1662,6 +1662,7 @@ int __init mx51_clocks_init_dt(void)
>  {
>  	unsigned long ckil, osc, ckih1, ckih2;
>  
> +	ckil = osc = ckih1 = ckih2 = 0;
>  	clk_get_freq_dt(&ckil, &osc, &ckih1, &ckih2);
>  	return mx51_clocks_init(ckil, osc, ckih1, ckih2);
>  }
> @@ -1670,6 +1671,7 @@ int __init mx53_clocks_init_dt(void)
>  {
>  	unsigned long ckil, osc, ckih1, ckih2;
>  
> +	ckil = osc = ckih1 = ckih2 = 0;
>  	clk_get_freq_dt(&ckil, &osc, &ckih1, &ckih2);
>  	return mx53_clocks_init(ckil, osc, ckih1, ckih2);
>  }
> -- 
> 1.7.4.1
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH v3 3/3] ARM:i.MX: fix the compile warnings in clock-mx51-mx53.c

[Jason Liu]

2011/11/3 Sascha Hauer <s.hauer@pengutronix.de>:
> On Wed, Nov 02, 2011 at 07:03:56PM +0800, Jason Liu wrote:
>> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'clk_get_freq_dt':
>> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'mx53_clocks_init_dt':
>> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckil' is used uninitialized in this function
>> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'osc' is used uninitialized in this function
>> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckih1' is used uninitialized in this function
>> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckih2' is used uninitialized in this function
>> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'mx51_clocks_init_dt':
>> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckil' is used uninitialized in this function
>> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'osc' is used uninitialized in this function
>> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckih1' is used uninitialized in this function
>> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckih2' is used uninitialized in this function
>
> You only get this warning because you have put the code in
> clk_get_freq_dt into #ifdef CONFIG_OF in the last patch. Instead please
> put the whole block including clk_get_freq_dt, mx51_clocks_init_dt and
> mx53_clocks_init_dt into #ifdef CONFIG_OF.

Yes, I can put #ifdef CONFIG_OF to cover the whole block including
clk_get_freq_dt/
mx51_clocks_init_dt/mx53_clocks_init_dt, but after enable CONFIG_OF,
you still will
meet these compiling warnings.

But refer to grant before, we don't need place #ifdef CONFIG_OF #endif into
the .c file, no-matter enable device_tree support or not. I'm not sure
why we still
meet compile error, shawn, any comments?

Jason Liu

> Sascha
>
>>
>> Signed-off-by: Jason Liu <jason.hui@linaro.org>
>> ---
>> ?arch/arm/mach-mx5/clock-mx51-mx53.c | ? ?2 ++
>> ?1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c
>> index 7c373b83..e352a5a 100644
>> --- a/arch/arm/mach-mx5/clock-mx51-mx53.c
>> +++ b/arch/arm/mach-mx5/clock-mx51-mx53.c
>> @@ -1662,6 +1662,7 @@ int __init mx51_clocks_init_dt(void)
>> ?{
>> ? ? ? unsigned long ckil, osc, ckih1, ckih2;
>>
>> + ? ? ckil = osc = ckih1 = ckih2 = 0;
>> ? ? ? clk_get_freq_dt(&ckil, &osc, &ckih1, &ckih2);
>> ? ? ? return mx51_clocks_init(ckil, osc, ckih1, ckih2);
>> ?}
>> @@ -1670,6 +1671,7 @@ int __init mx53_clocks_init_dt(void)
>> ?{
>> ? ? ? unsigned long ckil, osc, ckih1, ckih2;
>>
>> + ? ? ckil = osc = ckih1 = ckih2 = 0;
>> ? ? ? clk_get_freq_dt(&ckil, &osc, &ckih1, &ckih2);
>> ? ? ? return mx53_clocks_init(ckil, osc, ckih1, ckih2);
>> ?}
>> --
>> 1.7.4.1
>>
>>
>>
>
> --
> Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ? ? ? ? ? ? ? ? ? ? ? ? ? |
> Industrial Linux Solutions ? ? ? ? ? ? ? ? | http://www.pengutronix.de/ ?|
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 ? ?|
> Amtsgericht Hildesheim, HRA 2686 ? ? ? ? ? | Fax: ? +49-5121-206917-5555 |
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

[PATCH v3 3/3] ARM:i.MX: fix the compile warnings in clock-mx51-mx53.c

[Sascha Hauer]

On Thu, Nov 03, 2011 at 03:36:05PM +0800, Jason Liu wrote:
> 2011/11/3 Sascha Hauer <s.hauer@pengutronix.de>:
> > On Wed, Nov 02, 2011 at 07:03:56PM +0800, Jason Liu wrote:
> >> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'clk_get_freq_dt':
> >> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'mx53_clocks_init_dt':
> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckil' is used uninitialized in this function
> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'osc' is used uninitialized in this function
> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckih1' is used uninitialized in this function
> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckih2' is used uninitialized in this function
> >> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'mx51_clocks_init_dt':
> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckil' is used uninitialized in this function
> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'osc' is used uninitialized in this function
> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckih1' is used uninitialized in this function
> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckih2' is used uninitialized in this function
> >
> > You only get this warning because you have put the code in
> > clk_get_freq_dt into #ifdef CONFIG_OF in the last patch. Instead please
> > put the whole block including clk_get_freq_dt, mx51_clocks_init_dt and
> > mx53_clocks_init_dt into #ifdef CONFIG_OF.
> 
> Yes, I can put #ifdef CONFIG_OF to cover the whole block including
> clk_get_freq_dt/
> mx51_clocks_init_dt/mx53_clocks_init_dt, but after enable CONFIG_OF,
> you still will
> meet these compiling warnings.

I just tried it and no, I do not get any compiler warnings.

When passing the address of a variable to a function gcc considers this
variable as initialized after that, unless the function is a static
inline function and gcc can see that it actually does not get
initialized.
I hope this hasn't changed with gcc 4.6

> 
> But refer to grant before, we don't need place #ifdef CONFIG_OF #endif into
> the .c file, no-matter enable device_tree support or not. I'm not sure
> why we still
> meet compile error, shawn, any comments?

for_each_compatible_node is inside #ifdef CONFIG_OF in the header file.
So unless there are plans to provide some dummy stub for this without
CONFIG_OF I see no way around these ifdefs.

> 
> Jason Liu
> 
> > Sascha
> >
> >>
> >> Signed-off-by: Jason Liu <jason.hui@linaro.org>
> >> ---
> >> ?arch/arm/mach-mx5/clock-mx51-mx53.c | ? ?2 ++
> >> ?1 files changed, 2 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c
> >> index 7c373b83..e352a5a 100644
> >> --- a/arch/arm/mach-mx5/clock-mx51-mx53.c
> >> +++ b/arch/arm/mach-mx5/clock-mx51-mx53.c
> >> @@ -1662,6 +1662,7 @@ int __init mx51_clocks_init_dt(void)
> >> ?{
> >> ? ? ? unsigned long ckil, osc, ckih1, ckih2;
> >>
> >> + ? ? ckil = osc = ckih1 = ckih2 = 0;
> >> ? ? ? clk_get_freq_dt(&ckil, &osc, &ckih1, &ckih2);
> >> ? ? ? return mx51_clocks_init(ckil, osc, ckih1, ckih2);
> >> ?}
> >> @@ -1670,6 +1671,7 @@ int __init mx53_clocks_init_dt(void)
> >> ?{
> >> ? ? ? unsigned long ckil, osc, ckih1, ckih2;
> >>
> >> + ? ? ckil = osc = ckih1 = ckih2 = 0;
> >> ? ? ? clk_get_freq_dt(&ckil, &osc, &ckih1, &ckih2);
> >> ? ? ? return mx53_clocks_init(ckil, osc, ckih1, ckih2);
> >> ?}
> >> --
> >> 1.7.4.1
> >>
> >>
> >>
> >
> > --
> > Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ? ? ? ? ? ? ? ? ? ? ? ? ? |
> > Industrial Linux Solutions ? ? ? ? ? ? ? ? | http://www.pengutronix.de/ ?|
> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 ? ?|
> > Amtsgericht Hildesheim, HRA 2686 ? ? ? ? ? | Fax: ? +49-5121-206917-5555 |
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH v3 3/3] ARM:i.MX: fix the compile warnings in clock-mx51-mx53.c

[Jason Liu]

2011/11/3 Sascha Hauer <s.hauer@pengutronix.de>:
> On Thu, Nov 03, 2011 at 03:36:05PM +0800, Jason Liu wrote:
>> 2011/11/3 Sascha Hauer <s.hauer@pengutronix.de>:
>> > On Wed, Nov 02, 2011 at 07:03:56PM +0800, Jason Liu wrote:
>> >> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'clk_get_freq_dt':
>> >> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'mx53_clocks_init_dt':
>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckil' is used uninitialized in this function
>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'osc' is used uninitialized in this function
>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckih1' is used uninitialized in this function
>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckih2' is used uninitialized in this function
>> >> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'mx51_clocks_init_dt':
>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckil' is used uninitialized in this function
>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'osc' is used uninitialized in this function
>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckih1' is used uninitialized in this function
>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckih2' is used uninitialized in this function
>> >
>> > You only get this warning because you have put the code in
>> > clk_get_freq_dt into #ifdef CONFIG_OF in the last patch. Instead please
>> > put the whole block including clk_get_freq_dt, mx51_clocks_init_dt and
>> > mx53_clocks_init_dt into #ifdef CONFIG_OF.
>>
>> Yes, I can put #ifdef CONFIG_OF to cover the whole block including
>> clk_get_freq_dt/
>> mx51_clocks_init_dt/mx53_clocks_init_dt, but after enable CONFIG_OF,
>> you still will
>> meet these compiling warnings.
>
> I just tried it and no, I do not get any compiler warnings.

OK, thanks.

>
> When passing the address of a variable to a function gcc considers this
> variable as initialized after that, unless the function is a static
> inline function and gcc can see that it actually does not get
> initialized.
> I hope this hasn't changed with gcc 4.6

you right. After move the #ifdef to cover all the dt related, I did
not get any compile
warnings. I will update this patch soon. see v2 for it.

Jason Liu

>
>>
>> But refer to grant before, we don't need place #ifdef CONFIG_OF #endif into
>> the .c file, no-matter enable device_tree support or not. I'm not sure
>> why we still
>> meet compile error, shawn, any comments?
>
> for_each_compatible_node is inside #ifdef CONFIG_OF in the header file.
> So unless there are plans to provide some dummy stub for this without
> CONFIG_OF I see no way around these ifdefs.
>
>>
>> Jason Liu
>>
>> > Sascha
>> >
>> >>
>> >> Signed-off-by: Jason Liu <jason.hui@linaro.org>
>> >> ---
>> >> ?arch/arm/mach-mx5/clock-mx51-mx53.c | ? ?2 ++
>> >> ?1 files changed, 2 insertions(+), 0 deletions(-)
>> >>
>> >> diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c
>> >> index 7c373b83..e352a5a 100644
>> >> --- a/arch/arm/mach-mx5/clock-mx51-mx53.c
>> >> +++ b/arch/arm/mach-mx5/clock-mx51-mx53.c
>> >> @@ -1662,6 +1662,7 @@ int __init mx51_clocks_init_dt(void)
>> >> ?{
>> >> ? ? ? unsigned long ckil, osc, ckih1, ckih2;
>> >>
>> >> + ? ? ckil = osc = ckih1 = ckih2 = 0;
>> >> ? ? ? clk_get_freq_dt(&ckil, &osc, &ckih1, &ckih2);
>> >> ? ? ? return mx51_clocks_init(ckil, osc, ckih1, ckih2);
>> >> ?}
>> >> @@ -1670,6 +1671,7 @@ int __init mx53_clocks_init_dt(void)
>> >> ?{
>> >> ? ? ? unsigned long ckil, osc, ckih1, ckih2;
>> >>
>> >> + ? ? ckil = osc = ckih1 = ckih2 = 0;
>> >> ? ? ? clk_get_freq_dt(&ckil, &osc, &ckih1, &ckih2);
>> >> ? ? ? return mx53_clocks_init(ckil, osc, ckih1, ckih2);
>> >> ?}
>> >> --
>> >> 1.7.4.1
>> >>
>> >>
>> >>
>> >
>> > --
>> > Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ? ? ? ? ? ? ? ? ? ? ? ? ? |
>> > Industrial Linux Solutions ? ? ? ? ? ? ? ? | http://www.pengutronix.de/ ?|
>> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 ? ?|
>> > Amtsgericht Hildesheim, HRA 2686 ? ? ? ? ? | Fax: ? +49-5121-206917-5555 |
>> >
>> > _______________________________________________
>> > linux-arm-kernel mailing list
>> > linux-arm-kernel at lists.infradead.org
>> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>> >
>>
>
> --
> Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ? ? ? ? ? ? ? ? ? ? ? ? ? |
> Industrial Linux Solutions ? ? ? ? ? ? ? ? | http://www.pengutronix.de/ ?|
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 ? ?|
> Amtsgericht Hildesheim, HRA 2686 ? ? ? ? ? | Fax: ? +49-5121-206917-5555 |
>

[PATCH v3 3/3] ARM:i.MX: fix the compile warnings in clock-mx51-mx53.c

[Jason Liu]

2011/11/3 Jason Liu <liu.h.jason@gmail.com>:
> 2011/11/3 Sascha Hauer <s.hauer@pengutronix.de>:
>> On Thu, Nov 03, 2011 at 03:36:05PM +0800, Jason Liu wrote:
>>> 2011/11/3 Sascha Hauer <s.hauer@pengutronix.de>:
>>> > On Wed, Nov 02, 2011 at 07:03:56PM +0800, Jason Liu wrote:
>>> >> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'clk_get_freq_dt':
>>> >> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'mx53_clocks_init_dt':
>>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckil' is used uninitialized in this function
>>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'osc' is used uninitialized in this function
>>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckih1' is used uninitialized in this function
>>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1673: warning: 'ckih2' is used uninitialized in this function
>>> >> arch/arm/mach-mx5/clock-mx51-mx53.c: In function 'mx51_clocks_init_dt':
>>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckil' is used uninitialized in this function
>>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'osc' is used uninitialized in this function
>>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckih1' is used uninitialized in this function
>>> >> arch/arm/mach-mx5/clock-mx51-mx53.c:1665: warning: 'ckih2' is used uninitialized in this function
>>> >
>>> > You only get this warning because you have put the code in
>>> > clk_get_freq_dt into #ifdef CONFIG_OF in the last patch. Instead please
>>> > put the whole block including clk_get_freq_dt, mx51_clocks_init_dt and
>>> > mx53_clocks_init_dt into #ifdef CONFIG_OF.
>>>
>>> Yes, I can put #ifdef CONFIG_OF to cover the whole block including
>>> clk_get_freq_dt/
>>> mx51_clocks_init_dt/mx53_clocks_init_dt, but after enable CONFIG_OF,
>>> you still will
>>> meet these compiling warnings.
>>
>> I just tried it and no, I do not get any compiler warnings.
>
> OK, thanks.
>
>>
>> When passing the address of a variable to a function gcc considers this
>> variable as initialized after that, unless the function is a static
>> inline function and gcc can see that it actually does not get
>> initialized.
>> I hope this hasn't changed with gcc 4.6
>
> you right. After move the #ifdef to cover all the dt related, I did
> not get any compile
> warnings. I will update this patch soon. see v2 for it.

The version for this patch-set is messed up by my local script. In fact,
this initial version should be v1 (not v3) and the following is v2. I
will be careful
to not run into this issue later. sorry for the reader who confuse about it.

>
> Jason Liu
>
>>
>>>
>>> But refer to grant before, we don't need place #ifdef CONFIG_OF #endif into
>>> the .c file, no-matter enable device_tree support or not. I'm not sure
>>> why we still
>>> meet compile error, shawn, any comments?
>>
>> for_each_compatible_node is inside #ifdef CONFIG_OF in the header file.
>> So unless there are plans to provide some dummy stub for this without
>> CONFIG_OF I see no way around these ifdefs.
>>
>>>
>>> Jason Liu
>>>
>>> > Sascha
>>> >
>>> >>
>>> >> Signed-off-by: Jason Liu <jason.hui@linaro.org>
>>> >> ---
>>> >> ?arch/arm/mach-mx5/clock-mx51-mx53.c | ? ?2 ++
>>> >> ?1 files changed, 2 insertions(+), 0 deletions(-)
>>> >>
>>> >> diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c
>>> >> index 7c373b83..e352a5a 100644
>>> >> --- a/arch/arm/mach-mx5/clock-mx51-mx53.c
>>> >> +++ b/arch/arm/mach-mx5/clock-mx51-mx53.c
>>> >> @@ -1662,6 +1662,7 @@ int __init mx51_clocks_init_dt(void)
>>> >> ?{
>>> >> ? ? ? unsigned long ckil, osc, ckih1, ckih2;
>>> >>
>>> >> + ? ? ckil = osc = ckih1 = ckih2 = 0;
>>> >> ? ? ? clk_get_freq_dt(&ckil, &osc, &ckih1, &ckih2);
>>> >> ? ? ? return mx51_clocks_init(ckil, osc, ckih1, ckih2);
>>> >> ?}
>>> >> @@ -1670,6 +1671,7 @@ int __init mx53_clocks_init_dt(void)
>>> >> ?{
>>> >> ? ? ? unsigned long ckil, osc, ckih1, ckih2;
>>> >>
>>> >> + ? ? ckil = osc = ckih1 = ckih2 = 0;
>>> >> ? ? ? clk_get_freq_dt(&ckil, &osc, &ckih1, &ckih2);
>>> >> ? ? ? return mx53_clocks_init(ckil, osc, ckih1, ckih2);
>>> >> ?}
>>> >> --
>>> >> 1.7.4.1
>>> >>
>>> >>
>>> >>
>>> >
>>> > --
>>> > Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ? ? ? ? ? ? ? ? ? ? ? ? ? |
>>> > Industrial Linux Solutions ? ? ? ? ? ? ? ? | http://www.pengutronix.de/ ?|
>>> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 ? ?|
>>> > Amtsgericht Hildesheim, HRA 2686 ? ? ? ? ? | Fax: ? +49-5121-206917-5555 |
>>> >
>>> > _______________________________________________
>>> > linux-arm-kernel mailing list
>>> > linux-arm-kernel at lists.infradead.org
>>> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>> >
>>>
>>
>> --
>> Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ? ? ? ? ? ? ? ? ? ? ? ? ? |
>> Industrial Linux Solutions ? ? ? ? ? ? ? ? | http://www.pengutronix.de/ ?|
>> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 ? ?|
>> Amtsgericht Hildesheim, HRA 2686 ? ? ? ? ? | Fax: ? +49-5121-206917-5555 |
>>
>