All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hwmon: (asus_wmi_ec_sensors) Support T_Sensor on Prime X570-Pro
@ 2022-01-11  5:18 Anthony DeRossi
  2022-01-11 17:24 ` Eugene Shalygin
  2022-01-14 18:21 ` Guenter Roeck
  0 siblings, 2 replies; 4+ messages in thread
From: Anthony DeRossi @ 2022-01-11  5:18 UTC (permalink / raw)
  To: linux-hwmon; +Cc: linux, jdelvare, pauk.denis, eugene.shalygin

Asus Prime X570-Pro motherboards have a T_Sensor header that can be
connected to an optional temperature probe.

Signed-off-by: Anthony DeRossi <ajderossi@gmail.com>
---
 drivers/hwmon/asus_wmi_ec_sensors.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/asus_wmi_ec_sensors.c b/drivers/hwmon/asus_wmi_ec_sensors.c
index 22a1459305a7..a3a2f014dec0 100644
--- a/drivers/hwmon/asus_wmi_ec_sensors.c
+++ b/drivers/hwmon/asus_wmi_ec_sensors.c
@@ -112,7 +112,8 @@ struct asus_wmi_data {
 /* boards with EC support */
 static struct asus_wmi_data sensors_board_PW_X570_P = {
 	.known_board_sensors = {
-		SENSOR_TEMP_CHIPSET, SENSOR_TEMP_CPU, SENSOR_TEMP_MB, SENSOR_TEMP_VRM,
+		SENSOR_TEMP_CHIPSET, SENSOR_TEMP_CPU, SENSOR_TEMP_MB,
+		SENSOR_TEMP_T_SENSOR, SENSOR_TEMP_VRM,
 		SENSOR_FAN_CHIPSET,
 		SENSOR_MAX
 	},
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] hwmon: (asus_wmi_ec_sensors) Support T_Sensor on Prime X570-Pro
  2022-01-11  5:18 [PATCH] hwmon: (asus_wmi_ec_sensors) Support T_Sensor on Prime X570-Pro Anthony DeRossi
@ 2022-01-11 17:24 ` Eugene Shalygin
  2022-01-12  1:44   ` Anthony DeRossi
  2022-01-14 18:21 ` Guenter Roeck
  1 sibling, 1 reply; 4+ messages in thread
From: Eugene Shalygin @ 2022-01-11 17:24 UTC (permalink / raw)
  To: Anthony DeRossi; +Cc: linux-hwmon, Guenter Roeck, Jean Delvare, Denis Pauk

Thank you, Anthony, for the fix. It was also included in the v3 patch
for a new EC sensors driver that should replace this one. Perhaps I
can enable the T_Sensor for each B550/X570 ASUS model that provides
this connector? Seems like it's always found in the EC registers.
Before you submitted this patch another user provided information for
this board with no T_Sensor, and I thought this board was the
exception.

Best regards,
Eugene

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] hwmon: (asus_wmi_ec_sensors) Support T_Sensor on Prime X570-Pro
  2022-01-11 17:24 ` Eugene Shalygin
@ 2022-01-12  1:44   ` Anthony DeRossi
  0 siblings, 0 replies; 4+ messages in thread
From: Anthony DeRossi @ 2022-01-12  1:44 UTC (permalink / raw)
  To: Eugene Shalygin; +Cc: linux-hwmon, Guenter Roeck, Jean Delvare, Denis Pauk

On Tue, Jan 11, 2022 at 9:24 AM Eugene Shalygin
<eugene.shalygin@gmail.com> wrote:
>
> Thank you, Anthony, for the fix. It was also included in the v3 patch
> for a new EC sensors driver that should replace this one. Perhaps I
> can enable the T_Sensor for each B550/X570 ASUS model that provides
> this connector? Seems like it's always found in the EC registers.
> Before you submitted this patch another user provided information for
> this board with no T_Sensor, and I thought this board was the
> exception.

If the header is present on a B550/X570 board I assume the sensor is
in the EC registers, but I don't have any other models to test.

Anthony

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] hwmon: (asus_wmi_ec_sensors) Support T_Sensor on Prime X570-Pro
  2022-01-11  5:18 [PATCH] hwmon: (asus_wmi_ec_sensors) Support T_Sensor on Prime X570-Pro Anthony DeRossi
  2022-01-11 17:24 ` Eugene Shalygin
@ 2022-01-14 18:21 ` Guenter Roeck
  1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2022-01-14 18:21 UTC (permalink / raw)
  To: Anthony DeRossi; +Cc: linux-hwmon, jdelvare, pauk.denis, eugene.shalygin

On Mon, Jan 10, 2022 at 09:18:42PM -0800, Anthony DeRossi wrote:
> Asus Prime X570-Pro motherboards have a T_Sensor header that can be
> connected to an optional temperature probe.
> 
> Signed-off-by: Anthony DeRossi <ajderossi@gmail.com>

Applied to hwmon-next.

Guenter

> ---
>  drivers/hwmon/asus_wmi_ec_sensors.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/asus_wmi_ec_sensors.c b/drivers/hwmon/asus_wmi_ec_sensors.c
> index 22a1459305a7..a3a2f014dec0 100644
> --- a/drivers/hwmon/asus_wmi_ec_sensors.c
> +++ b/drivers/hwmon/asus_wmi_ec_sensors.c
> @@ -112,7 +112,8 @@ struct asus_wmi_data {
>  /* boards with EC support */
>  static struct asus_wmi_data sensors_board_PW_X570_P = {
>  	.known_board_sensors = {
> -		SENSOR_TEMP_CHIPSET, SENSOR_TEMP_CPU, SENSOR_TEMP_MB, SENSOR_TEMP_VRM,
> +		SENSOR_TEMP_CHIPSET, SENSOR_TEMP_CPU, SENSOR_TEMP_MB,
> +		SENSOR_TEMP_T_SENSOR, SENSOR_TEMP_VRM,
>  		SENSOR_FAN_CHIPSET,
>  		SENSOR_MAX
>  	},

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-14 18:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-11  5:18 [PATCH] hwmon: (asus_wmi_ec_sensors) Support T_Sensor on Prime X570-Pro Anthony DeRossi
2022-01-11 17:24 ` Eugene Shalygin
2022-01-12  1:44   ` Anthony DeRossi
2022-01-14 18:21 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.