All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	y2038@lists.linaro.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tina Ruchandani <ruchandani.tina@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'
Date: Sat, 23 Apr 2016 02:30:58 +0100	[thread overview]
Message-ID: <CAB=NE6X35iUW2RQvayREEBvu8ULdTBqKALm6AEQNhh570_XbPA@mail.gmail.com> (raw)
In-Reply-To: <87inz9y0qg.fsf@purkki.adurom.net>

On Apr 22, 2016 8:09 PM, "Kalle Valo" <kvalo@codeaurora.org> wrote:
>
> Johannes Berg <johannes@sipsolutions.net> writes:
>
> > On Mon, 2016-04-18 at 00:10 +0200, Arnd Bergmann wrote:
> >> On Sunday 17 April 2016 14:42:33 Johannes Berg wrote:
> >> >
> >> > I was thinking more restrictively of just the stuff that can't even
> >> > be built without modifying the sources - like the "#if VERBOSE"
> >> > thing.
> >>
> >> All the DEBUG() statements are inside of this kind of check, so if we
> >> remove the #ifdefs, it would be logical to remove the rest of the
> >> debugging infrastructure (DEBUG() macros, SHOW_*, pc_debug, maybe
> >> more) as well.
> >
> > Seems reasonable.
> >
> > Maybe we should Cc the maintainer, but I suspect that since the driver
> > is marked Obsolete anyway Luis won't care either :)
>
> I'm planning to apply this patch anyway, the debugging infrastructure
> removal can be a followup patch. But please let me know if I should drop
> this instead.

I'd say let's bury the driver now. We have a process to stage large chunks
of poo now through staging, let's use that to shaft prism54 there now and
give it a few cycles to let people call bloody murder before finally
removing. We need to do better at deleting ancient legacy shit. I'll stand
behind this one. Sue me if needed.

  Luis
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038

  reply	other threads:[~2016-04-23  1:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13  6:09 [PATCH v3] prism54: isl_38xx: Replace 'struct timeval' Tina Ruchandani
2016-04-13  6:09 ` Tina Ruchandani
2016-04-13  8:38 ` Johannes Berg
2016-04-13  8:38   ` Johannes Berg
2016-04-13  9:45   ` Arend Van Spriel
2016-04-13  9:45     ` Arend Van Spriel
2016-04-16 23:34   ` Arnd Bergmann
2016-04-16 23:34     ` Arnd Bergmann
2016-04-17 12:42     ` Johannes Berg
2016-04-17 12:42       ` Johannes Berg
2016-04-17 22:10       ` Arnd Bergmann
2016-04-17 22:10         ` Arnd Bergmann
2016-04-19  8:57         ` Johannes Berg
2016-04-19  8:57           ` Johannes Berg
2016-04-22 18:09           ` Kalle Valo
2016-04-22 18:09             ` Kalle Valo
2016-04-23  1:30             ` Luis R. Rodriguez [this message]
2016-04-26  9:10 ` [v3] " Kalle Valo
2016-04-26  9:10 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB=NE6X35iUW2RQvayREEBvu8ULdTBqKALm6AEQNhh570_XbPA@mail.gmail.com' \
    --to=mcgrof@kernel.org \
    --cc=arnd@arndb.de \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ruchandani.tina@gmail.com \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.