* [PATCH] arm/omap: use const char properly
@ 2013-06-06 13:24 Sebastian Andrzej Siewior
2013-06-06 13:42 ` Ruslan Bilovol
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2013-06-06 13:24 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap, Sebastian Andrzej Siewior
The itention was probably to make both pointers const but as it is now,
it is just const used twice.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
arch/arm/mach-omap2/id.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index 1272c41..54e4c16 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -601,7 +601,7 @@ void __init omap2_set_globals_tap(u32 class, void __iomem *tap)
#ifdef CONFIG_SOC_BUS
-static const char const *omap_types[] = {
+static const char * const omap_types[] = {
[OMAP2_DEVICE_TYPE_TEST] = "TST",
[OMAP2_DEVICE_TYPE_EMU] = "EMU",
[OMAP2_DEVICE_TYPE_SEC] = "HS",
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm/omap: use const char properly
2013-06-06 13:24 [PATCH] arm/omap: use const char properly Sebastian Andrzej Siewior
@ 2013-06-06 13:42 ` Ruslan Bilovol
2013-06-12 14:17 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Ruslan Bilovol @ 2013-06-06 13:42 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: Tony Lindgren, linux-omap
Hi Sebastian,
On Thu, Jun 6, 2013 at 4:24 PM, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> The itention was probably to make both pointers const but as it is now,
> it is just const used twice.
Yes, it's a typo I did accidentally. Good catch!
Regards,
Ruslan
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> arch/arm/mach-omap2/id.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index 1272c41..54e4c16 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -601,7 +601,7 @@ void __init omap2_set_globals_tap(u32 class, void __iomem *tap)
>
> #ifdef CONFIG_SOC_BUS
>
> -static const char const *omap_types[] = {
> +static const char * const omap_types[] = {
> [OMAP2_DEVICE_TYPE_TEST] = "TST",
> [OMAP2_DEVICE_TYPE_EMU] = "EMU",
> [OMAP2_DEVICE_TYPE_SEC] = "HS",
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm/omap: use const char properly
2013-06-06 13:42 ` Ruslan Bilovol
@ 2013-06-12 14:17 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2013-06-12 14:17 UTC (permalink / raw)
To: Ruslan Bilovol; +Cc: Sebastian Andrzej Siewior, linux-omap
* Ruslan Bilovol <ruslan.bilovol@ti.com> [130606 06:48]:
> Hi Sebastian,
>
> On Thu, Jun 6, 2013 at 4:24 PM, Sebastian Andrzej Siewior
> <bigeasy@linutronix.de> wrote:
> > The itention was probably to make both pointers const but as it is now,
> > it is just const used twice.
>
> Yes, it's a typo I did accidentally. Good catch!
Thanks applying into omap-for-v3.11/fixes-non-critical.
Regards,
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-12 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-06 13:24 [PATCH] arm/omap: use const char properly Sebastian Andrzej Siewior
2013-06-06 13:42 ` Ruslan Bilovol
2013-06-12 14:17 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.