* [PATCH] core/gatt: Fix not marking GATT D-Bus properties as stable
@ 2016-08-04 13:31 Szymon Janc
2016-08-05 11:44 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 2+ messages in thread
From: Szymon Janc @ 2016-08-04 13:31 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Szymon Janc
Those are no longer experimental. This fix not being able to use
GATT client over D-Bus without -E option.
---
src/gatt-client.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/gatt-client.c b/src/gatt-client.c
index f50db0b..029a9d1 100644
--- a/src/gatt-client.c
+++ b/src/gatt-client.c
@@ -613,12 +613,9 @@ static DBusMessage *descriptor_write_value(DBusConnection *conn,
}
static const GDBusPropertyTable descriptor_properties[] = {
- { "UUID", "s", descriptor_get_uuid, NULL, NULL,
- G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
- { "Characteristic", "o", descriptor_get_characteristic, NULL, NULL,
- G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
- { "Value", "ay", descriptor_get_value, NULL, descriptor_value_exists,
- G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
+ { "UUID", "s", descriptor_get_uuid },
+ { "Characteristic", "o", descriptor_get_characteristic, },
+ { "Value", "ay", descriptor_get_value, NULL, descriptor_value_exists },
{ }
};
@@ -1402,12 +1399,9 @@ static gboolean service_get_primary(const GDBusPropertyTable *property,
}
static const GDBusPropertyTable service_properties[] = {
- { "UUID", "s", service_get_uuid, NULL, NULL,
- G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
- { "Device", "o", service_get_device, NULL, NULL,
- G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
- { "Primary", "b", service_get_primary, NULL, NULL,
- G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
+ { "UUID", "s", service_get_uuid },
+ { "Device", "o", service_get_device },
+ { "Primary", "b", service_get_primary },
{ }
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] core/gatt: Fix not marking GATT D-Bus properties as stable
2016-08-04 13:31 [PATCH] core/gatt: Fix not marking GATT D-Bus properties as stable Szymon Janc
@ 2016-08-05 11:44 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2016-08-05 11:44 UTC (permalink / raw)
To: Szymon Janc; +Cc: linux-bluetooth
Hi Szymon,
On Thu, Aug 4, 2016 at 4:31 PM, Szymon Janc <szymon.janc@codecoup.pl> wrote:
> Those are no longer experimental. This fix not being able to use
> GATT client over D-Bus without -E option.
> ---
> src/gatt-client.c | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/src/gatt-client.c b/src/gatt-client.c
> index f50db0b..029a9d1 100644
> --- a/src/gatt-client.c
> +++ b/src/gatt-client.c
> @@ -613,12 +613,9 @@ static DBusMessage *descriptor_write_value(DBusConnection *conn,
> }
>
> static const GDBusPropertyTable descriptor_properties[] = {
> - { "UUID", "s", descriptor_get_uuid, NULL, NULL,
> - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> - { "Characteristic", "o", descriptor_get_characteristic, NULL, NULL,
> - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> - { "Value", "ay", descriptor_get_value, NULL, descriptor_value_exists,
> - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> + { "UUID", "s", descriptor_get_uuid },
> + { "Characteristic", "o", descriptor_get_characteristic, },
> + { "Value", "ay", descriptor_get_value, NULL, descriptor_value_exists },
> { }
> };
>
> @@ -1402,12 +1399,9 @@ static gboolean service_get_primary(const GDBusPropertyTable *property,
> }
>
> static const GDBusPropertyTable service_properties[] = {
> - { "UUID", "s", service_get_uuid, NULL, NULL,
> - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> - { "Device", "o", service_get_device, NULL, NULL,
> - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> - { "Primary", "b", service_get_primary, NULL, NULL,
> - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> + { "UUID", "s", service_get_uuid },
> + { "Device", "o", service_get_device },
> + { "Primary", "b", service_get_primary },
> { }
> };
>
> --
> 2.7.4
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-05 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-04 13:31 [PATCH] core/gatt: Fix not marking GATT D-Bus properties as stable Szymon Janc
2016-08-05 11:44 ` Luiz Augusto von Dentz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.