All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] 6lowpan: fix assignment of peer_addr
@ 2017-03-28 12:11 ` Colin King
  0 siblings, 0 replies; 7+ messages in thread
From: Colin King @ 2017-03-28 12:11 UTC (permalink / raw)
  To: Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
	David S . Miller, linux-bluetooth, netdev
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The data from peer->chan->dst is not being copied to peer_addr, the
current code just updates the pointer and not the contents of what
it points to.  Fix this with the intended assignment.

Detected by CoverityScan, CID#1422111 ("Parse warning
(PW.PARAM_SET_BUT_NOT_USED)")

Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/bluetooth/6lowpan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 24348c8579dd..ba28c7b1557f 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -432,7 +432,7 @@ static int setup_header(struct sk_buff *skb, struct net_device *netdev,
 		}
 
 		daddr = peer->lladdr;
-		peer_addr = &peer->chan->dst;
+		*peer_addr = peer->chan->dst;
 		*peer_addr_type = peer->chan->dst_type;
 		lowpan_cb(skb)->chan = peer->chan;
 
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] 6lowpan: fix assignment of peer_addr
@ 2017-03-28 12:11 ` Colin King
  0 siblings, 0 replies; 7+ messages in thread
From: Colin King @ 2017-03-28 12:11 UTC (permalink / raw)
  To: Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
	David S . Miller, linux-bluetooth, netdev
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The data from peer->chan->dst is not being copied to peer_addr, the
current code just updates the pointer and not the contents of what
it points to.  Fix this with the intended assignment.

Detected by CoverityScan, CID#1422111 ("Parse warning
(PW.PARAM_SET_BUT_NOT_USED)")

Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/bluetooth/6lowpan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 24348c8579dd..ba28c7b1557f 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -432,7 +432,7 @@ static int setup_header(struct sk_buff *skb, struct net_device *netdev,
 		}
 
 		daddr = peer->lladdr;
-		peer_addr = &peer->chan->dst;
+		*peer_addr = peer->chan->dst;
 		*peer_addr_type = peer->chan->dst_type;
 		lowpan_cb(skb)->chan = peer->chan;
 
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] 6lowpan: fix assignment of peer_addr
  2017-03-28 12:11 ` Colin King
@ 2017-03-28 13:32   ` Luiz Augusto von Dentz
  -1 siblings, 0 replies; 7+ messages in thread
From: Luiz Augusto von Dentz @ 2017-03-28 13:32 UTC (permalink / raw)
  To: Colin King
  Cc: Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
	David S . Miller, linux-bluetooth, open list:NETWORKING [GENERAL],
	kernel-janitors, Linux Kernel Mailing List

Hi Colin,

On Tue, Mar 28, 2017 at 3:11 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The data from peer->chan->dst is not being copied to peer_addr, the
> current code just updates the pointer and not the contents of what
> it points to.  Fix this with the intended assignment.
>
> Detected by CoverityScan, CID#1422111 ("Parse warning
> (PW.PARAM_SET_BUT_NOT_USED)")
>
> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  net/bluetooth/6lowpan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index 24348c8579dd..ba28c7b1557f 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -432,7 +432,7 @@ static int setup_header(struct sk_buff *skb, struct net_device *netdev,
>                 }
>
>                 daddr = peer->lladdr;
> -               peer_addr = &peer->chan->dst;
> +               *peer_addr = peer->chan->dst;
>                 *peer_addr_type = peer->chan->dst_type;
>                 lowpan_cb(skb)->chan = peer->chan;
>
> --
> 2.11.0

Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] 6lowpan: fix assignment of peer_addr
@ 2017-03-28 13:32   ` Luiz Augusto von Dentz
  0 siblings, 0 replies; 7+ messages in thread
From: Luiz Augusto von Dentz @ 2017-03-28 13:32 UTC (permalink / raw)
  To: Colin King
  Cc: Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
	David S . Miller, linux-bluetooth, open list:NETWORKING [GENERAL],
	kernel-janitors, Linux Kernel Mailing List

Hi Colin,

On Tue, Mar 28, 2017 at 3:11 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The data from peer->chan->dst is not being copied to peer_addr, the
> current code just updates the pointer and not the contents of what
> it points to.  Fix this with the intended assignment.
>
> Detected by CoverityScan, CID#1422111 ("Parse warning
> (PW.PARAM_SET_BUT_NOT_USED)")
>
> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  net/bluetooth/6lowpan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index 24348c8579dd..ba28c7b1557f 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -432,7 +432,7 @@ static int setup_header(struct sk_buff *skb, struct net_device *netdev,
>                 }
>
>                 daddr = peer->lladdr;
> -               peer_addr = &peer->chan->dst;
> +               *peer_addr = peer->chan->dst;
>                 *peer_addr_type = peer->chan->dst_type;
>                 lowpan_cb(skb)->chan = peer->chan;
>
> --
> 2.11.0

Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] 6lowpan: fix assignment of peer_addr
@ 2017-03-28 13:36   ` Marcel Holtmann
  0 siblings, 0 replies; 7+ messages in thread
From: Marcel Holtmann @ 2017-03-28 13:36 UTC (permalink / raw)
  To: Colin King
  Cc: Gustavo F. Padovan, Johan Hedberg, David S. Miller,
	Bluez mailing list, netdev, kernel-janitors, linux-kernel

Hi Colin,

> The data from peer->chan->dst is not being copied to peer_addr, the
> current code just updates the pointer and not the contents of what
> it points to.  Fix this with the intended assignment.
> 
> Detected by CoverityScan, CID#1422111 ("Parse warning
> (PW.PARAM_SET_BUT_NOT_USED)")
> 
> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/bluetooth/6lowpan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] 6lowpan: fix assignment of peer_addr
@ 2017-03-28 13:36   ` Marcel Holtmann
  0 siblings, 0 replies; 7+ messages in thread
From: Marcel Holtmann @ 2017-03-28 13:36 UTC (permalink / raw)
  To: Colin King
  Cc: Gustavo F. Padovan, Johan Hedberg, David S. Miller,
	Bluez mailing list, netdev-u79uwXL29TY76Z2rM5mHXA,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Hi Colin,

> The data from peer->chan->dst is not being copied to peer_addr, the
> current code just updates the pointer and not the contents of what
> it points to.  Fix this with the intended assignment.
> 
> Detected by CoverityScan, CID#1422111 ("Parse warning
> (PW.PARAM_SET_BUT_NOT_USED)")
> 
> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
> Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> ---
> net/bluetooth/6lowpan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] 6lowpan: fix assignment of peer_addr
@ 2017-03-28 13:36   ` Marcel Holtmann
  0 siblings, 0 replies; 7+ messages in thread
From: Marcel Holtmann @ 2017-03-28 13:36 UTC (permalink / raw)
  To: Colin King
  Cc: Gustavo F. Padovan, Johan Hedberg, David S. Miller,
	Bluez mailing list, netdev, kernel-janitors, linux-kernel

Hi Colin,

> The data from peer->chan->dst is not being copied to peer_addr, the
> current code just updates the pointer and not the contents of what
> it points to.  Fix this with the intended assignment.
> 
> Detected by CoverityScan, CID#1422111 ("Parse warning
> (PW.PARAM_SET_BUT_NOT_USED)")
> 
> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/bluetooth/6lowpan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-03-28 13:45 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-28 12:11 [PATCH] 6lowpan: fix assignment of peer_addr Colin King
2017-03-28 12:11 ` Colin King
2017-03-28 13:32 ` Luiz Augusto von Dentz
2017-03-28 13:32   ` Luiz Augusto von Dentz
2017-03-28 13:36 ` Marcel Holtmann
2017-03-28 13:36   ` Marcel Holtmann
2017-03-28 13:36   ` Marcel Holtmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.