* [PATCH BlueZ] core/device: Make it more clear random addresses can only be used with LE
@ 2016-09-06 11:04 Luiz Augusto von Dentz
2016-09-07 13:14 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2016-09-06 11:04 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Any random address type can only be connected over LE as BR/EDR only
support public addresses.
---
src/device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/device.c b/src/device.c
index b8556f1..9586022 100644
--- a/src/device.c
+++ b/src/device.c
@@ -1748,8 +1748,8 @@ static uint8_t select_conn_bearer(struct btd_device *dev)
else if (!dev->bredr_state.bonded && dev->le_state.bonded)
return dev->bdaddr_type;
- /* If the address is private it can only be connected over LE */
- if (device_address_is_private(dev))
+ /* If the address is random it can only be connected over LE */
+ if (dev->bdaddr_type == BDADDR_LE_RANDOM)
return dev->bdaddr_type;
if (dev->bredr_seen) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH BlueZ] core/device: Make it more clear random addresses can only be used with LE
2016-09-06 11:04 [PATCH BlueZ] core/device: Make it more clear random addresses can only be used with LE Luiz Augusto von Dentz
@ 2016-09-07 13:14 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2016-09-07 13:14 UTC (permalink / raw)
To: linux-bluetooth
Hi,
On Tue, Sep 6, 2016 at 2:04 PM, Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> Any random address type can only be connected over LE as BR/EDR only
> support public addresses.
> ---
> src/device.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/device.c b/src/device.c
> index b8556f1..9586022 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -1748,8 +1748,8 @@ static uint8_t select_conn_bearer(struct btd_device *dev)
> else if (!dev->bredr_state.bonded && dev->le_state.bonded)
> return dev->bdaddr_type;
>
> - /* If the address is private it can only be connected over LE */
> - if (device_address_is_private(dev))
> + /* If the address is random it can only be connected over LE */
> + if (dev->bdaddr_type == BDADDR_LE_RANDOM)
> return dev->bdaddr_type;
>
> if (dev->bredr_seen) {
> --
> 2.7.4
Applied.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-07 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-06 11:04 [PATCH BlueZ] core/device: Make it more clear random addresses can only be used with LE Luiz Augusto von Dentz
2016-09-07 13:14 ` Luiz Augusto von Dentz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.