* [Bluez PATCH v1] core: Fix loading AVDTP options
@ 2021-05-07 4:32 Howard Chung
2021-05-07 4:49 ` [Bluez,v1] " bluez.test.bot
2021-05-19 4:41 ` [Bluez PATCH v1] " Tedd Ho-Jeong An
0 siblings, 2 replies; 5+ messages in thread
From: Howard Chung @ 2021-05-07 4:32 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
Cc: chromeos-bluetooth-upstreaming, Yun-Hao Chung, mmandlik, apusaka
From: Yun-Hao Chung <howardchung@chromium.org>
Fix misassigned AVDTP StreamMode option, which causes StreamMode not
being set.
Fix AVDTP SessionMode option not freed.
Reviewed-by: mmandlik@chromium.org
Reviewed-by: apusaka@chromium.org
---
src/main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/main.c b/src/main.c
index c32bda7d407d..7612d6984890 100644
--- a/src/main.c
+++ b/src/main.c
@@ -774,9 +774,10 @@ static void parse_config(GKeyFile *config)
DBG("Invalid mode option: %s", str);
btd_opts.avdtp.session_mode = BT_IO_MODE_BASIC;
}
+ g_free(str);
}
- val = g_key_file_get_integer(config, "AVDTP", "StreamMode", &err);
+ str = g_key_file_get_string(config, "AVDTP", "StreamMode", &err);
if (err) {
DBG("%s", err->message);
g_clear_error(&err);
@@ -791,6 +792,7 @@ static void parse_config(GKeyFile *config)
DBG("Invalid mode option: %s", str);
btd_opts.avdtp.stream_mode = BT_IO_MODE_BASIC;
}
+ g_free(str);
}
parse_br_config(config);
--
2.31.1.607.g51e8a6a459-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [Bluez,v1] core: Fix loading AVDTP options
2021-05-07 4:32 [Bluez PATCH v1] core: Fix loading AVDTP options Howard Chung
@ 2021-05-07 4:49 ` bluez.test.bot
2021-05-19 3:50 ` Yun-hao Chung
2021-05-19 4:41 ` [Bluez PATCH v1] " Tedd Ho-Jeong An
1 sibling, 1 reply; 5+ messages in thread
From: bluez.test.bot @ 2021-05-07 4:49 UTC (permalink / raw)
To: linux-bluetooth, howardchung
[-- Attachment #1: Type: text/plain, Size: 2296 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=478213
---Test result---
Test Summary:
CheckPatch PASS 0.31 seconds
GitLint PASS 0.12 seconds
Prep - Setup ELL PASS 45.60 seconds
Build - Prep PASS 0.10 seconds
Build - Configure PASS 7.95 seconds
Build - Make PASS 193.97 seconds
Make Check PASS 9.40 seconds
Make Dist PASS 12.46 seconds
Make Dist - Configure PASS 4.88 seconds
Make Dist - Make PASS 80.65 seconds
Build w/ext ELL - Configure PASS 8.34 seconds
Build w/ext ELL - Make PASS 188.95 seconds
Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree
##############################
Test: Make Check - PASS
Desc: Run 'make check'
##############################
Test: Make Dist - PASS
Desc: Run 'make dist' and build the distribution tarball
##############################
Test: Make Dist - Configure - PASS
Desc: Configure the source from distribution tarball
##############################
Test: Make Dist - Make - PASS
Desc: Build the source from distribution tarball
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Bluez,v1] core: Fix loading AVDTP options
2021-05-07 4:49 ` [Bluez,v1] " bluez.test.bot
@ 2021-05-19 3:50 ` Yun-hao Chung
0 siblings, 0 replies; 5+ messages in thread
From: Yun-hao Chung @ 2021-05-19 3:50 UTC (permalink / raw)
To: Bluez mailing list
Hi linux-bluez,
Gentle ping.
On Fri, May 7, 2021 at 12:49 PM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=478213
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 0.31 seconds
> GitLint PASS 0.12 seconds
> Prep - Setup ELL PASS 45.60 seconds
> Build - Prep PASS 0.10 seconds
> Build - Configure PASS 7.95 seconds
> Build - Make PASS 193.97 seconds
> Make Check PASS 9.40 seconds
> Make Dist PASS 12.46 seconds
> Make Dist - Configure PASS 4.88 seconds
> Make Dist - Make PASS 80.65 seconds
> Build w/ext ELL - Configure PASS 8.34 seconds
> Build w/ext ELL - Make PASS 188.95 seconds
>
> Details
> ##############################
> Test: CheckPatch - PASS
> Desc: Run checkpatch.pl script with rule in .checkpatch.conf
>
> ##############################
> Test: GitLint - PASS
> Desc: Run gitlint with rule in .gitlint
>
> ##############################
> Test: Prep - Setup ELL - PASS
> Desc: Clone, build, and install ELL
>
> ##############################
> Test: Build - Prep - PASS
> Desc: Prepare environment for build
>
> ##############################
> Test: Build - Configure - PASS
> Desc: Configure the BlueZ source tree
>
> ##############################
> Test: Build - Make - PASS
> Desc: Build the BlueZ source tree
>
> ##############################
> Test: Make Check - PASS
> Desc: Run 'make check'
>
> ##############################
> Test: Make Dist - PASS
> Desc: Run 'make dist' and build the distribution tarball
>
> ##############################
> Test: Make Dist - Configure - PASS
> Desc: Configure the source from distribution tarball
>
> ##############################
> Test: Make Dist - Make - PASS
> Desc: Build the source from distribution tarball
>
> ##############################
> Test: Build w/ext ELL - Configure - PASS
> Desc: Configure BlueZ source with '--enable-external-ell' configuration
>
> ##############################
> Test: Build w/ext ELL - Make - PASS
> Desc: Build BlueZ source with '--enable-external-ell' configuration
>
>
>
> ---
> Regards,
> Linux Bluetooth
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Bluez PATCH v1] core: Fix loading AVDTP options
2021-05-07 4:32 [Bluez PATCH v1] core: Fix loading AVDTP options Howard Chung
2021-05-07 4:49 ` [Bluez,v1] " bluez.test.bot
@ 2021-05-19 4:41 ` Tedd Ho-Jeong An
2021-05-19 18:10 ` Luiz Augusto von Dentz
1 sibling, 1 reply; 5+ messages in thread
From: Tedd Ho-Jeong An @ 2021-05-19 4:41 UTC (permalink / raw)
To: Howard Chung, linux-bluetooth, luiz.dentz
Cc: chromeos-bluetooth-upstreaming, Yun-Hao Chung, mmandlik, apusaka
Hi Howard,
On Fri, 2021-05-07 at 12:32 +0800, Howard Chung wrote:
> From: Yun-Hao Chung <howardchung@chromium.org>
>
> Fix misassigned AVDTP StreamMode option, which causes StreamMode not
> being set.
> Fix AVDTP SessionMode option not freed.
>
> Reviewed-by: mmandlik@chromium.org
> Reviewed-by: apusaka@chromium.org
Reviewed-by: Tedd Ho-Jeong An <tedd.an@intel.com>
> ---
>
> src/main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/main.c b/src/main.c
> index c32bda7d407d..7612d6984890 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -774,9 +774,10 @@ static void parse_config(GKeyFile *config)
> DBG("Invalid mode option: %s", str);
> btd_opts.avdtp.session_mode = BT_IO_MODE_BASIC;
> }
> + g_free(str);
> }
>
> - val = g_key_file_get_integer(config, "AVDTP", "StreamMode", &err);
> + str = g_key_file_get_string(config, "AVDTP", "StreamMode", &err);
> if (err) {
> DBG("%s", err->message);
> g_clear_error(&err);
> @@ -791,6 +792,7 @@ static void parse_config(GKeyFile *config)
> DBG("Invalid mode option: %s", str);
> btd_opts.avdtp.stream_mode = BT_IO_MODE_BASIC;
> }
> + g_free(str);
> }
>
> parse_br_config(config);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Bluez PATCH v1] core: Fix loading AVDTP options
2021-05-19 4:41 ` [Bluez PATCH v1] " Tedd Ho-Jeong An
@ 2021-05-19 18:10 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 5+ messages in thread
From: Luiz Augusto von Dentz @ 2021-05-19 18:10 UTC (permalink / raw)
To: Tedd Ho-Jeong An
Cc: Howard Chung, linux-bluetooth, ChromeOS Bluetooth Upstreaming,
Yun-Hao Chung, Manish Mandlik, Archie Pusaka
Hi Howard,
On Tue, May 18, 2021 at 9:41 PM Tedd Ho-Jeong An <hj.tedd.an@gmail.com> wrote:
>
> Hi Howard,
>
> On Fri, 2021-05-07 at 12:32 +0800, Howard Chung wrote:
> > From: Yun-Hao Chung <howardchung@chromium.org>
> >
> > Fix misassigned AVDTP StreamMode option, which causes StreamMode not
> > being set.
> > Fix AVDTP SessionMode option not freed.
> >
> > Reviewed-by: mmandlik@chromium.org
> > Reviewed-by: apusaka@chromium.org
>
> Reviewed-by: Tedd Ho-Jeong An <tedd.an@intel.com>
>
> > ---
> >
> > src/main.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/main.c b/src/main.c
> > index c32bda7d407d..7612d6984890 100644
> > --- a/src/main.c
> > +++ b/src/main.c
> > @@ -774,9 +774,10 @@ static void parse_config(GKeyFile *config)
> > DBG("Invalid mode option: %s", str);
> > btd_opts.avdtp.session_mode = BT_IO_MODE_BASIC;
> > }
> > + g_free(str);
> > }
> >
> > - val = g_key_file_get_integer(config, "AVDTP", "StreamMode", &err);
> > + str = g_key_file_get_string(config, "AVDTP", "StreamMode", &err);
> > if (err) {
> > DBG("%s", err->message);
> > g_clear_error(&err);
> > @@ -791,6 +792,7 @@ static void parse_config(GKeyFile *config)
> > DBG("Invalid mode option: %s", str);
> > btd_opts.avdtp.stream_mode = BT_IO_MODE_BASIC;
> > }
> > + g_free(str);
> > }
> >
> > parse_br_config(config);
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-19 18:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 4:32 [Bluez PATCH v1] core: Fix loading AVDTP options Howard Chung
2021-05-07 4:49 ` [Bluez,v1] " bluez.test.bot
2021-05-19 3:50 ` Yun-hao Chung
2021-05-19 4:41 ` [Bluez PATCH v1] " Tedd Ho-Jeong An
2021-05-19 18:10 ` Luiz Augusto von Dentz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.