From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: HCI: Fix Set Extended (Scan Response) Data
Date: Wed, 9 Jun 2021 10:10:32 -0700 [thread overview]
Message-ID: <CABBYNZKTr+MVGfpoLA_YQOossdiLGV6sigKbKhc-Avi11Hp5MA@mail.gmail.com> (raw)
In-Reply-To: <6AC22489-B3C4-49B8-AF19-A0AEC8CFD91B@holtmann.org>
Hi Marcel,
On Tue, Jun 8, 2021 at 9:52 PM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Luiz,
>
> > These command do have variable length and the length can go up to 251,
> > so this changes the struct to not use a fixed size and then when
> > creating the PDU only the actual length of the data send to the
> > controller.
> >
> > Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> > ---
> > include/net/bluetooth/hci.h | 6 ++--
> > include/net/bluetooth/hci_core.h | 8 ++---
> > net/bluetooth/hci_request.c | 51 ++++++++++++++++++--------------
> > 3 files changed, 37 insertions(+), 28 deletions(-)
>
> if possible, please git blame and add Fixes: tag.
>
> Regards
>
> Marcel
Will do.
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2021-06-09 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 18:44 [PATCH] Bluetooth: HCI: Fix Set Extended (Scan Response) Data Luiz Augusto von Dentz
2021-06-08 19:42 ` bluez.test.bot
2021-06-08 19:57 ` Luiz Augusto von Dentz
2021-06-08 20:25 ` An, Tedd
2021-06-09 4:52 ` [PATCH] " Marcel Holtmann
2021-06-09 17:10 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZKTr+MVGfpoLA_YQOossdiLGV6sigKbKhc-Avi11Hp5MA@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.