From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: David Lechner <david@lechnology.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ] device: Remove GATT Attribute when device is removed
Date: Wed, 25 Aug 2021 14:16:16 -0700 [thread overview]
Message-ID: <CABBYNZLUo5wAATmUVYNoV-Nd1cUjC_zN0+tQQ7XSYywe6YSGcw@mail.gmail.com> (raw)
In-Reply-To: <0028fab2-5707-8011-d3f6-d14c7337d449@lechnology.com>
Hi David,
On Wed, Aug 25, 2021 at 10:44 AM David Lechner <david@lechnology.com> wrote:
>
> On 8/24/21 5:52 PM, Luiz Augusto von Dentz wrote:
> > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> >
> > This makes the GATT Attribute cache to be removed when device is removed
> > just like SDP ServiceRecords.
> >
> > Fixes: https://github.com/bluez/bluez/issues/191
> > ---
> Tested-by: David Lechner <david@lechnology.com>
>
> But wouldn't it be better to just delete the file altogether?
> This would prevent any future sections from being forgotten to
> be removed as well.
>
> I sent an alternative patch that does this: "device: delete
> cache file when device is removed"
We do like to keep some details such as the name, etc.
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2021-08-25 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 22:52 [PATCH BlueZ] device: Remove GATT Attribute when device is removed Luiz Augusto von Dentz
2021-08-24 23:35 ` [BlueZ] " bluez.test.bot
2021-08-25 22:13 ` Luiz Augusto von Dentz
2021-08-25 17:44 ` [PATCH BlueZ] " David Lechner
2021-08-25 21:16 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZLUo5wAATmUVYNoV-Nd1cUjC_zN0+tQQ7XSYywe6YSGcw@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=david@lechnology.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.