* [PATCH BlueZ] device: Remove GATT Attribute when device is removed
@ 2021-08-24 22:52 Luiz Augusto von Dentz
2021-08-24 23:35 ` [BlueZ] " bluez.test.bot
2021-08-25 17:44 ` [PATCH BlueZ] " David Lechner
0 siblings, 2 replies; 5+ messages in thread
From: Luiz Augusto von Dentz @ 2021-08-24 22:52 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This makes the GATT Attribute cache to be removed when device is removed
just like SDP ServiceRecords.
Fixes: https://github.com/bluez/bluez/issues/191
---
src/device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/device.c b/src/device.c
index 807106812..998485be7 100644
--- a/src/device.c
+++ b/src/device.c
@@ -4511,6 +4511,7 @@ static void device_remove_stored(struct btd_device *device)
key_file = g_key_file_new();
g_key_file_load_from_file(key_file, filename, 0, NULL);
g_key_file_remove_group(key_file, "ServiceRecords", NULL);
+ g_key_file_remove_group(key_file, "Attributes", NULL);
data = g_key_file_to_data(key_file, &length, NULL);
if (length > 0) {
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [BlueZ] device: Remove GATT Attribute when device is removed
2021-08-24 22:52 [PATCH BlueZ] device: Remove GATT Attribute when device is removed Luiz Augusto von Dentz
@ 2021-08-24 23:35 ` bluez.test.bot
2021-08-25 22:13 ` Luiz Augusto von Dentz
2021-08-25 17:44 ` [PATCH BlueZ] " David Lechner
1 sibling, 1 reply; 5+ messages in thread
From: bluez.test.bot @ 2021-08-24 23:35 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=536773
---Test result---
Test Summary:
CheckPatch PASS 0.26 seconds
GitLint PASS 0.10 seconds
Prep - Setup ELL PASS 39.79 seconds
Build - Prep PASS 0.10 seconds
Build - Configure PASS 6.95 seconds
Build - Make PASS 173.06 seconds
Make Check PASS 8.48 seconds
Make Distcheck PASS 204.33 seconds
Build w/ext ELL - Configure PASS 7.06 seconds
Build w/ext ELL - Make PASS 163.01 seconds
Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree
##############################
Test: Make Check - PASS
Desc: Run 'make check'
##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH BlueZ] device: Remove GATT Attribute when device is removed
2021-08-24 22:52 [PATCH BlueZ] device: Remove GATT Attribute when device is removed Luiz Augusto von Dentz
2021-08-24 23:35 ` [BlueZ] " bluez.test.bot
@ 2021-08-25 17:44 ` David Lechner
2021-08-25 21:16 ` Luiz Augusto von Dentz
1 sibling, 1 reply; 5+ messages in thread
From: David Lechner @ 2021-08-25 17:44 UTC (permalink / raw)
To: Luiz Augusto von Dentz, linux-bluetooth
On 8/24/21 5:52 PM, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> This makes the GATT Attribute cache to be removed when device is removed
> just like SDP ServiceRecords.
>
> Fixes: https://github.com/bluez/bluez/issues/191
> ---
Tested-by: David Lechner <david@lechnology.com>
But wouldn't it be better to just delete the file altogether?
This would prevent any future sections from being forgotten to
be removed as well.
I sent an alternative patch that does this: "device: delete
cache file when device is removed"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH BlueZ] device: Remove GATT Attribute when device is removed
2021-08-25 17:44 ` [PATCH BlueZ] " David Lechner
@ 2021-08-25 21:16 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 5+ messages in thread
From: Luiz Augusto von Dentz @ 2021-08-25 21:16 UTC (permalink / raw)
To: David Lechner; +Cc: linux-bluetooth
Hi David,
On Wed, Aug 25, 2021 at 10:44 AM David Lechner <david@lechnology.com> wrote:
>
> On 8/24/21 5:52 PM, Luiz Augusto von Dentz wrote:
> > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> >
> > This makes the GATT Attribute cache to be removed when device is removed
> > just like SDP ServiceRecords.
> >
> > Fixes: https://github.com/bluez/bluez/issues/191
> > ---
> Tested-by: David Lechner <david@lechnology.com>
>
> But wouldn't it be better to just delete the file altogether?
> This would prevent any future sections from being forgotten to
> be removed as well.
>
> I sent an alternative patch that does this: "device: delete
> cache file when device is removed"
We do like to keep some details such as the name, etc.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BlueZ] device: Remove GATT Attribute when device is removed
2021-08-24 23:35 ` [BlueZ] " bluez.test.bot
@ 2021-08-25 22:13 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 5+ messages in thread
From: Luiz Augusto von Dentz @ 2021-08-25 22:13 UTC (permalink / raw)
To: linux-bluetooth
Hi,
On Tue, Aug 24, 2021 at 4:35 PM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=536773
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 0.26 seconds
> GitLint PASS 0.10 seconds
> Prep - Setup ELL PASS 39.79 seconds
> Build - Prep PASS 0.10 seconds
> Build - Configure PASS 6.95 seconds
> Build - Make PASS 173.06 seconds
> Make Check PASS 8.48 seconds
> Make Distcheck PASS 204.33 seconds
> Build w/ext ELL - Configure PASS 7.06 seconds
> Build w/ext ELL - Make PASS 163.01 seconds
>
> Details
> ##############################
> Test: CheckPatch - PASS
> Desc: Run checkpatch.pl script with rule in .checkpatch.conf
>
> ##############################
> Test: GitLint - PASS
> Desc: Run gitlint with rule in .gitlint
>
> ##############################
> Test: Prep - Setup ELL - PASS
> Desc: Clone, build, and install ELL
>
> ##############################
> Test: Build - Prep - PASS
> Desc: Prepare environment for build
>
> ##############################
> Test: Build - Configure - PASS
> Desc: Configure the BlueZ source tree
>
> ##############################
> Test: Build - Make - PASS
> Desc: Build the BlueZ source tree
>
> ##############################
> Test: Make Check - PASS
> Desc: Run 'make check'
>
> ##############################
> Test: Make Distcheck - PASS
> Desc: Run distcheck to check the distribution
>
> ##############################
> Test: Build w/ext ELL - Configure - PASS
> Desc: Configure BlueZ source with '--enable-external-ell' configuration
>
> ##############################
> Test: Build w/ext ELL - Make - PASS
> Desc: Build BlueZ source with '--enable-external-ell' configuration
>
>
>
> ---
> Regards,
> Linux Bluetooth
Pushed.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-25 22:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24 22:52 [PATCH BlueZ] device: Remove GATT Attribute when device is removed Luiz Augusto von Dentz
2021-08-24 23:35 ` [BlueZ] " bluez.test.bot
2021-08-25 22:13 ` Luiz Augusto von Dentz
2021-08-25 17:44 ` [PATCH BlueZ] " David Lechner
2021-08-25 21:16 ` Luiz Augusto von Dentz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.